flack / openpsa

lib/net/nemein/wiki/style/view-wikipage-raw.php

Spacing +1 added lines, -1 removed lines

@@ -6,6 +6,6 @@
     &(view["content"]:h);
     <?php
 } else {
-    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub')."</p>";
+    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub') . "</p>";
 }
 ?>
\ No newline at end of file

lib/org/openpsa/invoices/style/admin-read.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         <div class="value"><?php echo $formatter->date($invoice->deliverydate); ?></div></div>
     <?php } ?>
 
-    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description');?>: </div>
+    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description'); ?>: </div>
     <div class="description value">&(view['description']:h);</div></div>
 
     <?php

Braces +2 added lines, -1 removed lines

@@ -8,7 +8,8 @@
     if ($customer->orgOpenpsaObtype < org_openpsa_contacts_group_dba::ORGANIZATION) {
         $customer = false;
     }
-} catch (midcom_error $e) {
+}
+catch (midcom_error $e) {
     $customer = false;
 }
 

lib/org/openpsa/sales/style/show-deliverable-subscription.php

Indentation +2 added lines, -2 removed lines

@@ -74,12 +74,12 @@
                         <tr>
                           <td class="title"><?php echo $data['l10n']->get('cost'); ?></td>
                           <?php
-                          if ($data['deliverable']->costType == '%') { ?>
+                            if ($data['deliverable']->costType == '%') { ?>
                               <td class="numeric"><?php echo $view['costPerUnit']; ?> %</td>
                               <td class="numeric">&nbsp;</td>
                               <td class="numeric">&nbsp;</td>
                           <?php
-                          } else { ?>
+                            } else { ?>
                               <td class="numeric"><?php echo $formatter->number($data['deliverable']->costPerUnit); ?></td>
                               <td class="numeric"><?php echo $view['plannedUnits']; ?></td>
                               <td class="numeric"><?php echo $view['units']; ?></td>

Spacing +4 added lines, -4 removed lines

@@ -3,7 +3,7 @@ 
 $state = $data['deliverable']->get_state();
 $formatter = $data['l10n']->get_formatter();
 $per_unit = $data['l10n']->get('per unit');
-if (   $data['product']
+if ($data['product']
     && $unit_option = org_openpsa_sales_viewer::get_unit_option($data['product']->unit)) {
     $per_unit = sprintf($data['l10n']->get('per %s'), $unit_option);
 }
@@ -109,7 +109,7 @@ 
         </div>
         <?php
         $tabs = [];
-        if (   $data['invoices_url']
+        if ($data['invoices_url']
             && $data['deliverable']->invoiced > 0) {
             $tabs[] = [
                 'url' => $data['invoices_url'] . "list/deliverable/{$data['deliverable']->guid}/",
@@ -117,7 +117,7 @@ 
             ];
         }
 
-        if (   $data['projects_url']
+        if ($data['projects_url']
             && $data['deliverable']->state >= org_openpsa_sales_salesproject_deliverable_dba::STATE_ORDERED
             && $data['product']
             && $data['product']->orgOpenpsaObtype == org_openpsa_products_product_dba::TYPE_SERVICE) {
@@ -172,7 +172,7 @@ 
             }
             echo "    </tbody>\n";
             echo "</table>\n";
-            if (   $at_entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
+            if ($at_entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
                 && midcom::get()->auth->can_user_do('midgard:create', class: org_openpsa_invoices_invoice_dba::class)) {
                 $label = $data['l10n']->get('generate now');
                 $process_link = $data['router']->generate('deliverable_run_cycle', ['guid' => $data['deliverable']->guid]);

lib/org/openpsa/relatedto/style/show_entries_html.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
             <?php
             //index is needed for sorting
             echo "'index_name',";
-            echo "'" . $data['l10n']->get('entry title') ."',";
+            echo "'" . $data['l10n']->get('entry title') . "',";
             echo "'" . $data['l10n']->get('entry text') . "',";
             echo "'" . $data['l10n']->get('entry created') . "',";
             echo "'index_creator', '" . $data['l10n_midcom']->get('creator') . "',";

Braces +2 added lines, -1 removed lines

@@ -25,7 +25,8 @@
             $row['creator_index'] = $creator->rname;
             $creator_card = org_openpsa_widgets_contact::get($entry->metadata->creator);
             $row['creator'] = $creator_card->show_inline();
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $row['creator_index'] = '';
             $row['creator'] = '';
         }

lib/midcom/helper/reflector/main.php

Braces +2 added lines, -1 removed lines

@@ -203,7 +203,8 @@
         if ($object instanceof mgdobject) {
             try {
                 $obj = midcom::get()->dbfactory->convert_midgard_to_midcom($object);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 return null;
             }
         } else {

Spacing +5 added lines, -5 removed lines

@@ -51,7 +51,7 @@ 
      *
      * @return static
      */
-    public static function get(string|object $src) : self
+    public static function get(string | object $src) : self
     {
         $identifier = get_called_class() . (is_object($src) ? get_class($src) : $src);
 
@@ -286,7 +286,7 @@ 
 
         $label_prop = $this->get_label_property();
 
-        if (    $label_prop != 'guid'
+        if ($label_prop != 'guid'
              && $this->property_exists($label_prop)) {
             $search_properties[$label_prop] = true;
         }
@@ -336,7 +336,7 @@ 
                 continue;
             }
 
-            if (   !$this->is_link($property)
+            if (!$this->is_link($property)
                 && $this->get_midgard_type($property) != MGD_TYPE_GUID) {
                 continue;
             }
@@ -370,7 +370,7 @@ 
     protected static function class_rewrite(string $schema_type) : string
     {
         $extends = midcom_baseclasses_components_configuration::get('midcom.helper.reflector', 'config')->get_array('class_extends');
-        if (   isset($extends[$schema_type])
+        if (isset($extends[$schema_type])
             && class_exists($extends[$schema_type])) {
             return $extends[$schema_type];
         }
@@ -390,7 +390,7 @@ 
     /**
      * Get the MgdSchema classname for given class
      */
-    public static function resolve_baseclass(string|object $classname) : string
+    public static function resolve_baseclass(string | object $classname) : string
     {
         static $cached = [];
 

lib/midgard/admin/asgard/handler/object/attachments.php

Spacing +3 added lines, -3 removed lines

@@ -98,13 +98,13 @@ 
         }
 
         $mimetype = $request->request->get('midgard_admin_asgard_mimetype');
-        if (   !empty($mimetype)
+        if (!empty($mimetype)
             && $local_file->mimetype != $mimetype) {
             $local_file->mimetype = $mimetype;
             $needs_update = true;
         }
 
-        if (   $needs_update
+        if ($needs_update
             && !$local_file->update()) {
             return null;
         }
@@ -234,7 +234,7 @@ 
         $this->bind_view_to_object($this->_file);
 
         $filename = $this->_process_form($request);
-        if (   $filename
+        if ($filename
             && $filename != $data['filename']) {
             return $this->relocate_to_file($filename);
         }

lib/org/openpsa/calendar/event/member.php

Braces +2 added lines, -1 removed lines

@@ -143,7 +143,8 @@
                 debug_add('person #' . $person->id . 'has no email address, aborting');
                 return null;
             }
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             return null;
         }
 

Spacing +3 added lines, -3 removed lines

@@ -66,7 +66,7 @@ 
 
         $event ??= new org_openpsa_calendar_event_dba($this->eid);
 
-        if (    $recipient->id == midcom_connection::get_user()
+        if ($recipient->id == midcom_connection::get_user()
              && !$event->send_notify_me) {
             //Do not send notification to current user
             debug_add('event->send_notify_me is false and recipient is current user, aborting notify');
@@ -192,7 +192,7 @@ 
 
             if (isset($events_by_date[$ymd])) {
                 foreach ($events_by_date[$ymd] as $event) {
-                    if (   $event->end <= $workday_starts_ts
+                    if ($event->end <= $workday_starts_ts
                         || $event->start >= $workday_ends_ts) {
                         // We need not consider this event, it is outside the defined workday
                         continue;
@@ -210,7 +210,7 @@ 
                 }
             }
             // End of day slot
-            if (   $last_end_time < $workday_ends_ts
+            if ($last_end_time < $workday_ends_ts
                 && (($workday_ends_ts - $last_end_time) >= $amount)) {
                 $slots[] = self::_create_slot($last_end_time, $workday_ends_ts, $last_event);
             }

lib/org/openpsa/slideshow/image.php

Braces +4 added lines, -2 removed lines

@@ -48,7 +48,8 @@ 
 
         try {
             $folder = midcom_db_topic::get_cached($this->topic);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
         $folder->delete_attachment(self::FOLDER_THUMBNAIL);
@@ -58,7 +59,8 @@ 
     {
         try {
             return new midcom_db_attachment($this->$type);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return null;
         }

lib/org/openpsa/relatedto/plugin.php

Braces +2 added lines, -1 removed lines

@@ -104,7 +104,8 @@
     {
         $ret = ['org_openpsa_relatedto' => []];
         foreach ($array as $rel) {
-            if (!midcom::get()->dbfactory->is_a($rel, org_openpsa_relatedto_dba::class)) { //Matches also 'org_openpsa_relatedto'
+            if (!midcom::get()->dbfactory->is_a($rel, org_openpsa_relatedto_dba::class)) {
+//Matches also 'org_openpsa_relatedto'
                 //Wrong type of object found in array, cruelly abort the whole procedure
                 return null;
             }