flack / openpsa

lib/midcom/admin/folder/handler/approvals.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
      */
     public function _handler_approval(Request $request, string $handler_id)
     {
-        if (   !$request->request->has('guid')
+        if (!$request->request->has('guid')
             || !$request->request->has('return_to')) {
             throw new midcom_error('Cannot process approval request, request is incomplete.');
         }

lib/midcom/helper/nav/backend.php

Spacing +2 added lines, -2 removed lines

@@ -279,7 +279,7 @@ 
             }
 
             $this->_leaves[$id] = $leaf;
-            $this->_loaded_leaves[$node->id][$id] =& $this->_leaves[$id];
+            $this->_loaded_leaves[$node->id][$id] = & $this->_leaves[$id];
         }
     }
 
@@ -337,7 +337,7 @@ 
                     continue;
                 }
 
-                if (   !$show_noentry
+                if (!$show_noentry
                     && self::$_nodes[$id]->noentry) {
                     // Hide "noentry" items
                     continue;

lib/midcom/core/context.php

Braces +2 added lines, -1 removed lines

@@ -165,7 +165,8 @@
                 try {
                     self::$root_topic = midcom_db_topic::get_cached($guid);
                     return self::$root_topic;
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     if ($e instanceof midcom_error_forbidden) {
                         throw $e;
                     }

Spacing +1 added lines, -1 removed lines

@@ -254,7 +254,7 @@
      */
     public function set_custom_key($key, &$value)
     {
-        $this->_data[MIDCOM_CONTEXT_CUSTOMDATA][$key] =& $value;
+        $this->_data[MIDCOM_CONTEXT_CUSTOMDATA][$key] = & $value;
     }
 
     public function show()

lib/org/openpsa/directmarketing/style/show-campaign.php

Spacing +2 added lines, -2 removed lines

@@ -50,14 +50,14 @@
     </div>
 
     <script type="text/javascript">
-    $('#<?php echo $grid->get_identifier();?>').on('click', 'td.delete i', function(event) {
+    $('#<?php echo $grid->get_identifier(); ?>').on('click', 'td.delete i', function(event) {
         var guid = $(event.target).data('person-guid'),
             member_guid = $(event.target).data('member-guid'),
             post_data = {org_openpsa_ajax_mode: 'unsubscribe', org_openpsa_ajax_person_guid: guid};
 
         $(event.target).removeClass('fa-trash').addClass('fa-spin fa-spinner');
         $.post('&(node[MIDCOM_NAV_ABSOLUTEURL]);campaign/unsubscribe/ajax/' + member_guid + '/', post_data, function() {
-            $('#<?php echo $grid->get_identifier();?>').trigger('reloadGrid');
+            $('#<?php echo $grid->get_identifier(); ?>').trigger('reloadGrid');
             $('#org_openpsa_widgets_contact-' + guid).fadeOut('fast', function() {
                 $('#org_openpsa_widgets_contact-' + guid).remove();
             });

src/midcom/datamanager/extension/type/urlnameType.php

Spacing +2 added lines, -2 removed lines

@@ -22,7 +22,7 @@ 
      */
     public function configureOptions(OptionsResolver $resolver)
     {
-        $resolver->setNormalizer('write_privilege', function (Options $options, $value) {
+        $resolver->setNormalizer('write_privilege', function(Options $options, $value) {
             return (array) $value + ['privilege' => 'midcom:urlname'];
         });
 
@@ -36,7 +36,7 @@ 
             ]
         ]);
 
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
             $validator_options = [
                 'allow_catenate' => $options['type_config']['allow_catenate'],
                 'allow_unclean' => $options['type_config']['allow_unclean'],

src/midcom/datamanager/storage/container/dbacontainer.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
             }
             $config['name'] = $name;
             $field = $this->prepare_field($config);
-            if (   isset($config['default'])
+            if (isset($config['default'])
                 && (!$this->object->id || $field instanceof transientnode)) {
                 $field->set_value($config['default']);
             }

lib/midcom/response/styled.php

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
 
     private function set_context(midcom_core_context $context)
     {
-        if (   $context->get_key(MIDCOM_CONTEXT_PERMALINKGUID) === null
+        if ($context->get_key(MIDCOM_CONTEXT_PERMALINKGUID) === null
             || $context->get_key(MIDCOM_CONTEXT_PAGETITLE) == '') {
             // Retrieve Metadata
             $nav = new midcom_helper_nav();

lib/midcom/baseclasses/core/dbobject.php

Braces +2 added lines, -1 removed lines

@@ -673,7 +673,8 @@
          */
         try {
             return $object->get_by_id($object->id);
-        } catch (Exception $e) {
+        }
+        catch (Exception $e) {
             return false;
         }
     }

Spacing +4 added lines, -4 removed lines

@@ -119,14 +119,14 @@ 
         if ($parent = $object->get_parent()) {
             // Attachments are a special case
             if ($object instanceof midcom_db_attachment) {
-                if (   !$parent->can_do('midgard:attachments')
+                if (!$parent->can_do('midgard:attachments')
                     || !$parent->can_do('midgard:update')) {
                     debug_add("Failed to create attachment, update or attachments privilege on the parent " . get_class($parent) . " {$parent->guid} not granted for the current user.",
                         MIDCOM_LOG_ERROR);
                     midcom_connection::set_error(MGD_ERR_ACCESS_DENIED);
                     return false;
                 }
-            } elseif (   !$parent->can_do('midgard:create')
+            } elseif (!$parent->can_do('midgard:create')
                       && !midcom::get()->auth->can_user_do('midgard:create', class: get_class($object))) {
                 debug_add("Failed to create object, create privilege on the parent " . get_class($parent) . " {$parent->guid} or the actual object class not granted for the current user.",
                     MIDCOM_LOG_ERROR);
@@ -238,7 +238,7 @@ 
             }
 
             // Default the owner to first group of current user
-            if (   empty($object->metadata->owner)
+            if (empty($object->metadata->owner)
                 && $first_group = midcom::get()->auth->user->get_first_group_guid()) {
                 $object->metadata->set('owner', $first_group);
             }
@@ -462,7 +462,7 @@ 
      */
     public static function get_by_guid(midcom_core_dbaobject $object, string $guid) : bool
     {
-        if (   !midcom::get()->auth->admin
+        if (!midcom::get()->auth->admin
             && !midcom::get()->auth->acl->can_do_byguid('midgard:read', $guid, get_class($object), midcom::get()->auth->acl->get_user_id())) {
             debug_add("Failed to load object, read privilege on the " . get_class($object) . " {$guid} not granted for the current user.", MIDCOM_LOG_ERROR);
             return false;

src/midcom/datamanager/validation/imageValidator.php

Spacing +3 added lines, -3 removed lines

@@ -12,10 +12,10 @@
 {
     public function validate($value, Constraint $constraint)
     {
-        if (   empty($value)
+        if (empty($value)
             || !empty($value['delete'])
-            || (   empty($value['file'])
-                && (   (empty($constraint->config['do_not_save_archival']) && empty($value['archival']))
+            || (empty($value['file'])
+                && ((empty($constraint->config['do_not_save_archival']) && empty($value['archival']))
                     || (!empty($constraint->config['do_not_save_archival']) && empty($value['main']))))) {
             $this->context->buildViolation('This value should not be blank.')
                 ->addViolation();