flack / openpsa

lib/org/openpsa/directmarketing/handler/subscriber.php

Braces +4 added lines, -2 removed lines

@@ -36,7 +36,8 @@ 
             // Add person to campaign
             try {
                 $campaign = new org_openpsa_directmarketing_campaign_dba($add_to);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 // FIXME: More informative error message
                 $this->notify('Failed adding person %s to campaign %s', $add_to, 'error');
                 return;
@@ -86,7 +87,8 @@ 
             try {
                 $campaigns[$membership->campaign] = new org_openpsa_directmarketing_campaign_dba($membership->campaign);
                 $campaign_membership_map[$membership->campaign] = $membership;
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 debug_add('Failed to load campaign ' . $membership->campaign . ', reason: ' . $e->getMessage());
             }
         }

lib/org/openpsa/invoices/handler/invoice/crud.php

Braces +4 added lines, -2 removed lines

@@ -48,7 +48,8 @@ 
             // We're creating invoice for chosen customer
             try {
                 $this->customer = new org_openpsa_contacts_group_dba($company);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $contact = new org_openpsa_contacts_person_dba($company);
                 $this->contact_id = $contact->id;
             }
@@ -155,7 +156,8 @@ 
             if (!empty($this->invoice->customer)) {
                 try {
                     $this->customer = org_openpsa_contacts_group_dba::get_cached($this->invoice->customer);
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     $customer_field['hidden'] = true;
                     $e->log();
                 }

Spacing +2 added lines, -2 removed lines

@@ -141,8 +141,8 @@
         $schema->get_field('paid')['hidden'] = empty($this->invoice->paid);
 
         $contact = $this->invoice->customerContact ?: $this->contact_id;
-        $customer_field =& $schema->get_field('customer');
-        $contact_field =& $schema->get_field('customerContact');
+        $customer_field = & $schema->get_field('customer');
+        $contact_field = & $schema->get_field('customerContact');
 
         if (!empty($contact)) {
             $customer_field['type_config']['options'] = $this->get_customers_for_contact($contact);

lib/org/openpsa/products/handler/product/create.php

Braces +2 added lines, -1 removed lines

@@ -89,7 +89,8 @@
         } elseif ((int) $group > 0) {
             try {
                 $this->parent = new org_openpsa_products_product_group_dba((int) $group);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

lib/midcom/helper/imagepopup/handler/list.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
         midcom::get()->auth->require_valid_user();
         midcom::get()->skip_page_style = true;
 
-        $this->add_stylesheet(MIDCOM_STATIC_URL ."/midcom.helper.imagepopup/styling.css", 'screen');
+        $this->add_stylesheet(MIDCOM_STATIC_URL . "/midcom.helper.imagepopup/styling.css", 'screen');
 
         $data['filetype'] = $filetype;
         $data['object'] = null;

lib/org/openpsa/expenses/handler/hours/admin.php

Braces +2 added lines, -1 removed lines

@@ -100,7 +100,8 @@
         try {
             $task = org_openpsa_projects_task_dba::get_cached($hour_report->task);
             $options['success_url'] = $this->router->generate('list_hours_task', ['guid' => $task->guid]);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
         return $this->get_workflow('delete', $options)->run($request);

src/midcom/datamanager/controller.php

Spacing +3 added lines, -3 removed lines

@@ -70,13 +70,13 @@ 
             }
         } elseif (!$this->form->isSubmitted()) {
             $this->form->handleRequest($request);
-            if (   $this->form->isSubmitted()
+            if ($this->form->isSubmitted()
                 && $button = $this->form->getClickedButton()) {
                 $operation = $button->getConfig()->getOption('operation');
             }
         }
 
-        if (   in_array($operation, [self::SAVE, self::NEXT])
+        if (in_array($operation, [self::SAVE, self::NEXT])
             && !$this->form->isValid()) {
             $operation = self::EDIT;
         }
@@ -159,7 +159,7 @@ 
                 if ($storage->get_last_operation() === self::SAVE) {
                     // Get GUIDs and such for new-created dependent objects
                     $this->dm->set_storage($storage->get_value(), $this->dm->get_schema()->get_name());
-                } elseif (   !$this->form->isValid()
+                } elseif (!$this->form->isValid()
                           && $storage->move_uploaded_files() > 0) {
                     $form = $this->dm->get_form($this->form->getName(), true);
                     $this->copy_errors($this->form, $form);

lib/net/nehmer/blog/style/feeds-item.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
 $item->title = $data['article']->title;
 $arg = $data['article']->name ?: $data['article']->guid;
 
-if (   $data['config']->get('link_to_external_url')
+if ($data['config']->get('link_to_external_url')
     && !empty($data['article']->url)) {
     $item->link = $data['article']->url;
 } else {
@@ -37,7 +37,7 @@ 
     $item->description .= '<div class="abstract">' . $view['abstract'] . '</div>';
 }
 
-if (   array_key_exists('image', $view)
+if (array_key_exists('image', $view)
     && $data['config']->get('rss_use_image')) {
     $item->description .= "\n<div class=\"image\">" . $view['image'] . '</div>';
 }

lib/midcom/admin/folder/management.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
             }
 
             // Skip components beginning with midcom or midgard
-            if (   preg_match('/^(midcom|midgard)\./', $manifest->name)
+            if (preg_match('/^(midcom|midgard)\./', $manifest->name)
                 && $manifest->name != 'midcom.helper.search') {
                 continue;
             }

lib/org/openpsa/sales/style/show-deliverable.php

Spacing +3 added lines, -3 removed lines

@@ -3,7 +3,7 @@ 
 $state = $data['deliverable']->get_state();
 $formatter = $data['l10n']->get_formatter();
 $per_unit = $data['l10n']->get('per unit');
-if (   $data['product']
+if ($data['product']
     && $unit_option = org_openpsa_sales_viewer::get_unit_option($data['product']->unit)) {
     $per_unit = sprintf($data['l10n']->get('per %s'), $unit_option);
 }
@@ -115,7 +115,7 @@ 
 	    </div>
      <?php
     $tabs = [];
-    if (   $data['invoices_url']
+    if ($data['invoices_url']
         && $data['deliverable']->invoiced > 0) {
         $tabs[] = [
             'url' => $data['invoices_url'] . "list/deliverable/{$data['deliverable']->guid}/",
@@ -123,7 +123,7 @@ 
         ];
     }
 
-    if (   $data['projects_url']
+    if ($data['projects_url']
         && $data['deliverable']->state >= org_openpsa_sales_salesproject_deliverable_dba::STATE_ORDERED
         && $data['product']
         && $data['product']->orgOpenpsaObtype == org_openpsa_products_product_dba::TYPE_SERVICE) {

Indentation +3 added lines, -3 removed lines

@@ -65,17 +65,17 @@
                         <tr>
                           <td class="title"><?php echo $data['l10n']->get('cost'); ?></td>
                           <?php
-                          if ($data['deliverable']->costType == '%') { ?>
+                            if ($data['deliverable']->costType == '%') { ?>
                               <td class="numeric"><?php echo $view['costPerUnit']; ?> %</td>
                               <td class="numeric">&nbsp;</td>
                               <td class="numeric">&nbsp;</td>
                           <?php
-                          } else { ?>
+                            } else { ?>
                               <td class="numeric"><?php echo $formatter->number($data['deliverable']->costPerUnit); ?></td>
                               <td class="numeric"><?php echo $view['plannedUnits']; ?></td>
                               <td class="numeric"><?php echo $view['units']; ?></td>
                           <?php
-                          } ?>
+                            } ?>
                               <td class="numeric"><?php echo $formatter->number($data['deliverable']->cost); ?></td>
                         </tr>
                       </tbody>