flack / openpsa

lib/org/openpsa/products/viewer.php

Spacing +3 added lines, -3 removed lines

@@ -30,11 +30,11 @@
         $object = $dm->get_storage()->get_value();
 
         $document = $indexer->new_document($dm);
-        if (   $config->get('enable_scheduling')
+        if ($config->get('enable_scheduling')
             && $object instanceof org_openpsa_products_product_dba) {
             // Check start/end for products
-            if (   $object->start > time()
-                || (   $object->end != 0
+            if ($object->start > time()
+                || ($object->end != 0
                     && $object->end < time())) {
                 // Not in market, remove from index
                 $indexer->delete($document->RI);

lib/midgard/admin/asgard/handler/object/permissions.php

Spacing +2 added lines, -2 removed lines

@@ -82,7 +82,7 @@ 
         $tmp = $this->_object;
 
         $i = 0;
-        while (   !empty($tmp->guid)
+        while (!empty($tmp->guid)
                && !($tmp instanceof midcom_db_topic)
                && $i < 100) {
             // Get the parent; wishing eventually to get a topic
@@ -127,7 +127,7 @@ 
 
         $assignees = $this->load_assignees();
         $this->process_assignees($assignees, $schemadb);
-        $assignee_field =& $schemadb->get('privileges')->get_field('add_assignee');
+        $assignee_field = & $schemadb->get('privileges')->get_field('add_assignee');
 
         if (!$this->additional_assignee) {
             // Populate additional assignee selector

lib/midcom/helper/imagepopup/handler/upload.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
         $temp = $request->files->get('file');
 
         // Verify file extension
-        if (   !$temp instanceof UploadedFile
+        if (!$temp instanceof UploadedFile
             || !in_array(strtolower($temp->getClientOriginalExtension()), ["gif", "jpg", "png"])) {
             throw new midcom_error('Invalid extension.');
         }

lib/org/openpsa/contacts/handler/group/action.php

Braces +2 added lines, -1 removed lines

@@ -33,7 +33,8 @@
                 $member->require_do('midgard:update');
                 $member->extra = $request->request->get('title');
                 $response['status'] = $member->update();
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
             $response['message'] = midcom_connection::get_error_string();

lib/org/openpsa/relatedto/handler/relatedto.php

Spacing +2 added lines, -2 removed lines

@@ -196,10 +196,10 @@
      *
      * @param array $link The necessary link information
      */
-    private function _render_line(array $link, midcom_core_dbaobject &$other_obj)
+    private function _render_line(array $link, midcom_core_dbaobject & $other_obj)
     {
         $this->_request_data['link'] = $link;
-        $this->_request_data['other_obj'] =& $other_obj;
+        $this->_request_data['other_obj'] = & $other_obj;
         $this->_request_data['icon'] = midcom_helper_reflector::get_object_icon($other_obj);
 
         if (get_class($other_obj) != $link['class']) {

Braces +6 added lines, -3 removed lines

@@ -107,7 +107,8 @@ 
             //TODO: check for duplicates ?
             try {
                 $result = ['other_obj' => midcom::get()->dbfactory->get_object_by_guid($link[$other . 'Guid'])];
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 continue;
             }
             $result['link'] = [
@@ -378,7 +379,8 @@ 
             if (!($this->_object instanceof org_openpsa_relatedto_dba)) {
                 $response['status'] = "method requires guid of a link object as an argument";
             }
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $response['status'] = "error: " . $e->getMessage();
         }
 
@@ -399,7 +401,8 @@ 
             $relation = new org_openpsa_relatedto_dba($guid);
             $result = $relation->delete();
             $status = 'Last message: ' . midcom_connection::get_error_string();
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $result = false;
             $status = "Object '{$guid}' could not be loaded, error:" . $e->getMessage();
         }

src/midcom/datamanager/indexer/document.php

Spacing +1 added lines, -1 removed lines

@@ -171,7 +171,7 @@
                     if (!empty($field->vars['value'])) {
                         //only index the first attachment for now
                         $attachment = array_shift($field->vars['value']);
-                        if (   !$attachment instanceof \midcom_db_attachment
+                        if (!$attachment instanceof \midcom_db_attachment
                             && !empty($attachment['object'])) {
                             //This is the form edit case
                             //@todo: In create case, nothing is found currently

lib/org/openpsa/directmarketing/importer/csv.php

Spacing +2 added lines, -2 removed lines

@@ -55,11 +55,11 @@
         foreach (array_filter($csv_line) as $field => $value) {
             // Process the row accordingly
             $field_matching = $this->_settings['fields'][$field];
-            if (   $field_matching
+            if ($field_matching
                 && str_contains($field_matching, ':')) {
                 [$schemadb, $schema_field] = explode(':', $field_matching);
 
-                if (   !array_key_exists($schemadb, $this->_schemadbs)
+                if (!array_key_exists($schemadb, $this->_schemadbs)
                     || !$this->_schemadbs[$schemadb]->get('default')->has_field($schema_field)) {
                     // Invalid matching, skip
                     continue;

src/midcom/datamanager/helper/autocomplete.php

Spacing +4 added lines, -6 removed lines

@@ -83,7 +83,7 @@ 
     private function apply_constraints(midcom_core_query $query, array $constraints)
     {
         foreach ($constraints as $key => $data) {
-            if (   !array_key_exists('value', $data)
+            if (!array_key_exists('value', $data)
                 || empty($data['field'])
                 || empty($data['op'])) {
                 debug_add("Constraint #{$key} is not correctly defined, skipping", MIDCOM_LOG_WARN);
@@ -144,7 +144,7 @@ 
     {
         $query = $this->request["term"];
         $wildcard_query = $query;
-        if (   isset($this->request['auto_wildcards'])
+        if (isset($this->request['auto_wildcards'])
             && !str_contains($query, '%')) {
             switch ($this->request['auto_wildcards']) {
                 case 'start':
@@ -252,9 +252,7 @@ 
                 return $label;
             }
         }
-        return midcom_helper_reflector::get($object)->get_object_label($object) ?:
-            self::build_label($object, array_column($result_headers, 'name')) ?:
-            get_class($object) . ' #' . $object->id;
+        return midcom_helper_reflector::get($object)->get_object_label($object) ?: self::build_label($object, array_column($result_headers, 'name')) ?: get_class($object) . ' #' . $object->id;
     }
 
     private static function build_label($object, array $fields) : string
@@ -289,7 +287,7 @@ 
             }
             return self::sanitize_label($value);
         }
-        if (   $field == 'username'
+        if ($field == 'username'
             && $object instanceof midcom_db_person) {
             $account = new midcom_core_account($object);
             return self::sanitize_label($account->get_username());

src/midcom/dba/parameters.php

Indentation +2 added lines, -2 removed lines

@@ -204,7 +204,7 @@ 
         if (   !$this->can_do('midgard:update')
             || !$this->can_do('midgard:parameters')) {
             debug_add("Failed to set parameters, midgard:update or midgard:parameters on " . static::class . " {$this->guid} not granted for the current user.",
-                  MIDCOM_LOG_ERROR);
+                    MIDCOM_LOG_ERROR);
             midcom_connection::set_error(MGD_ERR_ACCESS_DENIED);
             return false;
         }
@@ -248,7 +248,7 @@ 
         if (   !$this->can_do('midgard:update')
             || !$this->can_do('midgard:parameters')) {
             debug_add("Failed to delete parameters, midgard:update or midgard:parameters on " . static::class . " {$this->guid} not granted for the current user.",
-                  MIDCOM_LOG_ERROR);
+                    MIDCOM_LOG_ERROR);
             midcom_connection::set_error(MGD_ERR_ACCESS_DENIED);
             return false;
         }

Spacing +2 added lines, -2 removed lines

@@ -201,7 +201,7 @@ 
             return false;
         }
 
-        if (   !$this->can_do('midgard:update')
+        if (!$this->can_do('midgard:update')
             || !$this->can_do('midgard:parameters')) {
             debug_add("Failed to set parameters, midgard:update or midgard:parameters on " . static::class . " {$this->guid} not granted for the current user.",
                   MIDCOM_LOG_ERROR);
@@ -245,7 +245,7 @@ 
             return false;
         }
 
-        if (   !$this->can_do('midgard:update')
+        if (!$this->can_do('midgard:update')
             || !$this->can_do('midgard:parameters')) {
             debug_add("Failed to delete parameters, midgard:update or midgard:parameters on " . static::class . " {$this->guid} not granted for the current user.",
                   MIDCOM_LOG_ERROR);