Passed
Push — master ( 7328de...3ad1c9 )
by Andreas
37:49 queued 25:28
created
lib/org/openpsa/directmarketing/midcom/interfaces.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
     public function _on_watched_dba_delete(midcom_core_dbaobject $object)
18 18
     {
19 19
         $qb = org_openpsa_directmarketing_campaign_member_dba::new_query_builder();
20
-        if (   $object instanceof midcom_db_person
20
+        if ($object instanceof midcom_db_person
21 21
             || $object instanceof org_openpsa_contacts_person_dba) {
22 22
             $qb->add_constraint('person', '=', $object->id);
23 23
         } elseif ($object instanceof org_openpsa_directmarketing_campaign_dba) {
Please login to merge, or discard this patch.
lib/errors.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -140,7 +140,7 @@
 block discarded – undo
140 140
             return;
141 141
         }
142 142
 
143
-        if (   !is_writable($config['filename'])
143
+        if (!is_writable($config['filename'])
144 144
             && !is_writable(dirname($config['filename']))) {
145 145
             debug_add("Error logging file {$config['filename']} is not writable", MIDCOM_LOG_WARN);
146 146
             return;
Please login to merge, or discard this patch.
lib/org/openpsa/products/product/group.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
         }
75 75
 
76 76
         $result_cache[$cache_key] = [];
77
-        $ret =& $result_cache[$cache_key];
77
+        $ret = & $result_cache[$cache_key];
78 78
 
79 79
         if (empty($up)) {
80 80
             // TODO: use reflection to see what kind of property this is ?
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/handler/journal/list.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@
 block discarded – undo
149 149
             }
150 150
 
151 151
             $reflector = midcom_helper_reflector::get($linked_object);
152
-            $link_html = "<a href='" . midcom::get()->permalinks->create_permalink($linked_object->guid) . "'>" . $reflector->get_object_label($linked_object) ."</a>";
152
+            $link_html = "<a href='" . midcom::get()->permalinks->create_permalink($linked_object->guid) . "'>" . $reflector->get_object_label($linked_object) . "</a>";
153 153
             $data['linked_objects'][$entry->linkGuid] = $link_html;
154 154
             $data['linked_raw_objects'][$entry->linkGuid] = $reflector->get_object_label($linked_object);
155 155
         }
Please login to merge, or discard this patch.
lib/org/openpsa/mail/template.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@
 block discarded – undo
103 103
         foreach ($parameters as $key => $value) {
104 104
             $this->_patterns[] = "/__({$key})__/";
105 105
 
106
-            if (   is_array($value)
106
+            if (is_array($value)
107 107
                 || is_object($value)) {
108 108
                 $this->_patterns[] = "/__({$key})_([^ \.>\"-]*?)__/";
109 109
             }
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/sender.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
         $this->from = $from;
76 76
         $this->subject = $subject;
77 77
 
78
-        if (   $message->orgOpenpsaObtype != org_openpsa_directmarketing_campaign_message_dba::EMAIL_TEXT
78
+        if ($message->orgOpenpsaObtype != org_openpsa_directmarketing_campaign_message_dba::EMAIL_TEXT
79 79
             && $message->orgOpenpsaObtype != org_openpsa_directmarketing_campaign_message_dba::EMAIL_HTML) {
80 80
             throw new midcom_error('unsupported message type');
81 81
         }
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
         $token .= midcom_helper_misc::random_string($this->token_size - 1, 'abcdefghijklmnopqrstuvwxyz0123456789');
220 220
 
221 221
         //If token is not free or (very, very unlikely) matches our dummy token, recurse.
222
-        if (   $token === 'dummy'
222
+        if ($token === 'dummy'
223 223
             || !org_openpsa_directmarketing_campaign_messagereceipt_dba::token_is_free($token)) {
224 224
             return $this->_create_token();
225 225
         }
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
             return null;
241 241
         }
242 242
         $type = $this->_backend->get_type();
243
-        if (   $person->get_parameter('org.openpsa.directmarketing', "send_all_denied")
243
+        if ($person->get_parameter('org.openpsa.directmarketing', "send_all_denied")
244 244
             || $person->get_parameter('org.openpsa.directmarketing', "send_{$type}_denied")) {
245 245
             debug_add("Sending {$type} messages to person {$person->rname} is denied, unsubscribing member (member #{$member->id})");
246 246
             $member->orgOpenpsaObtype = org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED;
Please login to merge, or discard this patch.
lib/midcom/services/auth/backend.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
             return null;
101 101
         }
102 102
 
103
-        if (   midcom::get()->config->get('auth_check_client_ip')
103
+        if (midcom::get()->config->get('auth_check_client_ip')
104 104
             && $data['clientip'] != $request->getClientIp()) {
105 105
             debug_add("The session had mismatching client IP.", MIDCOM_LOG_INFO);
106 106
             debug_add("Expected {$data['clientip']}, got {$request->getClientIp()}.");
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
             return null;
115 115
         }
116 116
 
117
-        if (   !$this->check_timestamp($data['timestamp'], $user)
117
+        if (!$this->check_timestamp($data['timestamp'], $user)
118 118
             || !$this->authenticate($user->username, '', true)) {
119 119
             $this->logout($user);
120 120
             return null;
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/undelete.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@
 block discarded – undo
149 149
             $child_indent = $indent + 20;
150 150
             echo "{$prefix}<tbody class=\"children\">\n";
151 151
             foreach ($child_types as $type => $children) {
152
-                if (   count($children) < 10
152
+                if (count($children) < 10
153 153
                     || isset($_GET['show_children'][$object->guid][$type])) {
154 154
                         foreach ($children as $child) {
155 155
                             $this->show_type($child, $child_indent, "{$prefix}    ", false);
Please login to merge, or discard this patch.
lib/net/nehmer/blog/style/index-item.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
         &(published:h);
29 29
             <?php
30 30
             if ($data['linked']) {
31
-                echo $data['l10n']->get('to') ." <a href=\"{$data['node'][MIDCOM_NAV_ABSOLUTEURL]}\">{$data['node'][MIDCOM_NAV_NAME]}</a>\n";
31
+                echo $data['l10n']->get('to') . " <a href=\"{$data['node'][MIDCOM_NAV_ABSOLUTEURL]}\">{$data['node'][MIDCOM_NAV_NAME]}</a>\n";
32 32
             }
33 33
             ?>
34 34
     </p>
Please login to merge, or discard this patch.