Passed
Push — master ( 7328de...3ad1c9 )
by Andreas
37:49 queued 25:28
created
lib/org/openpsa/documents/midcom/interfaces.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 
41 41
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
42 42
     {
43
-        if (   $object instanceof org_openpsa_documents_document_dba
43
+        if ($object instanceof org_openpsa_documents_document_dba
44 44
             && $object->topic == $topic->id) {
45 45
             return "document/{$object->guid}/";
46 46
         }
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/midcom/interfaces.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -77,11 +77,11 @@  discard block
 block discarded – undo
77 77
 
78 78
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
79 79
     {
80
-        if (   $object instanceof org_openpsa_contacts_group_dba
80
+        if ($object instanceof org_openpsa_contacts_group_dba
81 81
             || $object instanceof midcom_db_group) {
82 82
             return "group/{$object->guid}/";
83 83
         }
84
-        if (   $object instanceof org_openpsa_contacts_person_dba
84
+        if ($object instanceof org_openpsa_contacts_person_dba
85 85
             || $object instanceof midcom_db_person) {
86 86
             return "person/{$object->guid}/";
87 87
         }
@@ -110,8 +110,8 @@  discard block
 block discarded – undo
110 110
             // We have a feed URL, but we should check if it is GeoRSS as well
111 111
             $items = net_nemein_rss_fetch::raw_fetch($data['rss_url'])->get_items();
112 112
 
113
-            if (   !empty($items)
114
-                && (   $items[0]->get_latitude()
113
+            if (!empty($items)
114
+                && ($items[0]->get_latitude()
115 115
                     || $items[0]->get_longitude())) {
116 116
                 // This is a GeoRSS feed
117 117
                 $data['georss_url'] = $data['rss_url'];
Please login to merge, or discard this patch.
lib/net/nemein/wiki/style/view-wikipage-raw.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,6 +6,6 @@
 block discarded – undo
6 6
     &(view["content"]:h);
7 7
     <?php
8 8
 } else {
9
-    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub')."</p>";
9
+    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub') . "</p>";
10 10
 }
11 11
 ?>
12 12
\ No newline at end of file
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/style/admin-read.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
         <div class="value"><?php echo $formatter->date($invoice->deliverydate); ?></div></div>
35 35
     <?php } ?>
36 36
 
37
-    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description');?>: </div>
37
+    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description'); ?>: </div>
38 38
     <div class="description value">&(view['description']:h);</div></div>
39 39
 
40 40
     <?php
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/style/show_entries_html.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
             <?php
47 47
             //index is needed for sorting
48 48
             echo "'index_name',";
49
-            echo "'" . $data['l10n']->get('entry title') ."',";
49
+            echo "'" . $data['l10n']->get('entry title') . "',";
50 50
             echo "'" . $data['l10n']->get('entry text') . "',";
51 51
             echo "'" . $data['l10n']->get('entry created') . "',";
52 52
             echo "'index_creator', '" . $data['l10n_midcom']->get('creator') . "',";
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/object/attachments.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -98,13 +98,13 @@  discard block
 block discarded – undo
98 98
         }
99 99
 
100 100
         $mimetype = $request->request->get('midgard_admin_asgard_mimetype');
101
-        if (   !empty($mimetype)
101
+        if (!empty($mimetype)
102 102
             && $local_file->mimetype != $mimetype) {
103 103
             $local_file->mimetype = $mimetype;
104 104
             $needs_update = true;
105 105
         }
106 106
 
107
-        if (   $needs_update
107
+        if ($needs_update
108 108
             && !$local_file->update()) {
109 109
             return null;
110 110
         }
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
         $this->bind_view_to_object($this->_file);
235 235
 
236 236
         $filename = $this->_process_form($request);
237
-        if (   $filename
237
+        if ($filename
238 238
             && $filename != $data['filename']) {
239 239
             return $this->relocate_to_file($filename);
240 240
         }
Please login to merge, or discard this patch.
lib/midcom/services/indexer/document.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -405,7 +405,7 @@
 block discarded – undo
405 405
     {
406 406
         // Complete fields
407 407
         $this->indexed = time();
408
-        if (   $this->author == ''
408
+        if ($this->author == ''
409 409
             && isset($this->creator->name)) {
410 410
             $this->author = $this->creator->name;
411 411
         }
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/duplicates/merge.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
                             $dup = $this->check_duplicate($results, $result, $conf['duplicate_check']);
89 89
 
90 90
                             if ($dup !== true) {
91
-                                if (   !is_object($dup)
91
+                                if (!is_object($dup)
92 92
                                     || !array_key_exists($dup->id, $todelete)) {
93 93
                                     $todelete[$result->id] = $result;
94 94
                                 }
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
                         }
98 98
                     }
99 99
                 }
100
-                if (   $needs_update
100
+                if ($needs_update
101 101
                     && !$result->update()) {
102 102
                     throw new midcom_error("Failed to update {$classname} #{$result->id}, errstr: " . midcom_connection::get_error_string());
103 103
                 }
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
         }
146 146
 
147 147
         foreach ($results as $result) {
148
-            if (   $result->$field === $object->$field
148
+            if ($result->$field === $object->$field
149 149
                 && $result->id !== $object->id) {
150 150
                 return $result;
151 151
             }
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
         $changed = false;
164 164
         foreach ($person2 as $property => $value) {
165 165
             // Copy only simple properties not marked to be skipped missing from person1
166
-            if (   !empty($person2->$property)
166
+            if (!empty($person2->$property)
167 167
                 && empty($person1->$property)
168 168
                 && !isset($skip_properties[$property])
169 169
                 && is_scalar($value)) {
Please login to merge, or discard this patch.
lib/midcom/helper/nav/leaf.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 
29 29
     public function is_readable_by(string $user_id) : bool
30 30
     {
31
-        return (   empty($this->object)
31
+        return (empty($this->object)
32 32
                 || !$this->guid
33 33
                 || !$user_id
34 34
                 || midcom::get()->auth->acl->can_do_byguid('midgard:read', $this->guid, $this->object->__midcom_class_name__, $user_id));
Please login to merge, or discard this patch.