@@ -110,7 +110,7 @@ |
||
| 110 | 110 | public function _on_updated() |
| 111 | 111 | { |
| 112 | 112 | // Sync the object's ACL properties into MidCOM ACL system |
| 113 | - if ( !$this->_skip_acl_refresh) { |
|
| 113 | + if (!$this->_skip_acl_refresh) { |
|
| 114 | 114 | if ($this->orgOpenpsaAccesstype && $this->orgOpenpsaOwnerWg) { |
| 115 | 115 | debug_add("Synchronizing task ACLs to MidCOM"); |
| 116 | 116 | $sync = new org_openpsa_core_acl_synchronizer(); |
@@ -51,7 +51,7 @@ |
||
| 51 | 51 | $this->article->require_do('midgard:update'); |
| 52 | 52 | |
| 53 | 53 | $schemadb = $data['schemadb']; |
| 54 | - if ( $this->_config->get('simple_name_handling') |
|
| 54 | + if ($this->_config->get('simple_name_handling') |
|
| 55 | 55 | && !midcom::get()->auth->can_user_do('midcom:urlname')) { |
| 56 | 56 | foreach ($schemadb->all() as $schema) { |
| 57 | 57 | $schema->get_field('name')['readonly'] = true; |
@@ -107,7 +107,7 @@ |
||
| 107 | 107 | |
| 108 | 108 | // sending per email enabled in billing data? |
| 109 | 109 | $billing_data = org_openpsa_invoices_billing_data_dba::get_by_object($this->invoice); |
| 110 | - if ( !$this->invoice->sent |
|
| 110 | + if (!$this->invoice->sent |
|
| 111 | 111 | && intval($billing_data->sendingoption) == 2) { |
| 112 | 112 | $buttons[] = $this->build_button('send_by_mail', 'paper-plane'); |
| 113 | 113 | } |
@@ -46,7 +46,7 @@ discard block |
||
| 46 | 46 | ] |
| 47 | 47 | ]); |
| 48 | 48 | |
| 49 | - $resolver->setNormalizer('constraints', function (Options $options, $value) { |
|
| 49 | + $resolver->setNormalizer('constraints', function(Options $options, $value) { |
|
| 50 | 50 | if ($options['required']) { |
| 51 | 51 | return [new constraint(['config' => $options['type_config']])]; |
| 52 | 52 | } |
@@ -78,7 +78,7 @@ discard block |
||
| 78 | 78 | |
| 79 | 79 | $builder->add('delete', CheckboxType::class, ['attr' => [ |
| 80 | 80 | "class" => "midcom_datamanager_photo_checkbox" |
| 81 | - ], "required" => false ]); |
|
| 81 | + ], "required" => false]); |
|
| 82 | 82 | $builder->add('identifier', HiddenType::class); |
| 83 | 83 | } |
| 84 | 84 | |
@@ -59,7 +59,7 @@ |
||
| 59 | 59 | |
| 60 | 60 | public function __set($name, $value) |
| 61 | 61 | { |
| 62 | - if ( $name == 'homepage' |
|
| 62 | + if ($name == 'homepage' |
|
| 63 | 63 | && !empty($value) |
| 64 | 64 | && $value != $this->homepage) { |
| 65 | 65 | $this->_register_prober = true; |
@@ -84,7 +84,7 @@ discard block |
||
| 84 | 84 | net_nemein_rss_manage::add_toolbar_buttons($this->_node_toolbar, $this->_topic->can_do('midgard:create')); |
| 85 | 85 | } |
| 86 | 86 | |
| 87 | - if ( $this->_topic->can_do('midgard:update') |
|
| 87 | + if ($this->_topic->can_do('midgard:update') |
|
| 88 | 88 | && $this->_topic->can_do('midcom:component_config')) { |
| 89 | 89 | $buttons[] = $workflow->get_button('config/', [ |
| 90 | 90 | MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'), |
@@ -114,7 +114,7 @@ discard block |
||
| 114 | 114 | $this->_request_data['categories'] = explode(',', $this->_config->get('categories')); |
| 115 | 115 | |
| 116 | 116 | foreach ($this->_request_data['schemadb']->all() as $schema) { |
| 117 | - if ( $schema->has_field('categories') |
|
| 117 | + if ($schema->has_field('categories') |
|
| 118 | 118 | && $schema->get_field('categories')['type'] == 'select') { |
| 119 | 119 | // TODO: Merge schema local and component config categories? |
| 120 | 120 | $options = array_combine($this->_request_data['categories'], $this->_request_data['categories']); |
@@ -61,7 +61,7 @@ |
||
| 61 | 61 | public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self |
| 62 | 62 | { |
| 63 | 63 | if ( !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer)) |
| 64 | - // check if the customerContact is set and has invoice_data |
|
| 64 | + // check if the customerContact is set and has invoice_data |
|
| 65 | 65 | && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) { |
| 66 | 66 | $bd = new self(); |
| 67 | 67 | $due = midcom_baseclasses_components_configuration::get('org.openpsa.invoices', 'config')->get('default_due_days'); |
@@ -52,7 +52,7 @@ discard block |
||
| 52 | 52 | */ |
| 53 | 53 | public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self |
| 54 | 54 | { |
| 55 | - if ( !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer)) |
|
| 55 | + if (!($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer)) |
|
| 56 | 56 | // check if the customerContact is set and has invoice_data |
| 57 | 57 | && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) { |
| 58 | 58 | $bd = new self(); |
@@ -68,7 +68,7 @@ discard block |
||
| 68 | 68 | /** |
| 69 | 69 | * Get the billing data for given contact if any. |
| 70 | 70 | */ |
| 71 | - private static function get_billing_data(string $dba_class, string|int $contact_id) : ?self |
|
| 71 | + private static function get_billing_data(string $dba_class, string | int $contact_id) : ?self |
|
| 72 | 72 | { |
| 73 | 73 | if ($contact_id == 0) { |
| 74 | 74 | return null; |
@@ -86,7 +86,8 @@ discard block |
||
| 86 | 86 | // if the property useContactAddress is set |
| 87 | 87 | $billing_data[0]->set_address(); |
| 88 | 88 | return $billing_data[0]; |
| 89 | - } catch (midcom_error $e) { |
|
| 89 | + } |
|
| 90 | + catch (midcom_error $e) { |
|
| 90 | 91 | $e->log(); |
| 91 | 92 | return null; |
| 92 | 93 | } |
@@ -131,10 +132,12 @@ discard block |
||
| 131 | 132 | { |
| 132 | 133 | try { |
| 133 | 134 | return new org_openpsa_contacts_person_dba($this->linkGuid); |
| 134 | - } catch (midcom_error) { |
|
| 135 | + } |
|
| 136 | + catch (midcom_error) { |
|
| 135 | 137 | try { |
| 136 | 138 | return new org_openpsa_contacts_group_dba($this->linkGuid); |
| 137 | - } catch (midcom_error $e) { |
|
| 139 | + } |
|
| 140 | + catch (midcom_error $e) { |
|
| 138 | 141 | debug_add("Failed to load contact with GUID: " . $this->linkGuid . " - last error:" . $e->getMessage(), MIDCOM_LOG_ERROR); |
| 139 | 142 | return false; |
| 140 | 143 | } |
@@ -26,7 +26,7 @@ |
||
| 26 | 26 | |
| 27 | 27 | private function load_controller() : controller |
| 28 | 28 | { |
| 29 | - if ( $this->_config->get('simple_name_handling') |
|
| 29 | + if ($this->_config->get('simple_name_handling') |
|
| 30 | 30 | && !midcom::get()->auth->admin) { |
| 31 | 31 | foreach ($this->_request_data['schemadb']->all() as $schema) { |
| 32 | 32 | $schema->get_field('name')['readonly'] = true; |
@@ -109,20 +109,20 @@ discard block |
||
| 109 | 109 | } |
| 110 | 110 | |
| 111 | 111 | // Approval attributes |
| 112 | - if ( midcom::get()->config->get('metadata_approval') |
|
| 112 | + if (midcom::get()->config->get('metadata_approval') |
|
| 113 | 113 | && !$object->metadata->is_approved()) { |
| 114 | 114 | $css_classes[] = 'unapproved'; |
| 115 | 115 | } |
| 116 | 116 | |
| 117 | 117 | // Hiding and scheduling attributes |
| 118 | - if ( ( !midcom::get()->config->get('show_hidden_objects') |
|
| 118 | + if ((!midcom::get()->config->get('show_hidden_objects') |
|
| 119 | 119 | || midcom::get()->config->get('metadata_scheduling')) |
| 120 | 120 | && !$object->metadata->is_visible()) { |
| 121 | 121 | $css_classes[] = 'hidden'; |
| 122 | 122 | } |
| 123 | 123 | |
| 124 | 124 | // Folder's class |
| 125 | - if ( $object instanceof midcom_db_topic |
|
| 125 | + if ($object instanceof midcom_db_topic |
|
| 126 | 126 | && $page_class = $object->get_parameter('midcom.services.metadata', 'page_class')) { |
| 127 | 127 | $css_classes[] = $page_class; |
| 128 | 128 | } |
@@ -193,7 +193,7 @@ discard block |
||
| 193 | 193 | private function _add_opengraph_metadata(midcom_helper_metadata $view_metadata) |
| 194 | 194 | { |
| 195 | 195 | $opengraph_type = $view_metadata->object->get_parameter('midcom.helper.metadata', 'opengraph_type'); |
| 196 | - if ( $opengraph_type |
|
| 196 | + if ($opengraph_type |
|
| 197 | 197 | && $opengraph_type != 'none') { |
| 198 | 198 | $request_metadata = $this->get_request_metadata(); |
| 199 | 199 | |