flack / openpsa

lib/org/openpsa/mail/backend.php

Braces +4 added lines, -2 removed lines

@@ -45,7 +45,8 @@ 
                     $object = self::_load_backend($backend, $params);
                     debug_add('Using backend ' . $backend);
                     return $object;
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     debug_add('Failed to load backend ' . $backend . ', message:' . $e->getMessage());
                 }
             }
@@ -80,7 +81,8 @@ 
             $ret = $this->mail($message);
             $this->error = null;
             return $ret;
-        } catch (Exception $e) {
+        }
+        catch (Exception $e) {
             $this->error = $e->getMessage();
             return false;
         }

src/midcom/console/command/cacheinvalidate.php

Braces +2 added lines, -1 removed lines

@@ -33,7 +33,8 @@
     {
         try {
             midcom::get()->cache->invalidate_all();
-        } catch (\Throwable $e) {
+        }
+        catch (\Throwable $e) {
             $output->writeln($e->getMessage());
         }
         $fs = new Filesystem;

lib/midcom/core/dbaproxy.php

Braces +2 added lines, -1 removed lines

@@ -64,7 +64,8 @@
         try {
             $this->__object = $this->__midcom_class_name__::get_cached($this->__identifier);
             return true;
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
         return false;

src/midcom/console/command/reindex.php

Braces +2 added lines, -1 removed lines

@@ -73,7 +73,8 @@
             if (is_a($stat, midcom_services_indexer_client::class)) {
                 try {
                     $stat->reindex();
-                } catch (RequestException $e) {
+                }
+                catch (RequestException $e) {
                     if ($e->hasResponse()) {
                         $crawler = new Crawler($e->getResponse()->getBody()->getContents());
                         $body = $crawler->filterXPath('//body')->html();

lib/org/openpsa/directmarketing/sender/backend/email.php

Spacing +1 added lines, -1 removed lines

@@ -166,7 +166,7 @@
         $address = addslashes($address);
         return preg_replace_callback(
             '/href="(http:\/\/.*?)"/i',
-            function ($match) use ($address) {
+            function($match) use ($address) {
                 return 'href="' . str_replace("URL", rawurlencode($match[1]), $address) . '"';
             },
             $html);

Indentation +7 added lines, -7 removed lines

@@ -148,13 +148,13 @@
     }
 
     /**
-    * Inserts a link detector to the given HTML source. All outgoing
-    * HTTP links in the source HTML are replaced with the given
-    * link detector address so that the token "URL" is replaced with
-    * encoded form of the original link. It is expected that the link detector
-    * address points to a script that records the passed link and
-    * forwards the client to the real link target.
-    */
+     * Inserts a link detector to the given HTML source. All outgoing
+     * HTTP links in the source HTML are replaced with the given
+     * link detector address so that the token "URL" is replaced with
+     * encoded form of the original link. It is expected that the link detector
+     * address points to a script that records the passed link and
+     * forwards the client to the real link target.
+     */
     private function _insert_link_detector(string $html, string $address) : string
     {
         $address = addslashes($address);

lib/org/openpsa/sales/salesproject/deliverable.php

Spacing +4 added lines, -4 removed lines

@@ -81,7 +81,7 @@ 
     {
         $this->calculate_price(false);
 
-        if (   $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
+        if ($this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
             && $this->continuous) {
             $this->end = 0;
         } elseif ($this->end < $this->start) {
@@ -169,7 +169,7 @@ 
         $calculator->run($this);
         $cost = $calculator->get_cost();
         $price = $calculator->get_price();
-        if (   $price != $this->price
+        if ($price != $this->price
             || $cost != $this->cost) {
             $this->price = $price;
             $this->cost = $cost;
@@ -216,7 +216,7 @@ 
         $units = $agreement_hours['invoiceable'];
         $uninvoiceableUnits = $agreement_hours['reported'] - ($agreement_hours['invoiceable'] + $agreement_hours['invoiced']);
 
-        if (   $units != $this->units
+        if ($units != $this->units
             || $uninvoiceableUnits != $this->uninvoiceableUnits) {
             debug_add("agreement values have changed, setting units to " . $units . ", uninvoiceable: " . $uninvoiceableUnits);
             $this->units = $units;
@@ -270,7 +270,7 @@ 
 
     public function invoice() : bool
     {
-        if (   $this->state >= self::STATE_INVOICED
+        if ($this->state >= self::STATE_INVOICED
             || $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
             return false;
         }

lib/midgard/admin/asgard/style/ASGARD_ROOT.php

Braces +4 added lines, -2 removed lines

@@ -122,7 +122,8 @@ 
                             try {
                                 $creator = new midcom_db_person($view_metadata->get('creator'));
                                 $creator_string = "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/view/{$creator->guid}/\">$creator->name</a>";
-                            } catch (midcom_error $e) {
+                            }
+                            catch (midcom_error $e) {
                                 $creator_string = $l10n->get('unknown person');
                             }
                             $created = (int) $view_metadata->get('created');
@@ -135,7 +136,8 @@ 
                                 try {
                                     $editor = new midcom_db_person($view_metadata->get('revisor'));
                                     $editor_string = "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/view/{$editor->guid}/\">$editor->name</a>";
-                                } catch (midcom_error $e) {
+                                }
+                                catch (midcom_error $e) {
                                     $editor_string = $l10n->get('unknown person');
                                 }
 

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
 
                             $edited = (int) $view_metadata->get('revised');
                             $revision = $view_metadata->get('revision');
-                            if (   $revision > 1
+                            if ($revision > 1
                                 && $edited != $created) {
                                 try {
                                     $editor = new midcom_db_person($view_metadata->get('revisor'));

lib/midcom/services/auth/main.php

Braces +2 added lines, -1 removed lines

@@ -575,7 +575,8 @@
                     $param = $param->__object;
                 }
                 $this->_group_cache[$id] = new midcom_core_group($param);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 debug_add("Group with identifier {$id} could not be loaded: " . $e->getMessage(), MIDCOM_LOG_WARN);
                 $this->_group_cache[$id] = null;
             }

Spacing +1 added lines, -1 removed lines

@@ -221,7 +221,7 @@
             return true;
         }
         if ($user === null) {
-            $user =& $this->user;
+            $user = & $this->user;
         }
 
         if ($user == 'EVERYONE') {

lib/midcom/services/auth/backend.php

Braces +2 added lines, -1 removed lines

@@ -87,7 +87,8 @@
                     $param = $param->__object;
                 }
                 $this->_user_cache[$id] = new midcom_core_user($param);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 // Keep it silent while missing user object can mess here
                 $this->_user_cache[$id] = null;
             }

Spacing +2 added lines, -2 removed lines

@@ -100,7 +100,7 @@ 
             return null;
         }
 
-        if (   midcom::get()->config->get('auth_check_client_ip')
+        if (midcom::get()->config->get('auth_check_client_ip')
             && $data['clientip'] != $request->getClientIp()) {
             debug_add("The session had mismatching client IP.", MIDCOM_LOG_INFO);
             debug_add("Expected {$data['clientip']}, got {$request->getClientIp()}.");
@@ -114,7 +114,7 @@ 
             return null;
         }
 
-        if (   !$this->check_timestamp($data['timestamp'], $user)
+        if (!$this->check_timestamp($data['timestamp'], $user)
             || !$this->authenticate($user->username, '', true)) {
             $this->logout($user);
             return null;