flack / openpsa

lib/midcom/helper/reflector/nameresolver.php

Spacing +3 added lines, -3 removed lines

@@ -32,7 +32,7 @@ 
     public function get_object_name(?string $name_property = null) : ?string
     {
         $name_property ??= midcom_helper_reflector::get_name_property($this->_object);
-        if (    empty($name_property)
+        if (empty($name_property)
             || !midcom_helper_reflector::get($this->_object)->property_exists($name_property)) {
             // Could not resolve valid property
             return null;
@@ -124,7 +124,7 @@ 
 
             $qb->add_constraint($child_name_property, '=', $name);
             if ($qb->count()) {
-                debug_add("Name clash in sibling class {$schema_type} for " . get_class($this->_object) . " #{$this->_object->id} (path '" . midcom_helper_reflector_tree::resolve_path($this->_object, '/') . "')" );
+                debug_add("Name clash in sibling class {$schema_type} for " . get_class($this->_object) . " #{$this->_object->id} (path '" . midcom_helper_reflector_tree::resolve_path($this->_object, '/') . "')");
                 return false;
             }
         }
@@ -199,7 +199,7 @@ 
         } while (!$this->name_is_unique());
 
         // Get a copy of the current, usable name
-        $ret = (string)$this->_object->{$name_prop};
+        $ret = (string) $this->_object->{$name_prop};
         // Restore the original name
         $this->_object->{$name_prop} = $original_name;
         return $ret;

lib/midcom/db/attachment.php

Spacing +2 added lines, -2 removed lines

@@ -155,7 +155,7 @@ 
         return "{$cacheroot}/{$subdir}/{$this->guid}/{$this->name}";
     }
 
-    public static function get_url(midgard_attachment|midcom_db_attachment|string $attachment, ?string $name = null) : string
+    public static function get_url(midgard_attachment | midcom_db_attachment | string $attachment, ?string $name = null) : string
     {
         if (is_string($attachment)) {
             $guid = $attachment;
@@ -301,7 +301,7 @@ 
     public function update_cache()
     {
         // Check if the attachment can be read anonymously
-        if (   midcom::get()->config->get('attachment_cache_enabled')
+        if (midcom::get()->config->get('attachment_cache_enabled')
             && !$this->can_do('midgard:read', 'EVERYONE')) {
             // Not public file, ensure it is removed
             $this->remove_from_cache();

lib/org/openpsa/user/handler/person/create.php

Spacing +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
 
     public function _handler_create(Request $request, array &$data, ?string $guid = null)
     {
-        midcom::get()->auth->require_user_do('org.openpsa.user:manage', class: org_openpsa_user_interface::class);
+        midcom::get()->auth->require_user_do('org.openpsa.user:manage', class : org_openpsa_user_interface::class);
 
         if ($guid !== null) {
             // Get the organization

lib/org/openpsa/contacts/handler/person/create.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 
     public function _handler_create(Request $request, ?string $guid = null)
     {
-        midcom::get()->auth->require_user_do('midgard:create', class: org_openpsa_contacts_person_dba::class);
+        midcom::get()->auth->require_user_do('midgard:create', class : org_openpsa_contacts_person_dba::class);
 
         $defaults = [];
         if (!empty($guid)) {

lib/org/openpsa/sales/handler/edit.php

Spacing +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
 
     public function _handler_new(Request $request, ?string $guid = null)
     {
-        midcom::get()->auth->require_user_do('midgard:create', class: org_openpsa_sales_salesproject_dba::class);
+        midcom::get()->auth->require_user_do('midgard:create', class : org_openpsa_sales_salesproject_dba::class);
 
         $this->_salesproject = new org_openpsa_sales_salesproject_dba;
 
@@ -48,7 +48,7 @@ 
         $schemadb = schemadb::from_path($this->_config->get('schemadb_salesproject'));
 
         if ($guid) {
-            $field =& $schemadb->get('default')->get_field('customer');
+            $field = & $schemadb->get('default')->get_field('customer');
             try {
                 $customer = new org_openpsa_contacts_group_dba($guid);
                 $field['type_config']['options'] = [0 => '', $customer->id => $customer->official];

Braces +4 added lines, -2 removed lines

@@ -54,7 +54,8 @@ 
                 $field['type_config']['options'] = [0 => '', $customer->id => $customer->official];
 
                 $defaults['customer'] = $customer->id;
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 $customer = new org_openpsa_contacts_person_dba($guid);
                 $defaults['customerContact'] = $customer->id;
                 $field['type_config']['options'] = $this->list_groups([$customer->id => true]);
@@ -126,7 +127,8 @@ 
             try {
                 $company = new org_openpsa_contacts_group_dba($company_id);
                 $ret[$company->id] = $company->get_label();
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

lib/org/openpsa/directmarketing/handler/import.php

Spacing +2 added lines, -2 removed lines

@@ -138,7 +138,7 @@ 
 
         if ($contacts = $importer->parse($input)) {
             $this->_request_data['import_status'] = $importer->import_subscribers($contacts, $this->_request_data['campaign']);
-            if (   $this->_request_data['import_status']['subscribed_new'] > 0
+            if ($this->_request_data['import_status']['subscribed_new'] > 0
                 || $this->_request_data['import_status']['already_subscribed'] > 0) {
                 $this->_import_success = true;
             }
@@ -195,7 +195,7 @@ 
                 $read_rows = 0;
                 $handle = fopen($data['tmp_file'], 'r');
                 $total_columns = 0;
-                while (   $read_rows < 2
+                while ($read_rows < 2
                        && $csv_line = fgetcsv($handle, 1000, $data['separator'])) {
                     if ($total_columns == 0) {
                         $total_columns = count($csv_line);

lib/org/openpsa/sales/validator.php

Spacing +2 added lines, -2 removed lines

@@ -17,7 +17,7 @@ 
     {
         $result = $this->validate_units($fields);
 
-        if (   empty($fields['end'])
+        if (empty($fields['end'])
             && empty($fields['continuous'])) {
             if ($result === true) {
                 $result = [];
@@ -29,7 +29,7 @@ 
 
     public function validate_units(array $fields)
     {
-        if (   empty($fields['invoiceByActualUnits'])
+        if (empty($fields['invoiceByActualUnits'])
             && empty($fields['plannedUnits'])) {
             return [
                 'plannedUnits' => midcom::get()->i18n->get_string('select either planned units or invoice by actual units', 'org.openpsa.sales')

lib/org/openpsa/sales/handler/deliverable/admin.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
             $schema->get_field('next_cycle')['hidden'] = false;
             $schema->get_field('next_cycle')['default'] = $entry->start;
             $schema->get_field('at_entry')['default'] = $entry->id;
-        } elseif (   ($this->_deliverable->continuous || $this->_deliverable->end > time())
+        } elseif (($this->_deliverable->continuous || $this->_deliverable->end > time())
                   && $this->_deliverable->state == org_openpsa_sales_salesproject_deliverable_dba::STATE_STARTED) {
             $schema->get_field('next_cycle')['hidden'] = false;
         }

lib/net/nehmer/comments/handler/moderate.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
         $message['title'] = sprintf($this->_l10n->get('comment %s reported as abuse'), $comment->title);
         $message['content'] = '';
         if ($logs = $comment->get_logs()) {
-            $message['content'] .= $this->_l10n->get('moderation history').":\n\n";
+            $message['content'] .= $this->_l10n->get('moderation history') . ":\n\n";
             foreach ($logs as $time => $log) {
                 $reported = $this->_l10n->get_formatter()->datetime(strtotime("{$time}Z"));
                 $message['content'] .= $this->_l10n->get(sprintf('%s: %s by %s (from %s)', "$reported:\n", $this->_l10n->get($log['action']), $log['reporter'], $log['ip'])) . "\n\n";