flack / openpsa

lib/midcom/services/uimessages.php

Spacing +1 added lines, -1 removed lines

@@ -133,7 +133,7 @@
      */
     public function show(bool $show_simple = false)
     {
-        if (   $show_simple
+        if ($show_simple
             || !midcom::get()->auth->can_user_do('midcom:ajax', class: static::class)) {
             $this->show_simple();
             return;

lib/midcom/services/toolbars.php

Spacing +1 added lines, -1 removed lines

@@ -272,7 +272,7 @@
 
     private function add_head_elements(bool $centralized = false) : bool
     {
-        if (   !midcom::get()->auth->user
+        if (!midcom::get()->auth->user
             || !midcom::get()->config->get('toolbars_enable_centralized')
             || !midcom::get()->auth->can_user_do('midcom:centralized_toolbar', class: __CLASS__)) {
             return false;

lib/midcom/baseclasses/core/dbobject.php

Spacing +4 added lines, -4 removed lines

@@ -119,14 +119,14 @@ 
         if ($parent = $object->get_parent()) {
             // Attachments are a special case
             if ($object instanceof midcom_db_attachment) {
-                if (   !$parent->can_do('midgard:attachments')
+                if (!$parent->can_do('midgard:attachments')
                     || !$parent->can_do('midgard:update')) {
                     debug_add("Failed to create attachment, update or attachments privilege on the parent " . get_class($parent) . " {$parent->guid} not granted for the current user.",
                         MIDCOM_LOG_ERROR);
                     midcom_connection::set_error(MGD_ERR_ACCESS_DENIED);
                     return false;
                 }
-            } elseif (   !$parent->can_do('midgard:create')
+            } elseif (!$parent->can_do('midgard:create')
                       && !midcom::get()->auth->can_user_do('midgard:create', class: get_class($object))) {
                 debug_add("Failed to create object, create privilege on the parent " . get_class($parent) . " {$parent->guid} or the actual object class not granted for the current user.",
                     MIDCOM_LOG_ERROR);
@@ -238,7 +238,7 @@ 
             }
 
             // Default the owner to first group of current user
-            if (   empty($object->metadata->owner)
+            if (empty($object->metadata->owner)
                 && $first_group = midcom::get()->auth->user->get_first_group_guid()) {
                 $object->metadata->set('owner', $first_group);
             }
@@ -462,7 +462,7 @@ 
      */
     public static function get_by_guid(midcom_core_dbaobject $object, string $guid) : bool
     {
-        if (   !midcom::get()->auth->admin
+        if (!midcom::get()->auth->admin
             && !midcom::get()->auth->acl->can_do_byguid('midgard:read', $guid, get_class($object), midcom::get()->auth->acl->get_user_id())) {
             debug_add("Failed to load object, read privilege on the " . get_class($object) . " {$guid} not granted for the current user.", MIDCOM_LOG_ERROR);
             return false;

Braces +2 added lines, -1 removed lines

@@ -423,7 +423,8 @@
          */
         try {
             return $object->get_by_id($object->id);
-        } catch (Exception) {
+        }
+        catch (Exception) {
             return false;
         }
     }

lib/org/openpsa/contacts/handler/group/view.php

Spacing +2 added lines, -2 removed lines

@@ -44,7 +44,7 @@ 
             ];
         }
 
-        if (   midcom::get()->auth->can_user_do('midgard:create', class: org_openpsa_contacts_person_dba::class)
+        if (midcom::get()->auth->can_user_do('midgard:create', class: org_openpsa_contacts_person_dba::class)
             && $this->group->can_do('midgard:create')) {
                 $buttons[] = $workflow->get_button($this->router->generate('person_new_group', ['guid' => $this->group->guid]), [
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('create person'),
@@ -54,7 +54,7 @@ 
 
         $siteconfig = org_openpsa_core_siteconfig::get_instance();
         $user_url = $siteconfig->get_node_full_url('org.openpsa.user');
-        if (   $user_url
+        if ($user_url
             && midcom::get()->auth->can_user_do('org.openpsa.user:access', class: org_openpsa_user_interface::class)) {
             $buttons[] = [
                 MIDCOM_TOOLBAR_URL => $user_url . "group/{$this->group->guid}/",

lib/org/openpsa/user/handler/person/view.php

Spacing +2 added lines, -2 removed lines

@@ -25,7 +25,7 @@ 
         $this->add_breadcrumb('', $person->get_label());
 
         $auth = midcom::get()->auth;
-        if (   $person->guid == midcom::get()->auth->user->guid
+        if ($person->guid == midcom::get()->auth->user->guid
             || $auth->can_user_do('org.openpsa.user:manage', class: org_openpsa_user_interface::class)) {
             $buttons = [];
             $workflow = $this->get_workflow('datamanager');
@@ -38,7 +38,7 @@ 
                 $delete_workflow = $this->get_workflow('delete', ['object' => $person]);
                 $buttons[] = $delete_workflow->get_button($this->router->generate('user_delete', ['guid' => $person->guid]));
             }
-            if (   $data['account']->get_username()
+            if ($data['account']->get_username()
                 && $person->can_do('midgard:privileges')) {
                 $buttons[] = $workflow->get_button($this->router->generate('user_privileges', ['guid' => $person->guid]), [
                     MIDCOM_TOOLBAR_LABEL => $this->_l10n->get("permissions"),

lib/org/openpsa/sales/handler/view.php

Spacing +3 added lines, -3 removed lines

@@ -83,7 +83,7 @@ 
         }
 
         if ($this->_config->get('sales_pdfbuilder_class')) {
-            if (   $this->_salesproject->can_do('midgard:update')
+            if ($this->_salesproject->can_do('midgard:update')
                 && $this->is_pdf_creatable()) {
                 $workflow = $this->get_workflow('datamanager');
                 $buttons[] = $workflow->get_button($this->router->generate('create_offer', ['guid' => $this->_salesproject->guid]), [
@@ -204,7 +204,7 @@ 
             case 'ordered':
                 if ($deliverable->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
                     $entries = $deliverable->get_at_entries();
-                    if (   $entries
+                    if ($entries
                         && $entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
                         && midcom::get()->auth->can_user_do('midgard:create', class: org_openpsa_invoices_invoice_dba::class)) {
                         return '<button class="run_cycle"><i class="fa fa-refresh"></i>' . $this->_l10n->get('generate now') . '</button>';
@@ -214,7 +214,7 @@ 
                 }
                 break;
             case 'delivered':
-                if (   $deliverable->orgOpenpsaObtype != org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
+                if ($deliverable->orgOpenpsaObtype != org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
                     && midcom::get()->auth->can_user_do('midgard:create', class: org_openpsa_invoices_invoice_dba::class)) {
                     $client_class = $this->_config->get('calculator');
                     $client = new $client_class();

src/midcom/datamanager/extension/textareaExtension.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
      */
     public function configureOptions(OptionsResolver $resolver) : void
     {
-        $map_attr = function (Options $options, $value) {
+        $map_attr = function(Options $options, $value) {
             $value ??= [];
             $value['rows'] = $options['widget_config']['height'];
             $value['cols'] = $options['widget_config']['width'];

src/midcom/datamanager/extension/transformer/jsdateTransformer.php

Spacing +4 added lines, -4 removed lines

@@ -33,8 +33,8 @@ 
             }
         }
 
-        if (   empty($input)
-            || (   $input instanceof DateTime
+        if (empty($input)
+            || ($input instanceof DateTime
                 && $input->format('Y-m-d H:i:s') == '0001-01-01 00:00:00')) {
             return $result;
         }
@@ -59,8 +59,8 @@ 
             throw new TransformationFailedException('Expected an array.');
         }
 
-        if (   empty($array['date'])
-            || (   $array['date'] instanceof DateTime
+        if (empty($array['date'])
+            || ($array['date'] instanceof DateTime
                 && $array['date']->format('Y-m-d H:i:s') == '0001-01-01 00:00:00')) {
             return null;
         }

lib/midcom/response/relocate.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
      */
     public function setTargetUrl(string $url) : static
     {
-        if (   !str_starts_with($url, "/")
+        if (!str_starts_with($url, "/")
             && !preg_match('|^https?://|', $url)) {
             $prefix = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ANCHORPREFIX) ?: '/';
             $url = $prefix . $url;