Passed
Push — master ( 1a9f82...722134 )
by Andreas
12:17
created
lib/midcom/services/auth/backend.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
             return null;
101 101
         }
102 102
 
103
-        if (   midcom::get()->config->get('auth_check_client_ip')
103
+        if (midcom::get()->config->get('auth_check_client_ip')
104 104
             && $data['clientip'] != $request->getClientIp()) {
105 105
             debug_add("The session had mismatching client IP.", MIDCOM_LOG_INFO);
106 106
             debug_add("Expected {$data['clientip']}, got {$request->getClientIp()}.");
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
             return null;
115 115
         }
116 116
 
117
-        if (   !$this->check_timestamp($data['timestamp'], $user)
117
+        if (!$this->check_timestamp($data['timestamp'], $user)
118 118
             || !$this->authenticate($user->username, '', true)) {
119 119
             $this->logout($user);
120 120
             return null;
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,8 @@
 block discarded – undo
77 77
         if (!array_key_exists($id, $this->_user_cache)) {
78 78
             try {
79 79
                 $this->_user_cache[$id] = new midcom_core_user($param);
80
-            } catch (midcom_error) {
80
+            }
81
+            catch (midcom_error) {
81 82
                 // Keep it silent while missing user object can mess here
82 83
                 $this->_user_cache[$id] = null;
83 84
             }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/undelete.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@
 block discarded – undo
149 149
             $child_indent = $indent + 20;
150 150
             echo "{$prefix}<tbody class=\"children\">\n";
151 151
             foreach ($child_types as $type => $children) {
152
-                if (   count($children) < 10
152
+                if (count($children) < 10
153 153
                     || isset($_GET['show_children'][$object->guid][$type])) {
154 154
                         foreach ($children as $child) {
155 155
                             $this->show_type($child, $child_indent, "{$prefix}    ", false);
Please login to merge, or discard this patch.
lib/net/nehmer/blog/style/index-item.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
         &(published:h);
29 29
             <?php
30 30
             if ($data['linked']) {
31
-                echo $data['l10n']->get('to') ." <a href=\"{$data['node'][MIDCOM_NAV_ABSOLUTEURL]}\">{$data['node'][MIDCOM_NAV_NAME]}</a>\n";
31
+                echo $data['l10n']->get('to') . " <a href=\"{$data['node'][MIDCOM_NAV_ABSOLUTEURL]}\">{$data['node'][MIDCOM_NAV_NAME]}</a>\n";
32 32
             }
33 33
             ?>
34 34
     </p>
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/handler/invoice/crud.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -141,8 +141,8 @@
 block discarded – undo
141 141
         $schema->get_field('paid')['hidden'] = empty($this->invoice->paid);
142 142
 
143 143
         $contact = $this->invoice->customerContact ?: $this->contact_id;
144
-        $customer_field =& $schema->get_field('customer');
145
-        $contact_field =& $schema->get_field('customerContact');
144
+        $customer_field = & $schema->get_field('customer');
145
+        $contact_field = & $schema->get_field('customerContact');
146 146
 
147 147
         if (!empty($contact)) {
148 148
             $customer_field['type_config']['options'] = $this->get_customers_for_contact($contact);
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,7 +42,8 @@  discard block
 block discarded – undo
42 42
             // We're creating invoice for chosen customer
43 43
             try {
44 44
                 $this->customer = new org_openpsa_contacts_group_dba($company);
45
-            } catch (midcom_error) {
45
+            }
46
+            catch (midcom_error) {
46 47
                 $contact = new org_openpsa_contacts_person_dba($company);
47 48
                 $this->contact_id = $contact->id;
48 49
             }
@@ -143,7 +144,8 @@  discard block
 block discarded – undo
143 144
             if (!empty($this->invoice->customer)) {
144 145
                 try {
145 146
                     $this->customer = org_openpsa_contacts_group_dba::get_cached($this->invoice->customer);
146
-                } catch (midcom_error $e) {
147
+                }
148
+                catch (midcom_error $e) {
147 149
                     $customer_field['hidden'] = true;
148 150
                     $e->log();
149 151
                 }
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/handler/journal/entry.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
     public function _handler_create(Request $request, string $guid)
34 34
     {
35 35
         $current_object = midcom::get()->dbfactory->get_object_by_guid($guid);
36
-        $entry= new org_openpsa_relatedto_journal_entry_dba();
36
+        $entry = new org_openpsa_relatedto_journal_entry_dba();
37 37
         $entry->linkGuid = $current_object->guid;
38 38
 
39 39
         midcom::get()->head->set_pagetitle($this->_l10n->get('add journal entry'));
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
53 53
         if ($entry->can_do('midgard:delete')) {
54 54
             $delete = $this->get_workflow('delete', ['object' => $entry]);
55
-            $url = $this->router->generate('journal_entry_delete', ['guid' => $guid ]);
55
+            $url = $this->router->generate('journal_entry_delete', ['guid' => $guid]);
56 56
             $workflow->add_dialog_button($delete, $url);
57 57
         }
58 58
         return $workflow->run($request);
Please login to merge, or discard this patch.
src/midcom/console/command/repligard.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
     private function _confirm(InputInterface $input, OutputInterface $output) : bool
101 101
     {
102 102
         $options = [true => 'y', false => 'N'];
103
-        $question = '<question>Delete all rows? [' . implode('|', $options). ']</question> ';
103
+        $question = '<question>Delete all rows? [' . implode('|', $options) . ']</question> ';
104 104
         $question = new ConfirmationQuestion($question, false);
105 105
         $dialog = $this->getHelperSet()->get('question');
106 106
         return $dialog->ask($input, $output, $question);
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,8 @@
 block discarded – undo
37 37
     {
38 38
         try {
39 39
             $this->db = connection::get_em()->getConnection()->getNativeConnection();
40
-        } catch (\Exception) {
40
+        }
41
+        catch (\Exception) {
41 42
             $this->db = $this->create_connection($input, $output);
42 43
         }
43 44
 
Please login to merge, or discard this patch.
src/midcom/datamanager/template/form.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
     public function form_end(FormView $view, array $data)
85 85
     {
86 86
         $string = '';
87
-        if (   !isset($data['render_rest'])
87
+        if (!isset($data['render_rest'])
88 88
             || $data['render_rest']) {
89 89
             $string .= $this->renderer->rest($view);
90 90
         }
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
             $data['attr']['class'] = 'shorttext';
224 224
         }
225 225
 
226
-        if (   !empty($data['value'])
226
+        if (!empty($data['value'])
227 227
             || is_numeric($data['value'])) {
228 228
             $data['attr']['value'] = $data['value'];
229 229
         }
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
     {
266 266
         if ($view->vars['readonly']) {
267 267
             $string = $this->get_view_renderer()->autocomplete_widget($view, $data);
268
-            return $string .  $this->renderer->widget($view['selection']);
268
+            return $string . $this->renderer->widget($view['selection']);
269 269
         }
270 270
 
271 271
         autocomplete::add_head_elements($data['handler_options']['creation_mode_enabled'], $data['handler_options']['sortable']);
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
         $jsinit .= "midcom_helper_datamanager2_autocomplete.create_dm2_widget('{$element_id}_search_input', {$data['min_chars']});\n";
276 276
 
277 277
         $string = '<fieldset ' . $this->renderer->block($view, 'widget_container_attributes') . '>';
278
-        $string .=  $this->renderer->widget($view['selection']);
278
+        $string .= $this->renderer->widget($view['selection']);
279 279
         $string .= ' ' . $this->renderer->widget($view['search_input']);
280 280
         $string .= '</fieldset>';
281 281
         return $string . $this->jsinit($jsinit);
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
         }
325 325
 
326 326
         $string = '<select ';
327
-        if (   $data['required']
327
+        if ($data['required']
328 328
             && null === $data['placeholder']
329 329
             && $data['placeholder_in_choices'] === false
330 330
             && $data['multiple'] === false) {
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
         $string .= $this->renderer->block($view, 'widget_attributes', $data) . '>';
339 339
         if (null !== $data['placeholder']) {
340 340
             $string .= '<option value=""';
341
-            if (   $data['required']
341
+            if ($data['required']
342 342
                 && empty($data['value'])
343 343
                 && "0" !== $data['value']) {
344 344
                 $string .= ' selected="selected"';
@@ -500,7 +500,7 @@  discard block
 block discarded – undo
500 500
             $string .= '<label class="midcom_datamanager_photo_label">' . $this->renderer->humanize('delete photo') . ' ' . $this->renderer->widget($data['form']['delete']) . '</label>';
501 501
             $string .= '<ul>';
502 502
             foreach ($objects as $info) {
503
-                if (   $info['size_x']
503
+                if ($info['size_x']
504 504
                     && $info['size_y']) {
505 505
                     $size = "{$info['size_x']}&times;{$info['size_y']}";
506 506
                 } else {
@@ -525,7 +525,7 @@  discard block
 block discarded – undo
525 525
         $string .= '</td></tr></table></div>';
526 526
         $string .= $this->renderer->row($data['form']['identifier']);
527 527
 
528
-        return $string . $this->jsinit('init_image_widget("' . $view->vars['id'] .'");');
528
+        return $string . $this->jsinit('init_image_widget("' . $view->vars['id'] . '");');
529 529
     }
530 530
 
531 531
     public function subform_widget(FormView $view, array $data)
Please login to merge, or discard this patch.
lib/org/openpsa/user/style/show-person-account.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
             echo '<span class="toolbar_label">' . $data['l10n_midcom']->get('delete') . '</span></a></li>';
24 24
             if (    midcom::get()->config->get('auth_allow_trusted') === true
25 25
                  && $data['person']->can_do('org.openpsa.user:su')) {
26
-                 echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '">' . $data['l10n']->get('switch to user') . "</a></li>\n";
26
+                    echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '">' . $data['l10n']->get('switch to user') . "</a></li>\n";
27 27
             }
28 28
             echo "</ul>\n";
29 29
         }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
             echo '<p>' . sprintf($data['l10n']->get('account blocked %s minutes'), $data['config']->get('password_block_timeframe_min')) . '</p>';
17 17
         }
18 18
 
19
-        if (   $data['person']->guid == midcom::get()->auth->user->guid
19
+        if ($data['person']->guid == midcom::get()->auth->user->guid
20 20
             || midcom::get()->auth->can_user_do('org.openpsa.user:manage', class: org_openpsa_user_interface::class)) {
21 21
             $workflow = new midcom\workflow\datamanager;
22 22
             echo '<ul class="area_toolbar">';
@@ -25,9 +25,9 @@  discard block
 block discarded – undo
25 25
                 'object' => $data['person'],
26 26
                 'label' => $data['l10n']->get('account')
27 27
             ]);
28
-            echo '<li><a href="' . $data['router']->generate('account_delete', ['guid' => $data['person']->guid]). '" ' . $workflow->render_attributes() . ' class="button">';
28
+            echo '<li><a href="' . $data['router']->generate('account_delete', ['guid' => $data['person']->guid]) . '" ' . $workflow->render_attributes() . ' class="button">';
29 29
             echo '<span class="toolbar_label">' . $data['l10n_midcom']->get('delete') . '</span></a></li>';
30
-            if (    midcom::get()->config->get('auth_allow_trusted') === true
30
+            if (midcom::get()->config->get('auth_allow_trusted') === true
31 31
                  && $data['person']->can_do('org.openpsa.user:su')) {
32 32
                  echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '">' . $data['l10n']->get('switch to user') . "</a></li>\n";
33 33
             }
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         }
36 36
     } else {
37 37
         echo '<p><span class="metadata">' . $data['l10n']->get("no account") . '</span></p>';
38
-        if (   $data['person']->guid == midcom::get()->auth->user->guid
38
+        if ($data['person']->guid == midcom::get()->auth->user->guid
39 39
             || midcom::get()->auth->can_user_do('org.openpsa.user:manage', class: org_openpsa_user_interface::class)) {
40 40
             $workflow = new midcom\workflow\datamanager;
41 41
             echo '<ul class="area_toolbar">';
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/tinymceType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -34,11 +34,11 @@
 block discarded – undo
34 34
      */
35 35
     public function configureOptions(OptionsResolver $resolver)
36 36
     {
37
-        $resolver->setDefault('config', function (Options $options) {
37
+        $resolver->setDefault('config', function(Options $options) {
38 38
             return \midcom_baseclasses_components_configuration::get('midcom.datamanager', 'config');
39 39
         });
40 40
 
41
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
41
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
42 42
             $widget_defaults = [
43 43
                 'height' => 25,
44 44
                 'width' => 80,
Please login to merge, or discard this patch.