Passed
Push — master ( 1a9f82...722134 )
by Andreas
12:17
created
src/midcom/datamanager/validation/imageValidator.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,10 +12,10 @@
 block discarded – undo
12 12
 {
13 13
     public function validate($value, Constraint $constraint)
14 14
     {
15
-        if (   empty($value)
15
+        if (empty($value)
16 16
             || !empty($value['delete'])
17
-            || (   empty($value['file'])
18
-                && (   (empty($constraint->config['do_not_save_archival']) && empty($value['archival']))
17
+            || (empty($value['file'])
18
+                && ((empty($constraint->config['do_not_save_archival']) && empty($value['archival']))
19 19
                     || (!empty($constraint->config['do_not_save_archival']) && empty($value['main']))))) {
20 20
             $this->context->buildViolation('This value should not be blank.')
21 21
                 ->addViolation();
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/handler/event/create.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
         if ($query->has('start')) {
46 46
             $defaults['start'] = strtotime(substr($query->get('start'), 0, 19)) + 1;
47 47
             if ($query->has('end')) {
48
-                $defaults['end']= strtotime(substr($query->get('end'), 0, 19));
48
+                $defaults['end'] = strtotime(substr($query->get('end'), 0, 19));
49 49
             } else {
50 50
                 $defaults['end'] = $defaults['start'] + 3600;
51 51
             }
Please login to merge, or discard this patch.
src/midcom/routing/resolver.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@
 block discarded – undo
138 138
         $prefix = $this->context->get_key(MIDCOM_CONTEXT_ANCHORPREFIX);
139 139
 
140 140
         // Check if we need to start up a plugin.
141
-        if (   count($argv) > 1
141
+        if (count($argv) > 1
142 142
             && $config = plugin::get_config($argv[0], $argv[1])) {
143 143
             $namespace = array_shift($argv);
144 144
             $name = array_shift($argv);
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -59,7 +59,8 @@  discard block
 block discarded – undo
59 59
 
60 60
             try {
61 61
                 $result = $router->match($url);
62
-            } catch (ResourceNotFoundException) {
62
+            }
63
+            catch (ResourceNotFoundException) {
63 64
                 throw new midcom_error_notfound('This URL method is unknown.');
64 65
             }
65 66
             $this->request->attributes->add($result);
@@ -118,11 +119,13 @@  discard block
 block discarded – undo
118 119
 
119 120
         try {
120 121
             $result = $router->match($url);
121
-        } catch (ResourceNotFoundException) {
122
+        }
123
+        catch (ResourceNotFoundException) {
122 124
             // No match
123 125
             debug_add("Component {$viewer->_component} in {$viewer->_topic->name} declared unable to handle request.", MIDCOM_LOG_INFO);
124 126
             throw new midcom_error_notfound("This page is not available on this server.");
125
-        } catch (MethodNotAllowedException $e) {
127
+        }
128
+        catch (MethodNotAllowedException $e) {
126 129
             debug_add("Component {$viewer->_component} in {$viewer->_topic->name} declared unable to handle request (method not allowed).", MIDCOM_LOG_INFO);
127 130
             throw new midcom_error_forbidden($e->getMessage(), Response::HTTP_METHOD_NOT_ALLOWED);
128 131
         }
Please login to merge, or discard this patch.
lib/midcom/db/topic.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
     public function _on_loaded()
34 34
     {
35 35
         // if we are missing the component, use the nullcomponent.
36
-        if (   !$this->component
36
+        if (!$this->component
37 37
             || !midcom::get()->componentloader->is_installed($this->component)) {
38 38
             debug_add("Topic {$this->id} has no component assigned to it, using 'midcom.core.nullcomponent'.",
39 39
             MIDCOM_LOG_INFO);
Please login to merge, or discard this patch.
src/midcom/events/watcher.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -72,7 +72,8 @@
 block discarded – undo
72 72
             $component = key($watch);
73 73
             try {
74 74
                 $interface = $this->loader->get_interface_class($component);
75
-            } catch (\midcom_error $e) {
75
+            }
76
+            catch (\midcom_error $e) {
76 77
                 debug_add("Failed to load the component {$component}: " . $e->getMessage(), MIDCOM_LOG_INFO);
77 78
                 continue;
78 79
             }
Please login to merge, or discard this patch.
lib/midcom/services/i18n/main.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@
 block discarded – undo
101 101
         $rawdata = base64_decode($request->cookies->get('midcom_services_i18n'));
102 102
         $array = unserialize($rawdata);
103 103
 
104
-        if (   !array_key_exists('language', $array)
104
+        if (!array_key_exists('language', $array)
105 105
             || !array_key_exists('charset', $array)) {
106 106
             debug_add("Rejecting cookie, it seems invalid.");
107 107
             return false;
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -155,7 +155,8 @@  discard block
 block discarded – undo
155 155
     {
156 156
         try {
157 157
             Locales::getName($lang);
158
-        } catch (Exception $e) {
158
+        }
159
+        catch (Exception $e) {
159 160
             debug_add("Language {$lang} not found:" . $e->getMessage(), MIDCOM_LOG_ERROR);
160 161
             return false;
161 162
         }
@@ -236,7 +237,8 @@  discard block
 block discarded – undo
236 237
     {
237 238
         try {
238 239
             return $this->get_l10n($component)->get($stringid);
239
-        } catch (midcom_error $e) {
240
+        }
241
+        catch (midcom_error $e) {
240 242
             $e->log(MIDCOM_LOG_WARN);
241 243
             return $stringid;
242 244
         }
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/handler/campaign/rules.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,8 @@
 block discarded – undo
99 99
         if ($request->request->has('midcom_helper_datamanager2_save')) {
100 100
             try {
101 101
                 $rules = $this->_load_rules($request);
102
-            } catch (midcom_error $e) {
102
+            }
103
+            catch (midcom_error $e) {
103 104
                 midcom::get()->uimessages->add('org.openpsa.directmarketing', $this->_l10n->get($e->getMessage()), 'error');
104 105
                 return;
105 106
             }
Please login to merge, or discard this patch.
lib/midcom/application.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@
 block discarded – undo
97 97
             $loader->load($this->getProjectDir() . '/config/services.yml');
98 98
         }
99 99
         if ($classes = midcom::get_registered_service_classes()) {
100
-            $loader->load(function (ContainerBuilder $container) use ($classes) {
100
+            $loader->load(function(ContainerBuilder $container) use ($classes) {
101 101
                 foreach ($classes as $id => $class) {
102 102
                     $container->findDefinition($id)->setClass($class);
103 103
                 }
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -161,7 +161,8 @@  discard block
 block discarded – undo
161 161
             $response = $this->handle($request);
162 162
             $response->send();
163 163
             $this->terminate($request, $response);
164
-        } catch (Error $e) {
164
+        }
165
+        catch (Error $e) {
165 166
             $this->getHttpKernel()->terminateWithException($e);
166 167
         }
167 168
     }
@@ -218,11 +219,13 @@  discard block
 block discarded – undo
218 219
         $this->skip_page_style = true;
219 220
         try {
220 221
             $response = $this->handle($request, HttpKernelInterface::SUB_REQUEST, false);
221
-        } catch (midcom_error_notfound | midcom_error_forbidden $e) {
222
+        }
223
+        catch (midcom_error_notfound | midcom_error_forbidden $e) {
222 224
             $e->log();
223 225
             midcom_core_context::leave();
224 226
             return;
225
-        } finally {
227
+        }
228
+        finally {
226 229
             $this->skip_page_style = $backup;
227 230
         }
228 231
 
Please login to merge, or discard this patch.
lib/midcom/helper/style.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@
 block discarded – undo
152 152
         $preparsed = midcom_helper_formatter::compile($style);
153 153
 
154 154
         if (midcom_core_context::get()->has_custom_key('request_data')) {
155
-            $data =& midcom_core_context::get()->get_custom_key('request_data');
155
+            $data = & midcom_core_context::get()->get_custom_key('request_data');
156 156
         }
157 157
 
158 158
         try {
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,8 @@
 block discarded – undo
136 136
 
137 137
         try {
138 138
             eval('?>' . $preparsed);
139
-        } catch (ParseError $e) {
139
+        }
140
+        catch (ParseError $e) {
140 141
             throw new midcom_error("Failed to parse style element '{$path}': " . $e->getMessage() . ' in line ' . $e->getLine());
141 142
         }
142 143
     }
Please login to merge, or discard this patch.