@@ -15,7 +15,7 @@ |
||
15 | 15 | |
16 | 16 | foreach ($properties as $propname => $val) { |
17 | 17 | $description = preg_replace('/ *\n */', "\n", $val['value']); |
18 | - if ( $val['link'] |
|
18 | + if ($val['link'] |
|
19 | 19 | && $linked_component = midcom::get()->dbclassloader->get_component_for_class($val['link_name'])) { |
20 | 20 | $proplink = $data['router']->generate('help', ['component' => $linked_component, 'help_id' => 'mgdschemas']); |
21 | 21 | $proplink = "<a href='{$proplink}#{$val['link_name']}' title='{$linked_component}/{$val['link_name']}::{$val['link_target']}'>{$val['link_name']}:{$val['link_target']}</a>"; |
@@ -110,7 +110,7 @@ |
||
110 | 110 | public function _on_updated() |
111 | 111 | { |
112 | 112 | // Sync the object's ACL properties into MidCOM ACL system |
113 | - if ( !$this->_skip_acl_refresh) { |
|
113 | + if (!$this->_skip_acl_refresh) { |
|
114 | 114 | if ($this->orgOpenpsaAccesstype && $this->orgOpenpsaOwnerWg) { |
115 | 115 | debug_add("Synchronizing task ACLs to MidCOM"); |
116 | 116 | $sync = new org_openpsa_core_acl_synchronizer(); |
@@ -51,7 +51,7 @@ |
||
51 | 51 | $this->article->require_do('midgard:update'); |
52 | 52 | |
53 | 53 | $schemadb = $data['schemadb']; |
54 | - if ( $this->_config->get('simple_name_handling') |
|
54 | + if ($this->_config->get('simple_name_handling') |
|
55 | 55 | && !midcom::get()->auth->can_user_do('midcom:urlname')) { |
56 | 56 | foreach ($schemadb->all() as $schema) { |
57 | 57 | $schema->get_field('name')['readonly'] = true; |
@@ -107,7 +107,7 @@ |
||
107 | 107 | |
108 | 108 | // sending per email enabled in billing data? |
109 | 109 | $billing_data = org_openpsa_invoices_billing_data_dba::get_by_object($this->invoice); |
110 | - if ( !$this->invoice->sent |
|
110 | + if (!$this->invoice->sent |
|
111 | 111 | && intval($billing_data->sendingoption) == 2) { |
112 | 112 | $buttons[] = $this->build_button('send_by_mail', 'paper-plane'); |
113 | 113 | } |
@@ -46,7 +46,7 @@ discard block |
||
46 | 46 | ] |
47 | 47 | ]); |
48 | 48 | |
49 | - $resolver->setNormalizer('constraints', function (Options $options, $value) { |
|
49 | + $resolver->setNormalizer('constraints', function(Options $options, $value) { |
|
50 | 50 | if ($options['required']) { |
51 | 51 | return [new constraint(['config' => $options['type_config']])]; |
52 | 52 | } |
@@ -78,7 +78,7 @@ discard block |
||
78 | 78 | |
79 | 79 | $builder->add('delete', CheckboxType::class, ['attr' => [ |
80 | 80 | "class" => "midcom_datamanager_photo_checkbox" |
81 | - ], "required" => false ]); |
|
81 | + ], "required" => false]); |
|
82 | 82 | $builder->add('identifier', HiddenType::class); |
83 | 83 | } |
84 | 84 |
@@ -59,7 +59,7 @@ |
||
59 | 59 | |
60 | 60 | public function __set($name, $value) |
61 | 61 | { |
62 | - if ( $name == 'homepage' |
|
62 | + if ($name == 'homepage' |
|
63 | 63 | && !empty($value) |
64 | 64 | && $value != $this->homepage) { |
65 | 65 | $this->_register_prober = true; |
@@ -409,7 +409,8 @@ |
||
409 | 409 | //Get the parent object |
410 | 410 | try { |
411 | 411 | $parent = midcom::get()->dbfactory->get_object_by_guid($this->objectguid); |
412 | - } catch (midcom_error $e) { |
|
412 | + } |
|
413 | + catch (midcom_error $e) { |
|
413 | 414 | $e->log(); |
414 | 415 | return; |
415 | 416 | } |
@@ -218,8 +218,8 @@ discard block |
||
218 | 218 | { |
219 | 219 | $config = midcom_baseclasses_components_configuration::get('net.nehmer.comments', 'config'); |
220 | 220 | |
221 | - if ( $config->get('ratings_enable') |
|
222 | - && ( $config->get('ratings_cache_to_object') |
|
221 | + if ($config->get('ratings_enable') |
|
222 | + && ($config->get('ratings_cache_to_object') |
|
223 | 223 | || $config->get('comment_count_cache_to_object'))) { |
224 | 224 | // Handle ratings |
225 | 225 | $comments = self::list_by_objectguid($this->objectguid); |
@@ -268,7 +268,7 @@ discard block |
||
268 | 268 | |
269 | 269 | private function _send_notifications() |
270 | 270 | { |
271 | - if ( empty($this->title) |
|
271 | + if (empty($this->title) |
|
272 | 272 | && empty($this->content)) { |
273 | 273 | // No need to send notifications about empty rating entries |
274 | 274 | return; |
@@ -84,7 +84,7 @@ discard block |
||
84 | 84 | net_nemein_rss_manage::add_toolbar_buttons($this->_node_toolbar, $this->_topic->can_do('midgard:create')); |
85 | 85 | } |
86 | 86 | |
87 | - if ( $this->_topic->can_do('midgard:update') |
|
87 | + if ($this->_topic->can_do('midgard:update') |
|
88 | 88 | && $this->_topic->can_do('midcom:component_config')) { |
89 | 89 | $buttons[] = $workflow->get_button('config/', [ |
90 | 90 | MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'), |
@@ -114,7 +114,7 @@ discard block |
||
114 | 114 | $this->_request_data['categories'] = explode(',', $this->_config->get('categories')); |
115 | 115 | |
116 | 116 | foreach ($this->_request_data['schemadb']->all() as $schema) { |
117 | - if ( $schema->has_field('categories') |
|
117 | + if ($schema->has_field('categories') |
|
118 | 118 | && $schema->get_field('categories')['type'] == 'select') { |
119 | 119 | // TODO: Merge schema local and component config categories? |
120 | 120 | $options = array_combine($this->_request_data['categories'], $this->_request_data['categories']); |
@@ -61,7 +61,7 @@ |
||
61 | 61 | public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self |
62 | 62 | { |
63 | 63 | if ( !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer)) |
64 | - // check if the customerContact is set and has invoice_data |
|
64 | + // check if the customerContact is set and has invoice_data |
|
65 | 65 | && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) { |
66 | 66 | $bd = new self(); |
67 | 67 | $due = midcom_baseclasses_components_configuration::get('org.openpsa.invoices', 'config')->get('default_due_days'); |
@@ -52,7 +52,7 @@ discard block |
||
52 | 52 | */ |
53 | 53 | public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self |
54 | 54 | { |
55 | - if ( !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer)) |
|
55 | + if (!($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer)) |
|
56 | 56 | // check if the customerContact is set and has invoice_data |
57 | 57 | && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) { |
58 | 58 | $bd = new self(); |
@@ -68,7 +68,7 @@ discard block |
||
68 | 68 | /** |
69 | 69 | * Get the billing data for given contact if any. |
70 | 70 | */ |
71 | - private static function get_billing_data(string $dba_class, string|int $contact_id) : ?self |
|
71 | + private static function get_billing_data(string $dba_class, string | int $contact_id) : ?self |
|
72 | 72 | { |
73 | 73 | if ($contact_id == 0) { |
74 | 74 | return null; |
@@ -86,7 +86,8 @@ discard block |
||
86 | 86 | // if the property useContactAddress is set |
87 | 87 | $billing_data[0]->set_address(); |
88 | 88 | return $billing_data[0]; |
89 | - } catch (midcom_error $e) { |
|
89 | + } |
|
90 | + catch (midcom_error $e) { |
|
90 | 91 | $e->log(); |
91 | 92 | return null; |
92 | 93 | } |
@@ -131,10 +132,12 @@ discard block |
||
131 | 132 | { |
132 | 133 | try { |
133 | 134 | return new org_openpsa_contacts_person_dba($this->linkGuid); |
134 | - } catch (midcom_error) { |
|
135 | + } |
|
136 | + catch (midcom_error) { |
|
135 | 137 | try { |
136 | 138 | return new org_openpsa_contacts_group_dba($this->linkGuid); |
137 | - } catch (midcom_error $e) { |
|
139 | + } |
|
140 | + catch (midcom_error $e) { |
|
138 | 141 | debug_add("Failed to load contact with GUID: " . $this->linkGuid . " - last error:" . $e->getMessage(), MIDCOM_LOG_ERROR); |
139 | 142 | return false; |
140 | 143 | } |