Passed
Push — master ( 3b4316...c86071 )
by Andreas
12:30
created
lib/net/nehmer/static/viewer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
             }
55 55
         }
56 56
 
57
-        if (   $this->_topic->can_do('midgard:update')
57
+        if ($this->_topic->can_do('midgard:update')
58 58
             && $this->_topic->can_do('midcom:component_config')) {
59 59
                 $buttons[] = $workflow->get_button($this->router->generate('config'), [
60 60
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'),
Please login to merge, or discard this patch.
lib/net/nehmer/static/handler/view.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -112,7 +112,8 @@
 block discarded – undo
112 112
         foreach ($qb->execute() as $article) {
113 113
             try {
114 114
                 $datamanager->set_storage($article);
115
-            } catch (midcom_error $e) {
115
+            }
116
+            catch (midcom_error $e) {
116 117
                 $e->log();
117 118
                 continue;
118 119
             }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
             ]);
41 41
         }
42 42
 
43
-        if (   $this->_article->topic === $this->_topic->id
43
+        if ($this->_article->topic === $this->_topic->id
44 44
             && $this->_article->can_do('midgard:delete')) {
45 45
             $delete = $this->get_workflow('delete', ['object' => $this->_article]);
46 46
             $buttons[] = $delete->get_button($this->router->generate('delete', ['guid' => $this->_article->guid]));
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         $this->_datamanager->set_storage($this->_article);
82 82
 
83 83
         $arg = $this->_article->name ?: $this->_article->guid;
84
-        if (   $arg != 'index'
84
+        if ($arg != 'index'
85 85
             && $this->_config->get('hide_navigation')) {
86 86
             $this->add_breadcrumb($this->router->generate('view', ['name' =>$arg]), $this->_article->title);
87 87
         }
@@ -91,13 +91,13 @@  discard block
 block discarded – undo
91 91
         midcom::get()->metadata->set_request_metadata($this->_article->metadata->revised, $this->_article->guid);
92 92
         $this->bind_view_to_object($this->_article, $this->_datamanager->get_schema()->get_name());
93 93
 
94
-        if (   $this->_config->get('indexinnav')
94
+        if ($this->_config->get('indexinnav')
95 95
             || $this->_config->get('autoindex')
96 96
             || $this->_article->name != 'index') {
97 97
             $this->set_active_leaf($this->_article->id);
98 98
         }
99 99
 
100
-        if (   $this->_config->get('folder_in_title')
100
+        if ($this->_config->get('folder_in_title')
101 101
             && $this->_topic->extra != $this->_article->title) {
102 102
             midcom::get()->head->set_pagetitle("{$this->_topic->extra}: {$this->_article->title}");
103 103
         } else {
Please login to merge, or discard this patch.
lib/org/openpsa/projects/style/show-project.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,8 @@
 block discarded – undo
46 46
             $customer_html = '<a href="' . $contacts_url . '/group/' . $customer->guid . '/">' . $customer_html . "</a>\n";
47 47
         }
48 48
         echo $customer_html;
49
-    } catch (midcom_error) {
49
+    }
50
+    catch (midcom_error) {
50 51
     }
51 52
 
52 53
     if ($project->manager) {
Please login to merge, or discard this patch.
lib/midcom/core/query.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
             $this->_user_id = midcom::get()->auth->acl->get_user_id();
103 103
         }
104 104
 
105
-        if (   $this->hide_invisible
105
+        if ($this->hide_invisible
106 106
             && !$this->_visibility_checks_added) {
107 107
             if (!midcom::get()->config->get('show_hidden_objects')) {
108 108
                 $this->add_constraint('metadata.hidden', '=', false);
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/transformer/multipleTransformer.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
                     return [];
55 55
                 }
56 56
                 $results = explode($this->multiple_separator, substr($input, 1, -1));
57
-                if (   !empty($this->config['widget_config']['id_field'])
57
+                if (!empty($this->config['widget_config']['id_field'])
58 58
                     && $this->config['widget_config']['id_field'] == 'id') {
59 59
                     $results = array_map(intval(...), $results);
60 60
                 }
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
     public function reverseTransform(mixed $array) : mixed
69 69
     {
70
-        if (!is_array($array) ) {
70
+        if (!is_array($array)) {
71 71
             throw new TransformationFailedException('Expected an array.');
72 72
         }
73 73
 
Please login to merge, or discard this patch.
src/midcom/dba/privileges.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
      */
67 67
     public function set_privilege($privilege, $assignee = null, int $value = MIDCOM_PRIVILEGE_ALLOW, string $classname = '') : bool
68 68
     {
69
-        if (   !$this->can_do('midgard:update')
69
+        if (!$this->can_do('midgard:update')
70 70
             || !$this->can_do('midgard:privileges')) {
71 71
             debug_add("Failed to set a privilege, midgard:update or midgard:privileges on " . static::class . " {$this->guid} not granted for the current user.",
72 72
             MIDCOM_LOG_ERROR);
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
      */
97 97
     public function unset_privilege($privilege, $assignee = null, string $classname = '') : bool
98 98
     {
99
-        if (   !$this->can_do('midgard:update')
99
+        if (!$this->can_do('midgard:update')
100 100
             || !$this->can_do('midgard:privileges')) {
101 101
             debug_add("Failed to unset a privilege, midgard:update or midgard:privileges on " . static::class . " {$this->guid} not granted for the current user.",
102 102
             MIDCOM_LOG_ERROR);
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
      *     midcom_core_group object or subtype thereof.
126 126
      * @param string $classname An optional class name to which a SELF privilege is restricted to.
127 127
      */
128
-    public function get_privilege(string $privilege, midcom_core_user|midcom_core_group|string $assignee, string $classname = '')
128
+    public function get_privilege(string $privilege, midcom_core_user | midcom_core_group | string $assignee, string $classname = '')
129 129
     {
130 130
         if (!$this->can_do('midgard:privileges')) {
131 131
             debug_add("Failed to get a privilege, midgard:update or midgard:privileges on " . static::class . " {$this->guid} not granted for the current user.",
Please login to merge, or discard this patch.
lib/midcom/helper/imagefilter.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -323,7 +323,7 @@  discard block
 block discarded – undo
323 323
         $tmpfile = null;
324 324
         $imagesize = getimagesize($this->_filename);
325 325
 
326
-        if (   $imagesize[2] == IMAGETYPE_JPEG
326
+        if ($imagesize[2] == IMAGETYPE_JPEG
327 327
             && $this->_jpegtran_available()) {
328 328
             /* jpegtran */
329 329
             $operations = [
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
         $imagesize = getimagesize($this->_filename);
391 391
 
392 392
         // Try lossless jpegtran rotation if possible
393
-        if (   $imagesize[2] == IMAGETYPE_JPEG
393
+        if ($imagesize[2] == IMAGETYPE_JPEG
394 394
             && ($rotate % 90 == 0)
395 395
             && $this->_jpegtran_available()) {
396 396
             $tmpfile = $this->_get_tempfile();
@@ -502,7 +502,7 @@  discard block
 block discarded – undo
502 502
      */
503 503
     public function fill(?int $x = null, ?int $y = null, ?string $color = null, string $gravity = 'center')
504 504
     {
505
-        if (   empty($x)
505
+        if (empty($x)
506 506
             || empty($y)
507 507
             || empty($color)) {
508 508
             //This is a bit silly, but here for backwards compatibility...
Please login to merge, or discard this patch.
lib/midcom/services/i18n/formatter.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
         $this->language = $language;
24 24
     }
25 25
 
26
-    public function number(int|float $value, int $precision = 2)
26
+    public function number(int | float $value, int $precision = 2)
27 27
     {
28 28
         // The fallback implementation in Intl only supports DECIMAL, so we hardcode the style here..
29 29
         $formatter = new NumberFormatter($this->get_locale(), NumberFormatter::DECIMAL);
@@ -31,24 +31,24 @@  discard block
 block discarded – undo
31 31
         return $formatter->format($value);
32 32
     }
33 33
 
34
-    public function date(int|string|DateTimeInterface $value = null, int|string $dateformat = 'medium')
34
+    public function date(int | string | DateTimeInterface $value = null, int | string $dateformat = 'medium')
35 35
     {
36 36
         return $this->datetime($value, $dateformat, IntlDateFormatter::NONE);
37 37
     }
38 38
 
39
-    public function time(int|string|DateTimeInterface $value = null, int|string $timeformat = 'short')
39
+    public function time(int | string | DateTimeInterface $value = null, int | string $timeformat = 'short')
40 40
     {
41 41
         return $this->datetime($value, IntlDateFormatter::NONE, $timeformat);
42 42
     }
43 43
 
44
-    public function datetime(int|string|DateTimeInterface $value = null, int|string $dateformat = 'medium', int|string $timeformat = 'short')
44
+    public function datetime(int | string | DateTimeInterface $value = null, int | string $dateformat = 'medium', int | string $timeformat = 'short')
45 45
     {
46 46
         $value ??= time();
47 47
         $formatter = new IntlDateFormatter($this->get_locale(), $this->constant($dateformat), $this->constant($timeformat));
48 48
         return $formatter->format($value);
49 49
     }
50 50
 
51
-    public function customdate(int|string|DateTimeInterface $value, string $pattern)
51
+    public function customdate(int | string | DateTimeInterface $value, string $pattern)
52 52
     {
53 53
         $formatter = new IntlDateFormatter($this->get_locale(), IntlDateFormatter::FULL, IntlDateFormatter::FULL);
54 54
         $formatter->setPattern($pattern);
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
         return $ranger->format($start, $end);
71 71
     }
72 72
 
73
-    private function constant(int|string $input) : int
73
+    private function constant(int | string $input) : int
74 74
     {
75 75
         if (is_int($input)) {
76 76
             return $input;
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/navigation.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
         $this->_component = 'midgard.admin.asgard';
35 35
 
36 36
         $this->_object = $object;
37
-        $this->_request_data =& $request_data;
37
+        $this->_request_data = & $request_data;
38 38
 
39 39
         $root_types = midgard_admin_asgard_plugin::get_root_classes();
40 40
 
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
             // we go through the path bottom up and show the first root type we find
51 51
             foreach (array_reverse($this->_object_path) as $node) {
52 52
                 foreach (array_keys($root_types) as $root_type) {
53
-                    if (   $node instanceof $root_type
53
+                    if ($node instanceof $root_type
54 54
                         || midcom_helper_reflector::is_same_class($root_type, $node->__midcom_class_name__)) {
55 55
                         $this->expanded_root_types[] = $root_type;
56 56
                         break;
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 
63 63
     protected function _is_collapsed(string $type, int $total) : bool
64 64
     {
65
-        return (   $total > $this->_config->get('max_navigation_entries')
65
+        return ($total > $this->_config->get('max_navigation_entries')
66 66
                 && empty($_GET['show_all_' . $type]));
67 67
     }
68 68
 
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
         foreach ($ref->get_child_classes() as $class) {
79 79
             $qb = $ref->_child_objects_type_qb($class, $object, false);
80 80
 
81
-            if (   !$qb
81
+            if (!$qb
82 82
                 || !($count = $qb->count_unchecked())) {
83 83
                 continue;
84 84
             }
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
     {
125 125
         $qb = $ref->_root_objects_qb();
126 126
 
127
-        if (   !$qb
127
+        if (!$qb
128 128
             || !($total = $qb->count_unchecked())) {
129 129
             return;
130 130
         }
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
         }
203 203
 
204 204
         echo "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/{$mode}/{$object->guid}/\" title=\"GUID: {$object->guid}, ID: {$object->id}\">{$icon}{$label}</a>\n";
205
-        if (   $selected
205
+        if ($selected
206 206
             || $autoexpand) {
207 207
             $this->_list_child_elements($object, $level + 1);
208 208
         }
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
                 continue;
223 223
             }
224 224
 
225
-            if (   method_exists($class, 'navigation')
225
+            if (method_exists($class, 'navigation')
226 226
                 && ($this->_request_data['plugin_name'] == "asgard_{$component}")) {
227 227
                 $this->_request_data['expanded'] = true;
228 228
                 midcom_show_style('midgard_admin_asgard_navigation_section_header');
@@ -256,13 +256,13 @@  discard block
 block discarded – undo
256 256
         if ($this->_is_selected($object)) {
257 257
             $css_class .= ' selected';
258 258
         }
259
-        if (   is_object($this->_object)
260
-            && (   $object->guid == $this->_object->guid
261
-                || (   $this->_object instanceof midcom_db_parameter
259
+        if (is_object($this->_object)
260
+            && ($object->guid == $this->_object->guid
261
+                || ($this->_object instanceof midcom_db_parameter
262 262
                     && $object->guid == $this->_object->parentguid))) {
263 263
             $css_class .= ' current';
264 264
         }
265
-        if ( !$object->can_do('midgard:update')) {
265
+        if (!$object->can_do('midgard:update')) {
266 266
             $css_class .= ' readonly';
267 267
         }
268 268
         return $css_class;
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
         // Get the types that might have special display conditions
284 284
         // @TODO: Should this just include to the configuration selection, although it would break the consistency
285 285
         // of other similar preference sets, which simply override the global settings?
286
-        if (   ($selected = midgard_admin_asgard_plugin::get_preference('midgard_types'))
286
+        if (($selected = midgard_admin_asgard_plugin::get_preference('midgard_types'))
287 287
             && preg_match_all('/\|([a-z0-9\.\-_]+)/', $selected, $regs)) {
288 288
             $types = array_flip($regs[1]);
289 289
             if ($exclude) {
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
             }
302 302
 
303 303
             // If the regular expression has been set, check which types should be shown
304
-            $label_mapping = array_filter($label_mapping, function ($root_type) use ($regexp, $exclude) {
304
+            $label_mapping = array_filter($label_mapping, function($root_type) use ($regexp, $exclude) {
305 305
                 return preg_match($regexp, $root_type) == $exclude;
306 306
             }, ARRAY_FILTER_USE_KEY);
307 307
         }
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
          * click if nothing is expanded
332 332
          */
333 333
         $types_shown = false;
334
-        if (    !empty($expanded_types)
334
+        if (!empty($expanded_types)
335 335
              && midgard_admin_asgard_plugin::get_preference('navigation_type') === 'dropdown') {
336 336
             $this->_draw_select_navigation();
337 337
             $types_shown = true;
Please login to merge, or discard this patch.