flack / openpsa

lib/org/openpsa/contacts/duplicates/check/person.php

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
             // if user's lastname is part of the email address, check to see if the difference is only in the domain part
             $email1 = preg_replace('/@.+/', '', $person1['email']);
             $email2 = preg_replace('/@.+/', '', $person2['email']);
-            if (   str_contains($email1, $person1['lastname'])
+            if (str_contains($email1, $person1['lastname'])
                 && $email1 == $email2) {
                 $p += 0.5;
             }

lib/org/openpsa/contacts/handler/duplicates.php

Spacing +8 added lines, -8 removed lines

@@ -59,7 +59,7 @@ 
 
     private function load_next()
     {
-        $i =& $this->_request_data['loop_i'];
+        $i = & $this->_request_data['loop_i'];
         while ($i < 100) {
             debug_add("Loop iteration {$i}");
             $qb = new midgard_query_builder('midgard_parameter');
@@ -87,7 +87,7 @@ 
                 continue;
             }
             // Make sure we actually have enough rights to do this
-            if (   !$object1->can_do('midgard:update')
+            if (!$object1->can_do('midgard:update')
                 || !$object1->can_do('midgard:delete')
                 || !$object2->can_do('midgard:update')
                 || !$object2->can_do('midgard:delete')) {
@@ -96,7 +96,7 @@ 
                 continue;
             }
             // Extra sanity check (in case of semi-successful not-duplicate mark)
-            if (   $object1->get_parameter('org.openpsa.contacts.duplicates:not_duplicate', $object2->guid)
+            if ($object1->get_parameter('org.openpsa.contacts.duplicates:not_duplicate', $object2->guid)
                 || $object2->get_parameter('org.openpsa.contacts.duplicates:not_duplicate', $object1->guid)) {
                 debug_add("It seems these two (#{$object1->id} and #{$object2->id}) have also marked as not duplicates, some cleanup might be a good thing", MIDCOM_LOG_WARN);
                 $i++;
@@ -128,7 +128,7 @@ 
             if ($keep == 'both') {
                 $option1->require_do('midgard:update');
                 $option2->require_do('midgard:update');
-                if (   $option1->set_parameter('org.openpsa.contacts.duplicates:not_duplicate', $option2->guid, time())
+                if ($option1->set_parameter('org.openpsa.contacts.duplicates:not_duplicate', $option2->guid, time())
                     && $option2->set_parameter('org.openpsa.contacts.duplicates:not_duplicate', $option1->guid, time())) {
                     // Clear the possible duplicate parameters
                     $option1->delete_parameter('org.openpsa.contacts.duplicates:possible_duplicate', $option2->guid);
@@ -146,11 +146,11 @@ 
                 }
             } else {
                 if ($keep == $option1->guid) {
-                    $object1 =& $option1;
-                    $object2 =& $option2;
+                    $object1 = & $option1;
+                    $object2 = & $option2;
                 } elseif ($keep == $option2->guid) {
-                    $object1 =& $option2;
-                    $object2 =& $option1;
+                    $object1 = & $option2;
+                    $object2 = & $option1;
                 } else {
                     throw new midcom_error('Something weird happened (basically we got bogus data)');
                 }

src/midcom/datamanager/schemadb.php

Spacing +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
 
             if ($path === '') {
                 // Infinite loop, set an UI message and stop executing
-                if (   !isset($schema['extends']['name'])
+                if (!isset($schema['extends']['name'])
                     || $schema['extends']['name'] === $schema_name) {
                     throw new midcom_error('schema ' . $schema_name . ' extends itself');
                 }

lib/net/nehmer/blog/handler/index.php

Spacing +2 added lines, -2 removed lines

@@ -75,7 +75,7 @@ 
 
     private function _process_category_constraint(org_openpsa_qbpager $qb)
     {
-        if (   !in_array($this->category, $this->_request_data['categories'])
+        if (!in_array($this->category, $this->_request_data['categories'])
             && !$this->_config->get('categories_custom_enable')) {
             throw new midcom_error('Custom categories are not allowed');
             // TODO: Check here if there are actually items in this cat?
@@ -88,7 +88,7 @@ 
         midcom::get()->head->set_pagetitle($this->_request_data['page_title']);
 
         // Activate correct leaf
-        if (   $this->_config->get('show_navigation_pseudo_leaves')
+        if ($this->_config->get('show_navigation_pseudo_leaves')
             && in_array($this->category, $this->_request_data['categories'])) {
             $this->set_active_leaf($this->_topic->id . '_CAT_' . $this->category);
         }

lib/net/nehmer/blog/handler/feed.php

Spacing +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
 
         if ($handler_id == 'feed-category-rss2') {
             // This is not a predefined category from configuration, check if site maintainer allows us to show it
-            if (   !in_array($args[0], $data['categories'])
+            if (!in_array($args[0], $data['categories'])
                 && !$this->_config->get('categories_custom_enable')) {
                 throw new midcom_error('Custom category support is disabled');
             }

lib/midcom/helper/nav/main.php

Spacing +3 added lines, -3 removed lines

@@ -336,7 +336,7 @@ 
         while ($parent = $object->get_parent()) {
             // Verify that this topic is within the current sites tree, if it is not,
             // we ignore it.
-            if (   is_a($parent, midcom_db_topic::class)
+            if (is_a($parent, midcom_db_topic::class)
                 && $this->is_node_in_tree($parent->id, $this->get_root_node())) {
                 return $parent;
             }
@@ -390,7 +390,7 @@ 
                     $entry = "<span class=\"{$current_class}\">{$entry}</span>";
                 }
             } else {
-                if (   !empty($data['napobject'][MIDCOM_NAV_GUID])
+                if (!empty($data['napobject'][MIDCOM_NAV_GUID])
                     && in_array($data['napobject'][MIDCOM_NAV_GUID], $skip_guids)) {
                     continue;
                 }
@@ -504,7 +504,7 @@ 
                     $id = "custom-{$key}";
 
                     $url = "{$prefix}{$entry[MIDCOM_NAV_URL]}";
-                    if (   str_starts_with($entry[MIDCOM_NAV_URL], '/')
+                    if (str_starts_with($entry[MIDCOM_NAV_URL], '/')
                         || preg_match('|^https?://|', $entry[MIDCOM_NAV_URL])) {
                         $url = $entry[MIDCOM_NAV_URL];
                     }

lib/midcom/helper/imagepopup/handler/upload.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
         $temp = array_shift($_FILES);
 
         // Verify file extension
-        if (   is_uploaded_file($temp['tmp_name'])
+        if (is_uploaded_file($temp['tmp_name'])
             && !in_array(strtolower(pathinfo($temp['name'], PATHINFO_EXTENSION)), ["gif", "jpg", "png"])) {
             throw new midcom_error('Invalid extension.');
         }

lib/org/openpsa/directmarketing/link/log.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
 
     public function _on_creating() : bool
     {
-        if (   !$this->referrer
+        if (!$this->referrer
             && !empty($_SERVER['HTTP_REFERER'])) {
             $this->referrer = $_SERVER['HTTP_REFERER'];
         }

lib/org/openpsa/sales/salesproject.php

Spacing +3 added lines, -3 removed lines

@@ -119,7 +119,7 @@ 
             }
         }
         $profit = $value - $cost;
-        if (   $this->value != $value
+        if ($this->value != $value
             || $this->profit != $profit) {
             $this->value = $value;
             $this->profit = $value - $cost;
@@ -184,12 +184,12 @@ 
 
     public function _on_updating() : bool
     {
-        if (   $this->state != self::STATE_ACTIVE
+        if ($this->state != self::STATE_ACTIVE
             && !$this->end) {
             //Not active anymore and end not set, set it to now
             $this->end = time();
         }
-        if (   $this->end
+        if ($this->end
             && $this->state == self::STATE_ACTIVE) {
             //Returned to active state, clear the end marker.
             $this->end = 0;