flack / openpsa

lib/org/openpsa/notifications/notifier/email.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
             $mail->from = $config->get('default_sender') ?: '"OpenPSA Notifier" <noreply@' . $_SERVER['SERVER_NAME'] . '>';
         }
 
-        $mail->subject = $message['title'] ??  'org.openpsa.notifications message (no title provided)';
+        $mail->subject = $message['title'] ?? 'org.openpsa.notifications message (no title provided)';
         if (array_key_exists('attachments', $message)) {
             $mail->attachments = $message['attachments'];
         }

lib/org/openpsa/relatedto/handler/relatedto.php

Braces +6 added lines, -3 removed lines

@@ -116,7 +116,8 @@ 
             //TODO: check for duplicates ?
             try {
                 $result = ['other_obj' => midcom::get()->dbfactory->get_object_by_guid($link[$other . 'Guid'])];
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 continue;
             }
             $result['link'] = [
@@ -421,7 +422,8 @@ 
             if (!($this->_object instanceof org_openpsa_relatedto_dba)) {
                 $response->status = "method requires guid of a link object as an argument";
             }
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $response->status = "error: " . $e->getMessage();
         }
 
@@ -444,7 +446,8 @@ 
             $relation = new org_openpsa_relatedto_dba($guid);
             $response->result = $relation->delete();
             $response->status = 'Last message: ' . midcom_connection::get_error_string();
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $response->result = false;
             $response->status = "Object '{$guid}' could not be loaded, error:" . $e->getMessage();
         }

Spacing +1 added lines, -1 removed lines

@@ -199,7 +199,7 @@
     private function _render_line(array $link, midcom_core_dbaobject &$other_obj)
     {
         $this->_request_data['link'] = $link;
-        $this->_request_data['other_obj'] =& $other_obj;
+        $this->_request_data['other_obj'] = & $other_obj;
         $this->_request_data['icon'] = midcom_helper_reflector::get_object_icon($other_obj);
 
         if (get_class($other_obj) != $link['class']) {

lib/midcom/services/auth/frontend/form.php

Spacing +2 added lines, -2 removed lines

@@ -40,7 +40,7 @@ 
      */
     public function read_login_data(Request $request) : ?array
     {
-        if (   !$request->request->has('midcom_services_auth_frontend_form_submit')
+        if (!$request->request->has('midcom_services_auth_frontend_form_submit')
             || !$request->request->has('username')
             || !$request->request->has('password')) {
             return null;
@@ -76,7 +76,7 @@ 
     {
         // Store the submitted form if the session expired, but user wants to save the data
         if (!empty($_POST)) {
-            $data =& midcom_core_context::get()->get_custom_key('request_data');
+            $data = & midcom_core_context::get()->get_custom_key('request_data');
 
             $data['restored_form_data'] = [];
 

lib/org/openpsa/documents/midcom/interfaces.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
 
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
     {
-        if (   $object instanceof org_openpsa_documents_document_dba
+        if ($object instanceof org_openpsa_documents_document_dba
             && $object->topic == $topic->id) {
             return "document/{$object->guid}/";
         }

lib/midgard/admin/asgard/style/midgard_admin_asgard_rcs_history.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
                 echo "                    <td>" . strftime('%x %X Z', $revision['date']) . "</td>\n";
                 echo "                    <td>";
 
-                if (   $revision['user']
+                if ($revision['user']
                     && $user = midcom::get()->auth->get_user($revision['user'])) {
                     echo $user->get_storage()->name;
                 } elseif ($revision['ip']) {

lib/net/nemein/wiki/style/view-wikipage-raw.php

Spacing +1 added lines, -1 removed lines

@@ -6,6 +6,6 @@
     &(view["content"]:h);
     <?php
 } else {
-    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub')."</p>";
+    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub') . "</p>";
 }
 ?>
\ No newline at end of file

lib/org/openpsa/relatedto/style/show_entries_html.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
             <?php
             //index is needed for sorting
             echo "'index_name',";
-            echo "'" . $data['l10n']->get('entry title') ."',";
+            echo "'" . $data['l10n']->get('entry title') . "',";
             echo "'" . $data['l10n']->get('entry text') . "',";
             echo "'" . $data['l10n']->get('entry created') . "',";
             echo "'index_creator', '" . $data['l10n_midcom']->get('creator') . "',";

Braces +2 added lines, -1 removed lines

@@ -25,7 +25,8 @@
             $row['creator_index'] = $creator->rname;
             $creator_card = org_openpsa_widgets_contact::get($entry->metadata->creator);
             $row['creator'] = $creator_card->show_inline();
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $row['creator_index'] = '';
             $row['creator'] = '';
         }

src/midcom/datamanager/helper/autocomplete.php

Spacing +4 added lines, -6 removed lines

@@ -85,7 +85,7 @@ 
     {
         ksort($constraints);
         foreach ($constraints as $key => $data) {
-            if (   !array_key_exists('value', $data)
+            if (!array_key_exists('value', $data)
                 || empty($data['field'])
                 || empty($data['op'])) {
                 debug_add("Constraint #{$key} is not correctly defined, skipping", MIDCOM_LOG_WARN);
@@ -146,7 +146,7 @@ 
     {
         $query = $this->request["term"];
         $wildcard_query = $query;
-        if (   isset($this->request['auto_wildcards'])
+        if (isset($this->request['auto_wildcards'])
             && !str_contains($query, '%')) {
             switch ($this->request['auto_wildcards']) {
                 case 'start':
@@ -253,9 +253,7 @@ 
                 return $label;
             }
         }
-        return midcom_helper_reflector::get($object)->get_object_label($object) ?:
-            self::build_label($object, array_column($result_headers, 'name')) ?:
-            get_class($object) . ' #' . $object->id;
+        return midcom_helper_reflector::get($object)->get_object_label($object) ?: self::build_label($object, array_column($result_headers, 'name')) ?: get_class($object) . ' #' . $object->id;
     }
 
     private static function build_label($object, array $fields) : string
@@ -289,7 +287,7 @@ 
             }
             return self::sanitize_label($value);
         }
-        if (   $field == 'username'
+        if ($field == 'username'
             && $object instanceof midcom_db_person) {
             $account = new midcom_core_account($object);
             return self::sanitize_label($account->get_username());

lib/midcom/helper/reflector/main.php

Braces +2 added lines, -1 removed lines

@@ -203,7 +203,8 @@
         if ($object instanceof mgdobject) {
             try {
                 $obj = midcom::get()->dbfactory->convert_midgard_to_midcom($object);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 return null;
             }
         } else {

Spacing +3 added lines, -3 removed lines

@@ -304,7 +304,7 @@ 
 
         $label_prop = $this->get_label_property();
 
-        if (    $label_prop != 'guid'
+        if ($label_prop != 'guid'
              && $this->property_exists($label_prop)) {
             $search_properties[$label_prop] = true;
         }
@@ -354,7 +354,7 @@ 
                 continue;
             }
 
-            if (   !$this->is_link($property)
+            if (!$this->is_link($property)
                 && $this->get_midgard_type($property) != MGD_TYPE_GUID) {
                 continue;
             }
@@ -388,7 +388,7 @@ 
     protected static function class_rewrite(string $schema_type) : string
     {
         $extends = midcom_baseclasses_components_configuration::get('midcom.helper.reflector', 'config')->get_array('class_extends');
-        if (   isset($extends[$schema_type])
+        if (isset($extends[$schema_type])
             && class_exists($extends[$schema_type])) {
             return $extends[$schema_type];
         }