flack / openpsa

lib/org/openpsa/invoices/handler/invoice/crud.php

Spacing +2 added lines, -2 removed lines

@@ -141,8 +141,8 @@
         $schema->get_field('paid')['hidden'] = empty($this->invoice->paid);
 
         $contact = $this->invoice->customerContact ?: $this->contact_id;
-        $customer_field =& $schema->get_field('customer');
-        $contact_field =& $schema->get_field('customerContact');
+        $customer_field = & $schema->get_field('customer');
+        $contact_field = & $schema->get_field('customerContact');
 
         if (!empty($contact)) {
             $customer_field['type_config']['options'] = $this->get_customers_for_contact($contact);

lib/org/openpsa/reports/handler/projects/report.php

Spacing +4 added lines, -4 removed lines

@@ -47,12 +47,12 @@ 
         $qb_hr = org_openpsa_expenses_hour_report_dba::new_query_builder();
         $qb_hr->add_constraint('date', '<=', (int) $query_data['end']);
         $qb_hr->add_constraint('date', '>=', (int) $query_data['start']);
-        if (   array_key_exists('invoiceable_filter', $query_data)
+        if (array_key_exists('invoiceable_filter', $query_data)
             && $query_data['invoiceable_filter'] != -1) {
             $qb_hr->add_constraint('invoiceable', '=', (bool) $query_data['invoiceable_filter']);
         }
 
-        if (   array_key_exists('invoiced_filter', $query_data)
+        if (array_key_exists('invoiced_filter', $query_data)
             && $query_data['invoiced_filter'] != -1) {
             if ((int) $query_data['invoiced_filter']) {
                 debug_add('invoiced_filter parsed as ONLY, adding constraint');
@@ -71,7 +71,7 @@ 
             $tasks = $this->_expand_task($query_data['task']);
             $qb_hr->add_constraint('task', 'IN', $tasks);
         }
-        if (   array_key_exists('hour_type_filter', $query_data)
+        if (array_key_exists('hour_type_filter', $query_data)
             && $query_data['hour_type_filter'] != 'builtin:all') {
             $qb_hr->add_constraint('reportType', '=', $query_data['hour_type_filter']);
         }
@@ -140,7 +140,7 @@ 
 
     private function add_to_group(array $new_row, string $matching, string $sort, string $title)
     {
-        $rows =& $this->_request_data['report']['rows'];
+        $rows = & $this->_request_data['report']['rows'];
         if (array_key_exists($matching, $rows)) {
             $rows[$matching]['rows'][] = $new_row;
             $rows[$matching]['total_hours'] += $new_row['hour']->hours;

lib/org/openpsa/relatedto/handler/journal/entry.php

Spacing +2 added lines, -2 removed lines

@@ -33,7 +33,7 @@ 
     public function _handler_create(Request $request, string $guid)
     {
         $current_object = midcom::get()->dbfactory->get_object_by_guid($guid);
-        $entry= new org_openpsa_relatedto_journal_entry_dba();
+        $entry = new org_openpsa_relatedto_journal_entry_dba();
         $entry->linkGuid = $current_object->guid;
 
         midcom::get()->head->set_pagetitle($this->_l10n->get('add journal entry'));
@@ -52,7 +52,7 @@ 
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
         if ($entry->can_do('midgard:delete')) {
             $delete = $this->get_workflow('delete', ['object' => $entry]);
-            $url = $this->router->generate('journal_entry_delete', ['guid' => $guid ]);
+            $url = $this->router->generate('journal_entry_delete', ['guid' => $guid]);
             $workflow->add_dialog_button($delete, $url);
         }
         return $workflow->run($request);

src/midcom/console/command/repligard.php

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
     private function _confirm(InputInterface $input, OutputInterface $output) : bool
     {
         $options = [true => 'y', false => 'N'];
-        $question = '<question>Delete all rows? [' . implode('|', $options). ']</question> ';
+        $question = '<question>Delete all rows? [' . implode('|', $options) . ']</question> ';
         $question = new ConfirmationQuestion($question, false);
         $dialog = $this->getHelperSet()->get('question');
         return $dialog->ask($input, $output, $question);

src/midcom/datamanager/template/form.php

Spacing +8 added lines, -8 removed lines

@@ -84,7 +84,7 @@ 
     public function form_end(FormView $view, array $data)
     {
         $string = '';
-        if (   !isset($data['render_rest'])
+        if (!isset($data['render_rest'])
             || $data['render_rest']) {
             $string .= $this->renderer->rest($view);
         }
@@ -223,7 +223,7 @@ 
             $data['attr']['class'] = 'shorttext';
         }
 
-        if (   !empty($data['value'])
+        if (!empty($data['value'])
             || is_numeric($data['value'])) {
             $data['attr']['value'] = $data['value'];
         }
@@ -265,7 +265,7 @@ 
     {
         if ($view->vars['readonly']) {
             $string = $this->get_view_renderer()->autocomplete_widget($view, $data);
-            return $string .  $this->renderer->widget($view['selection']);
+            return $string . $this->renderer->widget($view['selection']);
         }
 
         autocomplete::add_head_elements($data['handler_options']['creation_mode_enabled'], $data['handler_options']['sortable']);
@@ -275,7 +275,7 @@ 
         $jsinit .= "midcom_helper_datamanager2_autocomplete.create_dm2_widget('{$element_id}_search_input', {$data['min_chars']});\n";
 
         $string = '<fieldset ' . $this->renderer->block($view, 'widget_container_attributes') . '>';
-        $string .=  $this->renderer->widget($view['selection']);
+        $string .= $this->renderer->widget($view['selection']);
         $string .= ' ' . $this->renderer->widget($view['search_input']);
         $string .= '</fieldset>';
         return $string . $this->jsinit($jsinit);
@@ -324,7 +324,7 @@ 
         }
 
         $string = '<select ';
-        if (   $data['required']
+        if ($data['required']
             && null === $data['placeholder']
             && $data['placeholder_in_choices'] === false
             && $data['multiple'] === false) {
@@ -338,7 +338,7 @@ 
         $string .= $this->renderer->block($view, 'widget_attributes', $data) . '>';
         if (null !== $data['placeholder']) {
             $string .= '<option value=""';
-            if (   $data['required']
+            if ($data['required']
                 && empty($data['value'])
                 && "0" !== $data['value']) {
                 $string .= ' selected="selected"';
@@ -500,7 +500,7 @@ 
             $string .= '<label class="midcom_datamanager_photo_label">' . $this->renderer->humanize('delete photo') . ' ' . $this->renderer->widget($data['form']['delete']) . '</label>';
             $string .= '<ul>';
             foreach ($objects as $info) {
-                if (   $info['size_x']
+                if ($info['size_x']
                     && $info['size_y']) {
                     $size = "{$info['size_x']}&times;{$info['size_y']}";
                 } else {
@@ -525,7 +525,7 @@ 
         $string .= '</td></tr></table></div>';
         $string .= $this->renderer->row($data['form']['identifier']);
 
-        return $string . $this->jsinit('init_image_widget("' . $view->vars['id'] .'");');
+        return $string . $this->jsinit('init_image_widget("' . $view->vars['id'] . '");');
     }
 
     public function subform_widget(FormView $view, array $data)

src/midcom/datamanager/extension/type/tinymceType.php

Spacing +2 added lines, -2 removed lines

@@ -34,11 +34,11 @@
      */
     public function configureOptions(OptionsResolver $resolver)
     {
-        $resolver->setDefault('config', function (Options $options) {
+        $resolver->setDefault('config', function(Options $options) {
             return \midcom_baseclasses_components_configuration::get('midcom.datamanager', 'config');
         });
 
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
             $widget_defaults = [
                 'height' => 25,
                 'width' => 80,

lib/org/openpsa/relatedto/suspect.php

Spacing +3 added lines, -3 removed lines

@@ -79,14 +79,14 @@ 
 
         $properties = ['fromClass', 'toClass', 'fromGuid', 'toGuid', 'fromComponent', 'toComponent', 'status', 'toExtra', 'toExtra'];
         foreach ($properties as $property) {
-            if (   !empty($defaults->$property)
+            if (!empty($defaults->$property)
                 && empty($link->$property)) {
                 debug_add("Copying property '{$property}' ('{$defaults->$property}') from defaults");
                 $link->$property = $defaults->$property;
             }
         }
 
-        if (   empty($link->toComponent)
+        if (empty($link->toComponent)
             && !empty($link->fromComponent)) {
             debug_add("Setting property 'toComponent' to '{$component}'");
             $link->toComponent = $component;
@@ -95,7 +95,7 @@ 
             $link->fromComponent = $component;
         }
 
-        if (   empty($link->toGuid)
+        if (empty($link->toGuid)
             && !empty($link->fromGuid)) {
             $link->toClass = get_class($obj);
             $link->toGuid = $obj->guid;

lib/midgard/admin/asgard/style/ASGARD_ROOT.php

Spacing +1 added lines, -1 removed lines

@@ -127,7 +127,7 @@
 
                             $edited = (int) $view_metadata->get('revised');
                             $revision = $view_metadata->get('revision');
-                            if (   $revision > 0
+                            if ($revision > 0
                                 && $edited != $created) {
                                 try {
                                     $editor = new midcom_db_person($view_metadata->get('revisor'));

lib/midgard/admin/asgard/navigation.php

Spacing +13 added lines, -13 removed lines

@@ -41,7 +41,7 @@ 
         $this->_component = 'midgard.admin.asgard';
 
         $this->_object = $object;
-        $this->_request_data =& $request_data;
+        $this->_request_data = & $request_data;
 
         $this->root_types = midcom_helper_reflector_tree::get_root_classes();
 
@@ -57,7 +57,7 @@ 
             // we go through the path bottom up and show the first root type we find
             foreach (array_reverse($this->_object_path) as $node) {
                 foreach ($this->root_types as $root_type) {
-                    if (   is_a($node, $root_type)
+                    if (is_a($node, $root_type)
                         || midcom_helper_reflector::is_same_class($root_type, $node->__midcom_class_name__)) {
                         $this->expanded_root_types[] = $root_type;
                         break;
@@ -69,7 +69,7 @@ 
 
     protected function _is_collapsed(string $type, int $total) : bool
     {
-        return (   $total > $this->_config->get('max_navigation_entries')
+        return ($total > $this->_config->get('max_navigation_entries')
                 && empty($_GET['show_all_' . $type]));
     }
 
@@ -85,7 +85,7 @@ 
         foreach ($ref->get_child_classes() as $class) {
             $qb = $ref->_child_objects_type_qb($class, $object, false);
 
-            if (   !$qb
+            if (!$qb
                 || !($count = $qb->count_unchecked())) {
                 continue;
             }
@@ -131,7 +131,7 @@ 
     {
         $qb = $ref->_root_objects_qb();
 
-        if (   !$qb
+        if (!$qb
             || !($total = $qb->count_unchecked())) {
             return;
         }
@@ -209,7 +209,7 @@ 
         }
 
         echo "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/{$mode}/{$object->guid}/\" title=\"GUID: {$object->guid}, ID: {$object->id}\">{$icon}{$label}</a>\n";
-        if (   $selected
+        if ($selected
             || $autoexpand) {
             $this->_list_child_elements($object, $level + 1);
         }
@@ -229,7 +229,7 @@ 
                 continue;
             }
 
-            if (   method_exists($class, 'navigation')
+            if (method_exists($class, 'navigation')
                 && ($this->_request_data['plugin_name'] == "asgard_{$component}")) {
                 $this->_request_data['expanded'] = true;
                 midcom_show_style('midgard_admin_asgard_navigation_section_header');
@@ -263,13 +263,13 @@ 
         if ($this->_is_selected($object)) {
             $css_class .= ' selected';
         }
-        if (   is_object($this->_object)
-            && (   $object->guid == $this->_object->guid
-                || (   is_a($this->_object, midcom_db_parameter::class)
+        if (is_object($this->_object)
+            && ($object->guid == $this->_object->guid
+                || (is_a($this->_object, midcom_db_parameter::class)
                     && $object->guid == $this->_object->parentguid))) {
             $css_class .= ' current';
         }
-        if ( !$object->can_do('midgard:update')) {
+        if (!$object->can_do('midgard:update')) {
             $css_class .= ' readonly';
         }
         return $css_class;
@@ -312,7 +312,7 @@ 
 
         // If the regular expression has been set, check which types should be shown
         if ($regexp !== '//') {
-            $label_mapping = array_filter($label_mapping, function ($root_type) use ($regexp, $exclude) {
+            $label_mapping = array_filter($label_mapping, function($root_type) use ($regexp, $exclude) {
                 return preg_match($regexp, $root_type) == $exclude;
             }, ARRAY_FILTER_USE_KEY);
         }
@@ -342,7 +342,7 @@ 
          * click if nothing is expanded
          */
         $types_shown = false;
-        if (    !empty($expanded_types)
+        if (!empty($expanded_types)
              && midgard_admin_asgard_plugin::get_preference('navigation_type') === 'dropdown') {
             $this->_draw_select_navigation();
             $types_shown = true;