flack / openpsa

lib/org/openpsa/directmarketing/handler/message/compose.php

Spacing +2 added lines, -2 removed lines

@@ -69,7 +69,7 @@ 
         }
 
         //Substyle handling
-        if (   !empty($data['message_array']['substyle'])
+        if (!empty($data['message_array']['substyle'])
             && !preg_match('/^builtin:/', $data['message_array']['substyle'])) {
             debug_add("Appending substyle {$data['message_array']['substyle']}");
             midcom::get()->style->append_substyle($data['message_array']['substyle']);
@@ -120,7 +120,7 @@ 
     private function _real_show_compose(array $data)
     {
         $prefix = '';
-        if (   !empty($data['message_array']['substyle'])
+        if (!empty($data['message_array']['substyle'])
             && preg_match('/^builtin:(.*)/', $data['message_array']['substyle'], $matches_style)) {
             $prefix = $matches_style[1] . '-';
         }

lib/errors.php

Spacing +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
             return;
         }
 
-        if (   !is_writable($config['filename'])
+        if (!is_writable($config['filename'])
             && !is_writable(dirname($config['filename']))) {
             debug_add("Error logging file {$config['filename']} is not writable", MIDCOM_LOG_WARN);
             return;

lib/org/openpsa/relatedto/handler/relatedto.php

Spacing +1 added lines, -1 removed lines

@@ -199,7 +199,7 @@
     private function _render_line(array $link, midcom_core_dbaobject &$other_obj)
     {
         $this->_request_data['link'] = $link;
-        $this->_request_data['other_obj'] =& $other_obj;
+        $this->_request_data['other_obj'] = & $other_obj;
         $this->_request_data['icon'] = midcom_helper_reflector::get_object_icon($other_obj);
 
         if (get_class($other_obj) != $link['class']) {

lib/net/nehmer/blog/handler/archive.php

Spacing +4 added lines, -4 removed lines

@@ -131,8 +131,8 @@ 
         $year_data = [];
         $first_post = $this->_compute_welcome_first_post();
         $this->_request_data['first_post'] = $first_post;
-        $this->_request_data['total_count'] =& $total_count;
-        $this->_request_data['year_data'] =& $year_data;
+        $this->_request_data['total_count'] = & $total_count;
+        $this->_request_data['year_data'] = & $year_data;
         if (!$first_post) {
             return;
         }
@@ -261,7 +261,7 @@ 
         switch ($handler_id) {
             case 'archive-year-category':
                 $category = trim(strip_tags($args[1]));
-                if (   $data['datamanager']->get_schema('default')->has_field('categories')
+                if ($data['datamanager']->get_schema('default')->has_field('categories')
                     && !$data['datamanager']->get_schema('default')->get_field('categories')['type_config']['allow_multiple']) {
                     $qb->add_constraint('extra1', '=', $category);
                 } else {
@@ -345,7 +345,7 @@ 
             throw new midcom_error_notfound("The year '{$year}' is not valid.");
         }
 
-        if (   $month < 1
+        if ($month < 1
             || $month > 12) {
             throw new midcom_error_notfound("The month {$month} is not valid.");
         }

lib/org/openpsa/user/validator.php

Spacing +3 added lines, -3 removed lines

@@ -47,7 +47,7 @@ 
         $result = $this->is_username_available($fields);
 
         $accounthelper = new org_openpsa_user_accounthelper();
-        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])){
+        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])) {
             $result = ['password' => midcom::get()->i18n->get_string('password weak', 'org.openpsa.user')];
         }
 
@@ -149,10 +149,10 @@ 
         $user = new midcom_db_person($fields["person"]);
 
         $accounthelper = new org_openpsa_user_accounthelper($user);
-        if (!$accounthelper->check_password_reuse($fields['new_password'])){
+        if (!$accounthelper->check_password_reuse($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password was already used', 'org.openpsa.user');
         }
-        if (!$accounthelper->check_password_strength($fields['new_password'])){
+        if (!$accounthelper->check_password_strength($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password weak', 'org.openpsa.user');
         }
         return $result ?: true;

lib/org/openpsa/products/product/group.php

Spacing +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
         }
 
         $result_cache[$cache_key] = [];
-        $ret =& $result_cache[$cache_key];
+        $ret = & $result_cache[$cache_key];
 
         if (empty($up)) {
             // TODO: use reflection to see what kind of property this is ?

lib/org/openpsa/relatedto/handler/journal/list.php

Spacing +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
             }
 
             $reflector = midcom_helper_reflector::get($linked_object);
-            $link_html = "<a href='" . midcom::get()->permalinks->create_permalink($linked_object->guid) . "'>" . $reflector->get_object_label($linked_object) ."</a>";
+            $link_html = "<a href='" . midcom::get()->permalinks->create_permalink($linked_object->guid) . "'>" . $reflector->get_object_label($linked_object) . "</a>";
             $data['linked_objects'][$entry->linkGuid] = $link_html;
             $data['linked_raw_objects'][$entry->linkGuid] = $reflector->get_object_label($linked_object);
         }

lib/org/openpsa/directmarketing/handler/message/report.php

Spacing +12 added lines, -12 removed lines

@@ -37,7 +37,7 @@ 
         $qb_receipts->add_constraint('orgOpenpsaObtype', '=', org_openpsa_directmarketing_campaign_messagereceipt_dba::SENT);
         $qb_receipts->add_order('metadata.created');
         $receipts = $qb_receipts->execute_unchecked();
-        $receipt_data =& $this->_request_data['report']['receipt_data'];
+        $receipt_data = & $this->_request_data['report']['receipt_data'];
         $receipt_data['first_send'] = $receipts[0]->metadata->created ?? 0;
         $receipt_data['last_send'] = end($receipts)->metadata->created ?? 0;
         $receipt_data['sent'] = count($receipts);
@@ -64,7 +64,7 @@ 
 
     private function _get_campaign_data(int $first_send)
     {
-        $campaign_data =& $this->_request_data['report']['campaign_data'];
+        $campaign_data = & $this->_request_data['report']['campaign_data'];
         $qb_unsub = org_openpsa_directmarketing_campaign_member_dba::new_query_builder();
         $qb_unsub->add_constraint('campaign', '=', $this->_message->campaign);
         $qb_unsub->add_constraint('orgOpenpsaObtype', '=', org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED);
@@ -88,7 +88,7 @@ 
     private function _get_link_data($segmentation_param)
     {
         $this->_request_data['report']['link_data'] = [];
-        $link_data =& $this->_request_data['report']['link_data'];
+        $link_data = & $this->_request_data['report']['link_data'];
 
         $link_data['counts'] = [];
         $link_data['percentages'] = ['of_links' => [], 'of_recipients' => []];
@@ -114,7 +114,7 @@ 
         foreach ($links as $link) {
             $segment = '';
             $segment_notfound = false;
-            if (   $segmentation_param
+            if ($segmentation_param
                 && !empty($link->person)) {
                 try {
                     $person = org_openpsa_contacts_person_dba::get_cached($link->person);
@@ -128,7 +128,7 @@ 
                 if (!isset($link_data['segments'][$segment])) {
                     $link_data['segments'][$segment] = $segment_prototype;
                 }
-                $segment_data =& $link_data['segments'][$segment];
+                $segment_data = & $link_data['segments'][$segment];
             } else {
                 $segment_data = $segment_prototype;
             }
@@ -238,15 +238,15 @@ 
         $this->_initialize_field($array['percentages']['of_links'], $link);
         $this->_initialize_field($array['percentages']['of_recipients'], $link);
 
-        $link_data =& $this->_request_data['report']['link_data'];
-        $array['percentages']['of_links'][$link->target]['total'] = ($array['counts'][$link->target]['total']/$link_data['total'])*100;
-        $array['percentages']['of_links'][$link->target][$link->token] = ($array['counts'][$link->target][$link->token]/$link_data['total'])*100;
+        $link_data = & $this->_request_data['report']['link_data'];
+        $array['percentages']['of_links'][$link->target]['total'] = ($array['counts'][$link->target]['total'] / $link_data['total']) * 100;
+        $array['percentages']['of_links'][$link->target][$link->token] = ($array['counts'][$link->target][$link->token] / $link_data['total']) * 100;
 
-        $receipt_data =& $this->_request_data['report']['receipt_data'];
-        $array['percentages']['of_recipients'][$link->target]['total'] = ((count($array['counts'][$link->target])-1)/($receipt_data['sent']-$receipt_data['bounced']))*100;
-        $array['percentages']['of_recipients'][$link->target][$link->token] = ($array['counts'][$link->target][$link->token]/($receipt_data['sent']-$receipt_data['bounced']))*100;
+        $receipt_data = & $this->_request_data['report']['receipt_data'];
+        $array['percentages']['of_recipients'][$link->target]['total'] = ((count($array['counts'][$link->target]) - 1) / ($receipt_data['sent'] - $receipt_data['bounced'])) * 100;
+        $array['percentages']['of_recipients'][$link->target][$link->token] = ($array['counts'][$link->target][$link->token] / ($receipt_data['sent'] - $receipt_data['bounced'])) * 100;
 
-        if (   !isset($array['percentages']['of_recipients']['total'])
+        if (!isset($array['percentages']['of_recipients']['total'])
             || $array['percentages']['of_recipients'][$link->target]['total'] > $array['percentages']['of_recipients']['total']) {
             $array['percentages']['of_recipients']['total'] = $array['percentages']['of_recipients'][$link->target]['total'];
         }

lib/org/openpsa/mail/template.php

Spacing +1 added lines, -1 removed lines

@@ -103,7 +103,7 @@
         foreach ($parameters as $key => $value) {
             $this->_patterns[] = "/__({$key})__/";
 
-            if (   is_array($value)
+            if (is_array($value)
                 || is_object($value)) {
                 $this->_patterns[] = "/__({$key})_([^ \.>\"-]*?)__/";
             }