flack / openpsa

lib/org/openpsa/invoices/handler/billingdata.php

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
     private function load_controller(org_openpsa_invoices_billing_data_dba $bd) : controller
     {
         $schemadb = schemadb::from_path($this->_config->get('schemadb_billing_data'));
-        $vat =& $schemadb->get('default')->get_field('vat');
+        $vat = & $schemadb->get('default')->get_field('vat');
         // Fill VAT select
         if ($options = $this->get_vat_options($this->_config->get('vat_percentages'))) {
             $vat['type_config']['options'] = $options;
@@ -68,7 +68,7 @@ 
         $data['controller'] = $this->load_controller($bd);
 
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
-        if (   $mode == 'edit'
+        if ($mode == 'edit'
             && $bd->can_do('midgard:delete')) {
             $delete = $this->get_workflow('delete', [
                 'object' => $bd,

lib/org/openpsa/products/midcom/interfaces.php

Braces +4 added lines, -2 removed lines

@@ -79,7 +79,8 @@ 
                 try {
                     $dms['group']->set_storage($group);
                     org_openpsa_products_viewer::index($dms['group'], $indexer, $topic, $config);
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     $e->log(MIDCOM_LOG_WARN);
                 }
             }
@@ -91,7 +92,8 @@ 
                     try {
                         $dms['product']->set_storage($product);
                         org_openpsa_products_viewer::index($dms['product'], $indexer, $topic, $config);
-                    } catch (midcom_error $e) {
+                    }
+                    catch (midcom_error $e) {
                         $e->log(MIDCOM_LOG_WARN);
                     }
                 }

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
      */
     public function _on_reindex($topic, midcom_helper_configuration $config, midcom_services_indexer $indexer)
     {
-        if (   !$config->get('index_products')
+        if (!$config->get('index_products')
             && !$config->get('index_groups')) {
             debug_add("No indexing to groups and products, skipping", MIDCOM_LOG_WARN);
             return true;

lib/org/openpsa/notifications/notifier/email.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
             $mail->from = $config->get('default_sender') ?: '"OpenPSA Notifier" <noreply@' . $_SERVER['SERVER_NAME'] . '>';
         }
 
-        $mail->subject = $message['title'] ??  'org.openpsa.notifications message (no title provided)';
+        $mail->subject = $message['title'] ?? 'org.openpsa.notifications message (no title provided)';
         if (array_key_exists('attachments', $message)) {
             $mail->attachments = $message['attachments'];
         }

lib/org/openpsa/documents/midcom/interfaces.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
 
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
     {
-        if (   $object instanceof org_openpsa_documents_document_dba
+        if ($object instanceof org_openpsa_documents_document_dba
             && $object->topic == $topic->id) {
             return "document/{$object->guid}/";
         }

lib/net/nemein/wiki/style/view-wikipage-raw.php

Spacing +1 added lines, -1 removed lines

@@ -6,6 +6,6 @@
     &(view["content"]:h);
     <?php
 } else {
-    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub')."</p>";
+    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub') . "</p>";
 }
 ?>
\ No newline at end of file

lib/org/openpsa/invoices/style/admin-read.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         <div class="value"><?php echo $formatter->date($invoice->deliverydate); ?></div></div>
     <?php } ?>
 
-    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description');?>: </div>
+    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description'); ?>: </div>
     <div class="description value">&(view['description']:h);</div></div>
 
     <?php

Braces +2 added lines, -1 removed lines

@@ -8,7 +8,8 @@
     if ($customer->orgOpenpsaObtype < org_openpsa_contacts_group_dba::ORGANIZATION) {
         $customer = false;
     }
-} catch (midcom_error $e) {
+}
+catch (midcom_error $e) {
     $customer = false;
 }
 

lib/org/openpsa/relatedto/style/show_entries_html.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
             <?php
             //index is needed for sorting
             echo "'index_name',";
-            echo "'" . $data['l10n']->get('entry title') ."',";
+            echo "'" . $data['l10n']->get('entry title') . "',";
             echo "'" . $data['l10n']->get('entry text') . "',";
             echo "'" . $data['l10n']->get('entry created') . "',";
             echo "'index_creator', '" . $data['l10n_midcom']->get('creator') . "',";

Braces +2 added lines, -1 removed lines

@@ -25,7 +25,8 @@
             $row['creator_index'] = $creator->rname;
             $creator_card = org_openpsa_widgets_contact::get($entry->metadata->creator);
             $row['creator'] = $creator_card->show_inline();
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $row['creator_index'] = '';
             $row['creator'] = '';
         }

lib/midcom/helper/reflector/main.php

Braces +2 added lines, -1 removed lines

@@ -203,7 +203,8 @@
         if ($object instanceof mgdobject) {
             try {
                 $obj = midcom::get()->dbfactory->convert_midgard_to_midcom($object);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 return null;
             }
         } else {

Spacing +3 added lines, -3 removed lines

@@ -304,7 +304,7 @@ 
 
         $label_prop = $this->get_label_property();
 
-        if (    $label_prop != 'guid'
+        if ($label_prop != 'guid'
              && $this->property_exists($label_prop)) {
             $search_properties[$label_prop] = true;
         }
@@ -354,7 +354,7 @@ 
                 continue;
             }
 
-            if (   !$this->is_link($property)
+            if (!$this->is_link($property)
                 && $this->get_midgard_type($property) != MGD_TYPE_GUID) {
                 continue;
             }
@@ -388,7 +388,7 @@ 
     protected static function class_rewrite(string $schema_type) : string
     {
         $extends = midcom_baseclasses_components_configuration::get('midcom.helper.reflector', 'config')->get_array('class_extends');
-        if (   isset($extends[$schema_type])
+        if (isset($extends[$schema_type])
             && class_exists($extends[$schema_type])) {
             return $extends[$schema_type];
         }

lib/midgard/admin/asgard/handler/object/attachments.php

Spacing +3 added lines, -3 removed lines

@@ -98,13 +98,13 @@ 
         }
 
         $mimetype = $request->request->get('midgard_admin_asgard_mimetype');
-        if (   !empty($mimetype)
+        if (!empty($mimetype)
             && $local_file->mimetype != $mimetype) {
             $local_file->mimetype = $mimetype;
             $needs_update = true;
         }
 
-        if (   $needs_update
+        if ($needs_update
             && !$local_file->update()) {
             return null;
         }
@@ -234,7 +234,7 @@ 
         $this->bind_view_to_object($this->_file);
 
         $filename = $this->_process_form($request);
-        if (   $filename
+        if ($filename
             && $filename != $data['filename']) {
             return $this->relocate_to_file($filename);
         }