flack / openpsa

lib/net/nemein/tag/tag.php

Spacing +3 added lines, -3 removed lines

@@ -42,7 +42,7 @@ 
 
     public function _on_creating()
     {
-        return (   $this->validate_tag($this->tag)
+        return ($this->validate_tag($this->tag)
                 && $this->_check_duplicates() == 0);
     }
 
@@ -66,7 +66,7 @@ 
             midcom::get()->uimessages->add(midcom::get()->i18n->get_string('net.nemein.tag', 'net.nemein.tag'), sprintf(midcom::get()->i18n->get_string('tag "%s" is not valid. tags may not be numeric', 'net.nemein.tag'), $tag), 'info');
             return false;
         }
-        if (   strstr($tag, '"')
+        if (strstr($tag, '"')
             || strstr($tag, "'")) {
             midcom::get()->uimessages->add(midcom::get()->i18n->get_string('net.nemein.tag', 'net.nemein.tag'), sprintf(midcom::get()->i18n->get_string('tag "%s" is not valid. tags may not contain quotes', 'net.nemein.tag'), $tag), 'info');
             return false;
@@ -77,7 +77,7 @@ 
 
     public function _on_updating()
     {
-        return (   $this->validate_tag($this->tag)
+        return ($this->validate_tag($this->tag)
                 && $this->_check_duplicates() == 0);
     }
 

lib/net/nemein/tag/exec/merge.php

Spacing +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
 <h1>Merge tags</h1>
 
 <?php
-if (   isset($_POST['from'])
+if (isset($_POST['from'])
     && isset($_POST['to'])) {
     if (net_nemein_tag_handler::merge_tags($_POST['from'], $_POST['to'])) {
         echo "<p>Successfully merged tag \"{$_POST['from']}\" to \"{$_POST['to']}\"</p>\n";

lib/net/nemein/redirector/viewer.php

Braces +2 added lines, -1 removed lines

@@ -152,7 +152,8 @@
                     try {
                         $topic = new midcom_db_topic($id);
                         $id = $topic->id;
-                    } catch (midcom_error $e) {
+                    }
+                    catch (midcom_error $e) {
                         $e->log();
                         break;
                     }

Spacing +2 added lines, -2 removed lines

@@ -19,8 +19,8 @@
     public function _on_initialize()
     {
         // Match /
-        if (   $this->_config->get('redirection_type') === null
-            || (   $this->_topic->can_do('net.nemein.redirector:noredirect')
+        if ($this->_config->get('redirection_type') === null
+            || ($this->_topic->can_do('net.nemein.redirector:noredirect')
                 && !$this->_config->get('admin_redirection'))) {
             $this->_request_switch['redirect'] = [
                 'handler' => [net_nemein_redirector_handler_tinyurl::class, 'list'],

lib/net/nemein/wiki/midcom/interfaces.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
 
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object)
     {
-        if (   $object instanceof midcom_db_article
+        if ($object instanceof midcom_db_article
             && $topic->id == $object->topic) {
             if ($object->name == 'index') {
                 return '';

Braces +2 added lines, -1 removed lines

@@ -30,7 +30,8 @@
             foreach ($result as $wikipage) {
                 try {
                     $datamanager->set_storage($wikipage);
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     $e->log(MIDCOM_LOG_WARN);
                     continue;
                 }

lib/net/nemein/wiki/handler/feed.php

Braces +2 added lines, -1 removed lines

@@ -66,7 +66,8 @@
             try {
                 $author = new midcom_db_person($wikipage->metadata->revisor);
                 $item->author = $author->name;
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
 

lib/net/nemein/wiki/handler/latest.php

Spacing +2 added lines, -2 removed lines

@@ -50,7 +50,7 @@ 
                     return;
                 }
 
-                if (   $history['date'] < $from
+                if ($history['date'] < $from
                     || $history['date'] > $to) {
                     // We can ignore revisions outside the timeframe
                     continue;
@@ -93,7 +93,7 @@ 
         $this->_seek_updated($from);
 
         $i = 0;
-        while (   $this->_updated_pages < $this->_max_pages
+        while ($this->_updated_pages < $this->_max_pages
                && $i < 20) {
             // Expand seek by another two weeks
             $to = $from;

lib/net/nemein/wiki/wikipage.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 
     public function _on_creating()
     {
-        if (   $this->title == ''
+        if ($this->title == ''
             || !$this->topic) {
             // We must have wikiword and topic at this stage
             return false;

Braces +2 added lines, -1 removed lines

@@ -193,7 +193,8 @@
 
         try {
             $diff_fields = $rcs_handler->get_diff($prev_version, $this_version);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return '';
         }

lib/net/nemein/rss/parser/item.php

Spacing +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
     public function get_link($key = 0, $rel = 'alternate')
     {
         $link = parent::get_link($key, $rel);
-        if (   $rel !== 'alternate'
+        if ($rel !== 'alternate'
             || $key !== 0) {
             return $link;
         }

lib/net/nehmer/comments/comment.php

Braces +2 added lines, -1 removed lines

@@ -408,7 +408,8 @@
         //Get the parent object
         try {
             $parent = midcom::get()->dbfactory->get_object_by_guid($this->objectguid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return false;
         }

Spacing +7 added lines, -7 removed lines

@@ -185,7 +185,7 @@ 
         }
 
         // Set the status
-        if (   $this->can_do('net.nehmer.comments:moderation')
+        if ($this->can_do('net.nehmer.comments:moderation')
             && !$this->_sudo_requested) {
             $this->status = self::ABUSE;
         } else {
@@ -209,7 +209,7 @@ 
             return false;
         }
         // Set the status
-        if (   !$this->can_do('net.nehmer.comments:moderation')
+        if (!$this->can_do('net.nehmer.comments:moderation')
             || $this->_sudo_requested) {
             return false;
         }
@@ -233,7 +233,7 @@ 
         }
 
         // Set the status
-        if (   !$this->can_do('net.nehmer.comments:moderation')
+        if (!$this->can_do('net.nehmer.comments:moderation')
             || $this->_sudo_requested) {
             return false;
         }
@@ -252,7 +252,7 @@ 
      */
     public function report_not_abuse()
     {
-        if (   !$this->can_do('net.nehmer.comments:moderation')
+        if (!$this->can_do('net.nehmer.comments:moderation')
             || $this->_sudo_requested) {
             return false;
         }
@@ -351,8 +351,8 @@ 
     {
         $config = midcom_baseclasses_components_configuration::get('net.nehmer.comments', 'config');
 
-        if (   $config->get('ratings_enable')
-            && (    $config->get('ratings_cache_to_object')
+        if ($config->get('ratings_enable')
+            && ($config->get('ratings_cache_to_object')
                  || $config->get('comment_count_cache_to_object'))) {
             // Handle ratings
             $comments = self::list_by_objectguid($this->objectguid);
@@ -409,7 +409,7 @@ 
             return false;
         }
 
-        if (   empty($this->title)
+        if (empty($this->title)
             && empty($this->content)) {
             // No need to send notifications about empty rating entries
             return false;