flack / openpsa

lib/org/openpsa/directmarketing/sender.php

Spacing +3 added lines, -3 removed lines

@@ -75,7 +75,7 @@ 
         $this->from = $from;
         $this->subject = $subject;
 
-        if (   $message->orgOpenpsaObtype != org_openpsa_directmarketing_campaign_message_dba::EMAIL_TEXT
+        if ($message->orgOpenpsaObtype != org_openpsa_directmarketing_campaign_message_dba::EMAIL_TEXT
             && $message->orgOpenpsaObtype != org_openpsa_directmarketing_campaign_message_dba::EMAIL_HTML) {
             throw new midcom_error('unsupported message type');
         }
@@ -219,7 +219,7 @@ 
         $token .= midcom_helper_misc::random_string($this->token_size - 1, 'abcdefghijklmnopqrstuvwxyz0123456789');
 
         //If token is not free or (very, very unlikely) matches our dummy token, recurse.
-        if (   $token === 'dummy'
+        if ($token === 'dummy'
             || !org_openpsa_directmarketing_campaign_messagereceipt_dba::token_is_free($token)) {
             return $this->_create_token();
         }
@@ -240,7 +240,7 @@ 
             return null;
         }
         $type = $this->_backend->get_type();
-        if (   $person->get_parameter('org.openpsa.directmarketing', "send_all_denied")
+        if ($person->get_parameter('org.openpsa.directmarketing', "send_all_denied")
             || $person->get_parameter('org.openpsa.directmarketing', "send_{$type}_denied")) {
             debug_add("Sending {$type} messages to person {$person->rname} is denied, unsubscribing member (member #{$member->id})");
             $member->orgOpenpsaObtype = org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED;

lib/midcom/helper/imagefilter.php

Spacing +3 added lines, -3 removed lines

@@ -341,7 +341,7 @@ 
         $tmpfile = null;
         $imagesize = getimagesize($this->_filename);
 
-        if (   $imagesize[2] == IMAGETYPE_JPEG
+        if ($imagesize[2] == IMAGETYPE_JPEG
             && $this->_jpegtran_available()) {
             /* jpegtran */
             $operations = [
@@ -409,7 +409,7 @@ 
         $imagesize = getimagesize($this->_filename);
 
         // Try lossless jpegtran rotation if possible
-        if (   $imagesize[2] == IMAGETYPE_JPEG
+        if ($imagesize[2] == IMAGETYPE_JPEG
             && ($rotate % 90 == 0)
             && $this->_jpegtran_available()) {
             $tmpfile = $this->_get_tempfile();
@@ -539,7 +539,7 @@ 
      */
     public function fill($x = null, $y = null, $color = null, string $gravity = 'center')
     {
-        if (   empty($x)
+        if (empty($x)
             || empty($y)
             || empty($color)) {
             //This is a bit silly, but here for backwards compatibility...

lib/org/openpsa/invoices/invoice/pdf.php

Spacing +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
             $attachment->update();
         } else {
             $attachment = $this->invoice->create_attachment($filename, $this->invoice->get_label(), "application/pdf");
-            if (   !$attachment
+            if (!$attachment
                 || !$this->invoice->set_parameter("midcom.helper.datamanager2.type.blobs", "guids_pdf_file", $attachment->guid . ":" . $attachment->guid)) {
                 throw new midcom_error("Failed to create invoice attachment for pdf: " . midcom_connection::get_error_string());
             }

lib/midcom/services/auth/backend.php

Spacing +2 added lines, -2 removed lines

@@ -100,7 +100,7 @@ 
             return null;
         }
 
-        if (   midcom::get()->config->get('auth_check_client_ip')
+        if (midcom::get()->config->get('auth_check_client_ip')
             && $data['clientip'] != $request->getClientIp()) {
             debug_add("The session had mismatching client IP.", MIDCOM_LOG_INFO);
             debug_add("Expected {$data['clientip']}, got {$request->getClientIp()}.");
@@ -114,7 +114,7 @@ 
             return null;
         }
 
-        if (   !$this->check_timestamp($data['timestamp'], $user)
+        if (!$this->check_timestamp($data['timestamp'], $user)
             || !$this->authenticate($user->username, '', true)) {
             $this->logout($user);
             return null;

lib/midgard/admin/asgard/handler/undelete.php

Spacing +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
             $child_indent = $indent + 20;
             echo "{$prefix}<tbody class=\"children\">\n";
             foreach ($child_types as $type => $children) {
-                if (   count($children) < 10
+                if (count($children) < 10
                     || isset($_GET['show_children'][$object->guid][$type])) {
                         foreach ($children as $child) {
                             $this->show_type($child, $child_indent, "{$prefix}    ", false);

lib/net/nehmer/blog/style/index-item.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
         &(published:h);
             <?php
             if ($data['linked']) {
-                echo $data['l10n']->get('to') ." <a href=\"{$data['node'][MIDCOM_NAV_ABSOLUTEURL]}\">{$data['node'][MIDCOM_NAV_NAME]}</a>\n";
+                echo $data['l10n']->get('to') . " <a href=\"{$data['node'][MIDCOM_NAV_ABSOLUTEURL]}\">{$data['node'][MIDCOM_NAV_NAME]}</a>\n";
             }
             ?>
     </p>

lib/org/openpsa/products/midcom/interfaces.php

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
      */
     public function _on_reindex($topic, midcom_helper_configuration $config, midcom_services_indexer $indexer)
     {
-        if (   !$config->get('index_products')
+        if (!$config->get('index_products')
             && !$config->get('index_groups')) {
             debug_add("No indexing to groups and products, skipping", MIDCOM_LOG_WARN);
             return true;

lib/org/openpsa/invoices/handler/invoice/crud.php

Spacing +2 added lines, -2 removed lines

@@ -141,8 +141,8 @@
         $schema->get_field('paid')['hidden'] = empty($this->invoice->paid);
 
         $contact = $this->invoice->customerContact ?: $this->contact_id;
-        $customer_field =& $schema->get_field('customer');
-        $contact_field =& $schema->get_field('customerContact');
+        $customer_field = & $schema->get_field('customer');
+        $contact_field = & $schema->get_field('customerContact');
 
         if (!empty($contact)) {
             $customer_field['type_config']['options'] = $this->get_customers_for_contact($contact);

lib/org/openpsa/reports/handler/projects/report.php

Spacing +4 added lines, -4 removed lines

@@ -47,12 +47,12 @@ 
         $qb_hr = org_openpsa_expenses_hour_report_dba::new_query_builder();
         $qb_hr->add_constraint('date', '<=', (int) $query_data['end']);
         $qb_hr->add_constraint('date', '>=', (int) $query_data['start']);
-        if (   array_key_exists('invoiceable_filter', $query_data)
+        if (array_key_exists('invoiceable_filter', $query_data)
             && $query_data['invoiceable_filter'] != -1) {
             $qb_hr->add_constraint('invoiceable', '=', (bool) $query_data['invoiceable_filter']);
         }
 
-        if (   array_key_exists('invoiced_filter', $query_data)
+        if (array_key_exists('invoiced_filter', $query_data)
             && $query_data['invoiced_filter'] != -1) {
             if ((int) $query_data['invoiced_filter']) {
                 debug_add('invoiced_filter parsed as ONLY, adding constraint');
@@ -71,7 +71,7 @@ 
             $tasks = $this->_expand_task($query_data['task']);
             $qb_hr->add_constraint('task', 'IN', $tasks);
         }
-        if (   array_key_exists('hour_type_filter', $query_data)
+        if (array_key_exists('hour_type_filter', $query_data)
             && $query_data['hour_type_filter'] != 'builtin:all') {
             $qb_hr->add_constraint('reportType', '=', $query_data['hour_type_filter']);
         }
@@ -140,7 +140,7 @@ 
 
     private function add_to_group(array $new_row, string $matching, string $sort, string $title)
     {
-        $rows =& $this->_request_data['report']['rows'];
+        $rows = & $this->_request_data['report']['rows'];
         if (array_key_exists($matching, $rows)) {
             $rows[$matching]['rows'][] = $new_row;
             $rows[$matching]['total_hours'] += $new_row['hour']->hours;