flack / openpsa

lib/org/openpsa/invoices/handler/billingdata.php

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
     private function load_controller(org_openpsa_invoices_billing_data_dba $bd) : controller
     {
         $schemadb = schemadb::from_path($this->_config->get('schemadb_billing_data'));
-        $vat =& $schemadb->get('default')->get_field('vat');
+        $vat = & $schemadb->get('default')->get_field('vat');
         // Fill VAT select
         if ($options = $this->get_vat_options($this->_config->get('vat_percentages'))) {
             $vat['type_config']['options'] = $options;
@@ -68,7 +68,7 @@ 
         $data['controller'] = $this->load_controller($bd);
 
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
-        if (   $mode == 'edit'
+        if ($mode == 'edit'
             && $bd->can_do('midgard:delete')) {
             $delete = $this->get_workflow('delete', [
                 'object' => $bd,

lib/org/openpsa/products/midcom/interfaces.php

Braces +4 added lines, -2 removed lines

@@ -79,7 +79,8 @@ 
                 try {
                     $dms['group']->set_storage($group);
                     org_openpsa_products_viewer::index($dms['group'], $indexer, $topic, $config);
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     $e->log(MIDCOM_LOG_WARN);
                 }
             }
@@ -91,7 +92,8 @@ 
                     try {
                         $dms['product']->set_storage($product);
                         org_openpsa_products_viewer::index($dms['product'], $indexer, $topic, $config);
-                    } catch (midcom_error $e) {
+                    }
+                    catch (midcom_error $e) {
                         $e->log(MIDCOM_LOG_WARN);
                     }
                 }

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
      */
     public function _on_reindex($topic, midcom_helper_configuration $config, midcom_services_indexer &$indexer)
     {
-        if (   !$config->get('index_products')
+        if (!$config->get('index_products')
             && !$config->get('index_groups')) {
             debug_add("No indexing to groups and products, skipping", MIDCOM_LOG_WARN);
             return true;

lib/org/openpsa/notifications/notifier/email.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
             $mail->from = $config->get('default_sender') ?: '"OpenPSA Notifier" <noreply@' . $_SERVER['SERVER_NAME'] . '>';
         }
 
-        $mail->subject = $message['title'] ??  'org.openpsa.notifications message (no title provided)';
+        $mail->subject = $message['title'] ?? 'org.openpsa.notifications message (no title provided)';
         if (array_key_exists('attachments', $message)) {
             $mail->attachments = $message['attachments'];
         }

lib/org/openpsa/qbpager/style/show_pages_as_list.php

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
         echo "\n<li class=\"separator\"></li>";
         echo "\n<li class=\"page splitter\">...</li>";
     }
-    if (   $i > 0
+    if ($i > 0
         && $i < $total_links) {
         echo "\n<li class=\"separator\"></li>";
     }

lib/org/openpsa/products/product/group.php

Spacing +2 added lines, -2 removed lines

@@ -78,7 +78,7 @@ 
         }
 
         $result_cache[$cache_key] = [];
-        $ret =& $result_cache[$cache_key];
+        $ret = & $result_cache[$cache_key];
 
         if (empty($up)) {
             // TODO: use reflection to see what kind of property this is ?
@@ -94,7 +94,7 @@ 
 
         $value_properties = array_unique(array_merge($label_fields, [$keyproperty, 'id']));
 
-        $mc = self::new_collector('up', (int)$up);
+        $mc = self::new_collector('up', (int) $up);
         if ($order_by_score) {
             $mc->add_order('metadata.score', 'DESC');
         }

lib/midcom/services/auth/frontend/form.php

Spacing +2 added lines, -2 removed lines

@@ -40,7 +40,7 @@ 
      */
     public function read_login_data(Request $request) : ?array
     {
-        if (   !$request->request->has('midcom_services_auth_frontend_form_submit')
+        if (!$request->request->has('midcom_services_auth_frontend_form_submit')
             || !$request->request->has('username')
             || !$request->request->has('password')) {
             return null;
@@ -76,7 +76,7 @@ 
     {
         // Store the submitted form if the session expired, but user wants to save the data
         if (!empty($_POST)) {
-            $data =& midcom_core_context::get()->get_custom_key('request_data');
+            $data = & midcom_core_context::get()->get_custom_key('request_data');
 
             $data['restored_form_data'] = [];
 

lib/org/openpsa/documents/midcom/interfaces.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
 
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
     {
-        if (   $object instanceof org_openpsa_documents_document_dba
+        if ($object instanceof org_openpsa_documents_document_dba
             && $object->topic == $topic->id) {
             return "document/{$object->guid}/";
         }

lib/org/openpsa/mypage/style/workingon_expenses.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
     echo "<form action=\"{$data['expenses_url']}\" method='post'><div>";
     $current_user = midcom::get()->auth->user->get_storage();
     echo "<input type=\"hidden\" name=\"person[]\" value=\"{$current_user->id}\" />";
-    echo "<input type=\"submit\" value=\"".sprintf($data['l10n']->get('see all %s hours'), round($total_hours, 2))."\" />";
+    echo "<input type=\"submit\" value=\"" . sprintf($data['l10n']->get('see all %s hours'), round($total_hours, 2)) . "\" />";
     echo "</div></form>";
     ?>
 </div>

lib/midcom/admin/folder/style/midcom-admin-folder-order-type.php

Spacing +2 added lines, -2 removed lines

@@ -4,7 +4,7 @@ 
 $count = count($data['navigation_items']);
 
 foreach ($data['navigation_items'] as $i => $item) {
-    if (   isset($item[MIDCOM_NAV_SORTABLE])
+    if (isset($item[MIDCOM_NAV_SORTABLE])
         && !$item[MIDCOM_NAV_SORTABLE]) {
         continue;
     }
@@ -19,7 +19,7 @@ 
     }
 
     // Skip all components that return the default icon
-    if (   isset($item[MIDCOM_NAV_COMPONENT])
+    if (isset($item[MIDCOM_NAV_COMPONENT])
         && ($tmp = midcom::get()->componentloader->get_component_icon($item[MIDCOM_NAV_COMPONENT], false))) {
         $icon = '<i class="fa fa-' . $tmp . '"></i>';
     } elseif (!$item[MIDCOM_NAV_GUID]) {