Passed
Push — master ( f0f689...643f59 )
by Andreas
09:19
created
src/midcom/httpkernel/subscriber.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
         $i = array_search('__request_data__', $arguments, true);
91 91
         if ($i !== false) {
92 92
             $context = $event->getRequest()->attributes->get('context');
93
-            $arguments[$i] =& $context->get_custom_key('request_data');
93
+            $arguments[$i] = & $context->get_custom_key('request_data');
94 94
             $event->setArguments($arguments);
95 95
         }
96 96
     }
Please login to merge, or discard this patch.
lib/midcom/baseclasses/components/viewer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@
 block discarded – undo
246 246
      */
247 247
     public function prepare_handler(midcom_baseclasses_components_handler $handler, array &$parameters)
248 248
     {
249
-        $this->parameters =& $parameters;
249
+        $this->parameters = & $parameters;
250 250
 
251 251
         $parameters['handler'] = explode('::', $parameters['_controller'], 2);
252 252
 
Please login to merge, or discard this patch.
lib/org/openpsa/projects/handler/task/resourcing.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
             return new midcom_response_relocate($this->router->generate('task_view', ['guid' => $guid]));
59 59
         }
60 60
 
61
-        if (   $request->request->has('save')
61
+        if ($request->request->has('save')
62 62
             && $prospects = $request->request->all('org_openpsa_projects_prospects')) {
63 63
             $qb = org_openpsa_projects_task_resource_dba::new_query_builder();
64 64
             $qb->add_constraint('guid', 'IN', array_keys($prospects));
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
                     // create relatedto
90 90
                     org_openpsa_relatedto_plugin::create($event, 'org.openpsa.calendar', $this->_task, 'org.openpsa.projects');
91 91
                 }
92
-                if (   $update_prospect
92
+                if ($update_prospect
93 93
                     && !$prospect->update()) {
94 94
                     debug_add('Failed to update prospect: ' . midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
95 95
                 }
Please login to merge, or discard this patch.
lib/org/openpsa/mail/backend.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,7 +46,8 @@  discard block
 block discarded – undo
46 46
                     $object = self::_load_backend($backend, $params);
47 47
                     debug_add('Using backend ' . $backend);
48 48
                     return $object;
49
-                } catch (midcom_error $e) {
49
+                }
50
+                catch (midcom_error $e) {
50 51
                     debug_add('Failed to load backend ' . $backend . ', message:' . $e->getMessage());
51 52
                 }
52 53
             }
@@ -76,7 +77,8 @@  discard block
 block discarded – undo
76 77
             $this->mail($message);
77 78
             $this->error = null;
78 79
             return true;
79
-        } catch (Exception $e) {
80
+        }
81
+        catch (Exception $e) {
80 82
             $this->error = $e->getMessage();
81 83
             return false;
82 84
         }
Please login to merge, or discard this patch.
src/midcom/grid/provider.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
 
237 237
     private function _convert_to_localdata() : string
238 238
     {
239
-        return "var " . $this->_grid->get_identifier() . '_entries = ' .  json_encode($this->get_rows()) . ";\n";
239
+        return "var " . $this->_grid->get_identifier() . '_entries = ' . json_encode($this->get_rows()) . ";\n";
240 240
     }
241 241
 
242 242
     private function _render_json()
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
             $this->_sort_field = $query['sidx'];
270 270
             $this->_sort_direction = strtoupper($query['sord'] ?? 'ASC');
271 271
         }
272
-        if (   !empty($query['_search'])
272
+        if (!empty($query['_search'])
273 273
             && $query['_search'] === 'true') {
274 274
             foreach ($query as $field => $value) {
275 275
                 if (in_array($field, ['_search', 'nd', 'page', 'rows', 'sidx', 'sord'])) {
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
 
295 295
         $this->_total_rows = $query->count();
296 296
 
297
-        if (   $this->_datatype == 'json'
297
+        if ($this->_datatype == 'json'
298 298
             && !empty($this->_results_per_page)) {
299 299
             $query->set_limit($this->_results_per_page);
300 300
             if (!empty($this->_offset)) {
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/handler/import.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
         $contacts = $importer->parse($input);
143 143
         if (!empty($contacts)) {
144 144
             $this->_request_data['import_status'] = $importer->import_subscribers($contacts, $this->_request_data['campaign']);
145
-            if (   $this->_request_data['import_status']['subscribed_new'] > 0
145
+            if ($this->_request_data['import_status']['subscribed_new'] > 0
146 146
                 || $this->_request_data['import_status']['already_subscribed'] > 0) {
147 147
                 $this->_import_success = true;
148 148
             }
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
                 $read_rows = 0;
200 200
                 $handle = fopen($data['tmp_file'], 'r');
201 201
                 $total_columns = 0;
202
-                while (   $read_rows < 2
202
+                while ($read_rows < 2
203 203
                        && $csv_line = fgetcsv($handle, 1000, $data['separator'])) {
204 204
                     if ($total_columns == 0) {
205 205
                         $total_columns = count($csv_line);
Please login to merge, or discard this patch.
lib/org/openpsa/documents/handler/document/admin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
 
91 91
         $this->_controller = $this->load_controller();
92 92
 
93
-        if (   $data['enable_versioning']
93
+        if ($data['enable_versioning']
94 94
             && $request->request->count() > 0) {
95 95
             $this->_backup_attachment($request);
96 96
         }
Please login to merge, or discard this patch.
lib/org/openpsa/core/queryfilter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
         $user = midcom::get()->auth->user->get_storage();
68 68
 
69 69
         if ($request->request->get('unset_filter') == $filter_id) {
70
-            if (   $user->get_parameter("org_openpsa_core_filter", $filter_id)
70
+            if ($user->get_parameter("org_openpsa_core_filter", $filter_id)
71 71
                 && !$user->delete_parameter("org_openpsa_core_filter", $filter_id)) {
72 72
                 $message_content = sprintf(
73 73
                     $l10n->get('the handed filter for %s could not be set as parameter'),
Please login to merge, or discard this patch.
src/midcom/console/command/cleanup/privileges.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,8 @@
 block discarded – undo
50 50
                 try {
51 51
                     \midgard_object_class::get_object_by_guid($priv->objectguid);
52 52
                     $seen_parents[$priv->objectguid] = true;
53
-                } catch (\Exception $e) {
53
+                }
54
+                catch (\Exception $e) {
54 55
                     $seen_parents[$priv->objectguid] = false;
55 56
                 }
56 57
             }
Please login to merge, or discard this patch.