Passed
Push — master ( f0f689...643f59 )
by Andreas
09:19
created
lib/midcom/baseclasses/components/plugin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
     public function initialize(midcom_baseclasses_components_viewer $master, Router $router)
19 19
     {
20 20
         $this->router = $router;
21
-        $this->_request_data =& $master->_request_data;
21
+        $this->_request_data = & $master->_request_data;
22 22
         $this->_topic = $master->_topic;
23 23
         $this->_request_data['l10n'] = $this->_l10n;
24 24
 
Please login to merge, or discard this patch.
lib/org/openpsa/projects/handler/task/crud.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,8 @@
 block discarded – undo
138 138
         try {
139 139
             $parent = new org_openpsa_projects_project($task->project);
140 140
             $options['success_url'] = $this->router->generate('project', ['guid' => $parent->guid]);
141
-        } catch (midcom_error $e) {
141
+        }
142
+        catch (midcom_error $e) {
142 143
             $e->log();
143 144
         }
144 145
 
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/handler/subscriber.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,8 @@  discard block
 block discarded – undo
36 36
             // Add person to campaign
37 37
             try {
38 38
                 $campaign = new org_openpsa_directmarketing_campaign_dba($add_to);
39
-            } catch (midcom_error $e) {
39
+            }
40
+            catch (midcom_error $e) {
40 41
                 // FIXME: More informative error message
41 42
                 $this->notify('Failed adding person %s to campaign %s', $add_to, 'error');
42 43
                 return;
@@ -86,7 +87,8 @@  discard block
 block discarded – undo
86 87
             try {
87 88
                 $campaigns[$membership->campaign] = new org_openpsa_directmarketing_campaign_dba($membership->campaign);
88 89
                 $campaign_membership_map[$membership->campaign] = $membership;
89
-            } catch (midcom_error $e) {
90
+            }
91
+            catch (midcom_error $e) {
90 92
                 debug_add('Failed to load campaign ' . $membership->campaign . ', reason: ' . $e->getMessage());
91 93
             }
92 94
         }
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/handler/invoice/crud.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,8 @@  discard block
 block discarded – undo
48 48
             // We're creating invoice for chosen customer
49 49
             try {
50 50
                 $this->customer = new org_openpsa_contacts_group_dba($company);
51
-            } catch (midcom_error $e) {
51
+            }
52
+            catch (midcom_error $e) {
52 53
                 $contact = new org_openpsa_contacts_person_dba($company);
53 54
                 $this->contact_id = $contact->id;
54 55
             }
@@ -155,7 +156,8 @@  discard block
 block discarded – undo
155 156
             if (!empty($this->invoice->customer)) {
156 157
                 try {
157 158
                     $this->customer = org_openpsa_contacts_group_dba::get_cached($this->invoice->customer);
158
-                } catch (midcom_error $e) {
159
+                }
160
+                catch (midcom_error $e) {
159 161
                     $customer_field['hidden'] = true;
160 162
                     $e->log();
161 163
                 }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -141,8 +141,8 @@
 block discarded – undo
141 141
         $schema->get_field('paid')['hidden'] = empty($this->invoice->paid);
142 142
 
143 143
         $contact = $this->invoice->customerContact ?: $this->contact_id;
144
-        $customer_field =& $schema->get_field('customer');
145
-        $contact_field =& $schema->get_field('customerContact');
144
+        $customer_field = & $schema->get_field('customer');
145
+        $contact_field = & $schema->get_field('customerContact');
146 146
 
147 147
         if (!empty($contact)) {
148 148
             $customer_field['type_config']['options'] = $this->get_customers_for_contact($contact);
Please login to merge, or discard this patch.
lib/org/openpsa/products/handler/product/create.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -89,7 +89,8 @@
 block discarded – undo
89 89
         } elseif ((int) $group > 0) {
90 90
             try {
91 91
                 $this->parent = new org_openpsa_products_product_group_dba((int) $group);
92
-            } catch (midcom_error $e) {
92
+            }
93
+            catch (midcom_error $e) {
93 94
                 $e->log();
94 95
             }
95 96
         }
Please login to merge, or discard this patch.
lib/midcom/helper/imagepopup/handler/list.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
         midcom::get()->auth->require_valid_user();
34 34
         midcom::get()->skip_page_style = true;
35 35
 
36
-        $this->add_stylesheet(MIDCOM_STATIC_URL ."/midcom.helper.imagepopup/styling.css", 'screen');
36
+        $this->add_stylesheet(MIDCOM_STATIC_URL . "/midcom.helper.imagepopup/styling.css", 'screen');
37 37
 
38 38
         $data['filetype'] = $filetype;
39 39
         $data['object'] = null;
Please login to merge, or discard this patch.
lib/org/openpsa/expenses/handler/hours/admin.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,8 @@
 block discarded – undo
100 100
         try {
101 101
             $task = org_openpsa_projects_task_dba::get_cached($hour_report->task);
102 102
             $options['success_url'] = $this->router->generate('list_hours_task', ['guid' => $task->guid]);
103
-        } catch (midcom_error $e) {
103
+        }
104
+        catch (midcom_error $e) {
104 105
             $e->log();
105 106
         }
106 107
         return $this->get_workflow('delete', $options)->run($request);
Please login to merge, or discard this patch.
src/midcom/datamanager/controller.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -70,13 +70,13 @@  discard block
 block discarded – undo
70 70
             }
71 71
         } elseif (!$this->form->isSubmitted()) {
72 72
             $this->form->handleRequest($request);
73
-            if (   $this->form->isSubmitted()
73
+            if ($this->form->isSubmitted()
74 74
                 && $button = $this->form->getClickedButton()) {
75 75
                 $operation = $button->getConfig()->getOption('operation');
76 76
             }
77 77
         }
78 78
 
79
-        if (   in_array($operation, [self::SAVE, self::NEXT])
79
+        if (in_array($operation, [self::SAVE, self::NEXT])
80 80
             && !$this->form->isValid()) {
81 81
             $operation = self::EDIT;
82 82
         }
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
                 if ($storage->get_last_operation() === self::SAVE) {
160 160
                     // Get GUIDs and such for new-created dependent objects
161 161
                     $this->dm->set_storage($storage->get_value(), $this->dm->get_schema()->get_name());
162
-                } elseif (   !$this->form->isValid()
162
+                } elseif (!$this->form->isValid()
163 163
                           && $storage->move_uploaded_files() > 0) {
164 164
                     $form = $this->dm->get_form($this->form->getName(), true);
165 165
                     $this->copy_errors($this->form, $form);
Please login to merge, or discard this patch.
lib/net/nehmer/blog/style/feeds-item.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 $item->title = $data['article']->title;
19 19
 $arg = $data['article']->name ?: $data['article']->guid;
20 20
 
21
-if (   $data['config']->get('link_to_external_url')
21
+if ($data['config']->get('link_to_external_url')
22 22
     && !empty($data['article']->url)) {
23 23
     $item->link = $data['article']->url;
24 24
 } else {
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
     $item->description .= '<div class="abstract">' . $view['abstract'] . '</div>';
38 38
 }
39 39
 
40
-if (   array_key_exists('image', $view)
40
+if (array_key_exists('image', $view)
41 41
     && $data['config']->get('rss_use_image')) {
42 42
     $item->description .= "\n<div class=\"image\">" . $view['image'] . '</div>';
43 43
 }
Please login to merge, or discard this patch.