@@ -20,7 +20,7 @@ discard block |
||
20 | 20 | if ($result === true) { |
21 | 21 | $result = []; |
22 | 22 | } |
23 | - if ( empty($fields['end']) |
|
23 | + if (empty($fields['end']) |
|
24 | 24 | && empty($fields['continuous'])) { |
25 | 25 | $result['end'] = midcom::get()->i18n->get_string('select either end date or continuous', 'org.openpsa.sales'); |
26 | 26 | } |
@@ -33,7 +33,7 @@ discard block |
||
33 | 33 | public function validate_units(array $fields) |
34 | 34 | { |
35 | 35 | $result = []; |
36 | - if ( empty($fields['invoiceByActualUnits']) |
|
36 | + if (empty($fields['invoiceByActualUnits']) |
|
37 | 37 | && empty($fields['plannedUnits'])) { |
38 | 38 | $result['plannedUnits'] = midcom::get()->i18n->get_string('select either planned units or invoice by actual units', 'org.openpsa.sales'); |
39 | 39 | return $result; |
@@ -51,7 +51,8 @@ discard block |
||
51 | 51 | try { |
52 | 52 | $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($task->get_agreement()); |
53 | 53 | $item->deliverable = $deliverable->id; |
54 | - } catch (midcom_error $e) { |
|
54 | + } |
|
55 | + catch (midcom_error $e) { |
|
55 | 56 | $e->log(); |
56 | 57 | } |
57 | 58 | $item->invoice = $invoice->id; |
@@ -133,7 +134,8 @@ discard block |
||
133 | 134 | $customer = org_openpsa_contacts_group_dba::get_cached($customer_id); |
134 | 135 | $data['customer_label'] = $customer->official; |
135 | 136 | $data['disabled'] = ''; |
136 | - } catch (midcom_error $e) { |
|
137 | + } |
|
138 | + catch (midcom_error $e) { |
|
137 | 139 | $data['customer_label'] = $this->_l10n->get('no customer'); |
138 | 140 | $data['disabled'] = ' disabled="disabled"'; |
139 | 141 | } |
@@ -156,7 +158,8 @@ discard block |
||
156 | 158 | } else { |
157 | 159 | $data['invoiceable_units'] = $task->plannedHours; |
158 | 160 | } |
159 | - } catch (midcom_error $e) { |
|
161 | + } |
|
162 | + catch (midcom_error $e) { |
|
160 | 163 | $e->log(); |
161 | 164 | if ($this->_config->get('default_hourly_price')) { |
162 | 165 | $data['default_price'] = $this->_config->get('default_hourly_price'); |
@@ -182,7 +182,8 @@ discard block |
||
182 | 182 | } |
183 | 183 | try { |
184 | 184 | $this->_storage = new $person_class($id); |
185 | - } catch (mgd_exception $e) { |
|
185 | + } |
|
186 | + catch (mgd_exception $e) { |
|
186 | 187 | debug_add("Failed to retrieve the person ID {$id}: " . $e->getMessage(), MIDCOM_LOG_INFO); |
187 | 188 | throw new midcom_error_midgard($e, $id); |
188 | 189 | } |
@@ -230,7 +231,8 @@ discard block |
||
230 | 231 | if (mgd_is_guid($id)) { |
231 | 232 | try { |
232 | 233 | return new $person_class($id); |
233 | - } catch (mgd_exception $e) { |
|
234 | + } |
|
235 | + catch (mgd_exception $e) { |
|
234 | 236 | debug_add("Failed to retrieve the person GUID {$id}: " . $e->getMessage(), MIDCOM_LOG_INFO); |
235 | 237 | throw new midcom_error_midgard($e, $id); |
236 | 238 | } |
@@ -478,7 +478,7 @@ |
||
478 | 478 | |
479 | 479 | $timeout = midcom::get()->config->get('auth_login_session_timeout', 0); |
480 | 480 | $last_seen = $person->get_parameter('midcom', 'online'); |
481 | - if ( !$last_seen |
|
481 | + if (!$last_seen |
|
482 | 482 | || ($timeout > 0 && time() - $timeout > $last_seen)) { |
483 | 483 | return 'offline'; |
484 | 484 | } |
@@ -94,7 +94,8 @@ |
||
94 | 94 | } |
95 | 95 | try { |
96 | 96 | $this->_storage = new midgard_group($id); |
97 | - } catch (Exception $e) { |
|
97 | + } |
|
98 | + catch (Exception $e) { |
|
98 | 99 | debug_add('Tried to load a midcom_core_group, but got error ' . $e->getMessage(), MIDCOM_LOG_ERROR); |
99 | 100 | debug_print_r('Passed argument was:', $id); |
100 | 101 | throw new midcom_error($e->getMessage()); |
@@ -27,7 +27,8 @@ |
||
27 | 27 | try { |
28 | 28 | midcom::get()->dbfactory->get_object_by_guid($result->fromGuid); |
29 | 29 | midcom::get()->dbfactory->get_object_by_guid($result->toGuid); |
30 | - } catch (midcom_error $e) { |
|
30 | + } |
|
31 | + catch (midcom_error $e) { |
|
31 | 32 | echo $i . "/" . $total . ": Deleting relatedto #" . $result->id . "\n"; |
32 | 33 | $result->delete(); |
33 | 34 | } |
@@ -28,7 +28,8 @@ |
||
28 | 28 | foreach ($qb->execute() as $feed) { |
29 | 29 | try { |
30 | 30 | midcom_db_topic::get_cached($feed->node); |
31 | - } catch (midcom_error $e) { |
|
31 | + } |
|
32 | + catch (midcom_error $e) { |
|
32 | 33 | debug_add("Node #{$feed->node} does not exist, skipping feed #{$feed->id}", MIDCOM_LOG_ERROR); |
33 | 34 | continue; |
34 | 35 | } |
@@ -32,7 +32,8 @@ |
||
32 | 32 | foreach ($qb->execute() as $article) { |
33 | 33 | try { |
34 | 34 | $dm->set_storage($article); |
35 | - } catch (midcom_error $e) { |
|
35 | + } |
|
36 | + catch (midcom_error $e) { |
|
36 | 37 | $e->log(MIDCOM_LOG_WARN); |
37 | 38 | continue; |
38 | 39 | } |
@@ -112,7 +112,8 @@ |
||
112 | 112 | foreach ($qb->execute() as $article) { |
113 | 113 | try { |
114 | 114 | $datamanager->set_storage($article); |
115 | - } catch (midcom_error $e) { |
|
115 | + } |
|
116 | + catch (midcom_error $e) { |
|
116 | 117 | $e->log(); |
117 | 118 | continue; |
118 | 119 | } |
@@ -194,7 +194,7 @@ |
||
194 | 194 | return false; |
195 | 195 | } |
196 | 196 | |
197 | - if ( !empty($this->_old_username) |
|
197 | + if (!empty($this->_old_username) |
|
198 | 198 | && $this->_old_username !== $new_username) { |
199 | 199 | if (!$history = @unserialize($this->_person->get_parameter('midcom', 'username_history'))) { |
200 | 200 | $history = []; |