Passed
Push — master ( a4538a...6ac431 )
by Andreas
19:26
created
lib/midcom/services/auth/frontend/form.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
      */
41 41
     public function read_login_data(Request $request) : ?array
42 42
     {
43
-        if (   !$request->request->has('midcom_services_auth_frontend_form_submit')
43
+        if (!$request->request->has('midcom_services_auth_frontend_form_submit')
44 44
             || !$request->request->has('username')
45 45
             || !$request->request->has('password')) {
46 46
             return null;
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
     {
77 77
         // Store the submitted form if the session expired, but user wants to save the data
78 78
         if (!empty($_POST)) {
79
-            $data =& midcom_core_context::get()->get_custom_key('request_data');
79
+            $data = & midcom_core_context::get()->get_custom_key('request_data');
80 80
 
81 81
             $data['restored_form_data'] = [];
82 82
 
Please login to merge, or discard this patch.
lib/net/nemein/wiki/midcom/interfaces.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
 
45 45
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
46 46
     {
47
-        if (   $object instanceof midcom_db_article
47
+        if ($object instanceof midcom_db_article
48 48
             && $topic->id == $object->topic) {
49 49
             if ($object->name == 'index') {
50 50
                 return '';
Please login to merge, or discard this patch.
lib/org/openpsa/documents/midcom/interfaces.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 
41 41
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
42 42
     {
43
-        if (   $object instanceof org_openpsa_documents_document_dba
43
+        if ($object instanceof org_openpsa_documents_document_dba
44 44
             && $object->topic == $topic->id) {
45 45
             return "document/{$object->guid}/";
46 46
         }
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/midcom/interfaces.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -77,11 +77,11 @@  discard block
 block discarded – undo
77 77
 
78 78
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
79 79
     {
80
-        if (   $object instanceof org_openpsa_contacts_group_dba
80
+        if ($object instanceof org_openpsa_contacts_group_dba
81 81
             || $object instanceof midcom_db_group) {
82 82
             return "group/{$object->guid}/";
83 83
         }
84
-        if (   $object instanceof org_openpsa_contacts_person_dba
84
+        if ($object instanceof org_openpsa_contacts_person_dba
85 85
             || $object instanceof midcom_db_person) {
86 86
             return "person/{$object->guid}/";
87 87
         }
@@ -110,8 +110,8 @@  discard block
 block discarded – undo
110 110
             // We have a feed URL, but we should check if it is GeoRSS as well
111 111
             $items = net_nemein_rss_fetch::raw_fetch($data['rss_url'])->get_items();
112 112
 
113
-            if (   !empty($items)
114
-                && (   $items[0]->get_latitude()
113
+            if (!empty($items)
114
+                && ($items[0]->get_latitude()
115 115
                     || $items[0]->get_longitude())) {
116 116
                 // This is a GeoRSS feed
117 117
                 $data['georss_url'] = $data['rss_url'];
Please login to merge, or discard this patch.
lib/net/nemein/wiki/style/view-wikipage-raw.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,6 +6,6 @@
 block discarded – undo
6 6
     &(view["content"]:h);
7 7
     <?php
8 8
 } else {
9
-    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub')."</p>";
9
+    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub') . "</p>";
10 10
 }
11 11
 ?>
12 12
\ No newline at end of file
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/style/admin-read.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
         <div class="value"><?php echo $formatter->date($invoice->deliverydate); ?></div></div>
35 35
     <?php } ?>
36 36
 
37
-    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description');?>: </div>
37
+    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description'); ?>: </div>
38 38
     <div class="description value">&(view['description']:h);</div></div>
39 39
 
40 40
     <?php
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/style/show_entries_html.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
             <?php
47 47
             //index is needed for sorting
48 48
             echo "'index_name',";
49
-            echo "'" . $data['l10n']->get('entry title') ."',";
49
+            echo "'" . $data['l10n']->get('entry title') . "',";
50 50
             echo "'" . $data['l10n']->get('entry text') . "',";
51 51
             echo "'" . $data['l10n']->get('entry created') . "',";
52 52
             echo "'index_creator', '" . $data['l10n_midcom']->get('creator') . "',";
Please login to merge, or discard this patch.
lib/net/nemein/rss/fetch.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
             $etag = trim($parser->data['headers']['etag']);
88 88
 
89 89
             $feed_etag = $this->_feed->get_parameter('net.nemein.rss', 'etag');
90
-            if (   !empty($feed_etag)
90
+            if (!empty($feed_etag)
91 91
                 && $feed_etag == $etag) {
92 92
                 // Feed hasn't changed, skip updating
93 93
                 debug_add("Feed {$this->_feed->url} has not changed since " . date('c', $this->_feed->latestfetch), MIDCOM_LOG_WARN);
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
         $guid = $item->get_id();
159 159
         $title = $item->get_title();
160 160
 
161
-        if (   (   empty($title)
161
+        if ((empty($title)
162 162
                 || trim($title) == '...')
163 163
             && empty($guid)) {
164 164
             // Something wrong with this entry, skip it
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
                 $meta_values['published'] = $article_date;
224 224
             }
225 225
 
226
-            if (   $this->apply_values($article, $values, $meta_values)
226
+            if ($this->apply_values($article, $values, $meta_values)
227 227
                 && !$article->update()) {
228 228
                 return null;
229 229
             }
@@ -252,14 +252,14 @@  discard block
 block discarded – undo
252 252
     private function find_author(net_nemein_rss_parser_item $item) : midcom_db_person
253 253
     {
254 254
         // Try to figure out item author
255
-        if (   $this->_feed->forceauthor
255
+        if ($this->_feed->forceauthor
256 256
             && $this->_feed->defaultauthor) {
257 257
             // Feed has a "default author" set, use it
258 258
             return new midcom_db_person($this->_feed->defaultauthor);
259 259
         }
260 260
         $author = $this->match_item_author($item);
261 261
         $fallback_person_id = 1;
262
-        if (   !$author
262
+        if (!$author
263 263
             || $author->id == $fallback_person_id) {
264 264
             if ($this->_feed->defaultauthor) {
265 265
                 // Feed has a "default author" set, use it
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
             }
430 430
         }
431 431
 
432
-        if (   !empty($author_info['username'])
432
+        if (!empty($author_info['username'])
433 433
             && $person = midcom::get()->auth->get_user_by_name($author_info['username'])) {
434 434
             return $person->get_storage();
435 435
         }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/object/attachments.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -98,13 +98,13 @@  discard block
 block discarded – undo
98 98
         }
99 99
 
100 100
         $mimetype = $request->request->get('midgard_admin_asgard_mimetype');
101
-        if (   !empty($mimetype)
101
+        if (!empty($mimetype)
102 102
             && $local_file->mimetype != $mimetype) {
103 103
             $local_file->mimetype = $mimetype;
104 104
             $needs_update = true;
105 105
         }
106 106
 
107
-        if (   $needs_update
107
+        if ($needs_update
108 108
             && !$local_file->update()) {
109 109
             return null;
110 110
         }
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
         $this->bind_view_to_object($this->_file);
235 235
 
236 236
         $filename = $this->_process_form($request);
237
-        if (   $filename
237
+        if ($filename
238 238
             && $filename != $data['filename']) {
239 239
             return $this->relocate_to_file($filename);
240 240
         }
Please login to merge, or discard this patch.