Passed
Push — master ( dc3f28...9cb9a1 )
by Andreas
16:51
created
lib/midcom/style/dm2_config_recreate.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
         continue;
10 10
     }
11 11
 
12
-    if (   !$object->can_do('midgard:update')
12
+    if (!$object->can_do('midgard:update')
13 13
         || !$object->can_do('midgard:attachments')) {
14 14
         echo sprintf(midcom::get()->i18n->get_string('not recreating object %s %s, reason %s', 'midcom'), $type, $object->guid, 'Insufficient privileges') . "\n";
15 15
         continue;
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/style/midgard_admin_asgard_welcome.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
                     <?php
31 31
                     foreach ($type_choices as $value => $label) {
32 32
                         $selected = '';
33
-                        if (   isset($data['type_filter'])
33
+                        if (isset($data['type_filter'])
34 34
                             && $data['type_filter'] == $value) {
35 35
                             $selected = ' selected="selected"';
36 36
                         }
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
                     <?php
46 46
                     foreach ($revised_after_choices as $value => $label) {
47 47
                         $selected = '';
48
-                        if (   isset($data['revised_after'])
48
+                        if (isset($data['revised_after'])
49 49
                             && $data['revised_after'] == date('Y-m-d', $value)) {
50 50
                             $selected = ' selected="selected"';
51 51
                         }
Please login to merge, or discard this patch.
lib/midcom/baseclasses/components/plugin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
     public function initialize(midcom_baseclasses_components_viewer $master, Router $router)
19 19
     {
20 20
         $this->router = $router;
21
-        $this->_request_data =& $master->_request_data;
21
+        $this->_request_data = & $master->_request_data;
22 22
         $this->_topic = $master->_topic;
23 23
         $this->_request_data['l10n'] = $this->_l10n;
24 24
 
Please login to merge, or discard this patch.
lib/midcom/helper/imagepopup/handler/list.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
         midcom::get()->auth->require_valid_user();
34 34
         midcom::get()->skip_page_style = true;
35 35
 
36
-        $this->add_stylesheet(MIDCOM_STATIC_URL ."/midcom.helper.imagepopup/styling.css", 'screen');
36
+        $this->add_stylesheet(MIDCOM_STATIC_URL . "/midcom.helper.imagepopup/styling.css", 'screen');
37 37
 
38 38
         $data['filetype'] = $filetype;
39 39
         $data['object'] = null;
Please login to merge, or discard this patch.
src/midcom/datamanager/controller.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -70,13 +70,13 @@  discard block
 block discarded – undo
70 70
             }
71 71
         } elseif (!$this->form->isSubmitted()) {
72 72
             $this->form->handleRequest($request);
73
-            if (   $this->form->isSubmitted()
73
+            if ($this->form->isSubmitted()
74 74
                 && $button = $this->form->getClickedButton()) {
75 75
                 $operation = $button->getConfig()->getOption('operation');
76 76
             }
77 77
         }
78 78
 
79
-        if (   in_array($operation, [self::SAVE, self::NEXT])
79
+        if (in_array($operation, [self::SAVE, self::NEXT])
80 80
             && !$this->form->isValid()) {
81 81
             $operation = self::EDIT;
82 82
         }
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
                 if ($storage->get_last_operation() === self::SAVE) {
160 160
                     // Get GUIDs and such for new-created dependent objects
161 161
                     $this->dm->set_storage($storage->get_value(), $this->dm->get_schema()->get_name());
162
-                } elseif (   !$this->form->isValid()
162
+                } elseif (!$this->form->isValid()
163 163
                           && $storage->move_uploaded_files() > 0) {
164 164
                     $form = $this->dm->get_form($this->form->getName(), true);
165 165
                     $this->copy_errors($this->form, $form);
Please login to merge, or discard this patch.
lib/org/openpsa/projects/style/show-frontpage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('ongoing') . "\">{$task_count['ongoing']}</span></td>\n";
69 69
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('on_hold') . "\">{$task_count['on_hold']}</span></td>\n";
70 70
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('closed') . "\">{$task_count['closed']}</span></td>\n";
71
-            echo "        <td class=\"numeric\"> " ;
71
+            echo "        <td class=\"numeric\"> ";
72 72
             echo "            <span title=\"" . $data['l10n']->get('reported') . "\">" . round($hours['reportedHours'], 2) . "</span>";
73 73
             if ($hours['plannedHours'] > 0) {
74 74
                 echo          " / <span title=\"" . $data['l10n']->get('planned hours') . "\">" . round($hours['plannedHours'], 2) . "</span>";
Please login to merge, or discard this patch.
lib/midcom/admin/folder/management.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
             }
51 51
 
52 52
             // Skip components beginning with midcom or midgard
53
-            if (   preg_match('/^(midcom|midgard)\./', $manifest->name)
53
+            if (preg_match('/^(midcom|midgard)\./', $manifest->name)
54 54
                 && $manifest->name != 'midcom.helper.search') {
55 55
                 continue;
56 56
             }
Please login to merge, or discard this patch.
lib/org/openpsa/sales/style/show-deliverable.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 $state = $data['deliverable']->get_state();
4 4
 $formatter = $data['l10n']->get_formatter();
5 5
 $per_unit = $data['l10n']->get('per unit');
6
-if (   $data['product']
6
+if ($data['product']
7 7
     && $unit_option = org_openpsa_sales_viewer::get_unit_option($data['product']->unit)) {
8 8
     $per_unit = sprintf($data['l10n']->get('per %s'), $unit_option);
9 9
 }
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 	    </div>
116 116
      <?php
117 117
     $tabs = [];
118
-    if (   $data['invoices_url']
118
+    if ($data['invoices_url']
119 119
         && $data['deliverable']->invoiced > 0) {
120 120
         $tabs[] = [
121 121
             'url' => $data['invoices_url'] . "list/deliverable/{$data['deliverable']->guid}/",
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
         ];
124 124
     }
125 125
 
126
-    if (   $data['projects_url']
126
+    if ($data['projects_url']
127 127
         && $data['deliverable']->state >= org_openpsa_sales_salesproject_deliverable_dba::STATE_ORDERED
128 128
         && $data['product']
129 129
         && $data['product']->orgOpenpsaObtype == org_openpsa_products_product_dba::TYPE_SERVICE) {
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/conflictmanager.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
         }
126 126
         // TODO: Shared tasks need a separate check (different member object)
127 127
 
128
-        if (   !empty($this->busy_members)
128
+        if (!empty($this->busy_members)
129 129
             || !empty($this->busy_resources)) {
130 130
             //Unresolved conflicts (note return value is for conflicts not lack of them)
131 131
             midcom::get()->auth->drop_sudo();
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
         }
189 189
 
190 190
         if (array_key_exists($member->event, $modified_events)) {
191
-            $event =& $modified_events[$member->event];
191
+            $event = & $modified_events[$member->event];
192 192
             $set_as_modified = false;
193 193
         } else {
194 194
             try {
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
         }
203 203
         debug_add("overlap found in event {$event->title} (#{$event->id})");
204 204
 
205
-        if (   $event->tentative
205
+        if ($event->tentative
206 206
             && $rob_tentative) {
207 207
             debug_add('event is tentative, robbing resources');
208 208
             $event->resources = array_diff_key($event->resources, $this->_event->resources);
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
         }
230 230
         debug_add("overlap found in event {$event->title} (#{$event->id})");
231 231
 
232
-        if (   $event->tentative
232
+        if ($event->tentative
233 233
             && $rob_tentative) {
234 234
             debug_add('event is tentative, robbing participants');
235 235
             $event->participants = array_diff_key($event->participants, $this->_event->participants);
Please login to merge, or discard this patch.