Passed
Push — master ( dc3f28...9cb9a1 )
by Andreas
16:51
created
src/midcom/console/command/exec.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,8 @@
 block discarded – undo
94 94
 
95 95
         try {
96 96
             require $basedir . $file;
97
-        } catch (\midcom_error_forbidden) {
97
+        }
98
+        catch (\midcom_error_forbidden) {
98 99
             $dialog = $this->getHelperSet()->get('question');
99 100
             $this->login($dialog, $input, $output);
100 101
             require $basedir . $file;
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/plugin.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 
143 143
         $parent = $object->get_parent();
144 144
 
145
-        if (   $object instanceof midcom_db_parameter
145
+        if ($object instanceof midcom_db_parameter
146 146
             && !empty($parent->guid)) {
147 147
             // Add "parameters" list to breadcrumb if we're in a param
148 148
             $breadcrumb[] = [
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
         }
153 153
 
154 154
         $i = 0;
155
-        while (   !empty($parent->guid)
155
+        while (!empty($parent->guid)
156 156
                && $i < 10) {
157 157
             $i++;
158 158
             $parent_reflector = midcom_helper_reflector::get($parent);
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
     {
260 260
         static $preferences = [];
261 261
 
262
-        if (   !array_key_exists($preference, $preferences)
262
+        if (!array_key_exists($preference, $preferences)
263 263
             && $person = midcom::get()->auth->user?->get_storage()) {
264 264
             $preferences[$preference] = $person->get_parameter('midgard.admin.asgard:preferences', $preference);
265 265
         }
Please login to merge, or discard this patch.
lib/midcom/core/group.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,8 @@
 block discarded – undo
74 74
             }
75 75
             try {
76 76
                 $this->_storage = new midgard_group($id);
77
-            } catch (mgd_exception $e) {
77
+            }
78
+            catch (mgd_exception $e) {
78 79
                 debug_add('Tried to load a midgard_group, but got error ' . $e->getMessage(), MIDCOM_LOG_ERROR);
79 80
                 throw new midcom_error_midgard($e, $id);
80 81
             }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
      *
57 57
      * Any error will trigger midcom_error.
58 58
      */
59
-    public function __construct(string|int|midgard_group $id)
59
+    public function __construct(string | int | midgard_group $id)
60 60
     {
61 61
         if (is_object($id)) {
62 62
             $this->_storage = $id;
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler/feed.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
 
49 49
         if ($category) {
50 50
             // This is not a predefined category from configuration, check if site maintainer allows us to show it
51
-            if (   !in_array($category, $data['categories'])
51
+            if (!in_array($category, $data['categories'])
52 52
                 && !$this->_config->get('categories_custom_enable')) {
53 53
                 throw new midcom_error('Custom category support is disabled');
54 54
             }
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler/create.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
         $this->_topic->require_do('midgard:create');
30 30
 
31 31
         $schemadb = $data['schemadb'];
32
-        if (   $this->_config->get('simple_name_handling')
32
+        if ($this->_config->get('simple_name_handling')
33 33
             && !midcom::get()->auth->can_user_do('midcom:urlname')) {
34 34
             foreach ($schemadb->all() as $schema) {
35 35
                 $schema->get_field('name')['readonly'] = true;
Please login to merge, or discard this patch.
lib/net/nehmer/blog/style/feeds-item.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
 
18 18
 $item->title = $data['article']->title;
19 19
 
20
-if (   $data['config']->get('link_to_external_url')
20
+if ($data['config']->get('link_to_external_url')
21 21
     && !empty($data['article']->url)) {
22 22
     $item->link = $data['article']->url;
23 23
 } else {
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
     $item->description .= '<div class="abstract">' . $view['abstract'] . '</div>';
34 34
 }
35 35
 
36
-if (   array_key_exists('image', $view)
36
+if (array_key_exists('image', $view)
37 37
     && $data['config']->get('rss_use_image')) {
38 38
     $item->description .= "\n<div class=\"image\">" . $view['image'] . '</div>';
39 39
 }
Please login to merge, or discard this patch.
lib/org/openpsa/reports/handler/base.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
             $data['query'] = new org_openpsa_reports_query_dba($guid);
76 76
             $data['query']->require_do('midgard:update');
77 77
         } else {
78
-            $data['query']= new org_openpsa_reports_query_dba();
78
+            $data['query'] = new org_openpsa_reports_query_dba();
79 79
             $data['query']->component = $this->_component;
80 80
         }
81 81
 
Please login to merge, or discard this patch.
lib/net/nemein/redirector/handler/redirect.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 
35 35
         // Catch first the configuration option for showing editing interface instead
36 36
         // of redirecting administrators
37
-        if (   $this->_topic->can_do('net.nemein.redirector:noredirect')
37
+        if ($this->_topic->can_do('net.nemein.redirector:noredirect')
38 38
             && !$this->_config->get('admin_redirection')) {
39 39
             return new midcom_response_relocate($this->router->generate('edit', ['tinyurl' => $tinyurl]));
40 40
         }
@@ -68,8 +68,8 @@  discard block
 block discarded – undo
68 68
     {
69 69
         $data['url'] = net_nemein_redirector_viewer::topic_links_to($this->_config);
70 70
 
71
-        if (   $this->_config->get('redirection_type') !== null
72
-            && (   !$this->_topic->can_do('net.nemein.redirector:noredirect')
71
+        if ($this->_config->get('redirection_type') !== null
72
+            && (!$this->_topic->can_do('net.nemein.redirector:noredirect')
73 73
                 || $this->_config->get('admin_redirection'))) {
74 74
             return $this->redirect($data['url']);
75 75
         }
Please login to merge, or discard this patch.
lib/net/nehmer/static/viewer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
             }
55 55
         }
56 56
 
57
-        if (   $this->_topic->can_do('midgard:update')
57
+        if ($this->_topic->can_do('midgard:update')
58 58
             && $this->_topic->can_do('midcom:component_config')) {
59 59
                 $buttons[] = $workflow->get_button($this->router->generate('config'), [
60 60
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'),
Please login to merge, or discard this patch.