flack / openpsa

lib/net/nehmer/comments/midcom/interfaces.php

Braces +2 added lines, -1 removed lines

@@ -47,7 +47,8 @@
         if ($node_id) {
             try {
                 $comments_topic = new midcom_db_topic($node_id);
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 return null;
             }
 

lib/net/nemein/rss/cron/fetchfeeds.php

Braces +2 added lines, -1 removed lines

@@ -29,7 +29,8 @@
         foreach ($qb->execute() as $feed) {
             try {
                 midcom_db_topic::get_cached($feed->node);
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 debug_add("Node #{$feed->node} does not exist, skipping feed #{$feed->id}", MIDCOM_LOG_ERROR);
                 continue;
             }

lib/midgard/admin/asgard/handler/welcome.php

Braces +6 added lines, -3 removed lines

@@ -112,7 +112,8 @@ 
             $row['approved'] = $object->is_approved() ? $object->metadata->approved : '';
             try {
                 $row['index_title'] = $reflector->get_object_label($object) ?: '[' . $this->_l10n->get('no title') . ']';
-            } catch (Exception $e) {
+            }
+            catch (Exception $e) {
                 $row['index_title'] = 'ERROR: ' . $e->getMessage();
             }
             $link = $this->router->generate('object_' . $this->_request_data['default_mode'], ['guid' => $object->guid]);
@@ -177,7 +178,8 @@ 
         foreach ($guids as $guid) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 continue;
             }
 
@@ -192,7 +194,8 @@ 
         foreach ($guids as $guid) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 continue;
             }
 

Spacing +2 added lines, -2 removed lines

@@ -31,7 +31,7 @@ 
                 $qb = new midcom_core_querybuilder($midcom_dba_classname);
                 $qb->add_constraint('metadata.revised', '>=', $since);
 
-                if (   $only_mine
+                if ($only_mine
                     && $guid = midcom::get()->auth->user?->guid) {
                     $qb->add_constraint('metadata.authors', 'LIKE', '|' . $guid . '|');
                 }
@@ -196,7 +196,7 @@ 
                 continue;
             }
 
-            if (   $object->can_do('midgard:update')
+            if ($object->can_do('midgard:update')
                 && $object->can_do('midcom:approve')) {
                 $object->metadata->approve();
                 midcom::get()->uimessages->add($this->_l10n->get($this->_component), sprintf($this->_l10n->get('object %s approved'), $object->guid));

lib/midgard/admin/user/style/midgard-admin-user-group-folders.php

Braces +2 added lines, -1 removed lines

@@ -17,7 +17,8 @@
         foreach ($data['objects'] as $guid => $privs) {
             try {
                 $object = new midcom_db_topic($guid);
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 continue;
             }
             echo "<tr>\n";

lib/midcom/db/member.php

Braces +4 added lines, -2 removed lines

@@ -26,7 +26,8 @@ 
         try {
             $person = new midcom_db_person($this->uid);
             $grp = new midcom_db_group($this->gid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return 'Invalid membership record';
         }
@@ -43,7 +44,8 @@ 
         }
         try {
             $person = new midcom_db_person($this->uid);
-        } catch (midcom_error) {
+        }
+        catch (midcom_error) {
             return;
         }
         midcom::get()->cache->invalidate($person->guid);

lib/midcom/db/style.php

Braces +2 added lines, -1 removed lines

@@ -43,7 +43,8 @@
                     break;
                 }
             }
-        } catch (midcom_error) {
+        }
+        catch (midcom_error) {
         }
 
         $path_parts = array_reverse($path_parts);

lib/midcom/baseclasses/core/dbobject.php

Braces +2 added lines, -1 removed lines

@@ -423,7 +423,8 @@
          */
         try {
             return $object->get_by_id($object->id);
-        } catch (Exception) {
+        }
+        catch (Exception) {
             return false;
         }
     }

Spacing +4 added lines, -4 removed lines

@@ -119,14 +119,14 @@ 
         if ($parent = $object->get_parent()) {
             // Attachments are a special case
             if ($object instanceof midcom_db_attachment) {
-                if (   !$parent->can_do('midgard:attachments')
+                if (!$parent->can_do('midgard:attachments')
                     || !$parent->can_do('midgard:update')) {
                     debug_add("Failed to create attachment, update or attachments privilege on the parent " . $parent::class . " {$parent->guid} not granted for the current user.",
                         MIDCOM_LOG_ERROR);
                     midcom_connection::set_error(MGD_ERR_ACCESS_DENIED);
                     return false;
                 }
-            } elseif (   !$parent->can_do('midgard:create')
+            } elseif (!$parent->can_do('midgard:create')
                       && !midcom::get()->auth->can_user_do('midgard:create', class: $object::class)) {
                 debug_add("Failed to create object, create privilege on the parent " . $parent::class . " {$parent->guid} or the actual object class not granted for the current user.",
                     MIDCOM_LOG_ERROR);
@@ -238,7 +238,7 @@ 
             }
 
             // Default the owner to first group of current user
-            if (   empty($object->metadata->owner)
+            if (empty($object->metadata->owner)
                 && $first_group = midcom::get()->auth->user->get_first_group_guid()) {
                 $object->metadata->set('owner', $first_group);
             }
@@ -462,7 +462,7 @@ 
      */
     public static function get_by_guid(midcom_core_dbaobject $object, string $guid) : bool
     {
-        if (   !midcom::get()->auth->admin
+        if (!midcom::get()->auth->admin
             && !midcom::get()->auth->acl->can_do_byguid('midgard:read', $guid, $object::class, midcom::get()->auth->acl->get_user_id())) {
             debug_add("Failed to load object, read privilege on the " . $object::class . " {$guid} not granted for the current user.", MIDCOM_LOG_ERROR);
             return false;

lib/midcom/connection.php

Braces +2 added lines, -1 removed lines

@@ -84,7 +84,8 @@
 
         try {
             $user = new midgard_user($login_tokens);
-        } catch (mgd_exception) {
+        }
+        catch (mgd_exception) {
             return null;
         }
         if (!$trusted && !self::verify_password($password, $user->password)) {

Spacing +1 added lines, -1 removed lines

@@ -201,7 +201,7 @@
             if ($part === '') {
                 continue;
             }
-            if (    midcom::get()->config->get('theme')
+            if (midcom::get()->config->get('theme')
                 && !$args_started
                 && self::check_page_exists($part)) {
                 $page_style .= '/' . $part;

lib/midcom/helper/_dbfactory.php

Braces +4 added lines, -2 removed lines

@@ -50,7 +50,8 @@ 
     {
         try {
             $tmp = midgard_object_class::get_object_by_guid($guid);
-        } catch (mgd_exception $e) {
+        }
+        catch (mgd_exception $e) {
             debug_add('Loading object by GUID ' . $guid . ' failed, reason: ' . $e->getMessage(), MIDCOM_LOG_INFO);
 
             throw new midcom_error_midgard($e, $guid);
@@ -159,7 +160,8 @@ 
 
         try {
             return $this->get_cached($classname, $parent_guid);
-        } catch (midcom_error) {
+        }
+        catch (midcom_error) {
             return null;
         }
     }

Spacing +5 added lines, -5 removed lines

@@ -55,7 +55,7 @@ 
 
             throw new midcom_error_midgard($e, $guid);
         }
-        if (   $tmp::class == 'midgard_person'
+        if ($tmp::class == 'midgard_person'
             && $this->person_class != 'midgard_person') {
             $tmp = new $this->person_class($guid);
         }
@@ -67,7 +67,7 @@ 
      *
      * @param string $classname Which DBA are we dealing with
      */
-    public function get_cached(string $classname, string|int $src) : midcom_core_dbaobject
+    public function get_cached(string $classname, string | int $src) : midcom_core_dbaobject
     {
         static $cache = [];
 
@@ -82,7 +82,7 @@ 
         }
         $object = new $classname($src);
         $cache[$classname][$object->guid] = $object;
-        $cache[$classname][$object->id] =& $cache[$classname][$object->guid];
+        $cache[$classname][$object->id] = & $cache[$classname][$object->guid];
         return $cache[$classname][$object->guid];
     }
 
@@ -129,7 +129,7 @@ 
             return true;
         }
 
-        if (   isset($object->__object)
+        if (isset($object->__object)
             && is_object($object->__object)
             && $object->__object instanceof $class) {
             // Decorator whose MgdSchema object matches
@@ -152,7 +152,7 @@ 
             return $this->get_parent_data_uncached($object);
         });
 
-        if (   empty($parent_guid)
+        if (empty($parent_guid)
             || $parent_guid === $object->guid) {
             return null;
         }