Passed
Push — master ( dc3f28...9cb9a1 )
by Andreas
16:51
created
src/midcom/dba/parameters.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
         if (   !$this->can_do('midgard:update')
205 205
             || !$this->can_do('midgard:parameters')) {
206 206
             debug_add("Failed to set parameters, midgard:update or midgard:parameters on " . static::class . " {$this->guid} not granted for the current user.",
207
-                  MIDCOM_LOG_ERROR);
207
+                    MIDCOM_LOG_ERROR);
208 208
             midcom_connection::set_error(MGD_ERR_ACCESS_DENIED);
209 209
             return false;
210 210
         }
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
         if (   !$this->can_do('midgard:update')
249 249
             || !$this->can_do('midgard:parameters')) {
250 250
             debug_add("Failed to delete parameters, midgard:update or midgard:parameters on " . static::class . " {$this->guid} not granted for the current user.",
251
-                  MIDCOM_LOG_ERROR);
251
+                    MIDCOM_LOG_ERROR);
252 252
             midcom_connection::set_error(MGD_ERR_ACCESS_DENIED);
253 253
             return false;
254 254
         }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
             return false;
202 202
         }
203 203
 
204
-        if (   !$this->can_do('midgard:update')
204
+        if (!$this->can_do('midgard:update')
205 205
             || !$this->can_do('midgard:parameters')) {
206 206
             debug_add("Failed to set parameters, midgard:update or midgard:parameters on " . static::class . " {$this->guid} not granted for the current user.",
207 207
                   MIDCOM_LOG_ERROR);
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
245 245
             return false;
246 246
         }
247 247
 
248
-        if (   !$this->can_do('midgard:update')
248
+        if (!$this->can_do('midgard:update')
249 249
             || !$this->can_do('midgard:parameters')) {
250 250
             debug_add("Failed to delete parameters, midgard:update or midgard:parameters on " . static::class . " {$this->guid} not granted for the current user.",
251 251
                   MIDCOM_LOG_ERROR);
Please login to merge, or discard this patch.
src/midcom/dba/attachments.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
             return false;
52 52
         }
53 53
 
54
-        if (   !$this->can_do('midgard:update')
54
+        if (!$this->can_do('midgard:update')
55 55
             || !$this->can_do('midgard:attachments')) {
56 56
             debug_add("Failed to set parameters, midgard:update or midgard:attachments on " . static::class . " {$this->guid} not granted for the current user.",
57 57
             MIDCOM_LOG_ERROR);
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
             return null;
72 72
         }
73 73
 
74
-        if (   !$this->can_do('midgard:update')
74
+        if (!$this->can_do('midgard:update')
75 75
             || !$this->can_do('midgard:attachments')) {
76 76
             debug_add("Failed to set parameters, midgard:update or midgard:attachments on the " . static::class . " {$this->guid} not granted for the current user.",
77 77
             MIDCOM_LOG_ERROR);
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
         $attachment->parentguid = $this->guid;
86 86
 
87 87
         if (!$attachment->create()) {
88
-            debug_add("Could not create the attachment '{$name}' for " . static::class . " {$this->guid}: "  . midcom_connection::get_error_string(),
88
+            debug_add("Could not create the attachment '{$name}' for " . static::class . " {$this->guid}: " . midcom_connection::get_error_string(),
89 89
             MIDCOM_LOG_INFO);
90 90
             return null;
91 91
         }
Please login to merge, or discard this patch.
lib/midcom/services/i18n/l10n.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -226,7 +226,7 @@
 block discarded – undo
226 226
     private function error(string $message, string $filename, int $line) : midcom_error
227 227
     {
228 228
         $line++; // Array is 0-indexed
229
-        return new midcom_error('L10n DB SYNTAX ERROR: ' .  $message . ' at ' . $filename . ' ' . $line);
229
+        return new midcom_error('L10n DB SYNTAX ERROR: ' . $message . ' at ' . $filename . ' ' . $line);
230 230
     }
231 231
 
232 232
     /**
Please login to merge, or discard this patch.
lib/midcom/services/rcs/main.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,8 @@
 block discarded – undo
56 56
         try {
57 57
             $backend->update(midcom::get()->auth->user->id ?? 'NOBODY', $message);
58 58
             return true;
59
-        } catch (midcom_error $e) {
59
+        }
60
+        catch (midcom_error $e) {
60 61
             debug_add('RCS: Could not save file!');
61 62
             $e->log();
62 63
             return false;
Please login to merge, or discard this patch.
src/midcom/httpkernel/subscriber.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
         $i = array_search('__request_data__', $arguments, true);
91 91
         if ($i !== false) {
92 92
             $context = $event->getRequest()->attributes->get('context');
93
-            $arguments[$i] =& $context->get_custom_key('request_data');
93
+            $arguments[$i] = & $context->get_custom_key('request_data');
94 94
             $event->setArguments($arguments);
95 95
         }
96 96
     }
Please login to merge, or discard this patch.
lib/midcom/baseclasses/components/viewer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@
 block discarded – undo
246 246
      */
247 247
     public function prepare_handler(midcom_baseclasses_components_handler $handler, array &$parameters)
248 248
     {
249
-        $this->parameters =& $parameters;
249
+        $this->parameters = & $parameters;
250 250
 
251 251
         $parameters['handler'] = explode('::', $parameters['_controller'], 2);
252 252
 
Please login to merge, or discard this patch.
lib/org/openpsa/projects/handler/task/resourcing.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
             return new midcom_response_relocate($this->router->generate('task_view', ['guid' => $guid]));
59 59
         }
60 60
 
61
-        if (   $request->request->has('save')
61
+        if ($request->request->has('save')
62 62
             && $prospects = $request->request->all('org_openpsa_projects_prospects')) {
63 63
             $qb = org_openpsa_projects_task_resource_dba::new_query_builder();
64 64
             $qb->add_constraint('guid', 'IN', array_keys($prospects));
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
                     // create relatedto
90 90
                     org_openpsa_relatedto_plugin::create($event, 'org.openpsa.calendar', $this->_task, 'org.openpsa.projects');
91 91
                 }
92
-                if (   $update_prospect
92
+                if ($update_prospect
93 93
                     && !$prospect->update()) {
94 94
                     debug_add('Failed to update prospect: ' . midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
95 95
                 }
Please login to merge, or discard this patch.
lib/org/openpsa/mail/backend.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,7 +46,8 @@  discard block
 block discarded – undo
46 46
                     $object = self::_load_backend($backend, $params);
47 47
                     debug_add('Using backend ' . $backend);
48 48
                     return $object;
49
-                } catch (midcom_error $e) {
49
+                }
50
+                catch (midcom_error $e) {
50 51
                     debug_add('Failed to load backend ' . $backend . ', message:' . $e->getMessage());
51 52
                 }
52 53
             }
@@ -76,7 +77,8 @@  discard block
 block discarded – undo
76 77
             $this->mail($message);
77 78
             $this->error = null;
78 79
             return true;
79
-        } catch (Exception $e) {
80
+        }
81
+        catch (Exception $e) {
80 82
             $this->error = $e->getMessage();
81 83
             return false;
82 84
         }
Please login to merge, or discard this patch.
lib/org/openpsa/documents/handler/document/admin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
 
91 91
         $this->_controller = $this->load_controller();
92 92
 
93
-        if (   $data['enable_versioning']
93
+        if ($data['enable_versioning']
94 94
             && $request->request->count() > 0) {
95 95
             $this->_backup_attachment($request);
96 96
         }
Please login to merge, or discard this patch.