Passed
Push — master ( dc3f28...9cb9a1 )
by Andreas
16:51
created
lib/midgard/admin/asgard/style/midgard_admin_asgard_rcs_history.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
                 echo "                    <td>" . $formatter->datetime($revision['date'], IntlDateFormatter::MEDIUM, IntlDateFormatter::LONG) . "</td>\n";
34 34
                 echo "                    <td>";
35 35
 
36
-                if (   $revision['user']
36
+                if ($revision['user']
37 37
                     && $user = midcom::get()->auth->get_user($revision['user'])) {
38 38
                     echo $user->get_storage()->name;
39 39
                 } elseif ($revision['ip']) {
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/handler/message/compose.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
         }
65 65
 
66 66
         //Substyle handling
67
-        if (   !empty($data['message_array']['substyle'])
67
+        if (!empty($data['message_array']['substyle'])
68 68
             && !str_starts_with($data['message_array']['substyle'], 'builtin:')) {
69 69
             debug_add("Appending substyle {$data['message_array']['substyle']}");
70 70
             midcom::get()->style->append_substyle($data['message_array']['substyle']);
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
     private function _real_show_compose(array $data)
114 114
     {
115 115
         $prefix = '';
116
-        if (   !empty($data['message_array']['substyle'])
116
+        if (!empty($data['message_array']['substyle'])
117 117
             && preg_match('/^builtin:(.*)/', $data['message_array']['substyle'], $matches_style)) {
118 118
             $prefix = $matches_style[1] . '-';
119 119
         }
Please login to merge, or discard this patch.
lib/org/openpsa/slideshow/handler/edit.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
         $images = $qb->execute();
62 62
         $failed = 0;
63 63
         foreach ($images as $image) {
64
-            if (   !$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
64
+            if (!$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
65 65
                 || !$image->generate_image('image', $this->_config->get('image_filter'))) {
66 66
                 $failed++;
67 67
             }
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
         $attachment->title = $title;
242 242
         $attachment->mimetype = $file->getMimeType();
243 243
         $attachment->parentguid = $image->guid;
244
-        if (   !$attachment->create()
244
+        if (!$attachment->create()
245 245
             || !$attachment->copy_from_file($file->getRealPath())) {
246 246
             throw new midcom_error('Failed to create attachment: ' . midcom_connection::get_error_string());
247 247
         }
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,8 @@
 block discarded – undo
123 123
         try {
124 124
             $this->$function($request->request, $request->files);
125 125
             $this->response['success'] = true;
126
-        } catch (midcom_error $e) {
126
+        }
127
+        catch (midcom_error $e) {
127 128
             $this->response['success'] = false;
128 129
             $this->response['error'] = $e->getMessage();
129 130
         }
Please login to merge, or discard this patch.
src/midcom/console/command/reindex.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,8 @@
 block discarded – undo
73 73
             if ($stat instanceof midcom_services_indexer_client) {
74 74
                 try {
75 75
                     $stat->reindex();
76
-                } catch (RequestException $e) {
76
+                }
77
+                catch (RequestException $e) {
77 78
                     if ($e->hasResponse()) {
78 79
                         $crawler = new Crawler($e->getResponse()->getBody()->getContents());
79 80
                         $body = $crawler->filterXPath('//body')->html();
Please login to merge, or discard this patch.
lib/org/openpsa/products/viewer.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,11 +30,11 @@
 block discarded – undo
30 30
         $object = $dm->get_storage()->get_value();
31 31
 
32 32
         $document = $indexer->new_document($dm);
33
-        if (   $config->get('enable_scheduling')
33
+        if ($config->get('enable_scheduling')
34 34
             && $object instanceof org_openpsa_products_product_dba) {
35 35
             // Check start/end for products
36
-            if (   $object->start > time()
37
-                || (   $object->end != 0
36
+            if ($object->start > time()
37
+                || ($object->end != 0
38 38
                     && $object->end < time())) {
39 39
                 // Not in market, remove from index
40 40
                 $indexer->delete($document->RI);
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/object/permissions.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         $tmp = $this->_object;
83 83
 
84 84
         $i = 0;
85
-        while (   !empty($tmp->guid)
85
+        while (!empty($tmp->guid)
86 86
                && !($tmp instanceof midcom_db_topic)
87 87
                && $i < 100) {
88 88
             // Get the parent; wishing eventually to get a topic
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 
128 128
         $assignees = $this->load_assignees();
129 129
         $this->process_assignees($assignees, $schemadb);
130
-        $assignee_field =& $schemadb->get('privileges')->get_field('add_assignee');
130
+        $assignee_field = & $schemadb->get('privileges')->get_field('add_assignee');
131 131
 
132 132
         if (!$this->additional_assignee) {
133 133
             // Populate additional assignee selector
Please login to merge, or discard this patch.
lib/midcom/helper/imagepopup/handler/upload.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
         $temp = $request->files->get('file');
24 24
 
25 25
         // Verify file extension
26
-        if (   !$temp instanceof UploadedFile
26
+        if (!$temp instanceof UploadedFile
27 27
             || !in_array(strtolower($temp->getClientOriginalExtension()), ["gif", "jpg", "png"])) {
28 28
             throw new midcom_error('Invalid extension.');
29 29
         }
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/handler/group/action.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,8 @@
 block discarded – undo
33 33
                 $member->require_do('midgard:update');
34 34
                 $member->extra = $request->request->get('title');
35 35
                 $response['status'] = $member->update();
36
-            } catch (midcom_error $e) {
36
+            }
37
+            catch (midcom_error $e) {
37 38
                 $e->log();
38 39
             }
39 40
             $response['message'] = midcom_connection::get_error_string();
Please login to merge, or discard this patch.
src/midcom/datamanager/indexer/document.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@
 block discarded – undo
171 171
                     if (!empty($field->vars['value'])) {
172 172
                         //only index the first attachment for now
173 173
                         $attachment = array_shift($field->vars['value']);
174
-                        if (   !$attachment instanceof \midcom_db_attachment
174
+                        if (!$attachment instanceof \midcom_db_attachment
175 175
                             && !empty($attachment['object'])) {
176 176
                             //This is the form edit case
177 177
                             //@todo: In create case, nothing is found currently
Please login to merge, or discard this patch.