flack / openpsa

lib/midcom/core/collector.php

Spacing +1 added lines, -1 removed lines

@@ -142,7 +142,7 @@
             if ($counter <= $this->_offset) {
                 continue;
             }
-            if (   $this->_limit
+            if ($this->_limit
                 && $counter > ($this->_offset + $this->_limit)) {
                 break;
             }

lib/midcom/helper/reflector/tree.php

Spacing +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
     private static function _check_permissions(bool $deleted) : bool
     {
         // PONDER: Check for some generic user privilege instead  ??
-        if (   $deleted
+        if ($deleted
             && !midcom::get()->auth->admin
             && !midcom::get()->auth->is_component_sudo()) {
             debug_add('Non-admins are not allowed to list deleted objects', MIDCOM_LOG_ERROR);

lib/org/openpsa/invoices/invoice.php

Braces +4 added lines, -2 removed lines

@@ -120,14 +120,16 @@
         if (!empty($this->customer)) {
             try {
                 return org_openpsa_contacts_group_dba::get_cached($this->customer);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }
         if (!empty($this->customerContact)) {
             try {
                 return org_openpsa_contacts_person_dba::get_cached($this->customerContact);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

Spacing +2 added lines, -2 removed lines

@@ -208,7 +208,7 @@ 
                 $invoice_item->pricePerUnit = $deliverable->pricePerUnit;
                 $invoice_item->deliverable = $deliverable->id;
                 //calculate price
-                if (   $deliverable->invoiceByActualUnits
+                if ($deliverable->invoiceByActualUnits
                     || $deliverable->plannedUnits == 0) {
                     $invoice_item->units = $hours;
                 } else {
@@ -249,7 +249,7 @@ 
      */
     public function get_billing_data() : org_openpsa_invoices_billing_data_dba
     {
-        return $this->_billing_data ??= org_openpsa_invoices_billing_data_dba::get_by_object($this);;
+        return $this->_billing_data ??= org_openpsa_invoices_billing_data_dba::get_by_object($this); ;
     }
 
     public function get_customer()

lib/org/openpsa/expenses/hour/report.php

Braces +2 added lines, -1 removed lines

@@ -98,7 +98,8 @@
             if ($this->old_task) {
                 self::update_cache(new org_openpsa_projects_task_dba($this->old_task));
             }
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
 

Spacing +1 added lines, -1 removed lines

@@ -113,7 +113,7 @@
     {
         if ($this->invoiceable) {
             $task = new org_openpsa_projects_task_dba($this->task);
-            $time_slot = (float)$task->get_parameter('org.openpsa.projects.projectbroker', 'minimum_slot');
+            $time_slot = (float) $task->get_parameter('org.openpsa.projects.projectbroker', 'minimum_slot');
             if (empty($time_slot)) {
                 $time_slot = (float) midcom_baseclasses_components_configuration::get('org.openpsa.expenses', 'config')->get('default_minimum_time_slot');
                 if (empty($time_slot)) {

lib/org/openpsa/expenses/midcom/interfaces.php

Braces +2 added lines, -1 removed lines

@@ -48,7 +48,8 @@
         foreach (array_unique($tasks_to_update) as $id) {
             try {
                 org_openpsa_expenses_hour_report_dba::update_cache(new org_openpsa_projects_task_dba($id));
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

lib/org/openpsa/sales/calculator/default.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 
     private function get_units($units = false) : float
     {
-        if (   $this->deliverable->invoiceByActualUnits
+        if ($this->deliverable->invoiceByActualUnits
             || $this->deliverable->plannedUnits == 0) {
             // In most cases we calculate the price based on the actual units entered
             return $units ?: $this->deliverable->units;

lib/org/openpsa/sales/salesproject/deliverable.php

Spacing +7 added lines, -7 removed lines

@@ -71,7 +71,7 @@ 
     {
         $this->calculate_price(false);
 
-        if (   $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
+        if ($this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
             && $this->continuous) {
             $this->end = 0;
         } elseif ($this->end < $this->start) {
@@ -138,7 +138,7 @@ 
         $calculator->run($this);
         $cost = $calculator->get_cost();
         $price = $calculator->get_price();
-        if (   $price != $this->price
+        if ($price != $this->price
             || $cost != $this->cost) {
             $this->price = $price;
             $this->cost = $cost;
@@ -178,7 +178,7 @@ 
         $units = $hours['invoiceable'];
         $uninvoiceableUnits = $hours['reported'] - ($hours['invoiceable'] + $hours['invoiced']);
 
-        if (   $units != $this->units
+        if ($units != $this->units
             || $uninvoiceableUnits != $this->uninvoiceableUnits) {
             debug_add("agreement values have changed, setting units to " . $units . ", uninvoiceable: " . $uninvoiceableUnits);
             $this->units = $units;
@@ -229,11 +229,11 @@ 
                 break;
             case 'q':
                 // Quarterly recurring subscription
-                $identifier = ceil(((int)$date->format('n')) / 4) . 'Q' . $date->format('y');
+                $identifier = ceil(((int) $date->format('n')) / 4) . 'Q' . $date->format('y');
                 break;
             case 'hy':
                 // Half-yearly recurring subscription
-                $identifier = ceil(((int)$date->format('n')) / 6) . '/' . $date->format('Y');
+                $identifier = ceil(((int) $date->format('n')) / 6) . '/' . $date->format('Y');
                 break;
             case 'y':
                 // Yearly recurring subscription
@@ -261,7 +261,7 @@ 
 
     public function invoice() : bool
     {
-        if (   $this->state >= self::STATE_INVOICED
+        if ($this->state >= self::STATE_INVOICED
             || $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
             return false;
         }
@@ -364,7 +364,7 @@ 
             midcom::get()->uimessages->add(midcom::get()->i18n->get_string('org.openpsa.sales', 'org.openpsa.sales'), sprintf(midcom::get()->i18n->get_string('marked deliverable "%s" delivered', 'org.openpsa.sales'), $this->title));
 
             // Check if we need to create task or ship goods
-            if (   $update_deliveries
+            if ($update_deliveries
                 && $product->orgOpenpsaObtype === org_openpsa_products_product_dba::TYPE_SERVICE) {
                 // Change status of tasks connected to the deliverable
                 $qb = org_openpsa_projects_task_dba::new_query_builder();

lib/org/openpsa/documents/elFinderVolumeOpenpsa.php

Spacing +7 added lines, -7 removed lines

@@ -67,7 +67,7 @@ 
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_MIME, '(' . $mime . ')');
         }
 
-        $tmpsize = (int)sprintf('%u', filesize($tmpname));
+        $tmpsize = (int) sprintf('%u', filesize($tmpname));
         if ($this->uploadMaxSize > 0 && $tmpsize > $this->uploadMaxSize) {
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_SIZE);
         }
@@ -250,7 +250,7 @@ 
         $output = [$object->get_label()];
 
         $parent = $object->get_parent();
-        while (   $parent
+        while ($parent
                && $parent->component == 'org.openpsa.documents') {
             $output[] = $parent->extra;
             $parent = $parent->get_parent();
@@ -347,12 +347,12 @@ 
             $data['mime'] = 'directory';
         }
 
-        if (   $owner
+        if ($owner
             && $group = midcom::get()->auth->get_assignee($owner)) {
             $data['group'] = $group->name;
         }
 
-        if (   $this->root !== $path
+        if ($this->root !== $path
             && $parent = $object->get_parent()) {
             $data['phash'] = $this->encode($parent->guid);
         }
@@ -411,7 +411,7 @@ 
      * @param  string $mode open mode
      * @return resource|false
      */
-    protected function _fopen($path, $mode="rb")
+    protected function _fopen($path, $mode = "rb")
     {
         $document = org_openpsa_documents_document_dba::get_cached($path);
         $attachments = blobs::get_attachments($document, 'document');
@@ -429,7 +429,7 @@ 
      * @param  string    $path  file path
      * @return bool
      */
-    protected function _fclose($fp, $path='')
+    protected function _fclose($fp, $path = '')
     {
         fclose($fp);
         return true;
@@ -611,7 +611,7 @@ 
     {
         $filename = midcom_db_attachment::safe_filename($name);
         $att = $doc->create_attachment($filename, $name, $mimetype);
-        if (   !$att
+        if (!$att
             || !$att->copy_from_handle($fp)) {
             return false;
         }

Braces +10 added lines, -5 removed lines

@@ -83,7 +83,8 @@ 
 
         $this->clearcache();
 
-        if ($file && $file['name'] === $name) { // file exists and check filename for item ID based filesystem
+        if ($file && $file['name'] === $name) {
+// file exists and check filename for item ID based filesystem
             if ($this->uploadOverwrite) {
                 if (!$file['write']) {
                     return $this->setError(elFinder::ERROR_PERM_DENIED);
@@ -139,11 +140,13 @@ 
     {
         try {
             return org_openpsa_documents_document_dba::get_cached($path);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             try {
                 return org_openpsa_documents_directory::get_cached($path);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }
@@ -275,7 +278,8 @@ 
         $object = midcom::get()->dbfactory->get_object_by_guid($path);
         try {
             $parentdir = org_openpsa_documents_directory::get_cached($parent);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return false;
         }
@@ -567,7 +571,8 @@ 
         try {
             $doc = new org_openpsa_documents_document_dba($path);
             return $doc->delete();
-        } catch (midcom_error) {
+        }
+        catch (midcom_error) {
             return false;
         }
     }

src/midcom/datamanager/extension/type/schemaType.php

Spacing +5 added lines, -5 removed lines

@@ -35,11 +35,11 @@ 
         $resolver
             ->setRequired('schema')
             ->setAllowedTypes('schema', [schema::class, 'string'])
-            ->setDefault('action', function (Options $options, $value) {
+            ->setDefault('action', function(Options $options, $value) {
                 return $options['schema']->get('action');
             });
 
-        $resolver->setNormalizer('csrf_protection', function (Options $options, $value) {
+        $resolver->setNormalizer('csrf_protection', function(Options $options, $value) {
             foreach ($options['schema']->get('fields') as $config) {
                 if ($config['widget'] === 'csrf') {
                     return true;
@@ -47,7 +47,7 @@ 
             }
             return false;
         });
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
             $validation = $options['schema']->get('validation');
             if (!empty($validation)) {
                 $cb_wrapper = new cb_wrapper($validation);
@@ -55,7 +55,7 @@ 
             }
             return $value;
         });
-        $resolver->setNormalizer('schema', function (Options $options, $value) {
+        $resolver->setNormalizer('schema', function(Options $options, $value) {
             if (is_string($value)) {
                 $schemadb = schemadb::from_path($value);
                 return $schemadb->get_first();
@@ -80,7 +80,7 @@ 
         // this is mainly there to skip validation in case the user pressed cancel
         $builder->addEventListener(FormEvents::POST_SUBMIT, function(PostSubmitEvent $event) {
             $form = $event->getForm();
-            if (   $form instanceof Form
+            if ($form instanceof Form
                 && $form->getClickedButton()
                 && $form->getClickedButton()->getConfig()->getOption('operation') == controller::CANCEL) {
                 $event->stopPropagation();