Passed
Push — master ( dc3f28...9cb9a1 )
by Andreas
16:51
created
lib/org/openpsa/documents/document.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
             return;
85 85
         }
86 86
         $parent = $this->get_parent();
87
-        if (   $parent
87
+        if ($parent
88 88
             && $parent->component == 'org.openpsa.documents') {
89 89
             midcom::get()->auth->request_sudo('org.openpsa.documents');
90 90
 
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
             $backup_attachment = $backup->create_attachment($original_attachment->name, $original_attachment->title, $original_attachment->mimetype);
155 155
 
156 156
             $original_handle = $original_attachment->open('r');
157
-            if (   !$backup_attachment
157
+            if (!$backup_attachment
158 158
                 || !$original_handle) {
159 159
                 // Failed to copy the attachment, abort
160 160
                 return $backup->delete();
Please login to merge, or discard this patch.
lib/midcom/admin/rcs/style/midcom-admin-rcs-history.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
         echo "                    <td><a href='" . $data['router']->generate('preview', ['guid' => $guid, 'revision' => $number]) . "'>{$revision['version']}</a></td>\n";
33 33
         echo "                    <td>" . $formatter->datetime($revision['date']) . "</td>\n";
34 34
 
35
-        if (   $revision['user']
35
+        if ($revision['user']
36 36
             && $user = midcom::get()->auth->get_user($revision['user'])) {
37 37
             $person_label = $user->get_storage()->name;
38 38
             echo "                    <td>{$person_label}</td>\n";
Please login to merge, or discard this patch.
src/midcom/datamanager/template/plaintext.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
 
18 18
     public function form_widget_simple(FormView $view, array $data)
19 19
     {
20
-        if (   !empty($data['value'])
20
+        if (!empty($data['value'])
21 21
             || is_numeric($data['value'])) {
22 22
             return $data['value'];
23 23
         }
Please login to merge, or discard this patch.
src/midcom/datamanager/template/view.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
 
144 144
     public function form_widget_simple(FormView $view, array $data)
145 145
     {
146
-        if (   !empty($data['value'])
146
+        if (!empty($data['value'])
147 147
             || is_numeric($data['value'])) {
148 148
             return $this->escape($data['value']);
149 149
         }
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/autocompleteType.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -116,7 +116,8 @@
 block discarded – undo
116 116
                 try {
117 117
                     $object = $options['widget_config']['class']::get_cached($identifier);
118 118
                     $preset[$identifier] = autocomplete_helper::create_item_label($object, $options['widget_config']['result_headers'], $options['widget_config']['titlefield']);
119
-                } catch (midcom_error $e) {
119
+                }
120
+                catch (midcom_error $e) {
120 121
                     $e->log();
121 122
                 }
122 123
             }
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
     public function configureOptions(OptionsResolver $resolver)
34 34
     {
35 35
         $resolver->setDefault('error_bubbling', false);
36
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
36
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
37 37
             $widget_defaults = [
38 38
                 'creation_mode_enabled' => false,
39 39
                 'class' => null,
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
             return helper::normalize($widget_defaults, $value);
68 68
         });
69
-        $resolver->setNormalizer('type_config', function (Options $options, $value) {
69
+        $resolver->setNormalizer('type_config', function(Options $options, $value) {
70 70
             $type_defaults = [
71 71
                 'options' => [],
72 72
                 'method' => 'GET',
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
     public function finishView(FormView $view, FormInterface $form, array $options)
109 109
     {
110 110
         $preset = [];
111
-        if (   !empty($view->children['selection']->vars['data'])
111
+        if (!empty($view->children['selection']->vars['data'])
112 112
             && !empty($options['widget_config']['class'])) {
113 113
             foreach (array_filter((array) $view->children['selection']->vars['data']) as $identifier) {
114 114
                 if ($options['widget_config']['id_field'] == 'id') {
Please login to merge, or discard this patch.
lib/midcom/core/dbaproxy.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,8 @@
 block discarded – undo
64 64
         try {
65 65
             $this->__object = $this->__midcom_class_name__::get_cached($this->__identifier);
66 66
             return true;
67
-        } catch (midcom_error $e) {
67
+        }
68
+        catch (midcom_error $e) {
68 69
             $e->log();
69 70
         }
70 71
         return false;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -22,11 +22,11 @@
 block discarded – undo
22 22
     /**
23 23
      * MidCOM DBA object identifier, can be ID or GUID
24 24
      */
25
-    private string|int $__identifier;
25
+    private string | int $__identifier;
26 26
 
27 27
     private bool $__tried_to_load = false;
28 28
 
29
-    public function __construct(string|int $identifier, string $classname)
29
+    public function __construct(string | int $identifier, string $classname)
30 30
     {
31 31
         $this->__midcom_class_name__ = $classname;
32 32
         $this->__identifier = $identifier;
Please login to merge, or discard this patch.
lib/midcom/services/auth/main.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -575,7 +575,8 @@
 block discarded – undo
575 575
                     $param = $param->__object;
576 576
                 }
577 577
                 $this->_group_cache[$id] = new midcom_core_group($param);
578
-            } catch (midcom_error $e) {
578
+            }
579
+            catch (midcom_error $e) {
579 580
                 debug_add("Group with identifier {$id} could not be loaded: " . $e->getMessage(), MIDCOM_LOG_WARN);
580 581
                 $this->_group_cache[$id] = null;
581 582
             }
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
             return true;
204 204
         }
205 205
         if ($user === null) {
206
-            $user =& $this->user;
206
+            $user = & $this->user;
207 207
         }
208 208
 
209 209
         if ($user == 'EVERYONE') {
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
      *
275 275
      * It always returns true for administrative users.
276 276
      */
277
-    public function is_group_member(midcom_core_group|string $group, ?midcom_core_user $user = null) : bool
277
+    public function is_group_member(midcom_core_group | string $group, ?midcom_core_user $user = null) : bool
278 278
     {
279 279
         if ($this->is_admin($user)) {
280 280
             // Administrators always have access.
@@ -519,7 +519,7 @@  discard block
 block discarded – undo
519 519
      * (group:...), any valid identifier for the midcom_core_group
520 520
      * constructor or a valid object of that type.
521 521
      */
522
-    public function get_group(string|int|midcom_db_group|midgard_group $id) : ?midcom_core_group
522
+    public function get_group(string | int | midcom_db_group | midgard_group $id) : ?midcom_core_group
523 523
     {
524 524
         $param = $id;
525 525
 
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/schemadb.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 
65 65
     protected function add_string_field(string $key, string $type)
66 66
     {
67
-        if (   $key == 'component'
67
+        if ($key == 'component'
68 68
             && $type == midcom_db_topic::class) {
69 69
             $this->_add_component_dropdown($key);
70 70
             return;
@@ -134,12 +134,12 @@  discard block
 block discarded – undo
134 134
         parent::add_longtext_field($key);
135 135
 
136 136
         // Check the user preference and configuration
137
-        if (   in_array($key, ['content', 'description'])
137
+        if (in_array($key, ['content', 'description'])
138 138
             && midgard_admin_asgard_plugin::get_preference('tinymce_enabled')) {
139 139
             $this->schema['fields'][$key]['widget'] = 'tinymce';
140 140
         }
141 141
 
142
-        if (   in_array($key, ['value', 'code'])
142
+        if (in_array($key, ['value', 'code'])
143 143
             && midgard_admin_asgard_plugin::get_preference('codemirror_enabled')) {
144 144
             $this->schema['fields'][$key]['widget'] = 'codemirror';
145 145
         }
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
         if ($score1 > $score2) {
258 258
             return 1;
259 259
         }
260
-        if (   $score1 < 3
260
+        if ($score1 < 3
261 261
             || $score1 > 6) {
262 262
             return strnatcmp($first, $second);
263 263
         }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/component/configuration.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
     {
278 278
         $success = true;
279 279
         foreach ($this->_request_data['config']->_global as $global_key => $global_value) {
280
-            if (   isset($config[$global_key])
280
+            if (isset($config[$global_key])
281 281
                 && $config[$global_key] != $global_value) {
282 282
                 continue;
283 283
                 // Skip the ones we will set next
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
         }
291 291
 
292 292
         foreach ($config as $key => $value) {
293
-            if (   is_array($value)
293
+            if (is_array($value)
294 294
                 || is_object($value)) {
295 295
                 /**
296 296
                  * See http://trac.midgard-project.org/ticket/1442
Please login to merge, or discard this patch.