Passed
Push — master ( dc3f28...9cb9a1 )
by Andreas
16:51
created
lib/org/openpsa/products/midcom/interfaces.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,7 +79,8 @@  discard block
 block discarded – undo
79 79
                 try {
80 80
                     $dms['group']->set_storage($group);
81 81
                     org_openpsa_products_viewer::index($dms['group'], $indexer, $topic, $config);
82
-                } catch (midcom_error $e) {
82
+                }
83
+                catch (midcom_error $e) {
83 84
                     $e->log(MIDCOM_LOG_WARN);
84 85
                 }
85 86
             }
@@ -91,7 +92,8 @@  discard block
 block discarded – undo
91 92
                     try {
92 93
                         $dms['product']->set_storage($product);
93 94
                         org_openpsa_products_viewer::index($dms['product'], $indexer, $topic, $config);
94
-                    } catch (midcom_error $e) {
95
+                    }
96
+                    catch (midcom_error $e) {
95 97
                         $e->log(MIDCOM_LOG_WARN);
96 98
                     }
97 99
                 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
      */
53 53
     public function _on_reindex($topic, midcom_helper_configuration $config, midcom_services_indexer $indexer)
54 54
     {
55
-        if (   !$config->get('index_products')
55
+        if (!$config->get('index_products')
56 56
             && !$config->get('index_groups')) {
57 57
             debug_add("No indexing to groups and products, skipping", MIDCOM_LOG_WARN);
58 58
             return true;
Please login to merge, or discard this patch.
lib/org/openpsa/notifications/notifier/email.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
             $mail->from = $config->get('default_sender') ?: '"OpenPSA Notifier" <noreply@' . $_SERVER['SERVER_NAME'] . '>';
39 39
         }
40 40
 
41
-        $mail->subject = $message['title'] ??  'org.openpsa.notifications message (no title provided)';
41
+        $mail->subject = $message['title'] ?? 'org.openpsa.notifications message (no title provided)';
42 42
         if (array_key_exists('attachments', $message)) {
43 43
             $mail->attachments = $message['attachments'];
44 44
         }
Please login to merge, or discard this patch.
lib/org/openpsa/documents/midcom/interfaces.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 
41 41
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
42 42
     {
43
-        if (   $object instanceof org_openpsa_documents_document_dba
43
+        if ($object instanceof org_openpsa_documents_document_dba
44 44
             && $object->topic == $topic->id) {
45 45
             return "document/{$object->guid}/";
46 46
         }
Please login to merge, or discard this patch.
lib/net/nemein/wiki/style/view-wikipage-raw.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,6 +6,6 @@
 block discarded – undo
6 6
     &(view["content"]:h);
7 7
     <?php
8 8
 } else {
9
-    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub')."</p>";
9
+    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub') . "</p>";
10 10
 }
11 11
 ?>
12 12
\ No newline at end of file
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/style/admin-read.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
         <div class="value"><?php echo $formatter->date($invoice->deliverydate); ?></div></div>
35 35
     <?php } ?>
36 36
 
37
-    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description');?>: </div>
37
+    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description'); ?>: </div>
38 38
     <div class="description value">&(view['description']:h);</div></div>
39 39
 
40 40
     <?php
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,8 @@
 block discarded – undo
8 8
     if ($customer->orgOpenpsaObtype < org_openpsa_contacts_group_dba::ORGANIZATION) {
9 9
         $customer = false;
10 10
     }
11
-} catch (midcom_error) {
11
+}
12
+catch (midcom_error) {
12 13
     $customer = false;
13 14
 }
14 15
 
Please login to merge, or discard this patch.
lib/org/openpsa/sales/style/show-deliverable-subscription.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -74,12 +74,12 @@
 block discarded – undo
74 74
                         <tr>
75 75
                           <td class="title"><?php echo $data['l10n']->get('cost'); ?></td>
76 76
                           <?php
77
-                          if ($data['deliverable']->costType == '%') { ?>
77
+                            if ($data['deliverable']->costType == '%') { ?>
78 78
                               <td class="numeric"><?php echo $view['costPerUnit']; ?> %</td>
79 79
                               <td class="numeric">&nbsp;</td>
80 80
                               <td class="numeric">&nbsp;</td>
81 81
                           <?php
82
-                          } else { ?>
82
+                            } else { ?>
83 83
                               <td class="numeric"><?php echo $formatter->number($data['deliverable']->costPerUnit); ?></td>
84 84
                               <td class="numeric"><?php echo $view['plannedUnits']; ?></td>
85 85
                               <td class="numeric"><?php echo $view['units']; ?></td>
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 $state = $data['deliverable']->get_state();
4 4
 $formatter = $data['l10n']->get_formatter();
5 5
 $per_unit = $data['l10n']->get('per unit');
6
-if (   $data['product']
6
+if ($data['product']
7 7
     && $unit_option = org_openpsa_sales_viewer::get_unit_option($data['product']->unit)) {
8 8
     $per_unit = sprintf($data['l10n']->get('per %s'), $unit_option);
9 9
 }
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
         </div>
110 110
         <?php
111 111
         $tabs = [];
112
-        if (   $data['invoices_url']
112
+        if ($data['invoices_url']
113 113
             && $data['deliverable']->invoiced > 0) {
114 114
             $tabs[] = [
115 115
                 'url' => $data['invoices_url'] . "list/deliverable/{$data['deliverable']->guid}/",
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
             ];
118 118
         }
119 119
 
120
-        if (   $data['projects_url']
120
+        if ($data['projects_url']
121 121
             && $data['deliverable']->state >= org_openpsa_sales_salesproject_deliverable_dba::STATE_ORDERED
122 122
             && $data['product']
123 123
             && $data['product']->orgOpenpsaObtype == org_openpsa_products_product_dba::TYPE_SERVICE) {
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
             }
173 173
             echo "    </tbody>\n";
174 174
             echo "</table>\n";
175
-            if (   $at_entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
175
+            if ($at_entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
176 176
                 && midcom::get()->auth->can_user_do('midgard:create', class: org_openpsa_invoices_invoice_dba::class)) {
177 177
                 $label = $data['l10n']->get('generate now');
178 178
                 $process_link = $data['router']->generate('deliverable_run_cycle', ['guid' => $data['deliverable']->guid]);
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/style/show_entries_html.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
             <?php
47 47
             //index is needed for sorting
48 48
             echo "'index_name',";
49
-            echo "'" . $data['l10n']->get('entry title') ."',";
49
+            echo "'" . $data['l10n']->get('entry title') . "',";
50 50
             echo "'" . $data['l10n']->get('entry text') . "',";
51 51
             echo "'" . $data['l10n']->get('entry created') . "',";
52 52
             echo "'index_creator', '" . $data['l10n_midcom']->get('creator') . "',";
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,8 @@
 block discarded – undo
25 25
             $row['creator_index'] = $creator->rname;
26 26
             $creator_card = org_openpsa_widgets_contact::get($entry->metadata->creator);
27 27
             $row['creator'] = $creator_card->show_inline();
28
-        } catch (midcom_error) {
28
+        }
29
+        catch (midcom_error) {
29 30
             $row['creator_index'] = '';
30 31
             $row['creator'] = '';
31 32
         }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/object/attachments.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -98,13 +98,13 @@  discard block
 block discarded – undo
98 98
         }
99 99
 
100 100
         $mimetype = $request->request->get('midgard_admin_asgard_mimetype');
101
-        if (   !empty($mimetype)
101
+        if (!empty($mimetype)
102 102
             && $local_file->mimetype != $mimetype) {
103 103
             $local_file->mimetype = $mimetype;
104 104
             $needs_update = true;
105 105
         }
106 106
 
107
-        if (   $needs_update
107
+        if ($needs_update
108 108
             && !$local_file->update()) {
109 109
             return null;
110 110
         }
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
         $this->bind_view_to_object($this->_file);
235 235
 
236 236
         $filename = $this->_process_form($request);
237
-        if (   $filename
237
+        if ($filename
238 238
             && $filename != $data['filename']) {
239 239
             return $this->relocate_to_file($filename);
240 240
         }
Please login to merge, or discard this patch.
lib/org/openpsa/slideshow/image.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,8 @@  discard block
 block discarded – undo
48 48
 
49 49
         try {
50 50
             $folder = midcom_db_topic::get_cached($this->topic);
51
-        } catch (midcom_error $e) {
51
+        }
52
+        catch (midcom_error $e) {
52 53
             $e->log();
53 54
         }
54 55
         $folder->delete_attachment(self::FOLDER_THUMBNAIL);
@@ -58,7 +59,8 @@  discard block
 block discarded – undo
58 59
     {
59 60
         try {
60 61
             return new midcom_db_attachment($this->$type);
61
-        } catch (midcom_error $e) {
62
+        }
63
+        catch (midcom_error $e) {
62 64
             $e->log();
63 65
             return null;
64 66
         }
Please login to merge, or discard this patch.