flack / openpsa

lib/midcom/services/auth/acl.php

Spacing +2 added lines, -2 removed lines

@@ -568,10 +568,10 @@
         }
 
         //owner privileges override everything but person privileges, so we have to cross-check those here
-        if (   $privilegename != 'midgard:owner'
+        if ($privilegename != 'midgard:owner'
             && $last_scope < MIDCOM_PRIVILEGE_SCOPE_OWNER) {
             $owner_privileges = $this->get_owner_default_privileges();
-            if (    array_key_exists($privilegename, $owner_privileges)
+            if (array_key_exists($privilegename, $owner_privileges)
                  && $this->_load_content_privilege('midgard:owner', $guid, $class, $user_id)
                  && self::$_content_privileges_cache[$cache_id]['midgard:owner']) {
                 self::$_content_privileges_cache[$cache_id][$privilegename] = ($owner_privileges[$privilegename] == MIDCOM_PRIVILEGE_ALLOW);

Indentation +9 added lines, -9 removed lines

@@ -253,15 +253,15 @@
     private static array $_default_magic_class_privileges = [];
 
     /**
-    * Internal cache of the content privileges of users on content objects, this is
-    * an associative array using a combination of the user identifier and the object's
-    * guid as index. The privileges for the anonymous user use the magic
-    * EVERYONE as user identifier.
-    *
-    * This must not be merged with the class-wide privileges_cache, because otherwise
-    * class_default_privileges for child objects might be overridden by parent default
-    * privileges
-    */
+     * Internal cache of the content privileges of users on content objects, this is
+     * an associative array using a combination of the user identifier and the object's
+     * guid as index. The privileges for the anonymous user use the magic
+     * EVERYONE as user identifier.
+     *
+     * This must not be merged with the class-wide privileges_cache, because otherwise
+     * class_default_privileges for child objects might be overridden by parent default
+     * privileges
+     */
     private static array $_content_privileges_cache = [];
 
     /**

lib/midcom/services/rcs/backend/rcs.php

Braces +4 added lines, -2 removed lines

@@ -50,9 +50,11 @@
         $filepath = $this->generate_filename();
         try {
             $this->exec('co -q -f -r' . escapeshellarg(trim($revision)) . " {$filepath} 2>/dev/null");
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
-        } finally {
+        }
+        finally {
             if (!file_exists($filepath)) {
                 return [];
             }

Spacing +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
                 $revisions[$history['revision']] = $history;
 
                 $i += 3;
-                while (   $i < $total
+                while ($i < $total
                         && !str_starts_with($lines[$i], '----')
                         && !str_starts_with($lines[$i], '=====')) {
                     $i++;

lib/midcom/helper/misc.php

Braces +2 added lines, -1 removed lines

@@ -55,7 +55,8 @@
     {
         try {
             return eval("return [{$data}\n];");
-        } catch (ParseError $e) {
+        }
+        catch (ParseError $e) {
             throw new midcom_error('Failed to parse config data: ' . $e->getMessage() . ' in ' . $path . ' line ' . $e->getLine());
         }
     }

src/midcom/datamanager/extension/type/captchaType.php

Spacing +2 added lines, -2 removed lines

@@ -43,11 +43,11 @@
     public function buildForm(FormBuilderInterface $builder, array $options)
     {
         $session_key = md5($builder->getForm()->getName() . '_session_key');
-        $builder->addEventListener(FormEvents::POST_SUBMIT, function (FormEvent $event) use ($session_key) {
+        $builder->addEventListener(FormEvents::POST_SUBMIT, function(FormEvent $event) use ($session_key) {
             $value = $event->getForm()->getData();
             $session = new midcom_services_session('midcom_datamanager_captcha');
 
-            if (   !$session->exists($session_key)
+            if (!$session->exists($session_key)
                 || $value != $session->get($session_key)) {
                 $event->getForm()->addError(new FormError($this->l10n->get('captcha validation failed')));
             }

src/midcom/datamanager/extension/formExtension.php

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
         $view->vars['readonly'] = $options['readonly'];
 
         if ($options['write_privilege'] !== null) {
-            if (   array_key_exists('group', $options['write_privilege'])
+            if (array_key_exists('group', $options['write_privilege'])
                 && !$this->auth->is_group_member($options['write_privilege']['group'])) {
                 $view->vars['readonly'] = true;
             }

lib/org/openpsa/contacts/handler/search.php

Spacing +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
 
         // Handle automatic wildcards
         $auto_wildcards = $this->_config->get('auto_wildcards');
-        if (   $auto_wildcards
+        if ($auto_wildcards
             && !str_contains($this->_query_string_processed, '%')) {
             switch ($auto_wildcards) {
                 case 'both':

lib/org/openpsa/directmarketing/support/bounce_detector.php

Spacing +2 added lines, -2 removed lines

@@ -45,7 +45,7 @@ 
 }
 $recipient = $_ENV["RECIPIENT"];
 $token_length = strlen($recipient) - strlen($prefix) - strlen($suffix);
-if (   $token_length <= 0
+if ($token_length <= 0
     || !str_starts_with($recipient, $prefix)
     || !str_ends_with($recipient, $suffix)) {
     error_log("Recipient address does not match address template: $recipient");
@@ -61,7 +61,7 @@ 
         fclose($fh);
         exit(0);
     }
-} elseif (   str_starts_with($BOUNCE_LOGGER, "http://")
+} elseif (str_starts_with($BOUNCE_LOGGER, "http://")
           || str_starts_with($BOUNCE_LOGGER, "https://")) {
     $client = new org_openpsa_httplib();
     $client->post($BOUNCE_LOGGER, ["token" => $token]);

src/midcom/routing/parser.php

Spacing +2 added lines, -2 removed lines

@@ -46,7 +46,7 @@ 
         $url = $this->context->get_key(MIDCOM_CONTEXT_URI);
 
         $prefix_length = strlen(midcom_connection::get_url('prefix'));
-        if (   $prefix_length > 1
+        if ($prefix_length > 1
             && str_starts_with($url, midcom_connection::get_url('prefix'))) {
             $url = substr($url, $prefix_length);
         }
@@ -71,7 +71,7 @@ 
      */
     public function find_urlmethod() : ?string
     {
-        if (   empty($this->argv)
+        if (empty($this->argv)
             || !str_starts_with($this->argv[0], 'midcom-')) {
             return null;
         }

src/midcom/datamanager/extension/transformer/imageTransformer.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
         }
 
         $result = [];
-        if (   !empty($array['file'])
+        if (!empty($array['file'])
             || !empty($array['identifier']) && str_starts_with($array['identifier'], 'tmpfile-')) {
             $result['file'] = parent::reverseTransform($array);
         } elseif (!empty($array['objects'])) {