flack / openpsa

lib/org/openpsa/expenses/handler/hours/admin.php

Braces +2 added lines, -1 removed lines

@@ -100,7 +100,8 @@
         try {
             $task = org_openpsa_projects_task_dba::get_cached($hour_report->task);
             $options['success_url'] = $this->router->generate('list_hours_task', ['guid' => $task->guid]);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
         return $this->get_workflow('delete', $options)->run($request);

Spacing +1 added lines, -1 removed lines

@@ -133,7 +133,7 @@
         return new midcom_response_relocate($relocate);
     }
 
-    private function parse_input(ParameterBag $input, string $action) : int|bool
+    private function parse_input(ParameterBag $input, string $action) : int | bool
     {
         if (!in_array($action, ['invoiceable', 'invoice', 'task'])) {
             throw new midcom_error('passed action ' . $action . ' is unknown');

src/midcom/datamanager/controller.php

Spacing +3 added lines, -3 removed lines

@@ -70,13 +70,13 @@ 
             }
         } elseif (!$this->form->isSubmitted()) {
             $this->form->handleRequest($request);
-            if (   $this->form->isSubmitted()
+            if ($this->form->isSubmitted()
                 && $button = $this->form->getClickedButton()) {
                 $operation = $button->getConfig()->getOption('operation');
             }
         }
 
-        if (   in_array($operation, [self::SAVE, self::NEXT])
+        if (in_array($operation, [self::SAVE, self::NEXT])
             && !$this->form->isValid()) {
             $operation = self::EDIT;
         }
@@ -159,7 +159,7 @@ 
                 if ($storage->get_last_operation() === self::SAVE) {
                     // Get GUIDs and such for new-created dependent objects
                     $this->dm->set_storage($storage->get_value(), $this->dm->get_schema()->get_name());
-                } elseif (   !$this->form->isValid()
+                } elseif (!$this->form->isValid()
                           && $storage->move_uploaded_files() > 0) {
                     $form = $this->dm->get_form($this->form->getName(), true);
                     $this->copy_errors($this->form, $form);

lib/org/openpsa/projects/style/show-frontpage.php

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('ongoing') . "\">{$task_count['ongoing']}</span></td>\n";
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('on_hold') . "\">{$task_count['on_hold']}</span></td>\n";
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('closed') . "\">{$task_count['closed']}</span></td>\n";
-            echo "        <td class=\"numeric\"> " ;
+            echo "        <td class=\"numeric\"> ";
             echo "            <span title=\"" . $data['l10n']->get('reported') . "\">" . round($hours['reportedHours'], 2) . "</span>";
             if ($hours['plannedHours'] > 0) {
                 echo          " / <span title=\"" . $data['l10n']->get('planned hours') . "\">" . round($hours['plannedHours'], 2) . "</span>";

Braces +2 added lines, -1 removed lines

@@ -21,7 +21,8 @@
         try {
             $customer = new org_openpsa_contacts_group_dba($customer);
             $customer_title = $customer->official;
-        } catch (midcom_error) {
+        }
+        catch (midcom_error) {
             $customer_title = $data['l10n']->get('no customer');
         }
 

lib/midcom/admin/folder/management.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
             }
 
             // Skip components beginning with midcom or midgard
-            if (   preg_match('/^(midcom|midgard)\./', $manifest->name)
+            if (preg_match('/^(midcom|midgard)\./', $manifest->name)
                 && $manifest->name != 'midcom.helper.search') {
                 continue;
             }

lib/org/openpsa/sales/style/show-deliverable.php

Spacing +3 added lines, -3 removed lines

@@ -3,7 +3,7 @@ 
 $state = $data['deliverable']->get_state();
 $formatter = $data['l10n']->get_formatter();
 $per_unit = $data['l10n']->get('per unit');
-if (   $data['product']
+if ($data['product']
     && $unit_option = org_openpsa_sales_viewer::get_unit_option($data['product']->unit)) {
     $per_unit = sprintf($data['l10n']->get('per %s'), $unit_option);
 }
@@ -115,7 +115,7 @@ 
 	    </div>
      <?php
     $tabs = [];
-    if (   $data['invoices_url']
+    if ($data['invoices_url']
         && $data['deliverable']->invoiced > 0) {
         $tabs[] = [
             'url' => $data['invoices_url'] . "list/deliverable/{$data['deliverable']->guid}/",
@@ -123,7 +123,7 @@ 
         ];
     }
 
-    if (   $data['projects_url']
+    if ($data['projects_url']
         && $data['deliverable']->state >= org_openpsa_sales_salesproject_deliverable_dba::STATE_ORDERED
         && $data['product']
         && $data['product']->orgOpenpsaObtype == org_openpsa_products_product_dba::TYPE_SERVICE) {

Indentation +3 added lines, -3 removed lines

@@ -65,17 +65,17 @@
                         <tr>
                           <td class="title"><?php echo $data['l10n']->get('cost'); ?></td>
                           <?php
-                          if ($data['deliverable']->costType == '%') { ?>
+                            if ($data['deliverable']->costType == '%') { ?>
                               <td class="numeric"><?php echo $view['costPerUnit']; ?> %</td>
                               <td class="numeric">&nbsp;</td>
                               <td class="numeric">&nbsp;</td>
                           <?php
-                          } else { ?>
+                            } else { ?>
                               <td class="numeric"><?php echo $formatter->number($data['deliverable']->costPerUnit); ?></td>
                               <td class="numeric"><?php echo $view['plannedUnits']; ?></td>
                               <td class="numeric"><?php echo $view['units']; ?></td>
                           <?php
-                          } ?>
+                            } ?>
                               <td class="numeric"><?php echo $formatter->number($data['deliverable']->cost); ?></td>
                         </tr>
                       </tbody>

lib/org/openpsa/sales/style/show-offers.php

Indentation +22 added lines, -22 removed lines

@@ -5,29 +5,29 @@
     ?>
     <div class="area org_openpsa_helper_box"><h3><?php echo $data['l10n']->get('offers'); ?></h3>
     	<ul><?php
-         foreach ($data['offers'] as $offer) {
-             echo '<li><span class="org_openpsa_helpers_fileinfo">';
-             $attachment = $offer->get_file();
-             $delete_link = $data['router']->generate('delete_offer', ['guid' => $offer->guid]);
-             $edit_link = $data['router']->generate('edit_offer', ['guid' => $offer->guid]);
+            foreach ($data['offers'] as $offer) {
+                echo '<li><span class="org_openpsa_helpers_fileinfo">';
+                $attachment = $offer->get_file();
+                $delete_link = $data['router']->generate('delete_offer', ['guid' => $offer->guid]);
+                $edit_link = $data['router']->generate('edit_offer', ['guid' => $offer->guid]);
 
-             if (!empty($attachment)) {
-                 $url = midcom_db_attachment::get_url($attachment);
-                 echo '<a href="' . $url . '" class="icon"><i class="fa fa-file-text-o"></i></a>';
-             }
-             echo '<span class="info">';
-             echo '<span class="filename">' . $offer->get_label();
-             echo ' <a class="actions" href="' . $delete_link . '"><i class="fa fa-trash" title="' . $data['l10n_midcom']->get('delete') . '"></i></a>';
-             echo ' <a class="actions" ' . $wf->render_attributes() . ' href="' . $edit_link . '"><i class="fa fa-pencil" title="' . $data['l10n_midcom']->get('edit') . '"></i></a>';
-             echo "</span>\n";
-             if (!empty($attachment)) {
-                 echo ' <span class="date">' . $formatter->datetime($attachment->metadata->revised) . '</span> ';
-                 $person_card = org_openpsa_widgets_contact::get($attachment->metadata->revisor);
-                 echo $person_card->show_inline();
-             }
-             echo "</span></span></li>\n";
-         }
-         ?>
+                if (!empty($attachment)) {
+                    $url = midcom_db_attachment::get_url($attachment);
+                    echo '<a href="' . $url . '" class="icon"><i class="fa fa-file-text-o"></i></a>';
+                }
+                echo '<span class="info">';
+                echo '<span class="filename">' . $offer->get_label();
+                echo ' <a class="actions" href="' . $delete_link . '"><i class="fa fa-trash" title="' . $data['l10n_midcom']->get('delete') . '"></i></a>';
+                echo ' <a class="actions" ' . $wf->render_attributes() . ' href="' . $edit_link . '"><i class="fa fa-pencil" title="' . $data['l10n_midcom']->get('edit') . '"></i></a>';
+                echo "</span>\n";
+                if (!empty($attachment)) {
+                    echo ' <span class="date">' . $formatter->datetime($attachment->metadata->revised) . '</span> ';
+                    $person_card = org_openpsa_widgets_contact::get($attachment->metadata->revisor);
+                    echo $person_card->show_inline();
+                }
+                echo "</span></span></li>\n";
+            }
+            ?>
      </ul>
     </div>
 <?php  } ?>
\ No newline at end of file

lib/org/openpsa/calendar/conflictmanager.php

Spacing +4 added lines, -4 removed lines

@@ -125,7 +125,7 @@ 
         }
         // TODO: Shared tasks need a separate check (different member object)
 
-        if (   !empty($this->busy_members)
+        if (!empty($this->busy_members)
             || !empty($this->busy_resources)) {
             //Unresolved conflicts (note return value is for conflicts not lack of them)
             midcom::get()->auth->drop_sudo();
@@ -188,7 +188,7 @@ 
         }
 
         if (array_key_exists($member->event, $modified_events)) {
-            $event =& $modified_events[$member->event];
+            $event = & $modified_events[$member->event];
             $set_as_modified = false;
         } else {
             try {
@@ -202,7 +202,7 @@ 
         }
         debug_add("overlap found in event {$event->title} (#{$event->id})");
 
-        if (   $event->tentative
+        if ($event->tentative
             && $rob_tentative) {
             debug_add('event is tentative, robbing resources');
             $event->resources = array_diff_key($event->resources, $this->_event->resources);
@@ -229,7 +229,7 @@ 
         }
         debug_add("overlap found in event {$event->title} (#{$event->id})");
 
-        if (   $event->tentative
+        if ($event->tentative
             && $rob_tentative) {
             debug_add('event is tentative, robbing participants');
             $event->participants = array_diff_key($event->participants, $this->_event->participants);

Braces +4 added lines, -2 removed lines

@@ -142,7 +142,8 @@ 
             try {
                 $event = new org_openpsa_calendar_event_dba($member->event);
                 $set_as_modified = true;
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 debug_add("event_resource #{$member->id} links to bogus event #{$member->event}, skipping and removing", MIDCOM_LOG_WARN);
                 $member->delete();
                 return;
@@ -170,7 +171,8 @@ 
 
         try {
             $event = new org_openpsa_calendar_event_dba($member->eid);
-        } catch (midcom_error) {
+        }
+        catch (midcom_error) {
             debug_add("eventmember #{$member->id} links to bogus event #{$member->eid}, skipping and removing", MIDCOM_LOG_WARN);
             $member->delete();
             return;

lib/org/openpsa/notifications/main.php

Spacing +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
 
         // If user has preference for this message, we use that
         $personal_preferences = $recipient->list_parameters('org.openpsa.notifications');
-        if (   !empty($personal_preferences)
+        if (!empty($personal_preferences)
             && array_key_exists("{$component}:{$action}", $personal_preferences)) {
             return $personal_preferences[$action];
         }

Braces +2 added lines, -1 removed lines

@@ -58,7 +58,8 @@
         // TODO: Should we sudo here to ensure getting correct prefs regardless of ACLs?
         try {
             $recipient = midcom_db_person::get_cached($recipient);
-        } catch (midcom_error) {
+        }
+        catch (midcom_error) {
             return false;
         }
 

lib/org/openpsa/projects/project.php

Spacing +1 added lines, -1 removed lines

@@ -249,7 +249,7 @@
             $new_status = $this->_find_status($this->_status_map[$this->status_type], $status_types);
         }
 
-        if (   $new_status !== null
+        if ($new_status !== null
             && $this->status != $new_status) {
             $this->status = $new_status;
             $update_required = true;