Passed
Push — master ( dc3f28...9cb9a1 )
by Andreas
16:51
created
lib/org/openpsa/reports/handler/invoices/report.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -132,7 +132,8 @@
 block discarded – undo
132 132
                         && $deliverable->end > $this->_request_data['start'])) {
133 133
                     $invoices = array_merge($invoices, $this->_get_invoices_for_subscription($deliverable, $at_entry));
134 134
                 }
135
-            } catch (midcom_error) {
135
+            }
136
+            catch (midcom_error) {
136 137
             }
137 138
         }
138 139
         $invoices = array_merge($invoices, $this->_get_deliverable_invoices());
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/style/show_entries_html.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,8 @@
 block discarded – undo
25 25
             $row['creator_index'] = $creator->rname;
26 26
             $creator_card = org_openpsa_widgets_contact::get($entry->metadata->creator);
27 27
             $row['creator'] = $creator_card->show_inline();
28
-        } catch (midcom_error) {
28
+        }
29
+        catch (midcom_error) {
29 30
             $row['creator_index'] = '';
30 31
             $row['creator'] = '';
31 32
         }
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/exec/delete_dangling_links.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,8 @@
 block discarded – undo
25 25
     try {
26 26
         midcom::get()->dbfactory->get_object_by_guid($result->fromGuid);
27 27
         midcom::get()->dbfactory->get_object_by_guid($result->toGuid);
28
-    } catch (midcom_error) {
28
+    }
29
+    catch (midcom_error) {
29 30
         echo $i . "/" . $total . ": Deleting relatedto #" . $result->id . "\n";
30 31
         $result->delete();
31 32
     }
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/handler/relatedto.php 1 patch
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -107,7 +107,8 @@  discard block
 block discarded – undo
107 107
             //TODO: check for duplicates ?
108 108
             try {
109 109
                 $result = ['other_obj' => midcom::get()->dbfactory->get_object_by_guid($link[$other . 'Guid'])];
110
-            } catch (midcom_error) {
110
+            }
111
+            catch (midcom_error) {
111 112
                 continue;
112 113
             }
113 114
             $result['link'] = [
@@ -378,7 +379,8 @@  discard block
 block discarded – undo
378 379
             if (!($this->_object instanceof org_openpsa_relatedto_dba)) {
379 380
                 $response['status'] = "method requires guid of a link object as an argument";
380 381
             }
381
-        } catch (midcom_error $e) {
382
+        }
383
+        catch (midcom_error $e) {
382 384
             $response['status'] = "error: " . $e->getMessage();
383 385
         }
384 386
 
@@ -399,7 +401,8 @@  discard block
 block discarded – undo
399 401
             $relation = new org_openpsa_relatedto_dba($guid);
400 402
             $result = $relation->delete();
401 403
             $status = 'Last message: ' . midcom_connection::get_error_string();
402
-        } catch (midcom_error $e) {
404
+        }
405
+        catch (midcom_error $e) {
403 406
             $result = false;
404 407
             $status = "Object '{$guid}' could not be loaded, error:" . $e->getMessage();
405 408
         }
Please login to merge, or discard this patch.
lib/org/openpsa/user/midcom/interfaces.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,7 +23,8 @@  discard block
 block discarded – undo
23 23
         midcom::get()->auth->request_sudo($this->_component);
24 24
         try {
25 25
             $person = new midcom_db_person($args['guid']);
26
-        } catch (midcom_error) {
26
+        }
27
+        catch (midcom_error) {
27 28
             $handler->print_error('Person with guid #' . $args['guid'] . ' does not exist');
28 29
             midcom::get()->auth->drop_sudo();
29 30
             return false;
@@ -31,7 +32,8 @@  discard block
 block discarded – undo
31 32
         $accounthelper = new org_openpsa_user_accounthelper($person);
32 33
         try {
33 34
             $accounthelper->reopen_account();
34
-        } catch (midcom_error $e) {
35
+        }
36
+        catch (midcom_error $e) {
35 37
             $handler->print_error($e->getMessage());
36 38
             midcom::get()->auth->drop_sudo();
37 39
             return false;
Please login to merge, or discard this patch.
lib/org/openpsa/widgets/contact.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -103,7 +103,8 @@  discard block
 block discarded – undo
103 103
 
104 104
         try {
105 105
             $person = midcom_db_person::get_cached($src);
106
-        } catch (midcom_error) {
106
+        }
107
+        catch (midcom_error) {
107 108
             return $cache[$src] = new self(new midcom_db_person);
108 109
         }
109 110
 
@@ -303,7 +304,8 @@  discard block
 block discarded – undo
303 304
         foreach ($mc->get_rows(['gid', 'extra']) as $data) {
304 305
             try {
305 306
                 $group = org_openpsa_contacts_group_dba::get_cached($data['gid']);
306
-            } catch (midcom_error $e) {
307
+            }
308
+            catch (midcom_error $e) {
307 309
                 $e->log();
308 310
                 continue;
309 311
             }
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/sender.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -160,7 +160,8 @@  discard block
 block discarded – undo
160 160
             $this->_backend->send($person, $member, $token, $subject, $content, $from);
161 161
             self::$_messages_sent++;
162 162
             $status = org_openpsa_directmarketing_campaign_messagereceipt_dba::SENT;
163
-        } catch (midcom_error $e) {
163
+        }
164
+        catch (midcom_error $e) {
164 165
             $status = org_openpsa_directmarketing_campaign_messagereceipt_dba::FAILURE;
165 166
             if (!$this->test_mode) {
166 167
                 $params[] = [
@@ -209,7 +210,8 @@  discard block
 block discarded – undo
209 210
     {
210 211
         try {
211 212
             $person = org_openpsa_contacts_person_dba::get_cached($member->person);
212
-        } catch (midcom_error) {
213
+        }
214
+        catch (midcom_error) {
213 215
             debug_add("Person #{$member->person} deleted or missing, removing member (member #{$member->id})");
214 216
             $member->orgOpenpsaObtype = org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED;
215 217
             $member->delete();
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/midcom/interfaces.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -51,7 +51,8 @@  discard block
 block discarded – undo
51 51
         try {
52 52
             midcom::get()->dynamic_load($batch_url);
53 53
             $ret = true;
54
-        } catch (midcom_error $e) {
54
+        }
55
+        catch (midcom_error $e) {
55 56
             $ret = $e->getMessage();
56 57
         }
57 58
         ob_end_clean();
@@ -74,7 +75,8 @@  discard block
 block discarded – undo
74 75
         $stat = true;
75 76
         try {
76 77
             $campaign = new org_openpsa_directmarketing_campaign_dba($args['campaign_guid']);
77
-        } catch (midcom_error) {
78
+        }
79
+        catch (midcom_error) {
78 80
             $handler->print_error("{$args['campaign_guid']} is not a valid campaign GUID");
79 81
             $stat = false;
80 82
         }
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/handler/message/report.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,8 @@
 block discarded – undo
114 114
                 try {
115 115
                     $person = org_openpsa_contacts_person_dba::get_cached($link->person);
116 116
                     $segment = $person->get_parameter('org.openpsa.directmarketing.segments', $segmentation_param);
117
-                } catch (midcom_error) {
117
+                }
118
+                catch (midcom_error) {
118 119
                 }
119 120
                 if (empty($segment)) {
120 121
                     $segment = $this->_l10n->get('no segment');
Please login to merge, or discard this patch.