flack / openpsa

lib/org/openpsa/projects/handler/task/view.php

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
             MIDCOM_TOOLBAR_ACCESSKEY => 'e',
         ]);
 
-        if (   $this->task->reportedHours == 0
+        if ($this->task->reportedHours == 0
             && $this->task->can_do('midgard:delete')) {
             $delete_workflow = $this->get_workflow('delete', ['object' => $this->task]);
             $buttons[] = $delete_workflow->get_button($this->router->generate('task_delete', ['guid' => $this->task->guid]));

Braces +2 added lines, -1 removed lines

@@ -109,7 +109,8 @@
                         MIDCOM_TOOLBAR_GLYPHICON => 'money',
                     ];
                 }
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
             }
         }
 

lib/org/openpsa/projects/handler/task/list.php

Spacing +1 added lines, -1 removed lines

@@ -169,7 +169,7 @@
             case 'proposed':
                 $html = $this->render_status($task->manager, "from %s");
                 $task->get_members();
-                if (   $task->can_do('midgard:update')
+                if ($task->can_do('midgard:update')
                     && isset($task->resources[midcom_connection::get_user()])) {
                     $html .= '<form method="post" action="' . $this->router->generate('workflow', ['guid' => $task->guid]) . '">';
                     //TODO: If we need all resources to accept task hide tools when we have accepted and replace with "pending acceptance from..."

Braces +4 added lines, -2 removed lines

@@ -255,7 +255,8 @@ 
             $url = $this->router->generate('project', ['guid' => $project->guid]);
             $ret['project'] = '<a href="' . $url . '">' . $project->title . '</a>';
             $ret['index_project'] = $project->title;
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
 
@@ -267,7 +268,8 @@ 
                 $customer_url = "{$contacts_url}group/{$customer->guid}/";
                 $ret['customer'] = "<a href='{$customer_url}' title='{$customer->official}'>{$customer->get_label()}</a>";
                 $ret['index_customer'] = $customer->name;
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 $ret['customer'] = '';
                 $ret['index_customer'] = '';
             }

lib/org/openpsa/invoices/handler/scheduled.php

Braces +4 added lines, -2 removed lines

@@ -61,7 +61,8 @@ 
         try {
             $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($at_entry->arguments['deliverable']);
             $salesproject = org_openpsa_sales_salesproject_dba::get_cached($deliverable->salesproject);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return $invoice;
         }
@@ -103,7 +104,8 @@ 
                     $invoice[$fieldname] = '<a href="' . $sales_url . 'list/customer/' . $object->guid . '/">' . $invoice[$fieldname] . '</a>';
                 }
                 $invoice['index_' . $fieldname] = $object->get_label();
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

lib/midcom/core/privilege.php

Indentation -1 removed lines

@@ -37,7 +37,6 @@
                 - 1: MIDCOM_PRIVILEGE_ALLOW
                 - 2: MIDCOM_PRIVILEGE_DENY
                 - 3: MIDCOM_PRIVILEGE_INHERIT
-
  * @property string $guid
  * @package midcom
  */

Braces +2 added lines, -1 removed lines

@@ -112,7 +112,8 @@
         if ($this->__cached_object === null) {
             try {
                 $this->__cached_object = midcom::get()->dbfactory->get_object_by_guid($this->objectguid);
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 return null;
             }
         }

Spacing +6 added lines, -6 removed lines

@@ -75,7 +75,7 @@ 
      * The Default constructor creates an empty privilege, if you specify
      * another privilege object in the constructor, a copy is constructed.
      */
-    public function __construct(midcom_core_privilege_db|array|string $src = null)
+    public function __construct(midcom_core_privilege_db | array | string $src = null)
     {
         if (is_array($src)) {
             // Store given values to our privilege array
@@ -210,7 +210,7 @@ 
      * - Any midcom_core_user or midcom_core_group object or subtype thereof.
      * - Any string identifier which can be resolved using midcom_services_auth::get_assignee().
      */
-    public function set_assignee(midcom_core_group|midcom_core_user|string $assignee) : bool
+    public function set_assignee(midcom_core_group | midcom_core_user | string $assignee) : bool
     {
         if (is_string($assignee)) {
             if ($this->is_magic_assignee($assignee)) {
@@ -266,12 +266,12 @@ 
             }
         }
 
-        if (   !$this->is_magic_assignee()
+        if (!$this->is_magic_assignee()
             && !$this->get_assignee()) {
             debug_add("The assignee identifier '{$this->assignee}' is invalid.", MIDCOM_LOG_INFO);
             return false;
         }
-        if (   $this->assignee == 'OWNER'
+        if ($this->assignee == 'OWNER'
             && $this->privilegename == 'midgard:owner') {
             debug_add("Tried to assign midgard:owner to the OWNER magic assignee, this is invalid.", MIDCOM_LOG_INFO);
             return false;
@@ -283,7 +283,7 @@ 
                 MIDCOM_LOG_INFO);
             return false;
         }
-        if (   !$object->can_do('midgard:update')
+        if (!$object->can_do('midgard:update')
             || !$object->can_do('midgard:privileges')) {
             debug_add("Insufficient privileges on the content object with the GUID '{$this->__guid}', midgard:update and midgard:privileges required.",
                 MIDCOM_LOG_INFO);
@@ -444,7 +444,7 @@ 
         return new midcom_core_privilege($result[0]);
     }
 
-    private function _load(midcom_core_privilege_db|string $src = null)
+    private function _load(midcom_core_privilege_db | string $src = null)
     {
         if ($src instanceof midcom_core_privilege_db) {
             // Got a privilege object as argument, use that

src/midcom/datamanager/extension/subscriber/purifySubscriber.php

Braces +2 added lines, -1 removed lines

@@ -72,7 +72,8 @@
         $data = $event->getData();
         try {
             $data = $purifier->purify($data);
-        } catch (\Exception $e) {
+        }
+        catch (\Exception $e) {
             debug_add("HTML Purifier failed: " . $e->getMessage(), MIDCOM_LOG_WARN);
         }
         $event->setData($data);

Spacing +2 added lines, -2 removed lines

@@ -34,7 +34,7 @@ 
 
     public function purify_content(FormEvent $event)
     {
-        if (   isset($this->config['Cache']['SerializerPath'])
+        if (isset($this->config['Cache']['SerializerPath'])
             && !file_exists($this->config['Cache']['SerializerPath'])) {
             mkdir($this->config['Cache']['SerializerPath']);
         }
@@ -48,7 +48,7 @@ 
 
         // Load custom element/attribute definitions
         $definitions = $this->get_from_global_config('html_purify_HTMLDefinition');
-        if (   !empty($definitions)
+        if (!empty($definitions)
             && $def = $purifier_config->maybeGetRawHTMLDefinition()) {
             if (!empty($definitions['addAttribute'])) {
                 foreach (array_filter((array) $definitions['addAttribute'], is_array(...)) as $attrdef) {

lib/net/nemein/wiki/wikipage.php

Braces +2 added lines, -1 removed lines

@@ -193,7 +193,8 @@
 
         try {
             $diff_fields = $rcs_handler->get_diff($prev_version, $this_version);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return '';
         }

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 
     public function _on_creating() : bool
     {
-        if (   $this->title == ''
+        if ($this->title == ''
             || !$this->topic) {
             // We must have wikiword and topic at this stage
             return false;

lib/org/openpsa/reports/style/projects_report-basic-header.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
                         <th><?php echo $data['l10n']->get('type'); ?></th>
 <?php
         }   ?>
-<?php   if (   array_key_exists('invoiceable_filter', $query_data)) {
+<?php   if (array_key_exists('invoiceable_filter', $query_data)) {
             ?>
                         <th><?php echo midcom::get()->i18n->get_string('invoiceable', 'org.openpsa.projects'); ?></th>
 <?php

src/midcom/datamanager/extension/transformer/attachmentTransformer.php

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
             return null;
         }
 
-        if (! $input instanceof midcom_db_attachment) {
+        if (!$input instanceof midcom_db_attachment) {
             throw new UnexpectedTypeException($input, midcom_db_attachment::class);
         }
 

src/midcom/datamanager/schema.php

Spacing +4 added lines, -4 removed lines

@@ -160,7 +160,7 @@ 
             'customdata' => []
         ], $config));
 
-        $normalize_widget = function (Options $options, $value) {
+        $normalize_widget = function(Options $options, $value) {
             if ($value == 'text') {
                 if (!empty($options['widget_config']['hideinput'])) {
                     return PasswordType::class;
@@ -185,7 +185,7 @@ 
             return $value;
         };
 
-        $normalize_storage = function (Options $options, $value) use ($name) {
+        $normalize_storage = function(Options $options, $value) use ($name) {
             $default = [
                 'location' => 'parameter',
                 'domain' => 'midcom.helper.datamanager2',
@@ -227,7 +227,7 @@ 
             return $value;
         };
 
-        $normalize_validation = function (Options $options, $value) {
+        $normalize_validation = function(Options $options, $value) {
             $validation = [];
 
             foreach ((array) $value as $key => $rule) {
@@ -239,7 +239,7 @@ 
                     $rule = ['type' => $rule];
                 } elseif (!array_key_exists('type', $rule)) {
                     throw new midcom_error("Missing validation rule type for rule {$key} on field {$options['name']}, this is a required option.");
-                } elseif (   $rule['type'] == 'compare'
+                } elseif ($rule['type'] == 'compare'
                           && !array_key_exists('compare_with', $rule)) {
                     throw new midcom_error("Missing compare_with option for compare type rule {$key} on field {$options['name']}, this is a required option.");
                 }