@@ -82,7 +82,7 @@ discard block |
||
| 82 | 82 | { |
| 83 | 83 | $entries = array_merge($this->get_status_entries(), $this->get_journal_entries()); |
| 84 | 84 | |
| 85 | - usort($entries, function ($a, $b) { |
|
| 85 | + usort($entries, function($a, $b) { |
|
| 86 | 86 | if ($a['timestamp'] == $b['timestamp']) { |
| 87 | 87 | return $b['order'] <=> $a['order']; |
| 88 | 88 | } |
@@ -116,8 +116,8 @@ discard block |
||
| 116 | 116 | 'order' => 3 |
| 117 | 117 | ]; |
| 118 | 118 | } |
| 119 | - if ( $this->invoice->due |
|
| 120 | - && ( ( $this->invoice->due < time() |
|
| 119 | + if ($this->invoice->due |
|
| 120 | + && (($this->invoice->due < time() |
|
| 121 | 121 | && $this->invoice->paid == 0) |
| 122 | 122 | || $this->invoice->due < $this->invoice->paid)) { |
| 123 | 123 | $entries[] = [ |
@@ -90,7 +90,7 @@ |
||
| 90 | 90 | $data['query'] = new org_openpsa_reports_query_dba($args[0]); |
| 91 | 91 | $data['query']->require_do('midgard:update'); |
| 92 | 92 | } else { |
| 93 | - $data['query']= new org_openpsa_reports_query_dba(); |
|
| 93 | + $data['query'] = new org_openpsa_reports_query_dba(); |
|
| 94 | 94 | $data['query']->component = $this->_component; |
| 95 | 95 | } |
| 96 | 96 | |
@@ -59,7 +59,7 @@ |
||
| 59 | 59 | |
| 60 | 60 | public function __set($name, $value) |
| 61 | 61 | { |
| 62 | - if ( $name == 'homepage' |
|
| 62 | + if ($name == 'homepage' |
|
| 63 | 63 | && !empty($value) |
| 64 | 64 | && $value != $this->homepage) { |
| 65 | 65 | $this->_register_prober = true; |
@@ -98,7 +98,7 @@ |
||
| 98 | 98 | |
| 99 | 99 | public function reverseTransform($array) |
| 100 | 100 | { |
| 101 | - if (!is_array($array) ) { |
|
| 101 | + if (!is_array($array)) { |
|
| 102 | 102 | throw new TransformationFailedException('Expected an array.'); |
| 103 | 103 | } |
| 104 | 104 | |
@@ -246,7 +246,7 @@ discard block |
||
| 246 | 246 | */ |
| 247 | 247 | public function set_assignee($assignee) : bool |
| 248 | 248 | { |
| 249 | - if ( is_a($assignee, midcom_core_user::class) |
|
| 249 | + if (is_a($assignee, midcom_core_user::class) |
|
| 250 | 250 | || is_a($assignee, midcom_core_group::class)) { |
| 251 | 251 | $this->assignee = $assignee->id; |
| 252 | 252 | } elseif (is_string($assignee)) { |
@@ -305,12 +305,12 @@ discard block |
||
| 305 | 305 | } |
| 306 | 306 | } |
| 307 | 307 | |
| 308 | - if ( !$this->is_magic_assignee() |
|
| 308 | + if (!$this->is_magic_assignee() |
|
| 309 | 309 | && !$this->get_assignee()) { |
| 310 | 310 | debug_add("The assignee identifier '{$this->assignee}' is invalid.", MIDCOM_LOG_INFO); |
| 311 | 311 | return false; |
| 312 | 312 | } |
| 313 | - if ( $this->assignee == 'OWNER' |
|
| 313 | + if ($this->assignee == 'OWNER' |
|
| 314 | 314 | && $this->privilegename == 'midgard:owner') { |
| 315 | 315 | debug_add("Tried to assign midgard:owner to the OWNER magic assignee, this is invalid.", MIDCOM_LOG_INFO); |
| 316 | 316 | return false; |
@@ -322,7 +322,7 @@ discard block |
||
| 322 | 322 | MIDCOM_LOG_INFO); |
| 323 | 323 | return false; |
| 324 | 324 | } |
| 325 | - if ( !$object->can_do('midgard:update') |
|
| 325 | + if (!$object->can_do('midgard:update') |
|
| 326 | 326 | || !$object->can_do('midgard:privileges')) { |
| 327 | 327 | debug_add("Insufficient privileges on the content object with the GUID '{$this->__guid}', midgard:update and midgard:privileges required.", |
| 328 | 328 | MIDCOM_LOG_INFO); |
@@ -143,7 +143,7 @@ |
||
| 143 | 143 | protected function save_attachment_list() : bool |
| 144 | 144 | { |
| 145 | 145 | if (!empty($this->config['widget_config']['sortable'])) { |
| 146 | - uasort($this->map, function ($a, $b) { |
|
| 146 | + uasort($this->map, function($a, $b) { |
|
| 147 | 147 | if ($a->metadata->score == $b->metadata->score) { |
| 148 | 148 | return strnatcasecmp($a->name, $b->name); |
| 149 | 149 | } |
@@ -84,7 +84,7 @@ discard block |
||
| 84 | 84 | net_nemein_rss_manage::add_toolbar_buttons($this->_node_toolbar, $this->_topic->can_do('midgard:create')); |
| 85 | 85 | } |
| 86 | 86 | |
| 87 | - if ( $this->_topic->can_do('midgard:update') |
|
| 87 | + if ($this->_topic->can_do('midgard:update') |
|
| 88 | 88 | && $this->_topic->can_do('midcom:component_config')) { |
| 89 | 89 | $buttons[] = $workflow->get_button('config/', [ |
| 90 | 90 | MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'), |
@@ -114,7 +114,7 @@ discard block |
||
| 114 | 114 | $this->_request_data['categories'] = explode(',', $this->_config->get('categories')); |
| 115 | 115 | |
| 116 | 116 | foreach ($this->_request_data['schemadb']->all() as $schema) { |
| 117 | - if ( $schema->has_field('categories') |
|
| 117 | + if ($schema->has_field('categories') |
|
| 118 | 118 | && $schema->get_field('categories')['type'] == 'select') { |
| 119 | 119 | // TODO: Merge schema local and component config categories? |
| 120 | 120 | $options = array_combine($this->_request_data['categories'], $this->_request_data['categories']); |
@@ -60,7 +60,7 @@ |
||
| 60 | 60 | */ |
| 61 | 61 | public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self |
| 62 | 62 | { |
| 63 | - if ( !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer)) |
|
| 63 | + if (!($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer)) |
|
| 64 | 64 | // check if the customerContact is set and has invoice_data |
| 65 | 65 | && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) { |
| 66 | 66 | $bd = new self(); |
@@ -26,7 +26,7 @@ |
||
| 26 | 26 | |
| 27 | 27 | private function load_controller() : controller |
| 28 | 28 | { |
| 29 | - if ( $this->_config->get('simple_name_handling') |
|
| 29 | + if ($this->_config->get('simple_name_handling') |
|
| 30 | 30 | && !midcom::get()->auth->admin) { |
| 31 | 31 | foreach ($this->_request_data['schemadb']->all() as $schema) { |
| 32 | 32 | $schema->get_field('name')['readonly'] = true; |