flack / openpsa

lib/midcom/services/cache/module/nap.php

Spacing +4 added lines, -4 removed lines

@@ -54,7 +54,7 @@ 
             // Get parent from DB and compare to catch moves
             if ($parent = $napobject[MIDCOM_NAV_OBJECT]->get_parent()) {
                 $parent_entry = $this->get_guid($parent->guid);
-                if (   $parent_entry
+                if ($parent_entry
                     && $parent_entry[MIDCOM_NAV_ID] != $cached_node_id) {
                     $this->backend->deleteItem($parent_entry[MIDCOM_NAV_ID] . '-leaves');
                 }
@@ -69,7 +69,7 @@ 
             $parent_id = $napobject[MIDCOM_NAV_NODEID];
             $parent_entry = $this->get_node($parent_id);
 
-            if (   $parent_entry
+            if ($parent_entry
                 && array_key_exists(MIDCOM_NAV_SUBNODES, $parent_entry)) {
                 unset($parent_entry[MIDCOM_NAV_SUBNODES]);
                 $this->put_node($parent_id, $parent_entry);
@@ -79,7 +79,7 @@ 
             if ($parent = $napobject[MIDCOM_NAV_OBJECT]->get_parent()) {
                 $parent_entry_from_object = $this->get_guid($parent->guid);
 
-                if (    !empty($parent_entry_from_object[MIDCOM_NAV_ID])
+                if (!empty($parent_entry_from_object[MIDCOM_NAV_ID])
                      && !empty($parent_entry[MIDCOM_NAV_ID])
                      && $parent_entry_from_object[MIDCOM_NAV_ID] != $parent_entry[MIDCOM_NAV_ID]) {
                     unset($parent_entry_from_object[MIDCOM_NAV_SUBNODES]);
@@ -105,7 +105,7 @@ 
             $nav = new midcom_helper_nav;
             if ($object instanceof midcom_db_topic) {
                 $napobject = $nav->get_node($object->id);
-            } elseif (   ($node = $nav->find_closest_topic($object))
+            } elseif (($node = $nav->find_closest_topic($object))
                       && $nodeobject = $nav->get_node($node->id)) {
                 $napobject = $nav->get_leaf($nodeobject[MIDCOM_NAV_ID] . '-' . $object->id);
             }

lib/midcom/exec/reindex.php

Spacing +2 added lines, -2 removed lines

@@ -47,7 +47,7 @@ 
 $reindex_topic_uri = midcom::get()->get_page_prefix() . 'midcom-exec-midcom/reindex_singlenode.php';
 
 $options = ['timeout' => 300];
-if (   !empty($_SERVER['PHP_AUTH_USER'])
+if (!empty($_SERVER['PHP_AUTH_USER'])
     && !empty($_SERVER['PHP_AUTH_PW'])) {
     $options['auth'] = ['user' => $_SERVER['PHP_AUTH_USER'], 'password' => $_SERVER['PHP_AUTH_PW']];
 }
@@ -65,7 +65,7 @@ 
             } else {
                 echo "OK.\n";
             }
-        }, function (TransferException $e) use ($uri) {
+        }, function(TransferException $e) use ($uri) {
             echo "failure.\n   Background processing failed, error: {$e->getMessage()}\n";
             echo "Url: " . $uri . "\n";
         })->wait();

lib/midcom/helper/reflector/tree.php

Spacing +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
     private static function _check_permissions(bool $deleted) : bool
     {
         // PONDER: Check for some generic user privilege instead  ??
-        if (   $deleted
+        if ($deleted
             && !midcom::get()->auth->admin
             && !midcom::get()->auth->is_component_sudo()) {
             debug_add('Non-admins are not allowed to list deleted objects', MIDCOM_LOG_ERROR);

lib/org/openpsa/user/handler/person/view.php

Spacing +2 added lines, -2 removed lines

@@ -25,7 +25,7 @@ 
         $this->add_breadcrumb('', $person->get_label());
 
         $auth = midcom::get()->auth;
-        if (   $person->guid == midcom::get()->auth->user->guid
+        if ($person->guid == midcom::get()->auth->user->guid
             || $auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
             $buttons = [];
             $workflow = $this->get_workflow('datamanager');
@@ -38,7 +38,7 @@ 
                 $delete_workflow = $this->get_workflow('delete', ['object' => $person]);
                 $buttons[] = $delete_workflow->get_button($this->router->generate('user_delete', ['guid' => $person->guid]));
             }
-            if (   $data['account']->get_username()
+            if ($data['account']->get_username()
                 && $person->can_do('midgard:privileges')) {
                 $buttons[] = $workflow->get_button($this->router->generate('user_privileges', ['guid' => $person->guid]), [
                     MIDCOM_TOOLBAR_LABEL => $this->_l10n->get("permissions"),

lib/org/openpsa/relatedto/finder.php

Spacing +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
             }
         }
 
-        if (   empty($link->toComponent)
+        if (empty($link->toComponent)
             && !empty($link->fromComponent)) {
             debug_add("Setting property 'toComponent' to '{$component}'");
             $link->toComponent = $component;
@@ -61,7 +61,7 @@ 
             $link->fromComponent = $component;
         }
 
-        if (   empty($link->toGuid)
+        if (empty($link->toGuid)
             && !empty($link->fromGuid)) {
             $link->toClass = get_class($obj);
             $link->toGuid = $obj->guid;

lib/org/openpsa/sales/calculator/default.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 
     private function get_units($units = false) : float
     {
-        if (   $this->deliverable->invoiceByActualUnits
+        if ($this->deliverable->invoiceByActualUnits
             || $this->deliverable->plannedUnits == 0) {
             // In most cases we calculate the price based on the actual units entered
             return $units ?: $this->deliverable->units;

lib/org/openpsa/sales/salesproject/deliverable.php

Spacing +7 added lines, -7 removed lines

@@ -71,7 +71,7 @@ 
     {
         $this->calculate_price(false);
 
-        if (   $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
+        if ($this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
             && $this->continuous) {
             $this->end = 0;
         } elseif ($this->end < $this->start) {
@@ -138,7 +138,7 @@ 
         $calculator->run($this);
         $cost = $calculator->get_cost();
         $price = $calculator->get_price();
-        if (   $price != $this->price
+        if ($price != $this->price
             || $cost != $this->cost) {
             $this->price = $price;
             $this->cost = $cost;
@@ -178,7 +178,7 @@ 
         $units = $hours['invoiceable'];
         $uninvoiceableUnits = $hours['reported'] - ($hours['invoiceable'] + $hours['invoiced']);
 
-        if (   $units != $this->units
+        if ($units != $this->units
             || $uninvoiceableUnits != $this->uninvoiceableUnits) {
             debug_add("agreement values have changed, setting units to " . $units . ", uninvoiceable: " . $uninvoiceableUnits);
             $this->units = $units;
@@ -229,11 +229,11 @@ 
                 break;
             case 'q':
                 // Quarterly recurring subscription
-                $identifier = ceil(((int)$date->format('n')) / 4) . 'Q' . $date->format('y');
+                $identifier = ceil(((int) $date->format('n')) / 4) . 'Q' . $date->format('y');
                 break;
             case 'hy':
                 // Half-yearly recurring subscription
-                $identifier = ceil(((int)$date->format('n')) / 6) . '/' . $date->format('Y');
+                $identifier = ceil(((int) $date->format('n')) / 6) . '/' . $date->format('Y');
                 break;
             case 'y':
                 // Yearly recurring subscription
@@ -261,7 +261,7 @@ 
 
     public function invoice() : bool
     {
-        if (   $this->state >= self::STATE_INVOICED
+        if ($this->state >= self::STATE_INVOICED
             || $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
             return false;
         }
@@ -364,7 +364,7 @@ 
             midcom::get()->uimessages->add(midcom::get()->i18n->get_string('org.openpsa.sales', 'org.openpsa.sales'), sprintf(midcom::get()->i18n->get_string('marked deliverable "%s" delivered', 'org.openpsa.sales'), $this->title));
 
             // Check if we need to create task or ship goods
-            if (   $update_deliveries
+            if ($update_deliveries
                 && $product->orgOpenpsaObtype === org_openpsa_products_product_dba::TYPE_SERVICE) {
                 // Change status of tasks connected to the deliverable
                 $qb = org_openpsa_projects_task_dba::new_query_builder();

lib/org/openpsa/documents/elFinderVolumeOpenpsa.php

Spacing +7 added lines, -7 removed lines

@@ -67,7 +67,7 @@ 
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_MIME, '(' . $mime . ')');
         }
 
-        $tmpsize = (int)sprintf('%u', filesize($tmpname));
+        $tmpsize = (int) sprintf('%u', filesize($tmpname));
         if ($this->uploadMaxSize > 0 && $tmpsize > $this->uploadMaxSize) {
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_SIZE);
         }
@@ -250,7 +250,7 @@ 
         $output = [$object->get_label()];
 
         $parent = $object->get_parent();
-        while (   $parent
+        while ($parent
                && $parent->component == 'org.openpsa.documents') {
             $output[] = $parent->extra;
             $parent = $parent->get_parent();
@@ -347,12 +347,12 @@ 
             $data['mime'] = 'directory';
         }
 
-        if (   $owner
+        if ($owner
             && $group = midcom::get()->auth->get_assignee($owner)) {
             $data['group'] = $group->name;
         }
 
-        if (   $this->root !== $path
+        if ($this->root !== $path
             && $parent = $object->get_parent()) {
             $data['phash'] = $this->encode($parent->guid);
         }
@@ -411,7 +411,7 @@ 
      * @param  string $mode open mode
      * @return resource|false
      */
-    protected function _fopen($path, $mode="rb")
+    protected function _fopen($path, $mode = "rb")
     {
         $document = org_openpsa_documents_document_dba::get_cached($path);
         $attachments = blobs::get_attachments($document, 'document');
@@ -429,7 +429,7 @@ 
      * @param  string    $path  file path
      * @return bool
      */
-    protected function _fclose($fp, $path='')
+    protected function _fclose($fp, $path = '')
     {
         fclose($fp);
         return true;
@@ -611,7 +611,7 @@ 
     {
         $filename = midcom_db_attachment::safe_filename($name);
         $att = $doc->create_attachment($filename, $name, $mimetype);
-        if (   !$att
+        if (!$att
             || !$att->copy_from_handle($fp)) {
             return false;
         }

src/midcom/datamanager/extension/type/schemaType.php

Spacing +5 added lines, -5 removed lines

@@ -35,11 +35,11 @@ 
         $resolver
             ->setRequired('schema')
             ->setAllowedTypes('schema', [schema::class, 'string'])
-            ->setDefault('action', function (Options $options, $value) {
+            ->setDefault('action', function(Options $options, $value) {
                 return $options['schema']->get('action');
             });
 
-        $resolver->setNormalizer('csrf_protection', function (Options $options, $value) {
+        $resolver->setNormalizer('csrf_protection', function(Options $options, $value) {
             foreach ($options['schema']->get('fields') as $config) {
                 if ($config['widget'] === 'csrf') {
                     return true;
@@ -47,7 +47,7 @@ 
             }
             return false;
         });
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
             $validation = $options['schema']->get('validation');
             if (!empty($validation)) {
                 $cb_wrapper = new cb_wrapper($validation);
@@ -55,7 +55,7 @@ 
             }
             return $value;
         });
-        $resolver->setNormalizer('schema', function (Options $options, $value) {
+        $resolver->setNormalizer('schema', function(Options $options, $value) {
             if (is_string($value)) {
                 $schemadb = schemadb::from_path($value);
                 return $schemadb->get_first();
@@ -80,7 +80,7 @@ 
         // this is mainly there to skip validation in case the user pressed cancel
         $builder->addEventListener(FormEvents::POST_SUBMIT, function(PostSubmitEvent $event) {
             $form = $event->getForm();
-            if (   $form instanceof Form
+            if ($form instanceof Form
                 && $form->getClickedButton()
                 && $form->getClickedButton()->getConfig()->getOption('operation') == controller::CANCEL) {
                 $event->stopPropagation();