flack / openpsa

lib/org/openpsa/sales/calculator/default.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 
     private function get_units($units = false) : float
     {
-        if (   $this->deliverable->invoiceByActualUnits
+        if ($this->deliverable->invoiceByActualUnits
             || $this->deliverable->plannedUnits == 0) {
             // In most cases we calculate the price based on the actual units entered
             return $units ?: $this->deliverable->units;

lib/org/openpsa/sales/midcom/interfaces.php

Braces +8 added lines, -4 removed lines

@@ -31,7 +31,8 @@ 
             try {
                 $agreement = new org_openpsa_sales_salesproject_deliverable_dba($agreement);
                 $agreement->update_units();
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }
@@ -49,7 +50,8 @@ 
 
         try {
             $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($args['deliverable']);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $handler->print_error("Deliverable {$args['deliverable']} not found: " . midcom_connection::get_error_string());
             return false;
         }
@@ -69,7 +71,8 @@ 
         }
         try {
             $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($args['deliverable']);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $handler->print_error('no deliverable with passed GUID: ' . $args['deliverable'] . ', aborting');
             return false;
         }
@@ -77,7 +80,8 @@ 
         //get the owner of the salesproject the deliverable belongs to
         try {
             $project = new org_openpsa_sales_salesproject_dba($deliverable->salesproject);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $handler->print_error('Failed to load salesproject: ' . $e->getMessage());
             return false;
         }

lib/org/openpsa/contacts/handler.php

Spacing +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
         $prefix = $nap->get_node($this->_topic->id)[MIDCOM_NAV_ABSOLUTEURL];
 
         $tree = new org_openpsa_widgets_tree(org_openpsa_contacts_group_dba::class, 'owner');
-        $tree->link_callback = function ($guid) use ($prefix) {
+        $tree->link_callback = function($guid) use ($prefix) {
             return $prefix . 'group/' . $guid . '/';
         };
         $tree->constraints[] = ['orgOpenpsaObtype', '<', org_openpsa_contacts_group_dba::ORGANIZATION];
@@ -43,7 +43,7 @@ 
     {
         $my_company_guid = $this->_config->get('owner_organization');
 
-        if (   empty($my_company_guid)
+        if (empty($my_company_guid)
             || !mgd_is_guid($my_company_guid)) {
             if (midcom::get()->auth->admin) {
                 midcom::get()->uimessages->add(

lib/org/openpsa/sales/style/show-salesproject-grid.php

Braces +6 added lines, -3 removed lines

@@ -31,7 +31,8 @@ 
                 if ($data['contacts_url']) {
                     $row['customer'] = "<a href=\"{$data['contacts_url']}group/{$customer->guid}/\">{$label}</a>";
                 }
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }
@@ -44,7 +45,8 @@ 
             $contact_widget = org_openpsa_widgets_contact::get($salesproject->customerContact);
             $row['index_customerContact'] = $customer->get_label();
             $row['customerContact'] = $contact_widget->show_inline();
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
     }
@@ -56,7 +58,8 @@ 
         $owner_widget = org_openpsa_widgets_contact::get($salesproject->owner);
         $row['index_owner'] = $owner->rname;
         $row['owner'] = $owner_widget->show_inline();
-    } catch (midcom_error $e) {
+    }
+    catch (midcom_error $e) {
         $row['index_owner'] = '';
         $row['owner'] = '';
     }

lib/org/openpsa/expenses/handler/index.php

Braces +4 added lines, -2 removed lines

@@ -102,7 +102,8 @@ 
         foreach ($hours as $guid => $row) {
             try {
                 $task = org_openpsa_projects_task_dba::get_cached($row['task']);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 // Task couldn't be loaded, probably because of ACL
                 continue;
             }
@@ -115,7 +116,8 @@ 
                     $person_object = midcom_db_person::get_cached($row['person']);
                     $person_label = $this->_get_list_link($person_object->name, null, null, $row['person']);
                     $person_name = $person_object->name;
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     $person_label = $this->_l10n->get('no person');
                     $person_name = '';
                 }

lib/org/openpsa/sales/salesproject/deliverable.php

Spacing +7 added lines, -7 removed lines

@@ -71,7 +71,7 @@ 
     {
         $this->calculate_price(false);
 
-        if (   $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
+        if ($this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
             && $this->continuous) {
             $this->end = 0;
         } elseif ($this->end < $this->start) {
@@ -138,7 +138,7 @@ 
         $calculator->run($this);
         $cost = $calculator->get_cost();
         $price = $calculator->get_price();
-        if (   $price != $this->price
+        if ($price != $this->price
             || $cost != $this->cost) {
             $this->price = $price;
             $this->cost = $cost;
@@ -178,7 +178,7 @@ 
         $units = $hours['invoiceable'];
         $uninvoiceableUnits = $hours['reported'] - ($hours['invoiceable'] + $hours['invoiced']);
 
-        if (   $units != $this->units
+        if ($units != $this->units
             || $uninvoiceableUnits != $this->uninvoiceableUnits) {
             debug_add("agreement values have changed, setting units to " . $units . ", uninvoiceable: " . $uninvoiceableUnits);
             $this->units = $units;
@@ -229,11 +229,11 @@ 
                 break;
             case 'q':
                 // Quarterly recurring subscription
-                $identifier = ceil(((int)$date->format('n')) / 4) . 'Q' . $date->format('y');
+                $identifier = ceil(((int) $date->format('n')) / 4) . 'Q' . $date->format('y');
                 break;
             case 'hy':
                 // Half-yearly recurring subscription
-                $identifier = ceil(((int)$date->format('n')) / 6) . '/' . $date->format('Y');
+                $identifier = ceil(((int) $date->format('n')) / 6) . '/' . $date->format('Y');
                 break;
             case 'y':
                 // Yearly recurring subscription
@@ -261,7 +261,7 @@ 
 
     public function invoice() : bool
     {
-        if (   $this->state >= self::STATE_INVOICED
+        if ($this->state >= self::STATE_INVOICED
             || $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
             return false;
         }
@@ -364,7 +364,7 @@ 
             midcom::get()->uimessages->add(midcom::get()->i18n->get_string('org.openpsa.sales', 'org.openpsa.sales'), sprintf(midcom::get()->i18n->get_string('marked deliverable "%s" delivered', 'org.openpsa.sales'), $this->title));
 
             // Check if we need to create task or ship goods
-            if (   $update_deliveries
+            if ($update_deliveries
                 && $product->orgOpenpsaObtype === org_openpsa_products_product_dba::TYPE_SERVICE) {
                 // Change status of tasks connected to the deliverable
                 $qb = org_openpsa_projects_task_dba::new_query_builder();

src/midcom/datamanager/extension/type/schemaType.php

Spacing +5 added lines, -5 removed lines

@@ -35,11 +35,11 @@ 
         $resolver
             ->setRequired('schema')
             ->setAllowedTypes('schema', [schema::class, 'string'])
-            ->setDefault('action', function (Options $options, $value) {
+            ->setDefault('action', function(Options $options, $value) {
                 return $options['schema']->get('action');
             });
 
-        $resolver->setNormalizer('csrf_protection', function (Options $options, $value) {
+        $resolver->setNormalizer('csrf_protection', function(Options $options, $value) {
             foreach ($options['schema']->get('fields') as $config) {
                 if ($config['widget'] === 'csrf') {
                     return true;
@@ -47,7 +47,7 @@ 
             }
             return false;
         });
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
             $validation = $options['schema']->get('validation');
             if (!empty($validation)) {
                 $cb_wrapper = new cb_wrapper($validation);
@@ -55,7 +55,7 @@ 
             }
             return $value;
         });
-        $resolver->setNormalizer('schema', function (Options $options, $value) {
+        $resolver->setNormalizer('schema', function(Options $options, $value) {
             if (is_string($value)) {
                 $schemadb = schemadb::from_path($value);
                 return $schemadb->get_first();
@@ -80,7 +80,7 @@ 
         // this is mainly there to skip validation in case the user pressed cancel
         $builder->addEventListener(FormEvents::POST_SUBMIT, function(PostSubmitEvent $event) {
             $form = $event->getForm();
-            if (   $form instanceof Form
+            if ($form instanceof Form
                 && $form->getClickedButton()
                 && $form->getClickedButton()->getConfig()->getOption('operation') == controller::CANCEL) {
                 $event->stopPropagation();

src/midcom/datamanager/extension/type/subformType.php

Spacing +3 added lines, -3 removed lines

@@ -38,7 +38,7 @@ 
                 'max_count' => 0
             ]
         ]);
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
             $validation = [];
             if ($options['type_config']['max_count'] > 0) {
                 $validation['max'] = $options['type_config']['max_count'];
@@ -51,12 +51,12 @@ 
             }
             return $validation;
         });
-        $resolver->setNormalizer('entry_options', function (Options $options, $value) {
+        $resolver->setNormalizer('entry_options', function(Options $options, $value) {
             return array_replace([
                 'widget_config' => $options['widget_config']
             ], (array) $value);
         });
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
             if (!array_key_exists('sortable', $value)) {
                 $value['sortable'] = false;
             }

lib/org/openpsa/user/handler/person/privileges.php

Spacing +2 added lines, -2 removed lines

@@ -23,9 +23,9 @@
         $schemadb = schemadb::from_path($this->_config->get('schemadb_acl'));
 
         // Get the calendar root event
-        if (   class_exists('org_openpsa_calendar_interface')
+        if (class_exists('org_openpsa_calendar_interface')
             && $root_event = org_openpsa_calendar_interface::find_root_event()) {
-            $field =& $schemadb->get('default')->get_field('calendar');
+            $field = & $schemadb->get('default')->get_field('calendar');
             $field['type_config']['privilege_object'] = $root_event;
             $field['type_config']['assignee'] = 'user:' . $person->guid;
         }