flack / openpsa

lib/org/openpsa/user/validator.php

Spacing +3 added lines, -3 removed lines

@@ -47,7 +47,7 @@ 
         $result = $this->is_username_available($fields);
 
         $accounthelper = new org_openpsa_user_accounthelper();
-        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])){
+        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])) {
             $result = ['password' => midcom::get()->i18n->get_string('password weak', 'org.openpsa.user')];
         }
 
@@ -149,10 +149,10 @@ 
         $user = new midcom_db_person($fields["person"]);
 
         $accounthelper = new org_openpsa_user_accounthelper($user);
-        if (!$accounthelper->check_password_reuse($fields['new_password'])){
+        if (!$accounthelper->check_password_reuse($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password was already used', 'org.openpsa.user');
         }
-        if (!$accounthelper->check_password_strength($fields['new_password'])){
+        if (!$accounthelper->check_password_strength($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password weak', 'org.openpsa.user');
         }
         return $result ?: true;

Braces +3 added lines, -3 removed lines

@@ -47,7 +47,7 @@ 
         $result = $this->is_username_available($fields);
 
         $accounthelper = new org_openpsa_user_accounthelper();
-        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])){
+        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])) {
             $result = ['password' => midcom::get()->i18n->get_string('password weak', 'org.openpsa.user')];
         }
 
@@ -149,10 +149,10 @@ 
         $user = new midcom_db_person($fields["person"]);
 
         $accounthelper = new org_openpsa_user_accounthelper($user);
-        if (!$accounthelper->check_password_reuse($fields['new_password'])){
+        if (!$accounthelper->check_password_reuse($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password was already used', 'org.openpsa.user');
         }
-        if (!$accounthelper->check_password_strength($fields['new_password'])){
+        if (!$accounthelper->check_password_strength($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password weak', 'org.openpsa.user');
         }
         return $result ?: true;

lib/org/openpsa/products/product/group.php

Spacing +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
         }
 
         $result_cache[$cache_key] = [];
-        $ret =& $result_cache[$cache_key];
+        $ret = & $result_cache[$cache_key];
 
         if (empty($up)) {
             // TODO: use reflection to see what kind of property this is ?

lib/org/openpsa/relatedto/handler/journal/list.php

Spacing +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
             }
 
             $reflector = midcom_helper_reflector::get($linked_object);
-            $link_html = "<a href='" . midcom::get()->permalinks->create_permalink($linked_object->guid) . "'>" . $reflector->get_object_label($linked_object) ."</a>";
+            $link_html = "<a href='" . midcom::get()->permalinks->create_permalink($linked_object->guid) . "'>" . $reflector->get_object_label($linked_object) . "</a>";
             $data['linked_objects'][$entry->linkGuid] = $link_html;
             $data['linked_raw_objects'][$entry->linkGuid] = $reflector->get_object_label($linked_object);
         }

Braces +2 added lines, -1 removed lines

@@ -142,7 +142,8 @@
             //create reflector with linked object to get the right label
             try {
                 $linked_object = midcom::get()->dbfactory->get_object_by_guid($entry->linkGuid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 unset($data['entries'][$i]);
                 $e->log();
                 continue;

lib/org/openpsa/mail/template.php

Spacing +1 added lines, -1 removed lines

@@ -103,7 +103,7 @@
         foreach ($parameters as $key => $value) {
             $this->_patterns[] = "/__({$key})__/";
 
-            if (   is_array($value)
+            if (is_array($value)
                 || is_object($value)) {
                 $this->_patterns[] = "/__({$key})_([^ \.>\"-]*?)__/";
             }

lib/midcom/helper/imagefilter.php

Spacing +3 added lines, -3 removed lines

@@ -341,7 +341,7 @@ 
         $tmpfile = null;
         $imagesize = getimagesize($this->_filename);
 
-        if (   $imagesize[2] == IMAGETYPE_JPEG
+        if ($imagesize[2] == IMAGETYPE_JPEG
             && $this->_jpegtran_available()) {
             /* jpegtran */
             $operations = [
@@ -409,7 +409,7 @@ 
         $imagesize = getimagesize($this->_filename);
 
         // Try lossless jpegtran rotation if possible
-        if (   $imagesize[2] == IMAGETYPE_JPEG
+        if ($imagesize[2] == IMAGETYPE_JPEG
             && ($rotate % 90 == 0)
             && $this->_jpegtran_available()) {
             $tmpfile = $this->_get_tempfile();
@@ -539,7 +539,7 @@ 
      */
     public function fill($x = null, $y = null, $color = null, string $gravity = 'center')
     {
-        if (   empty($x)
+        if (empty($x)
             || empty($y)
             || empty($color)) {
             //This is a bit silly, but here for backwards compatibility...

lib/org/openpsa/invoices/invoice/pdf.php

Spacing +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
             $attachment->update();
         } else {
             $attachment = $this->invoice->create_attachment($filename, $this->invoice->get_label(), "application/pdf");
-            if (   !$attachment
+            if (!$attachment
                 || !$this->invoice->set_parameter("midcom.helper.datamanager2.type.blobs", "guids_pdf_file", $attachment->guid . ":" . $attachment->guid)) {
                 throw new midcom_error("Failed to create invoice attachment for pdf: " . midcom_connection::get_error_string());
             }

lib/midcom/services/i18n/l10n.php

Spacing +2 added lines, -2 removed lines

@@ -131,7 +131,7 @@ 
             self::$_localedb[$this->_library] = [];
         }
 
-        $this->_stringdb =& self::$_localedb[$this->_library];
+        $this->_stringdb = & self::$_localedb[$this->_library];
 
         $this->set_language(midcom::get()->i18n->get_current_language());
     }
@@ -256,7 +256,7 @@ 
     private function error(string $message, string $filename, int $line) : midcom_error
     {
         $line++; // Array is 0-indexed
-        return new midcom_error('L10n DB SYNTAX ERROR: ' .  $message . ' at ' . $filename . ' ' . $line);
+        return new midcom_error('L10n DB SYNTAX ERROR: ' . $message . ' at ' . $filename . ' ' . $line);
     }
 
     /**

lib/midgard/admin/asgard/handler/object/permissions.php

Spacing +2 added lines, -2 removed lines

@@ -92,7 +92,7 @@ 
         $tmp = $this->_object;
 
         $i = 0;
-        while (   !empty($tmp->guid)
+        while (!empty($tmp->guid)
                && !is_a($tmp, midcom_db_topic::class)
                && $i < 100) {
             // Get the parent; wishing eventually to get a topic
@@ -137,7 +137,7 @@ 
 
         $assignees = $this->load_assignees();
         $this->process_assignees($assignees, $schemadb);
-        $assignee_field =& $schemadb->get('privileges')->get_field('add_assignee');
+        $assignee_field = & $schemadb->get('privileges')->get_field('add_assignee');
 
         if (!$this->additional_assignee) {
             // Populate additional assignee selector

lib/midgard/admin/asgard/handler/undelete.php

Spacing +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
             $child_indent = $indent + 20;
             echo "{$prefix}<tbody class=\"children\">\n";
             foreach ($child_types as $type => $children) {
-                if (   count($children) < 10
+                if (count($children) < 10
                     || isset($_GET['show_children'][$object->guid][$type])) {
                         foreach ($children as $child) {
                             $this->show_type($child, $child_indent, "{$prefix}    ", false);