@@ -58,7 +58,7 @@ discard block |
||
| 58 | 58 | $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]); |
| 59 | 59 | $response = $workflow->run($request); |
| 60 | 60 | |
| 61 | - if ( $workflow->get_state() == 'save' |
|
| 61 | + if ($workflow->get_state() == 'save' |
|
| 62 | 62 | && $this->create_account($this->person, $data["controller"]->get_form_values())) { |
| 63 | 63 | midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), sprintf($this->_l10n->get('person %s created'), $this->person->name)); |
| 64 | 64 | } |
@@ -148,7 +148,7 @@ discard block |
||
| 148 | 148 | $accounthelper = new org_openpsa_user_accounthelper($this->person); |
| 149 | 149 | |
| 150 | 150 | // Update account |
| 151 | - if ( !$accounthelper->set_account($controller->get_form_values()["username"], $password) |
|
| 151 | + if (!$accounthelper->set_account($controller->get_form_values()["username"], $password) |
|
| 152 | 152 | && midcom_connection::get_error() != MGD_ERR_OK) { |
| 153 | 153 | // Failure, give a message |
| 154 | 154 | midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), $this->_l10n->get("failed to update the user account, reason") . ': ' . midcom_connection::get_error_string(), 'error'); |
@@ -70,13 +70,13 @@ discard block |
||
| 70 | 70 | } |
| 71 | 71 | } elseif (!$this->form->isSubmitted()) { |
| 72 | 72 | $this->form->handleRequest($request); |
| 73 | - if ( $this->form->isSubmitted() |
|
| 73 | + if ($this->form->isSubmitted() |
|
| 74 | 74 | && $button = $this->form->getClickedButton()) { |
| 75 | 75 | $operation = $button->getConfig()->getOption('operation'); |
| 76 | 76 | } |
| 77 | 77 | } |
| 78 | 78 | |
| 79 | - if ( in_array($operation, [self::SAVE, self::NEXT]) |
|
| 79 | + if (in_array($operation, [self::SAVE, self::NEXT]) |
|
| 80 | 80 | && !$this->form->isValid()) { |
| 81 | 81 | $operation = self::EDIT; |
| 82 | 82 | } |
@@ -159,7 +159,7 @@ discard block |
||
| 159 | 159 | if ($storage->get_last_operation() === self::SAVE) { |
| 160 | 160 | // Get GUIDs and such for new-created dependent objects |
| 161 | 161 | $this->dm->set_storage($storage->get_value(), $this->dm->get_schema()->get_name()); |
| 162 | - } elseif ( !$this->form->isValid() |
|
| 162 | + } elseif (!$this->form->isValid() |
|
| 163 | 163 | && $storage->move_uploaded_files() > 0) { |
| 164 | 164 | $form = $this->dm->get_form($this->form->getName(), true); |
| 165 | 165 | $this->copy_errors($this->form, $form); |
@@ -18,7 +18,7 @@ discard block |
||
| 18 | 18 | $item->title = $data['article']->title; |
| 19 | 19 | $arg = $data['article']->name ?: $data['article']->guid; |
| 20 | 20 | |
| 21 | -if ( $data['config']->get('link_to_external_url') |
|
| 21 | +if ($data['config']->get('link_to_external_url') |
|
| 22 | 22 | && !empty($data['article']->url)) { |
| 23 | 23 | $item->link = $data['article']->url; |
| 24 | 24 | } else { |
@@ -37,7 +37,7 @@ discard block |
||
| 37 | 37 | $item->description .= '<div class="abstract">' . $view['abstract'] . '</div>'; |
| 38 | 38 | } |
| 39 | 39 | |
| 40 | -if ( array_key_exists('image', $view) |
|
| 40 | +if (array_key_exists('image', $view) |
|
| 41 | 41 | && $data['config']->get('rss_use_image')) { |
| 42 | 42 | $item->description .= "\n<div class=\"image\">" . $view['image'] . '</div>'; |
| 43 | 43 | } |
@@ -68,7 +68,7 @@ |
||
| 68 | 68 | echo " <td class=\"numeric\"><span title=\"" . $data['l10n']->get('ongoing') . "\">{$task_count['ongoing']}</span></td>\n"; |
| 69 | 69 | echo " <td class=\"numeric\"><span title=\"" . $data['l10n']->get('on_hold') . "\">{$task_count['on_hold']}</span></td>\n"; |
| 70 | 70 | echo " <td class=\"numeric\"><span title=\"" . $data['l10n']->get('closed') . "\">{$task_count['closed']}</span></td>\n"; |
| 71 | - echo " <td class=\"numeric\"> " ; |
|
| 71 | + echo " <td class=\"numeric\"> "; |
|
| 72 | 72 | echo " <span title=\"" . $data['l10n']->get('reported') . "\">" . round($hours['reportedHours'], 2) . "</span>"; |
| 73 | 73 | if ($hours['plannedHours'] > 0) { |
| 74 | 74 | echo " / <span title=\"" . $data['l10n']->get('planned hours') . "\">" . round($hours['plannedHours'], 2) . "</span>"; |
@@ -101,7 +101,7 @@ |
||
| 101 | 101 | |
| 102 | 102 | $this->_controller = $this->load_controller(); |
| 103 | 103 | |
| 104 | - if ( $data['enable_versioning'] |
|
| 104 | + if ($data['enable_versioning'] |
|
| 105 | 105 | && $request->request->count() > 0) { |
| 106 | 106 | $this->_backup_attachment(); |
| 107 | 107 | } |
@@ -50,7 +50,7 @@ |
||
| 50 | 50 | } |
| 51 | 51 | |
| 52 | 52 | // Skip components beginning with midcom or midgard |
| 53 | - if ( preg_match('/^(midcom|midgard)\./', $manifest->name) |
|
| 53 | + if (preg_match('/^(midcom|midgard)\./', $manifest->name) |
|
| 54 | 54 | && $manifest->name != 'midcom.helper.search') { |
| 55 | 55 | continue; |
| 56 | 56 | } |
@@ -223,7 +223,7 @@ discard block |
||
| 223 | 223 | return $this->render_link($parts[1], $parts[2]) . $after; |
| 224 | 224 | |
| 225 | 225 | // Macro [something: <data>] (for example [abbr: BOFH - Bastard Operator From Hell] or [photo: <GUID>]) |
| 226 | - case ( preg_match('/^(.*?): (.*)/', $fulltext, $macro_parts) |
|
| 226 | + case (preg_match('/^(.*?): (.*)/', $fulltext, $macro_parts) |
|
| 227 | 227 | && method_exists($this, "_run_macro_{$macro_parts[1]}")): |
| 228 | 228 | $method = "_run_macro_{$macro_parts[1]}"; |
| 229 | 229 | return $this->$method($macro_parts[2], $match[0], $after); |
@@ -256,7 +256,7 @@ discard block |
||
| 256 | 256 | $folder = $wikipage_match['latest_parent']; |
| 257 | 257 | } |
| 258 | 258 | |
| 259 | - if ( isset($folder[MIDCOM_NAV_OBJECT]) |
|
| 259 | + if (isset($folder[MIDCOM_NAV_OBJECT]) |
|
| 260 | 260 | && $folder[MIDCOM_NAV_OBJECT]->can_do('midgard:create')) { |
| 261 | 261 | $workflow = $this->get_workflow('datamanager'); |
| 262 | 262 | return "<a href=\"{$folder[MIDCOM_NAV_ABSOLUTEURL]}create/?wikiword={$wikipage_match['remaining_path']}\" " . $workflow->render_attributes() . " class=\"wiki_missing\" title=\"" . $this->_l10n->get('click to create') . "\">{$text}</a>"; |
@@ -291,7 +291,7 @@ discard block |
||
| 291 | 291 | $links[$parts[1]] = $parts[2]; |
| 292 | 292 | } |
| 293 | 293 | // Ignore macros [something: <data>] (for example [abbr: BOFH - Bastard Operator From Hell] or [photo: <GUID>]) |
| 294 | - elseif ( !preg_match('/^(.*?): (.*)/', $fulltext, $macro_parts) |
|
| 294 | + elseif (!preg_match('/^(.*?): (.*)/', $fulltext, $macro_parts) |
|
| 295 | 295 | || !method_exists($this, "_run_macro_{$macro_parts[1]}")) { |
| 296 | 296 | // MediaWiki-style link [wikipage] (no text) |
| 297 | 297 | $links[$fulltext] = $fulltext; |
@@ -3,7 +3,7 @@ discard block |
||
| 3 | 3 | $state = $data['deliverable']->get_state(); |
| 4 | 4 | $formatter = $data['l10n']->get_formatter(); |
| 5 | 5 | $per_unit = $data['l10n']->get('per unit'); |
| 6 | -if ( $data['product'] |
|
| 6 | +if ($data['product'] |
|
| 7 | 7 | && $unit_option = org_openpsa_sales_viewer::get_unit_option($data['product']->unit)) { |
| 8 | 8 | $per_unit = sprintf($data['l10n']->get('per %s'), $unit_option); |
| 9 | 9 | } |
@@ -115,7 +115,7 @@ discard block |
||
| 115 | 115 | </div> |
| 116 | 116 | <?php |
| 117 | 117 | $tabs = []; |
| 118 | - if ( $data['invoices_url'] |
|
| 118 | + if ($data['invoices_url'] |
|
| 119 | 119 | && $data['deliverable']->invoiced > 0) { |
| 120 | 120 | $tabs[] = [ |
| 121 | 121 | 'url' => $data['invoices_url'] . "list/deliverable/{$data['deliverable']->guid}/", |
@@ -123,7 +123,7 @@ discard block |
||
| 123 | 123 | ]; |
| 124 | 124 | } |
| 125 | 125 | |
| 126 | - if ( $data['projects_url'] |
|
| 126 | + if ($data['projects_url'] |
|
| 127 | 127 | && $data['deliverable']->state >= org_openpsa_sales_salesproject_deliverable_dba::STATE_ORDERED |
| 128 | 128 | && $data['product'] |
| 129 | 129 | && $data['product']->orgOpenpsaObtype == org_openpsa_products_product_dba::TYPE_SERVICE) { |
@@ -19,8 +19,8 @@ |
||
| 19 | 19 | public function _on_initialize() |
| 20 | 20 | { |
| 21 | 21 | // Match / |
| 22 | - if ( $this->_config->get('redirection_type') === null |
|
| 23 | - || ( $this->_topic->can_do('net.nemein.redirector:noredirect') |
|
| 22 | + if ($this->_config->get('redirection_type') === null |
|
| 23 | + || ($this->_topic->can_do('net.nemein.redirector:noredirect') |
|
| 24 | 24 | && !$this->_config->get('admin_redirection'))) { |
| 25 | 25 | $this->_request_switch['redirect'] = [ |
| 26 | 26 | 'handler' => [net_nemein_redirector_handler_tinyurl::class, 'list'], |