flack / openpsa

lib/org/openpsa/products/handler/product/create.php

Braces +2 added lines, -1 removed lines

@@ -63,7 +63,8 @@
         if ($group > 0) {
             try {
                 $this->parent = new org_openpsa_products_product_group_dba($group);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

lib/net/nehmer/blog/handler/view.php

Spacing +2 added lines, -2 removed lines

@@ -38,7 +38,7 @@ 
             ]);
         }
 
-        if (   $this->_article->topic === $this->_topic->id
+        if ($this->_article->topic === $this->_topic->id
             && $this->_article->can_do('midgard:delete')) {
             $delete = $this->get_workflow('delete', ['object' => $this->_article]);
             $buttons[] = $delete->get_button($this->router->generate('delete', ['guid' => $this->_article->guid]));
@@ -73,7 +73,7 @@ 
         if ($this->_config->get('comments_enable')) {
             if ($node = net_nehmer_comments_interface::get_node($this->_topic, $this->_config->get('comments_topic'))) {
                 $data['comments_url'] = $node[MIDCOM_NAV_RELATIVEURL] . "comment/{$this->_article->guid}/";
-                if (   $this->_topic->can_do('midgard:update')
+                if ($this->_topic->can_do('midgard:update')
                     && $this->_topic->can_do('net.nehmer.comments:moderation')) {
                     net_nehmer_comments_viewer::add_head_elements();
                 }

src/midcom/datamanager/helper/autocomplete.php

Spacing +4 added lines, -6 removed lines

@@ -76,7 +76,7 @@ 
     private function apply_constraints(midcom_core_query $query, array $constraints)
     {
         foreach ($constraints as $key => $data) {
-            if (   !array_key_exists('value', $data)
+            if (!array_key_exists('value', $data)
                 || empty($data['field'])
                 || empty($data['op'])) {
                 debug_add("Constraint #{$key} is not correctly defined, skipping", MIDCOM_LOG_WARN);
@@ -137,7 +137,7 @@ 
     {
         $query = $this->request["term"];
         $wildcard_query = $query;
-        if (   isset($this->request['auto_wildcards'])
+        if (isset($this->request['auto_wildcards'])
             && !str_contains($query, '%')) {
             switch ($this->request['auto_wildcards']) {
                 case 'start':
@@ -245,9 +245,7 @@ 
                 return $label;
             }
         }
-        return midcom_helper_reflector::get($object)->get_object_label($object) ?:
-            self::build_label($object, array_column($result_headers, 'name')) ?:
-            $object::class . ' #' . $object->id;
+        return midcom_helper_reflector::get($object)->get_object_label($object) ?: self::build_label($object, array_column($result_headers, 'name')) ?: $object::class . ' #' . $object->id;
     }
 
     private static function build_label($object, array $fields) : string
@@ -282,7 +280,7 @@ 
             }
             return self::sanitize_label($value);
         }
-        if (   $field == 'username'
+        if ($field == 'username'
             && $object instanceof midcom_db_person) {
             $account = new midcom_core_account($object);
             return self::sanitize_label($account->get_username());

lib/midcom/helper/reflector/nameresolver.php

Spacing +3 added lines, -3 removed lines

@@ -32,7 +32,7 @@ 
     public function get_object_name(?string $name_property = null) : ?string
     {
         $name_property ??= midcom_helper_reflector::get_name_property($this->_object);
-        if (    empty($name_property)
+        if (empty($name_property)
             || !midcom_helper_reflector::get($this->_object)->property_exists($name_property)) {
             // Could not resolve valid property
             return null;
@@ -124,7 +124,7 @@ 
 
             $qb->add_constraint($child_name_property, '=', $name);
             if ($qb->count()) {
-                debug_add("Name clash in sibling class {$schema_type} for " . $this->_object::class . " #{$this->_object->id} (path '" . midcom_helper_reflector_tree::resolve_path($this->_object, '/') . "')" );
+                debug_add("Name clash in sibling class {$schema_type} for " . $this->_object::class . " #{$this->_object->id} (path '" . midcom_helper_reflector_tree::resolve_path($this->_object, '/') . "')");
                 return false;
             }
         }
@@ -199,7 +199,7 @@ 
         } while (!$this->name_is_unique());
 
         // Get a copy of the current, usable name
-        $ret = (string)$this->_object->{$name_prop};
+        $ret = (string) $this->_object->{$name_prop};
         // Restore the original name
         $this->_object->{$name_prop} = $original_name;
         return $ret;

lib/midcom/services/rcs/handler.php

Spacing +3 added lines, -3 removed lines

@@ -46,7 +46,7 @@ 
     {
         $this->object = $this->load_object($guid);
 
-        if (   !midcom::get()->config->get('midcom_services_rcs_enable')
+        if (!midcom::get()->config->get('midcom_services_rcs_enable')
             || !$this->object->_use_rcs) {
             throw new midcom_error_notfound("Revision control not supported for " . $this->object::class . ".");
         }
@@ -257,7 +257,7 @@ 
             throw new midcom_error_notfound("Revision {$args[1]} does not exist.");
         }
 
-        $data['preview'] = array_filter($this->backend->get_revision($revision), function ($value, $key) {
+        $data['preview'] = array_filter($this->backend->get_revision($revision), function($value, $key) {
             return !is_array($value)
                 && !in_array($value, ['', '0000-00-00'])
                 && midcom_services_rcs::is_field_showable($key);
@@ -285,7 +285,7 @@ 
         $this->object->require_do('midgard:update');
         // TODO: set another privilege for restoring?
 
-        if (   $this->backend->get_history()->version_exists($args[1])
+        if ($this->backend->get_history()->version_exists($args[1])
             && $this->backend->restore_to_revision($args[1])) {
             midcom::get()->uimessages->add($this->_l10n->get('midcom.admin.rcs'), sprintf($this->_l10n->get('restore to version %s successful'), $args[1]));
             return new midcom_response_relocate($this->get_object_url());

lib/org/openpsa/relatedto/finder.php

Spacing +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
             }
         }
 
-        if (   empty($link->toComponent)
+        if (empty($link->toComponent)
             && !empty($link->fromComponent)) {
             debug_add("Setting property 'toComponent' to '{$component}'");
             $link->toComponent = $component;
@@ -61,7 +61,7 @@ 
             $link->fromComponent = $component;
         }
 
-        if (   empty($link->toGuid)
+        if (empty($link->toGuid)
             && !empty($link->fromGuid)) {
             $link->toClass = $obj::class;
             $link->toGuid = $obj->guid;

lib/org/openpsa/user/handler/person/privileges.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 
         // Get the calendar root event
         if (class_exists('org_openpsa_calendar_interface')) {
-            $field =& $schemadb->get('default')->get_field('calendar');
+            $field = & $schemadb->get('default')->get_field('calendar');
             $field['type_config']['privilege_object'] = org_openpsa_calendar_interface::find_root_event();
             $field['type_config']['assignee'] = 'user:' . $person->guid;
         }

lib/org/openpsa/user/handler/group/privileges.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 
         // Get the calendar root event
         if (class_exists('org_openpsa_calendar_interface')) {
-            $field =& $schemadb->get('default')->get_field('calendar');
+            $field = & $schemadb->get('default')->get_field('calendar');
             $field['type_config']['privilege_object'] = org_openpsa_calendar_interface::find_root_event();
             $field['type_config']['assignee'] = 'group:' . $group->guid;
         }

src/midcom/console/command/cleanup/parameters.php

Braces +2 added lines, -1 removed lines

@@ -52,7 +52,8 @@
                 try {
                     \midgard_object_class::get_object_by_guid($param->parentguid);
                     $seen[$param->parentguid] = true;
-                } catch (\Throwable) {
+                }
+                catch (\Throwable) {
                     $seen[$param->parentguid] = false;
                 }
             }