Passed
Push — master ( 05b81b...989dc8 )
by Andreas
12:34
created
lib/midcom/core/group.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,8 @@
 block discarded – undo
74 74
             }
75 75
             try {
76 76
                 $this->_storage = new midgard_group($id);
77
-            } catch (mgd_exception $e) {
77
+            }
78
+            catch (mgd_exception $e) {
78 79
                 debug_add('Tried to load a midgard_group, but got error ' . $e->getMessage(), MIDCOM_LOG_ERROR);
79 80
                 throw new midcom_error_midgard($e, $id);
80 81
             }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
      *
57 57
      * Any error will trigger midcom_error.
58 58
      */
59
-    public function __construct(string|int|midgard_group $id)
59
+    public function __construct(string | int | midgard_group $id)
60 60
     {
61 61
         if (is_object($id)) {
62 62
             $this->_storage = $id;
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler/feed.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
 
49 49
         if ($category) {
50 50
             // This is not a predefined category from configuration, check if site maintainer allows us to show it
51
-            if (   !in_array($category, $data['categories'])
51
+            if (!in_array($category, $data['categories'])
52 52
                 && !$this->_config->get('categories_custom_enable')) {
53 53
                 throw new midcom_error('Custom category support is disabled');
54 54
             }
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler/create.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
         $this->_topic->require_do('midgard:create');
30 30
 
31 31
         $schemadb = $data['schemadb'];
32
-        if (   $this->_config->get('simple_name_handling')
32
+        if ($this->_config->get('simple_name_handling')
33 33
             && !midcom::get()->auth->can_user_do('midcom:urlname')) {
34 34
             foreach ($schemadb->all() as $schema) {
35 35
                 $schema->get_field('name')['readonly'] = true;
Please login to merge, or discard this patch.
lib/net/nehmer/blog/style/feeds-item.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
 
18 18
 $item->title = $data['article']->title;
19 19
 
20
-if (   $data['config']->get('link_to_external_url')
20
+if ($data['config']->get('link_to_external_url')
21 21
     && !empty($data['article']->url)) {
22 22
     $item->link = $data['article']->url;
23 23
 } else {
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
     $item->description .= '<div class="abstract">' . $view['abstract'] . '</div>';
34 34
 }
35 35
 
36
-if (   array_key_exists('image', $view)
36
+if (array_key_exists('image', $view)
37 37
     && $data['config']->get('rss_use_image')) {
38 38
     $item->description .= "\n<div class=\"image\">" . $view['image'] . '</div>';
39 39
 }
Please login to merge, or discard this patch.
lib/org/openpsa/reports/handler/base.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
             $data['query'] = new org_openpsa_reports_query_dba($guid);
76 76
             $data['query']->require_do('midgard:update');
77 77
         } else {
78
-            $data['query']= new org_openpsa_reports_query_dba();
78
+            $data['query'] = new org_openpsa_reports_query_dba();
79 79
             $data['query']->component = $this->_component;
80 80
         }
81 81
 
Please login to merge, or discard this patch.
lib/net/nemein/redirector/handler/redirect.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 
35 35
         // Catch first the configuration option for showing editing interface instead
36 36
         // of redirecting administrators
37
-        if (   $this->_topic->can_do('net.nemein.redirector:noredirect')
37
+        if ($this->_topic->can_do('net.nemein.redirector:noredirect')
38 38
             && !$this->_config->get('admin_redirection')) {
39 39
             return new midcom_response_relocate($this->router->generate('edit', ['tinyurl' => $tinyurl]));
40 40
         }
@@ -68,8 +68,8 @@  discard block
 block discarded – undo
68 68
     {
69 69
         $data['url'] = net_nemein_redirector_viewer::topic_links_to($this->_config);
70 70
 
71
-        if (   $this->_config->get('redirection_type') !== null
72
-            && (   !$this->_topic->can_do('net.nemein.redirector:noredirect')
71
+        if ($this->_config->get('redirection_type') !== null
72
+            && (!$this->_topic->can_do('net.nemein.redirector:noredirect')
73 73
                 || $this->_config->get('admin_redirection'))) {
74 74
             return $this->redirect($data['url']);
75 75
         }
Please login to merge, or discard this patch.
lib/net/nehmer/static/viewer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
             }
55 55
         }
56 56
 
57
-        if (   $this->_topic->can_do('midgard:update')
57
+        if ($this->_topic->can_do('midgard:update')
58 58
             && $this->_topic->can_do('midcom:component_config')) {
59 59
                 $buttons[] = $workflow->get_button($this->router->generate('config'), [
60 60
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'),
Please login to merge, or discard this patch.
lib/net/nehmer/static/handler/view.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -112,7 +112,8 @@
 block discarded – undo
112 112
         foreach ($qb->execute() as $article) {
113 113
             try {
114 114
                 $datamanager->set_storage($article);
115
-            } catch (midcom_error $e) {
115
+            }
116
+            catch (midcom_error $e) {
116 117
                 $e->log();
117 118
                 continue;
118 119
             }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
             ]);
41 41
         }
42 42
 
43
-        if (   $this->_article->topic === $this->_topic->id
43
+        if ($this->_article->topic === $this->_topic->id
44 44
             && $this->_article->can_do('midgard:delete')) {
45 45
             $delete = $this->get_workflow('delete', ['object' => $this->_article]);
46 46
             $buttons[] = $delete->get_button($this->router->generate('delete', ['guid' => $this->_article->guid]));
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         $this->_datamanager->set_storage($this->_article);
82 82
 
83 83
         $arg = $this->_article->name ?: $this->_article->guid;
84
-        if (   $arg != 'index'
84
+        if ($arg != 'index'
85 85
             && $this->_config->get('hide_navigation')) {
86 86
             $this->add_breadcrumb($this->router->generate('view', ['name' =>$arg]), $this->_article->title);
87 87
         }
@@ -91,13 +91,13 @@  discard block
 block discarded – undo
91 91
         midcom::get()->metadata->set_request_metadata($this->_article->metadata->revised, $this->_article->guid);
92 92
         $this->bind_view_to_object($this->_article, $this->_datamanager->get_schema()->get_name());
93 93
 
94
-        if (   $this->_config->get('indexinnav')
94
+        if ($this->_config->get('indexinnav')
95 95
             || $this->_config->get('autoindex')
96 96
             || $this->_article->name != 'index') {
97 97
             $this->set_active_leaf($this->_article->id);
98 98
         }
99 99
 
100
-        if (   $this->_config->get('folder_in_title')
100
+        if ($this->_config->get('folder_in_title')
101 101
             && $this->_topic->extra != $this->_article->title) {
102 102
             midcom::get()->head->set_pagetitle("{$this->_topic->extra}: {$this->_article->title}");
103 103
         } else {
Please login to merge, or discard this patch.
lib/org/openpsa/projects/style/show-project.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,8 @@
 block discarded – undo
46 46
             $customer_html = '<a href="' . $contacts_url . '/group/' . $customer->guid . '/">' . $customer_html . "</a>\n";
47 47
         }
48 48
         echo $customer_html;
49
-    } catch (midcom_error) {
49
+    }
50
+    catch (midcom_error) {
50 51
     }
51 52
 
52 53
     if ($project->manager) {
Please login to merge, or discard this patch.