Passed
Push — master ( 05b81b...989dc8 )
by Andreas
12:34
created
lib/org/openpsa/widgets/contact.php 2 patches
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
     /**
94 94
      * Retrieve an object, uses in-request caching
95 95
      */
96
-    public static function get(string|int $src) : self
96
+    public static function get(string | int $src) : self
97 97
     {
98 98
         static $cache = [];
99 99
 
@@ -136,12 +136,12 @@  discard block
 block discarded – undo
136 136
             }
137 137
         }
138 138
 
139
-        if (   $this->_config->get('jabber_enable_presence')
139
+        if ($this->_config->get('jabber_enable_presence')
140 140
             && $person->get_parameter('org.openpsa.jabber', 'jid')) {
141 141
             $this->contact_details['jid'] = $person->get_parameter('org.openpsa.jabber', 'jid');
142 142
         }
143 143
 
144
-        if (   $this->_config->get('skype_enable_presence')
144
+        if ($this->_config->get('skype_enable_presence')
145 145
             && $person->get_parameter('org.openpsa.skype', 'name')) {
146 146
             $this->contact_details['skype'] = $person->get_parameter('org.openpsa.skype', 'name');
147 147
         }
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
         if (!empty($attachments[$type])) {
179 179
             return '<img class="photo" src="' . midcom_db_attachment::get_url($attachments[$type]) . '">';
180 180
         }
181
-        if (   $this->_config->get('gravatar_enable')
181
+        if ($this->_config->get('gravatar_enable')
182 182
             && !empty($this->contact_details['email'])) {
183 183
             $size = ($type == 'view') ? 500 : 32;
184 184
             $gravatar_url = "https://www.gravatar.com/avatar/" . md5(strtolower(trim($this->contact_details['email']))) . "?s=" . $size . '&d=identicon';
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
 
292 292
     private function _show_groups()
293 293
     {
294
-        if (   !$this->show_groups
294
+        if (!$this->show_groups
295 295
             || empty($this->contact_details['id'])) {
296 296
             return;
297 297
         }
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
355 355
                     $default_shown = true;
356 356
                     $cards_to_show[] = $cardname;
357 357
                 }
358
-            } elseif (    $customer->$property
358
+            } elseif ($customer->$property
359 359
                       || ($customer->street && !$inherited_cards_only && !$default_shown)) {
360 360
                 $inherited_cards_only = false;
361 361
                 $multiple_addresses = true;
@@ -377,8 +377,8 @@  discard block
 block discarded – undo
377 377
 
378 378
         foreach ($cards_to_show as $cardname) {
379 379
             echo '<div class="vcard">';
380
-            if (   $multiple_addresses
381
-                || (   $cardname != 'visiting'
380
+            if ($multiple_addresses
381
+                || ($cardname != 'visiting'
382 382
                     && !$inherited_cards_only)) {
383 383
                 echo '<div style="text-align:center"><em>' . midcom::get()->i18n->get_string($cardname . ' address', 'org.openpsa.contacts') . "</em></div>\n";
384 384
             }
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -103,7 +103,8 @@  discard block
 block discarded – undo
103 103
 
104 104
         try {
105 105
             $person = midcom_db_person::get_cached($src);
106
-        } catch (midcom_error) {
106
+        }
107
+        catch (midcom_error) {
107 108
             return $cache[$src] = new self(new midcom_db_person);
108 109
         }
109 110
 
@@ -303,7 +304,8 @@  discard block
 block discarded – undo
303 304
         foreach ($mc->get_rows(['gid', 'extra']) as $data) {
304 305
             try {
305 306
                 $group = org_openpsa_contacts_group_dba::get_cached($data['gid']);
306
-            } catch (midcom_error $e) {
307
+            }
308
+            catch (midcom_error $e) {
307 309
                 $e->log();
308 310
                 continue;
309 311
             }
Please login to merge, or discard this patch.
lib/midcom/services/uimessages.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -133,7 +133,7 @@
 block discarded – undo
133 133
      */
134 134
     public function show(bool $show_simple = false)
135 135
     {
136
-        if (   $show_simple
136
+        if ($show_simple
137 137
             || !midcom::get()->auth->can_user_do('midcom:ajax', class: static::class)) {
138 138
             $this->show_simple();
139 139
             return;
Please login to merge, or discard this patch.
lib/midcom/services/toolbars.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -272,7 +272,7 @@
 block discarded – undo
272 272
 
273 273
     private function add_head_elements(bool $centralized = false) : bool
274 274
     {
275
-        if (   !midcom::get()->auth->user
275
+        if (!midcom::get()->auth->user
276 276
             || !midcom::get()->config->get('toolbars_enable_centralized')
277 277
             || !midcom::get()->auth->can_user_do('midcom:centralized_toolbar', class: __CLASS__)) {
278 278
             return false;
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/handler/group/view.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
             ];
45 45
         }
46 46
 
47
-        if (   midcom::get()->auth->can_user_do('midgard:create', class: org_openpsa_contacts_person_dba::class)
47
+        if (midcom::get()->auth->can_user_do('midgard:create', class: org_openpsa_contacts_person_dba::class)
48 48
             && $this->group->can_do('midgard:create')) {
49 49
                 $buttons[] = $workflow->get_button($this->router->generate('person_new_group', ['guid' => $this->group->guid]), [
50 50
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('create person'),
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 
55 55
         $siteconfig = org_openpsa_core_siteconfig::get_instance();
56 56
         $user_url = $siteconfig->get_node_full_url('org.openpsa.user');
57
-        if (   $user_url
57
+        if ($user_url
58 58
             && midcom::get()->auth->can_user_do('org.openpsa.user:access', class: org_openpsa_user_interface::class)) {
59 59
             $buttons[] = [
60 60
                 MIDCOM_TOOLBAR_URL => $user_url . "group/{$this->group->guid}/",
Please login to merge, or discard this patch.
lib/org/openpsa/user/handler/person/view.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
         $this->add_breadcrumb('', $person->get_label());
26 26
 
27 27
         $auth = midcom::get()->auth;
28
-        if (   $person->guid == midcom::get()->auth->user->guid
28
+        if ($person->guid == midcom::get()->auth->user->guid
29 29
             || $auth->can_user_do('org.openpsa.user:manage', class: org_openpsa_user_interface::class)) {
30 30
             $buttons = [];
31 31
             $workflow = $this->get_workflow('datamanager');
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
                 $delete_workflow = $this->get_workflow('delete', ['object' => $person]);
39 39
                 $buttons[] = $delete_workflow->get_button($this->router->generate('user_delete', ['guid' => $person->guid]));
40 40
             }
41
-            if (   $data['account']->get_username()
41
+            if ($data['account']->get_username()
42 42
                 && $person->can_do('midgard:privileges')) {
43 43
                 $buttons[] = $workflow->get_button($this->router->generate('user_privileges', ['guid' => $person->guid]), [
44 44
                     MIDCOM_TOOLBAR_LABEL => $this->_l10n->get("permissions"),
Please login to merge, or discard this patch.
lib/org/openpsa/sales/handler/view.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         }
84 84
 
85 85
         if ($this->_config->get('sales_pdfbuilder_class')) {
86
-            if (   $this->_salesproject->can_do('midgard:update')
86
+            if ($this->_salesproject->can_do('midgard:update')
87 87
                 && $this->is_pdf_creatable()) {
88 88
                 $workflow = $this->get_workflow('datamanager');
89 89
                 $buttons[] = $workflow->get_button($this->router->generate('create_offer', ['guid' => $this->_salesproject->guid]), [
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
             case 'ordered':
205 205
                 if ($deliverable->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
206 206
                     $entries = $deliverable->get_at_entries();
207
-                    if (   $entries
207
+                    if ($entries
208 208
                         && $entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
209 209
                         && midcom::get()->auth->can_user_do('midgard:create', class: org_openpsa_invoices_invoice_dba::class)) {
210 210
                         return '<button class="run_cycle"><i class="fa fa-refresh"></i>' . $this->_l10n->get('generate now') . '</button>';
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
                 }
215 215
                 break;
216 216
             case 'delivered':
217
-                if (   $deliverable->orgOpenpsaObtype != org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
217
+                if ($deliverable->orgOpenpsaObtype != org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
218 218
                     && midcom::get()->auth->can_user_do('midgard:create', class: org_openpsa_invoices_invoice_dba::class)) {
219 219
                     $client_class = $this->_config->get('calculator');
220 220
                     $client = new $client_class();
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/textareaExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
      */
23 23
     public function configureOptions(OptionsResolver $resolver) : void
24 24
     {
25
-        $map_attr = function (Options $options, $value) {
25
+        $map_attr = function(Options $options, $value) {
26 26
             $value ??= [];
27 27
             $value['rows'] = $options['widget_config']['height'];
28 28
             $value['cols'] = $options['widget_config']['width'];
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/transformer/jsdateTransformer.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -33,8 +33,8 @@  discard block
 block discarded – undo
33 33
             }
34 34
         }
35 35
 
36
-        if (   empty($input)
37
-            || (   $input instanceof DateTime
36
+        if (empty($input)
37
+            || ($input instanceof DateTime
38 38
                 && $input->format('Y-m-d H:i:s') == '0001-01-01 00:00:00')) {
39 39
             return $result;
40 40
         }
@@ -59,8 +59,8 @@  discard block
 block discarded – undo
59 59
             throw new TransformationFailedException('Expected an array.');
60 60
         }
61 61
 
62
-        if (   empty($array['date'])
63
-            || (   $array['date'] instanceof DateTime
62
+        if (empty($array['date'])
63
+            || ($array['date'] instanceof DateTime
64 64
                 && $array['date']->format('Y-m-d H:i:s') == '0001-01-01 00:00:00')) {
65 65
             return null;
66 66
         }
Please login to merge, or discard this patch.
lib/midcom/response/relocate.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
      */
28 28
     public function setTargetUrl(string $url) : static
29 29
     {
30
-        if (   !str_starts_with($url, "/")
30
+        if (!str_starts_with($url, "/")
31 31
             && !preg_match('|^https?://|', $url)) {
32 32
             $prefix = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ANCHORPREFIX) ?: '/';
33 33
             $url = $prefix . $url;
Please login to merge, or discard this patch.