net_nemein_wiki_handler_feed

Complexity

Total Complexity

5

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Test Coverage

Coverage

46.67%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	_handler_rss()	0	43	5

<?php
/**
 * @package net.nemein.wiki
 * @author The Midgard Project, http://www.midgard-project.org
 * @copyright The Midgard Project, http://www.midgard-project.org
 * @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
 */

use Symfony\Component\HttpFoundation\Response;

/**
 * Wikipage feed handler
 *
 * @package net.nemein.wiki
 */
class net_nemein_wiki_handler_feed extends midcom_baseclasses_components_handler
{
    /**
     * @return Response
     */
    public function _handler_rss()
    {
        $nap = new midcom_helper_nav();
        $node = $nap->get_node($this->_topic->id);

        $rss_creator = new UniversalFeedCreator();
        $rss_creator->title = $node[MIDCOM_NAV_NAME];
        $rss_creator->link = $node[MIDCOM_NAV_FULLURL];
        $rss_creator->syndicationURL = "{$node[MIDCOM_NAV_FULLURL]}rss.xml";

        $qb = net_nemein_wiki_wikipage::new_query_builder();
        $qb->add_constraint('topic.component', '=', midcom_core_context::get()->get_key(MIDCOM_CONTEXT_COMPONENT));
        $qb->add_constraint('topic', 'INTREE', $this->_topic->id);
        $qb->add_order('metadata.revised', 'DESC');
        $qb->set_limit($this->_config->get('rss_count'));

It seems like $this->_config->get('rss_count') can also be of type false; however, parameter $limit of midcom_core_query::set_limit() does only seem to accept integer, maybe add an additional type check?

        foreach ($qb->execute() as $wikipage) {
            if ($wikipage->topic == $this->_topic->id) {

The property topic does not exist on midcom_core_dbaobject. Since you implemented __get, consider adding a @property annotation.

                $pagenode = $node;
            } else {
                $pagenode = $nap->get_node($wikipage->topic);
            }
            $item = new FeedItem();
            $item->title = $wikipage->title;
            $item->link = $pagenode[MIDCOM_NAV_FULLURL];
            if ($wikipage->name != 'index') {
                $item->link .= "{$wikipage->name}/";
            }
            $item->date = $wikipage->metadata->revised;
            try {
                $author = new midcom_db_person($wikipage->metadata->revisor);
                $item->author = $author->name;
            } catch (midcom_error $e) {
                $e->log();
            }

            $parser = new net_nemein_wiki_parser($wikipage);
            $item->description = $parser->get_html();
            $rss_creator->addItem($item);
        }

        return new Response($rss_creator->createFeed('RSS2.0'), Response::HTTP_OK, [
            'Content-Type' => 'text/xml; charset=UTF-8'
        ]);
    }
}