flack / openpsa

src/midcom/datamanager/extension/type/tinymceType.php

Spacing +2 added lines, -2 removed lines

@@ -26,11 +26,11 @@
      */
     public function configureOptions(OptionsResolver $resolver)
     {
-        $resolver->setDefault('config', function (Options $options) {
+        $resolver->setDefault('config', function(Options $options) {
             return \midcom_baseclasses_components_configuration::get('midcom.datamanager', 'config');
         });
 
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
             $widget_defaults = [
                 'mode' => 'exact',
                 'theme' => $options['config']->get('tinymce_default_theme'),

lib/midcom/services/_sessioning.php

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
 
     protected function prepare_storage()
     {
-        $cookie_secure = (   !empty($_SERVER['HTTPS'])
+        $cookie_secure = (!empty($_SERVER['HTTPS'])
                           && $_SERVER['HTTPS'] !== 'off'
                           && midcom::get()->config->get('auth_backend_simple_cookie_secure'));
 

src/midcom/datamanager/helper/autocomplete.php

Spacing +3 added lines, -3 removed lines

@@ -88,7 +88,7 @@ 
     {
         ksort($constraints);
         foreach ($constraints as $key => $data) {
-            if (   !array_key_exists('value', $data)
+            if (!array_key_exists('value', $data)
                 || empty($data['field'])
                 || empty($data['op'])) {
                 debug_add("Constraint #{$key} is not correctly defined, skipping", MIDCOM_LOG_WARN);
@@ -149,7 +149,7 @@ 
     {
         $query = $this->request["term"];
         $wildcard_query = $query;
-        if (   isset($this->request['auto_wildcards'])
+        if (isset($this->request['auto_wildcards'])
             && strpos($query, '%') === false) {
             switch ($this->request['auto_wildcards']) {
                 case 'start':
@@ -304,7 +304,7 @@ 
                     }
                     break;
             }
-        } elseif (   $item_name == 'username'
+        } elseif ($item_name == 'username'
                   && $object instanceof midcom_db_person) {
             $account = new midcom_core_account($object);
             return self::sanitize_label($account->get_username());

src/midcom/datamanager/extension/formExtension.php

Spacing +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
         $view->vars['readonly'] = $options['readonly'];
 
         if ($options['write_privilege'] !== null) {
-            if (   array_key_exists('group', $options['write_privilege'])
+            if (array_key_exists('group', $options['write_privilege'])
                 && !midcom::get()->auth->is_group_member($options['write_privilege']['group'])) {
                 $view->vars['readonly'] = true;
             }

src/midcom/datamanager/validation/imageValidator.php

Spacing +3 added lines, -3 removed lines

@@ -12,10 +12,10 @@
 {
     public function validate($value, Constraint $constraint)
     {
-        if (   empty($value)
+        if (empty($value)
             || !empty($value['delete'])
-            || (   empty($value['file'])
-                && (   empty($constraint->config['do_not_save_archival']) && empty($value['archival'])
+            || (empty($value['file'])
+                && (empty($constraint->config['do_not_save_archival']) && empty($value['archival'])
                     xor empty($value['main'])))) {
             $this->context->buildViolation('This value should not be blank.')
                 ->addViolation();

src/midcom/datamanager/extension/type/subformType.php

Spacing +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
                 'max_count' => 0
             ]
         ]);
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
             $validation = [];
             if ($options['type_config']['max_count'] > 0) {
                 $validation['max'] = $options['type_config']['max_count'];
@@ -54,13 +54,13 @@ 
             }
             return $validation;
         });
-        $resolver->setNormalizer('entry_options', function (Options $options, $value) {
+        $resolver->setNormalizer('entry_options', function(Options $options, $value) {
             return array_replace([
                 'required' => false, //@todo no idea why this is necessary
                 'widget_config' => $options['widget_config']
             ], (array) $value);
         });
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
             if (!array_key_exists('sortable', $value)) {
                 $value['sortable'] = false;
             }

lib/org/openpsa/sales/handler/edit.php

Braces +4 added lines, -2 removed lines

@@ -68,7 +68,8 @@ 
                 $field['type_config']['options'] = [0 => '', $customer->id => $customer->official];
 
                 $defaults['customer'] = $customer->id;
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $customer = new org_openpsa_contacts_person_dba($guid);
                 $defaults['customerContact'] = $customer->id;
                 $field['type_config']['options'] = $this->list_groups(new org_openpsa_sales_salesproject_dba, [$customer->id => true]);
@@ -142,7 +143,8 @@ 
             try {
                 $company = org_openpsa_contacts_group_dba::get_cached($company_id);
                 $ret[$company->id] = $company->get_label();
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

Spacing +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
         $schemadb = schemadb::from_path($this->_config->get('schemadb_salesproject'));
 
         if (!empty($guid)) {
-            $field =& $schemadb->get('default')->get_field('customer');
+            $field = & $schemadb->get('default')->get_field('customer');
             try {
                 $customer = new org_openpsa_contacts_group_dba($guid);
                 $field['type_config']['options'] = [0 => '', $customer->id => $customer->official];

lib/org/openpsa/user/validator.php

Spacing +3 added lines, -3 removed lines

@@ -47,7 +47,7 @@ 
         $result = $this->is_username_available($fields);
 
         $accounthelper = new org_openpsa_user_accounthelper();
-        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])){
+        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])) {
             $result = ['password' => midcom::get()->i18n->get_string('password weak', 'org.openpsa.user')];
         }
 
@@ -155,10 +155,10 @@ 
         $user = new midcom_db_person($fields["person"]);
 
         $accounthelper = new org_openpsa_user_accounthelper($user);
-        if (!$accounthelper->check_password_reuse($fields['new_password'])){
+        if (!$accounthelper->check_password_reuse($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password was already used', 'org.openpsa.user');
         }
-        if (!$accounthelper->check_password_strength($fields['new_password'])){
+        if (!$accounthelper->check_password_strength($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password weak', 'org.openpsa.user');
         }
         if (!empty($result)) {

Braces +3 added lines, -3 removed lines

@@ -47,7 +47,7 @@ 
         $result = $this->is_username_available($fields);
 
         $accounthelper = new org_openpsa_user_accounthelper();
-        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])){
+        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])) {
             $result = ['password' => midcom::get()->i18n->get_string('password weak', 'org.openpsa.user')];
         }
 
@@ -155,10 +155,10 @@ 
         $user = new midcom_db_person($fields["person"]);
 
         $accounthelper = new org_openpsa_user_accounthelper($user);
-        if (!$accounthelper->check_password_reuse($fields['new_password'])){
+        if (!$accounthelper->check_password_reuse($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password was already used', 'org.openpsa.user');
         }
-        if (!$accounthelper->check_password_strength($fields['new_password'])){
+        if (!$accounthelper->check_password_strength($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password weak', 'org.openpsa.user');
         }
         if (!empty($result)) {

lib/midgard/admin/user/validator.php

Spacing +2 added lines, -2 removed lines

@@ -29,8 +29,8 @@
             $mc->add_constraint('authtype', '=', midcom::get()->config->get('auth_type'));
             $mc->execute();
             $keys = $mc->list_keys();
-            if (   count($keys) > 0
-                && (   !isset($fields['person'])
+            if (count($keys) > 0
+                && (!isset($fields['person'])
                     || key($keys) != $fields['person'])) {
                 return [
                     "username" => sprintf(midcom::get()->i18n->get_string("username %s is already in use", "midgard.admin.user"), $fields['username'])