flack / openpsa

src/midcom/console/command/reindex.php

Braces +2 added lines, -1 removed lines

@@ -74,7 +74,8 @@
             if (is_a($stat, midcom_services_indexer_client::class)) {
                 try {
                     $stat->reindex();
-                } catch (RequestException $e) {
+                }
+                catch (RequestException $e) {
                     if ($e->hasResponse()) {
                         $crawler = new Crawler($e->getResponse()->getBody()->getContents());
                         $body = $crawler->filter('body')->html();

src/midcom/console/command/exec.php

Braces +2 added lines, -1 removed lines

@@ -79,7 +79,8 @@
 
         try {
             require OPENPSA_PROJECT_BASEDIR . $file;
-        } catch (\midcom_error_forbidden $e) {
+        }
+        catch (\midcom_error_forbidden $e) {
             $dialog = $this->getHelperSet()->get('question');
             $this->login($dialog, $input, $output);
             require OPENPSA_PROJECT_BASEDIR . $file;

src/midcom/httpkernel/subscriber.php

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
         foreach ($arguments as $i => $argument) {
             if ($argument === '__request_data__') {
                 $context = $event->getRequest()->attributes->get('context');
-                $arguments[$i] =& $context->get_custom_key('request_data');
+                $arguments[$i] = & $context->get_custom_key('request_data');
             }
         }
         $event->setArguments($arguments);

lib/midgard/admin/asgard/style/ASGARD_ROOT.php

Spacing +3 added lines, -3 removed lines

@@ -5,8 +5,8 @@ 
 }
 
 // Check the user preference and configuration
-if (   midgard_admin_asgard_plugin::get_preference('escape_frameset')
-    || (   midgard_admin_asgard_plugin::get_preference('escape_frameset') !== '0'
+if (midgard_admin_asgard_plugin::get_preference('escape_frameset')
+    || (midgard_admin_asgard_plugin::get_preference('escape_frameset') !== '0'
         && $data['config']->get('escape_frameset'))) {
     $head->add_jsonload('if(top.frames.length != 0 && top.location.href != this.location.href){top.location.href = this.location.href}');
 }
@@ -133,7 +133,7 @@ 
 
                             $edited = (int) $view_metadata->get('revised');
                             $revision = $view_metadata->get('revision');
-                            if (   $revision > 1
+                            if ($revision > 1
                                 && $edited != $created) {
                                 try {
                                     $editor = new midcom_db_person($view_metadata->get('revisor'));

Braces +4 added lines, -2 removed lines

@@ -8,7 +8,8 @@ 
                             try {
                                 $creator = new midcom_db_person($view_metadata->get('creator'));
                                 $creator_string = "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/view/{$creator->guid}/\">$creator->name</a>";
-                            } catch (midcom_error $e) {
+                            }
+                            catch (midcom_error $e) {
                                 $creator_string = $data['l10n']->get('unknown person');
                             }
                             $created = (int) $view_metadata->get('created');
@@ -21,7 +22,8 @@ 
                                 try {
                                     $editor = new midcom_db_person($view_metadata->get('revisor'));
                                     $editor_string = "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/view/{$editor->guid}/\">$editor->name</a>";
-                                } catch (midcom_error $e) {
+                                }
+                                catch (midcom_error $e) {
                                     $editor_string = $data['l10n']->get('unknown person');
                                 }
 

lib/midcom/services/uimessages.php

Spacing +1 added lines, -1 removed lines

@@ -162,7 +162,7 @@
         if (!$this->_message_stack) {
             return;
         }
-        if (   $show_simple
+        if ($show_simple
             || !midcom::get()->auth->can_user_do('midcom:ajax', null, static::class)) {
             $this->show_simple();
             return;

lib/midcom/services/cache/main.php

Spacing +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
 
         $this->_modules[$name] = new $classname();
         $this->_modules[$name]->initialize();
-        $this->$name =& $this->_modules[$name];
+        $this->$name = & $this->_modules[$name];
     }
 
     /**

lib/midcom/admin/help/style/midcom_admin_help_mgdschemas.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
 
         foreach ($properties as $propname => $val) {
             $description = preg_replace('/ *\n */', "\n", $val['value']);
-            if (   $val['link']
+            if ($val['link']
                 && $linked_component = midcom::get()->dbclassloader->get_component_for_class($val['link_name'])) {
                 $proplink = $data['router']->generate('help', ['component' => $linked_component, 'help_id' => 'mgdschemas']);
                 $proplink = "<a href='{$proplink}#{$val['link_name']}' title='{$linked_component}/{$val['link_name']}::{$val['link_target']}'>{$val['link_name']}:{$val['link_target']}</a>";

lib/org/openpsa/projects/task.php

Spacing +1 added lines, -1 removed lines

@@ -110,7 +110,7 @@
     public function _on_updated()
     {
         // Sync the object's ACL properties into MidCOM ACL system
-        if (   !$this->_skip_acl_refresh) {
+        if (!$this->_skip_acl_refresh) {
             if ($this->orgOpenpsaAccesstype && $this->orgOpenpsaOwnerWg) {
                 debug_add("Synchronizing task ACLs to MidCOM");
                 $sync = new org_openpsa_core_acl_synchronizer();

Braces +4 added lines, -2 removed lines

@@ -238,7 +238,8 @@ 
                     $salesproject = org_openpsa_sales_salesproject_dba::get_cached($agreement->salesproject);
                     $this->customer = $salesproject->customer;
                 }
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
             }
         } else {
             // No agreement, we can't be invoiceable
@@ -283,7 +284,8 @@ 
         try {
             $agreement = new org_openpsa_sales_salesproject_deliverable_dba($this->get_agreement());
             $agreement->update_units($this->id, $hours);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
         }
 
         if ($update) {

lib/org/openpsa/sales/style/show-deliverable-subscription.php

Indentation +7 added lines, -7 removed lines

@@ -80,30 +80,30 @@
                         <tr>
                           <td class="title"><?php echo $data['l10n']->get('cost'); ?></td>
                           <?php
-                          if ($data['deliverable']->costType == '%') {
-                              ?>
+                            if ($data['deliverable']->costType == '%') {
+                                ?>
                               <td class="numeric"><?php echo $view['costPerUnit']; ?> %</td>
                               <td class="numeric">&nbsp;</td>
                               <td class="numeric">&nbsp;</td>
                           <?php
-                          } else {
-                              ?>
+                            } else {
+                                ?>
                               <td class="numeric"><?php echo $formatter->number($data['deliverable']->costPerUnit); ?></td>
                               <td class="numeric"><?php echo $view['plannedUnits']; ?></td>
                               <td class="numeric"><?php echo $view['units']; ?></td>
                           <?php
-                          } ?>
+                            } ?>
                               <td class="numeric"><?php echo $formatter->number($data['deliverable']->cost); ?></td>
                         </tr>
                       </tbody>
                     </table>
                 <?php if ($data['deliverable']->invoiceByActualUnits) {
-                              ?>
+                                ?>
                     <ul>
                         <li><?php echo $data['l10n']->get('invoice by actual units'); ?></li>
                     </ul>
                     <?php
-                          } ?>
+                            } ?>
                     </div>
                 </div>
                 <div class="field">

Spacing +4 added lines, -4 removed lines

@@ -3,7 +3,7 @@ 
 $state = $data['deliverable']->get_state();
 $formatter = $data['l10n']->get_formatter();
 $per_unit = $data['l10n']->get('per unit');
-if (   $data['product']
+if ($data['product']
     && $unit_option = org_openpsa_sales_viewer::get_unit_option($data['product']->unit)) {
     $per_unit = sprintf($data['l10n']->get('per %s'), $unit_option);
 }
@@ -124,7 +124,7 @@ 
         </div>
         <?php
         $tabs = [];
-        if (   $data['invoices_url']
+        if ($data['invoices_url']
             && $data['deliverable']->invoiced > 0) {
             $tabs[] = [
                 'url' => $data['invoices_url'] . "list/deliverable/{$data['deliverable']->guid}/",
@@ -132,7 +132,7 @@ 
             ];
         }
 
-        if (   $data['projects_url']
+        if ($data['projects_url']
             && $data['deliverable']->state >= org_openpsa_sales_salesproject_deliverable_dba::STATE_ORDERED
             && $data['product']
             && $data['product']->orgOpenpsaObtype == org_openpsa_products_product_dba::TYPE_SERVICE) {
@@ -191,7 +191,7 @@ 
             }
             echo "    </tbody>\n";
             echo "</table>\n";
-            if (   $at_entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
+            if ($at_entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
                 && midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_invoices_invoice_dba::class)) {
                 $label = $data['l10n']->get('generate now');
                 $process_link = $data['router']->generate('deliverable_run_cycle', ['guid' => $data['deliverable']->guid]);