Passed
Pull Request — master (#204)
by
unknown
23:41
created
lib/org/openpsa/sales/style/show-offers.php 1 patch
Indentation   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -5,29 +5,29 @@
 block discarded – undo
5 5
     ?>
6 6
     <div class="area org_openpsa_helper_box"><h3><?php echo $data['l10n']->get('offers'); ?></h3>
7 7
     	<ul><?php
8
-         foreach ($data['offers'] as $offer) {
9
-             echo '<li><span class="org_openpsa_helpers_fileinfo">';
10
-             $attachment = $offer->get_file();
11
-             $delete_link = $data['router']->generate('delete_offer', ['guid' => $offer->guid]);
12
-             $edit_link = $data['router']->generate('edit_offer', ['guid' => $offer->guid]);
8
+            foreach ($data['offers'] as $offer) {
9
+                echo '<li><span class="org_openpsa_helpers_fileinfo">';
10
+                $attachment = $offer->get_file();
11
+                $delete_link = $data['router']->generate('delete_offer', ['guid' => $offer->guid]);
12
+                $edit_link = $data['router']->generate('edit_offer', ['guid' => $offer->guid]);
13 13
 
14
-             if (!empty($attachment)) {
15
-                 $url = midcom_db_attachment::get_url($attachment);
16
-                 echo '<a href="' . $url . '" class="icon"><i class="fa fa-file-text-o"></i></a>';
17
-             }
18
-             echo '<span class="info">';
19
-             echo '<span class="filename">' . $offer->get_label();
20
-             echo ' <a class="actions" href="' . $delete_link . '"><i class="fa fa-trash" title="' . $data['l10n_midcom']->get('delete') . '"></i></a>';
21
-             echo ' <a class="actions" ' . $wf->render_attributes() . ' href="' . $edit_link . '"><i class="fa fa-pencil" title="' . $data['l10n_midcom']->get('edit') . '"></i></a>';
22
-             echo "</span>\n";
23
-             if (!empty($attachment)) {
24
-                 echo ' <span class="date">' . $formatter->datetime($attachment->metadata->revised) . '</span> ';
25
-                 $person_card = org_openpsa_widgets_contact::get($attachment->metadata->revisor);
26
-                 echo $person_card->show_inline();
27
-             }
28
-             echo "</span></span></li>\n";
29
-         }
30
-         ?>
14
+                if (!empty($attachment)) {
15
+                    $url = midcom_db_attachment::get_url($attachment);
16
+                    echo '<a href="' . $url . '" class="icon"><i class="fa fa-file-text-o"></i></a>';
17
+                }
18
+                echo '<span class="info">';
19
+                echo '<span class="filename">' . $offer->get_label();
20
+                echo ' <a class="actions" href="' . $delete_link . '"><i class="fa fa-trash" title="' . $data['l10n_midcom']->get('delete') . '"></i></a>';
21
+                echo ' <a class="actions" ' . $wf->render_attributes() . ' href="' . $edit_link . '"><i class="fa fa-pencil" title="' . $data['l10n_midcom']->get('edit') . '"></i></a>';
22
+                echo "</span>\n";
23
+                if (!empty($attachment)) {
24
+                    echo ' <span class="date">' . $formatter->datetime($attachment->metadata->revised) . '</span> ';
25
+                    $person_card = org_openpsa_widgets_contact::get($attachment->metadata->revisor);
26
+                    echo $person_card->show_inline();
27
+                }
28
+                echo "</span></span></li>\n";
29
+            }
30
+            ?>
31 31
      </ul>
32 32
     </div>
33 33
 <?php  } ?>
34 34
\ No newline at end of file
Please login to merge, or discard this patch.
lib/net/nemein/wiki/resolver.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
             $localpath = $path;
159 159
             $matches['latest_parent'] = $folder_tree['/'];
160 160
             $missing_levels = 0;
161
-            while (   $localpath
161
+            while ($localpath
162 162
                    && $localpath != '/') {
163 163
                 $localpath = dirname($localpath);
164 164
                 $missing_levels++;
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 
186 186
         $root_folder = $folder;
187 187
         $max = 100;
188
-        while (   $folder[MIDCOM_NAV_COMPONENT] == 'net.nemein.wiki'
188
+        while ($folder[MIDCOM_NAV_COMPONENT] == 'net.nemein.wiki'
189 189
                && (($parent = $nap->get_node_uplink($folder[MIDCOM_NAV_ID])) != -1)
190 190
                && $max > 0) {
191 191
             $root_folder = $folder;
Please login to merge, or discard this patch.
lib/org/openpsa/products/product/group.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
         }
81 81
 
82 82
         $result_cache[$cache_key] = [];
83
-        $ret =& $result_cache[$cache_key];
83
+        $ret = & $result_cache[$cache_key];
84 84
 
85 85
         if (empty($up)) {
86 86
             // TODO: use reflection to see what kind of property this is ?
@@ -100,14 +100,14 @@  discard block
 block discarded – undo
100 100
             $value_properties[] = $keyproperty;
101 101
         }
102 102
         foreach ($label_fields as $fieldname) {
103
-            if (   $fieldname != 'id'
103
+            if ($fieldname != 'id'
104 104
                 && $fieldname != $keyproperty) {
105 105
                 $value_properties[] = $fieldname;
106 106
                 continue;
107 107
             }
108 108
         }
109 109
 
110
-        $mc = self::new_collector('up', (int)$up);
110
+        $mc = self::new_collector('up', (int) $up);
111 111
         if ($order_by_score) {
112 112
             $mc->add_order('metadata.score', 'DESC');
113 113
         }
Please login to merge, or discard this patch.
lib/org/openpsa/projects/project.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -249,7 +249,7 @@
 block discarded – undo
249 249
             $new_status = $this->_find_status($this->_status_map[$this->status_type], $status_types);
250 250
         }
251 251
 
252
-        if (   $new_status !== null
252
+        if ($new_status !== null
253 253
             && $this->status != $new_status) {
254 254
             $this->status = $new_status;
255 255
             $update_required = true;
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/handler/search.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@
 block discarded – undo
82 82
 
83 83
         // Handle automatic wildcards
84 84
         $auto_wildcards = $this->_config->get('auto_wildcards');
85
-        if (   $auto_wildcards
85
+        if ($auto_wildcards
86 86
             && strpos($this->_query_string_processed, '%') === false) {
87 87
             switch ($auto_wildcards) {
88 88
                 case 'both':
Please login to merge, or discard this patch.
lib/midcom/services/auth/frontend/form.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
      */
36 36
     public function read_login_data(Request $request)
37 37
     {
38
-        if (   !$request->request->has('midcom_services_auth_frontend_form_submit')
38
+        if (!$request->request->has('midcom_services_auth_frontend_form_submit')
39 39
             || !$request->request->has('username')
40 40
             || !$request->request->has('password')) {
41 41
             return null;
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
     {
176 176
         // Store the submitted form if the session expired, but user wants to save the data
177 177
         if (!empty($_POST)) {
178
-            $data =& midcom_core_context::get()->get_custom_key('request_data');
178
+            $data = & midcom_core_context::get()->get_custom_key('request_data');
179 179
 
180 180
             $data['restored_form_data'] = [];
181 181
 
Please login to merge, or discard this patch.
lib/midcom/services/i18n/main.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
         $rawdata = base64_decode($_COOKIE['midcom_services_i18n']);
115 115
         $array = unserialize($rawdata);
116 116
 
117
-        if (   !array_key_exists('language', $array)
117
+        if (!array_key_exists('language', $array)
118 118
             || !array_key_exists('charset', $array)) {
119 119
             debug_add("Rejecting cookie, it seems invalid.");
120 120
             return;
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
                 $lang = substr($lang, 0, 2);
144 144
                 $q = $this->_get_q($params);
145 145
 
146
-                if (   !isset($http_langs[$lang])
146
+                if (!isset($http_langs[$lang])
147 147
                     || $http_langs[$lang] < $q) {
148 148
                     $http_langs[$lang] = $q;
149 149
                 }
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
                 $option = array_shift($params);
164 164
                 continue;
165 165
             }
166
-            if (   $option_params[0] == "q"
166
+            if ($option_params[0] == "q"
167 167
                 && is_numeric($option_params[1])) {
168 168
                 // make sure that 0.0 <= $q <= 1.0
169 169
                 $q = max(0.0, min(1.0, $option_params[1]));
Please login to merge, or discard this patch.
lib/org/openpsa/products/handler/product/view.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,8 @@
 block discarded – undo
83 83
                 $productgroup = new org_openpsa_products_product_group_dba($this->_product->productGroup);
84 84
                 $replacements['<PRODUCTGROUP_TITLE>'] = $productgroup->title;
85 85
                 $replacements['<PRODUCTGROUP_CODE>'] = $productgroup->code;
86
-            } catch (midcom_error $e) {
86
+            }
87
+            catch (midcom_error $e) {
87 88
                 $replacements['<PRODUCTGROUP_TITLE>'] = '';
88 89
                 $replacements['<PRODUCTGROUP_CODE>'] = '';
89 90
             }
Please login to merge, or discard this patch.
lib/midcom/baseclasses/components/handler/dataexport.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
         foreach ($this->_datamanagers as $type => $datamanager) {
128 128
             foreach ($datamanager->get_schema($this->schemas[$type])->get('fields') as $name => $config) {
129 129
                 $title = $config['title'];
130
-                if (   $this->include_totals
130
+                if ($this->include_totals
131 131
                     && $config['type'] == 'number') {
132 132
                     $this->_totals[$type . '-' . $name] = 0;
133 133
                 }
@@ -194,18 +194,18 @@  discard block
 block discarded – undo
194 194
                     $data = array_pad($data, $target_size, '');
195 195
                     continue;
196 196
                 }
197
-                $object =& $row[$type];
197
+                $object = & $row[$type];
198 198
 
199 199
                 $datamanager->set_storage($object, $this->schemas[$type]);
200 200
 
201
-                if (   $this->include_guid
201
+                if ($this->include_guid
202 202
                     && $type == $first_type) {
203 203
                     $data[] = $object->guid;
204 204
                 }
205 205
 
206 206
                 $csvdata = $datamanager->get_content_csv();
207 207
                 foreach ($datamanager->get_schema()->get('fields') as $fieldname => $config) {
208
-                    if (   $this->include_totals
208
+                    if ($this->include_totals
209 209
                         && $config['type'] == 'number') {
210 210
                         $this->_totals[$type . '-' . $fieldname] += $csvdata[$fieldname];
211 211
                     }
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
         if (empty($this->csv['charset'])) {
234 234
             // Default to ISO-LATIN-15 (Latin-1 with EURO sign etc)
235 235
             $this->csv['charset'] = 'ISO-8859-15';
236
-            if (   isset($_SERVER['HTTP_USER_AGENT'])
236
+            if (isset($_SERVER['HTTP_USER_AGENT'])
237 237
                 && !preg_match('/Windows/i', $_SERVER['HTTP_USER_AGENT'])) {
238 238
                 // Except when not on windows, then default to UTF-8
239 239
                 $this->csv['charset'] = 'UTF-8';
Please login to merge, or discard this patch.